)]}'
{"id":"openocd~master~Ic7f0f643fdf067c059c8f2455a02ff18a3fed054","project":"openocd","branch":"master","topic":"romtable","hashtags":[],"change_id":"Ic7f0f643fdf067c059c8f2455a02ff18a3fed054","subject":"arm_adi_v5: let dap_lookup_cs_component() to get AP dbgbase","status":"MERGED","created":"2022-01-23 14:39:04.000000000","updated":"2022-05-14 08:55:33.000000000","submitted":"2022-05-14 08:55:33.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6823-romtable","meta_rev_id":"c6f3a1241f06182f7a11aba0ca5f82e355b0fed1","_number":6823,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-05-14 08:55:33.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-05-14 08:55:33.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-01-23 15:38:00.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2022-01-23 19:06:41.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"c21ab540628f1d6fb480be99ffe6dd1b69f37a3a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-01-23 14:39:04.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"4e1654b666413bd6046b6282a2af6c8d580f176b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-01-23 15:17:17.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"e3757c2aef9448826d25d1f131f501fd61f0859d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-01-23 15:36:47.000000000","message":"Uploaded patch set 3: New patch set was added with same tree, parent, and commit message as Patch Set 2.","accounts_in_message":[],"_revision_number":3},{"id":"77bd6297f4c7f5e6e0c3bb397b2219e5d6399473","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-01-23 15:38:00.000000000","message":"Patch Set 1:\n\nNo Builds Executed","accounts_in_message":[],"_revision_number":1},{"id":"b8101f8b38ec6059a6b8b0e6fb6a0a763b41a1ad","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-01-23 19:06:41.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15792/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/15002/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"d225e5fe2438beb85a7e725cf233524f79d19cad","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-01-29 19:15:05.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"857b2dce6f5b3971013d0646481b6589831ec645","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-04-28 21:05:52.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"c6f3a1241f06182f7a11aba0ca5f82e355b0fed1","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-05-14 08:55:33.000000000","message":"Change has been successfully cherry-picked as 613f1c6abbc92aff22ef1731469626759f91ebaa","accounts_in_message":[],"_revision_number":4}],"current_revision":"613f1c6abbc92aff22ef1731469626759f91ebaa","revisions":{"ba84b75fa886e68c5c1b60d2fcb5d07c66136b4a":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2022-01-23 15:17:17.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/23/6823/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/23/6823/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/23/6823/2 \u0026\u0026 git checkout -b change-6823 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/23/6823/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/23/6823/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/23/6823/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/23/6823/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/23/6823/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b35b911d82fb2ba3397161a8ef337d0b8782ed36","subject":"arm_adi_v5: abstract actions during ROM table parsing"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-01-15 17:34:21.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-01-23 15:04:08.000000000","tz":60},"subject":"arm_adi_v5: let dap_lookup_cs_component() to get AP dbgbase","message":"arm_adi_v5: let dap_lookup_cs_component() to get AP dbgbase\n\nSimplify the code in cortex_a and aarch64 by moving the call to\ndap_get_debugbase() inside dap_lookup_cs_component().\n\nThis has the further effects:\n- dap_get_debugbase() is not referenced outside arm_adi_v5.c and\n  becomes static;\n- dap_lookup_cs_component() looses one parameter;\n- the coreid parameter \u0027idx\u0027 is passed as value;\n- the caller in aarch64 don\u0027t have and don\u0027t print the irrelevant\n  value of AP register APID;\n- fixes the debug message in the caller in aarch64 to print the\n  coreid value instead of always zero.\n\nChange-Id: Ic7f0f643fdf067c059c8f2455a02ff18a3fed054\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"702b63b845b6489b6af81520798880459f666d4e":{"kind":"NO_CHANGE","_number":3,"created":"2022-01-23 15:36:47.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/23/6823/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/23/6823/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/23/6823/3 \u0026\u0026 git checkout -b change-6823 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/23/6823/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/23/6823/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/23/6823/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/23/6823/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/23/6823/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b6dc892c23edf91d7514caa4b40378f22ee922c2","subject":"arm_adi_v5: abstract actions during ROM table parsing"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-01-15 17:34:21.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-01-23 15:36:02.000000000","tz":60},"subject":"arm_adi_v5: let dap_lookup_cs_component() to get AP dbgbase","message":"arm_adi_v5: let dap_lookup_cs_component() to get AP dbgbase\n\nSimplify the code in cortex_a and aarch64 by moving the call to\ndap_get_debugbase() inside dap_lookup_cs_component().\n\nThis has the further effects:\n- dap_get_debugbase() is not referenced outside arm_adi_v5.c and\n  becomes static;\n- dap_lookup_cs_component() looses one parameter;\n- the coreid parameter \u0027idx\u0027 is passed as value;\n- the caller in aarch64 don\u0027t have and don\u0027t print the irrelevant\n  value of AP register APID;\n- fixes the debug message in the caller in aarch64 to print the\n  coreid value instead of always zero.\n\nChange-Id: Ic7f0f643fdf067c059c8f2455a02ff18a3fed054\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"bdac63edf80741e667699d948cf93f8c32045800":{"kind":"REWORK","_number":1,"created":"2022-01-23 14:39:04.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/23/6823/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/23/6823/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/23/6823/1 \u0026\u0026 git checkout -b change-6823 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/23/6823/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/23/6823/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/23/6823/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/23/6823/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/23/6823/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"bddf7136157cfc2fa7e713fefeaeb30d4fd1f8cb","subject":"arm_adi_v5: abstract actions during ROM table parsing"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-01-15 17:34:21.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-01-23 13:48:58.000000000","tz":60},"subject":"arm_adi_v5: let dap_lookup_cs_component() to get AP dbgbase","message":"arm_adi_v5: let dap_lookup_cs_component() to get AP dbgbase\n\nSimplify the code in cortex_a and aarch64 by moving the call to\ndap_get_debugbase() inside dap_lookup_cs_component().\n\nThis has the further effects:\n- dap_get_debugbase() is not referenced outside arm_adi_v5.c and\n  becomes static;\n- dap_lookup_cs_component() looses one parameter;\n- the coreid parameter \u0027idx\u0027 is passed as value;\n- the caller in aarch64 don\u0027t have and don\u0027t print the irrelevant\n  value of AP register APID;\n- fixes the debug message in the caller in aarch64 to print the\n  coreid value instead of always zero.\n\nChange-Id: Ic7f0f643fdf067c059c8f2455a02ff18a3fed054\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"613f1c6abbc92aff22ef1731469626759f91ebaa":{"kind":"REWORK","_number":4,"created":"2022-05-14 08:55:33.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/23/6823/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/23/6823/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/23/6823/4 \u0026\u0026 git checkout -b change-6823 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/23/6823/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/23/6823/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/23/6823/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/23/6823/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/23/6823/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7351330a0f1f6ac626964e515ed50bb43499e0e5","subject":"arm_adi_v5: abstract actions during ROM table parsing"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-01-15 17:34:21.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-05-14 08:55:33.000000000","tz":0},"subject":"arm_adi_v5: let dap_lookup_cs_component() to get AP dbgbase","message":"arm_adi_v5: let dap_lookup_cs_component() to get AP dbgbase\n\nSimplify the code in cortex_a and aarch64 by moving the call to\ndap_get_debugbase() inside dap_lookup_cs_component().\n\nThis has the further effects:\n- dap_get_debugbase() is not referenced outside arm_adi_v5.c and\n  becomes static;\n- dap_lookup_cs_component() looses one parameter;\n- the coreid parameter \u0027idx\u0027 is passed as value;\n- the caller in aarch64 don\u0027t have and don\u0027t print the irrelevant\n  value of AP register APID;\n- fixes the debug message in the caller in aarch64 to print the\n  coreid value instead of always zero.\n\nChange-Id: Ic7f0f643fdf067c059c8f2455a02ff18a3fed054\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6823\nTested-by: jenkins\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}