)]}'
{"id":"openocd~master~I589ef7ae8a651d0c422ce7d0b4ed913713a8217e","project":"openocd","branch":"master","topic":"romtable","hashtags":[],"change_id":"I589ef7ae8a651d0c422ce7d0b4ed913713a8217e","subject":"arm_adi_v5: replace dap_lookup_cs_component()","status":"MERGED","created":"2022-01-23 14:39:04.000000000","updated":"2022-05-14 08:55:52.000000000","submitted":"2022-05-14 08:55:52.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6824-romtable","meta_rev_id":"6500d15025dfd2af50640017d07dc1247dfd1c69","_number":6824,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-05-14 08:55:52.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-05-14 08:55:52.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-01-23 15:38:06.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2022-01-23 20:12:24.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"fcfd987114fbd5aab330031bac7abf6b86037aab","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-01-23 14:39:04.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"548e40bab51982e0fb296f536d087f199e180b15","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-01-23 15:17:17.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"a23088cb22f67bd1910ff547f3e680e6ba83ba4e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-01-23 15:36:47.000000000","message":"Uploaded patch set 3: New patch set was added with same tree, parent, and commit message as Patch Set 2.","accounts_in_message":[],"_revision_number":3},{"id":"b68028e1242753cf51bd254c9ffd4d9ab992af14","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-01-23 15:38:06.000000000","message":"Patch Set 1:\n\nNo Builds Executed","accounts_in_message":[],"_revision_number":1},{"id":"87b5661382a57fd74990a963209c4f8513e2b643","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-01-23 20:12:24.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15793/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/15006/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"89fc7876b370f7f5c7a7033bcbb60ebdb4e7176f","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-01-29 19:15:14.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"140d0e08078d674aaeaa879f0e5d058d7c0554ee","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-04-28 21:06:01.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"6500d15025dfd2af50640017d07dc1247dfd1c69","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-05-14 08:55:52.000000000","message":"Change has been successfully cherry-picked as d74f11dcd43914702ea7b011c4bbb7da8d4a2f5c","accounts_in_message":[],"_revision_number":4}],"current_revision":"d74f11dcd43914702ea7b011c4bbb7da8d4a2f5c","revisions":{"d74f11dcd43914702ea7b011c4bbb7da8d4a2f5c":{"kind":"REWORK","_number":4,"created":"2022-05-14 08:55:52.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/24/6824/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/24/6824/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/24/6824/4 \u0026\u0026 git checkout -b change-6824 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/24/6824/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/24/6824/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/24/6824/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/24/6824/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/24/6824/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"613f1c6abbc92aff22ef1731469626759f91ebaa","subject":"arm_adi_v5: let dap_lookup_cs_component() to get AP dbgbase"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-01-15 20:01:37.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-05-14 08:55:52.000000000","tz":0},"subject":"arm_adi_v5: replace dap_lookup_cs_component()","message":"arm_adi_v5: replace dap_lookup_cs_component()\n\nWith the generic function for ROM table walk-through, reimplement\ndap_lookup_cs_component().\n\nCatch the code CORESIGHT_COMPONENT_FOUND and halt the search.\nWhile there, drop two macros in arm_coresight.h, now unused.\n\nChange-Id: I589ef7ae8a651d0c422ce7d0b4ed913713a8217e\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6824\nTested-by: jenkins\n"}},"ace38233018c544b7984abf441178f07ba42d5ad":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2022-01-23 15:17:17.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/24/6824/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/24/6824/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/24/6824/2 \u0026\u0026 git checkout -b change-6824 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/24/6824/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/24/6824/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/24/6824/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/24/6824/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/24/6824/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ba84b75fa886e68c5c1b60d2fcb5d07c66136b4a","subject":"arm_adi_v5: let dap_lookup_cs_component() to get AP dbgbase"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-01-15 20:01:37.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-01-23 15:04:08.000000000","tz":60},"subject":"arm_adi_v5: replace dap_lookup_cs_component()","message":"arm_adi_v5: replace dap_lookup_cs_component()\n\nWith the generic function for ROM table walk-through, reimplement\ndap_lookup_cs_component().\n\nCatch the code CORESIGHT_COMPONENT_FOUND and halt the search.\nWhile there, drop two macros in arm_coresight.h, now unused.\n\nChange-Id: I589ef7ae8a651d0c422ce7d0b4ed913713a8217e\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"88a86f65246f146d9c4186f585997d993ff7049e":{"kind":"NO_CHANGE","_number":3,"created":"2022-01-23 15:36:47.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/24/6824/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/24/6824/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/24/6824/3 \u0026\u0026 git checkout -b change-6824 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/24/6824/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/24/6824/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/24/6824/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/24/6824/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/24/6824/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"702b63b845b6489b6af81520798880459f666d4e","subject":"arm_adi_v5: let dap_lookup_cs_component() to get AP dbgbase"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-01-15 20:01:37.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-01-23 15:36:02.000000000","tz":60},"subject":"arm_adi_v5: replace dap_lookup_cs_component()","message":"arm_adi_v5: replace dap_lookup_cs_component()\n\nWith the generic function for ROM table walk-through, reimplement\ndap_lookup_cs_component().\n\nCatch the code CORESIGHT_COMPONENT_FOUND and halt the search.\nWhile there, drop two macros in arm_coresight.h, now unused.\n\nChange-Id: I589ef7ae8a651d0c422ce7d0b4ed913713a8217e\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"ee950e305dd4510438ab15359a07f0e938c8ab5b":{"kind":"REWORK","_number":1,"created":"2022-01-23 14:39:04.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/24/6824/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/24/6824/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/24/6824/1 \u0026\u0026 git checkout -b change-6824 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/24/6824/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/24/6824/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/24/6824/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/24/6824/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/24/6824/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"bdac63edf80741e667699d948cf93f8c32045800","subject":"arm_adi_v5: let dap_lookup_cs_component() to get AP dbgbase"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-01-15 20:01:37.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-01-23 13:55:17.000000000","tz":60},"subject":"arm_adi_v5: replace dap_lookup_cs_component()","message":"arm_adi_v5: replace dap_lookup_cs_component()\n\nWith the generic function for ROM table walk-through, reimplement\ndap_lookup_cs_component().\n\nCatch the code CORESIGHT_COMPONENT_FOUND and halt the search.\nWhile there, drop two macros in arm_coresight.h, now unused.\n\nChange-Id: I589ef7ae8a651d0c422ce7d0b4ed913713a8217e\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}