)]}'
{"id":"openocd~master~Id206e4fa7a29e9402c8e2393026817b410bbb8bd","project":"openocd","branch":"master","topic":"adiv6","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2022-06-24 21:39:16.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Id206e4fa7a29e9402c8e2393026817b410bbb8bd","subject":"adiv6: stay in same AP during dap_lookup_cs_component()","status":"MERGED","created":"2022-01-23 21:05:11.000000000","updated":"2022-06-24 21:39:16.000000000","submitted":"2022-06-24 21:39:16.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6826-adiv6","meta_rev_id":"c2e3f9a48ebc054f56c05bea621af1f079664d67","_number":6826,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-06-24 21:39:16.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"value":0,"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-06-24 21:39:16.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"value":0,"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-01-24 01:51:48.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-01-30 00:58:42.000000000","updated_by":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"reviewer":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"state":"REVIEWER"}],"messages":[{"id":"954f0ddbaa3340e6f39340f52e52ce7d0e28b52b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-01-23 21:05:11.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f43da79e5a66cffe71cf39e05a0b09ee6f118be3","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-01-24 01:51:48.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15808/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/15019/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"3e9ed410c57e0bcdfee7077a8717d28f89e18538","author":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"real_author":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"date":"2022-01-30 00:58:42.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"f66be064ac47f6fd66ba3a6600ae2f77e55b04fc","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-06-10 22:13:18.000000000","message":"Uploaded patch set 2: Code-Review+2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"66b78ff9fa314d2265480f7fa24b3b80b137fbc4","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-06-11 05:18:49.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/16259/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/15470/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"c2e3f9a48ebc054f56c05bea621af1f079664d67","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-06-24 21:39:16.000000000","message":"Change has been successfully cherry-picked as 1842cf69a92d07866ebefee3bc7090a58782b059","accounts_in_message":[],"_revision_number":3}],"current_revision":"1842cf69a92d07866ebefee3bc7090a58782b059","revisions":{"8f59b9412c303eafe296a3910041fc046cad1e14":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2022-06-10 22:13:18.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/26/6826/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/26/6826/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/26/6826/2 \u0026\u0026 git checkout -b change-6826 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/26/6826/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/26/6826/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/26/6826/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/26/6826/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/26/6826/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f14c6de06fa5257e9192c4a3ec8dfe54cea6c01d","subject":"adiv6: add support for ROM tables in AP"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-01-23 00:25:45.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-06-10 22:05:46.000000000","tz":120},"subject":"adiv6: stay in same AP during dap_lookup_cs_component()","message":"adiv6: stay in same AP during dap_lookup_cs_component()\n\nConfiguration file can specify, as target\u0027s debug AP, an AP that\ncontains a ROM table that points, in turn, to other APs.\nCurrent code in cortex_a and aarch64 is not able to handle a\nreturn from dap_lookup_cs_component() that points to another AP.\n\nWhile it could be interesting to specify \u0027root\u0027 as target\u0027s debug\nAP, drop any found value if it\u0027s not in the starting AP.\n\nChange-Id: Id206e4fa7a29e9402c8e2393026817b410bbb8bd\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"1842cf69a92d07866ebefee3bc7090a58782b059":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2022-06-24 21:39:16.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/26/6826/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/26/6826/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/26/6826/3 \u0026\u0026 git checkout -b change-6826 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/26/6826/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/26/6826/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/26/6826/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/26/6826/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/26/6826/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9f0ac0e6bba85ca8afc99b77ce4ec2df96dba2bb","subject":"adiv6: add support for ROM tables in AP"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-01-23 00:25:45.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-06-24 21:39:16.000000000","tz":0},"subject":"adiv6: stay in same AP during dap_lookup_cs_component()","message":"adiv6: stay in same AP during dap_lookup_cs_component()\n\nConfiguration file can specify, as target\u0027s debug AP, an AP that\ncontains a ROM table that points, in turn, to other APs.\nCurrent code in cortex_a and aarch64 is not able to handle a\nreturn from dap_lookup_cs_component() that points to another AP.\n\nWhile it could be interesting to specify \u0027root\u0027 as target\u0027s debug\nAP, drop any found value if it\u0027s not in the starting AP.\n\nChange-Id: Id206e4fa7a29e9402c8e2393026817b410bbb8bd\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6826\nTested-by: jenkins\n"}},"63f3b6f37ccb58aab8b16efd3d723bc8a5060816":{"kind":"REWORK","_number":1,"created":"2022-01-23 21:05:11.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/26/6826/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/26/6826/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/26/6826/1 \u0026\u0026 git checkout -b change-6826 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/26/6826/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/26/6826/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/26/6826/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/26/6826/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/26/6826/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b9bda8bd5ec2b417c060f8be07e0d6cf2b4ae496","subject":"adiv6: add support for ROM tables in AP"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-01-23 00:25:45.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-01-23 15:36:03.000000000","tz":60},"subject":"adiv6: stay in same AP during dap_lookup_cs_component()","message":"adiv6: stay in same AP during dap_lookup_cs_component()\n\nConfiguration file can specify, as target\u0027s debug AP, an AP that\ncontains a ROM table that points, in turn, to other APs.\nCurrent code in cortex_a and aarch64 is not able to handle a\nreturn from dap_lookup_cs_component() that points to another AP.\n\nWhile it could be interesting to specify \u0027root\u0027 as target\u0027s debug\nAP, drop any found value if it\u0027s not in the starting AP.\n\nChange-Id: Id206e4fa7a29e9402c8e2393026817b410bbb8bd\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}