)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"9e5f3bafa4f9177d435611139c0633ffb80a1afa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8534214d_93c01932","updated":"2022-01-30 11:41:03.000000000","message":"Looks good to me, thanks! Just a small coding style issue.","commit_id":"ec686d0a9ac2a37b42b368075d02bf33a6c0a764"},{"author":{"_account_id":1001958,"name":"Ben McMorran","email":"bemcmorr@microsoft.com","username":"benmcmorran"},"change_message_id":"821d1946ce6719289118ee1a77285977beaa2957","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"bac0739a_eff23c78","updated":"2022-01-31 17:52:27.000000000","message":"Thanks all! I think I\u0027ve addressed all comments.","commit_id":"d4a1614b81262f508cc2a321752085bd45e8cb21"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"be8c07bc0e259e16dfa8df2cc163be6f9b688cf3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a1f47f69_95fe11ea","updated":"2022-01-31 22:03:26.000000000","message":"Thanks!","commit_id":"d4a1614b81262f508cc2a321752085bd45e8cb21"},{"author":{"_account_id":1001958,"name":"Ben McMorran","email":"bemcmorr@microsoft.com","username":"benmcmorran"},"change_message_id":"8ee1298eca2853750e61a3f425cb6c906d238fa2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"92a294bd_0256fb06","updated":"2022-02-02 21:19:27.000000000","message":"This is my first time using Gerrit. Is there any more action required on my part at this point now that it has a +2 review, or is this change simply waiting for a maintainer to submit it? I don\u0027t think I have permissions to submit the change on my own.","commit_id":"d4a1614b81262f508cc2a321752085bd45e8cb21"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"f828d6e9b362394fcfeb65d44abb4b67612f5bc2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ec5e3ca2_15027ff9","in_reply_to":"92a294bd_0256fb06","updated":"2022-02-02 21:29:27.000000000","message":"\u003e This is my first time using Gerrit. Is there any more action required on my part at this point now that it has a +2 review, or is this change simply waiting for a maintainer to submit it?\n\nNo action required from your side. We usually wait ~2 weeks before submitting a +2 patch.\n\n\u003e I don\u0027t think I have permissions to submit the change on my own.\n\nThat\u0027s correct.","commit_id":"d4a1614b81262f508cc2a321752085bd45e8cb21"}],"src/server/gdb_server.c":[{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"9e5f3bafa4f9177d435611139c0633ffb80a1afa","unresolved":true,"context_lines":[{"line_number":2467,"context_line":"\t\t\txml_printf(\u0026retval, \u0026thread_list, \u0026pos, \u0026size,"},{"line_number":2468,"context_line":"\t\t\t\t   \"\u003cthread id\u003d\\\"%\" PRIx64 \"\\\"\", thread_detail-\u003ethreadid);"},{"line_number":2469,"context_line":""},{"line_number":2470,"context_line":"\t\t\tif (thread_detail-\u003ethread_name_str !\u003d NULL)"},{"line_number":2471,"context_line":"\t\t\t\txml_printf(\u0026retval, \u0026thread_list, \u0026pos, \u0026size,"},{"line_number":2472,"context_line":"\t\t\t\t\t   \" name\u003d\\\"%s\\\"\", thread_detail-\u003ethread_name_str);"},{"line_number":2473,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"dec44019_6093a324","line":2470,"updated":"2022-01-30 11:41:03.000000000","message":"Do not compare with NULL here, see \"Avoid comparing pointers with NULL\" in the C style guides.","commit_id":"ec686d0a9ac2a37b42b368075d02bf33a6c0a764"},{"author":{"_account_id":1001958,"name":"Ben McMorran","email":"bemcmorr@microsoft.com","username":"benmcmorran"},"change_message_id":"821d1946ce6719289118ee1a77285977beaa2957","unresolved":false,"context_lines":[{"line_number":2467,"context_line":"\t\t\txml_printf(\u0026retval, \u0026thread_list, \u0026pos, \u0026size,"},{"line_number":2468,"context_line":"\t\t\t\t   \"\u003cthread id\u003d\\\"%\" PRIx64 \"\\\"\", thread_detail-\u003ethreadid);"},{"line_number":2469,"context_line":""},{"line_number":2470,"context_line":"\t\t\tif (thread_detail-\u003ethread_name_str !\u003d NULL)"},{"line_number":2471,"context_line":"\t\t\t\txml_printf(\u0026retval, \u0026thread_list, \u0026pos, \u0026size,"},{"line_number":2472,"context_line":"\t\t\t\t\t   \" name\u003d\\\"%s\\\"\", thread_detail-\u003ethread_name_str);"},{"line_number":2473,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"b6fae0bc_9f8448be","line":2470,"in_reply_to":"dec44019_6093a324","updated":"2022-01-31 17:52:27.000000000","message":"Done","commit_id":"ec686d0a9ac2a37b42b368075d02bf33a6c0a764"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"2112ab95fb276502029241e62a90511095f79c3a","unresolved":true,"context_lines":[{"line_number":2471,"context_line":"\t\t\t\txml_printf(\u0026retval, \u0026thread_list, \u0026pos, \u0026size,"},{"line_number":2472,"context_line":"\t\t\t\t\t   \" name\u003d\\\"%s\\\"\", thread_detail-\u003ethread_name_str);"},{"line_number":2473,"context_line":""},{"line_number":2474,"context_line":"\t\t\txml_printf(\u0026retval, \u0026thread_list, \u0026pos, \u0026size, \"\u003e\");"},{"line_number":2475,"context_line":""},{"line_number":2476,"context_line":"\t\t\tif (thread_detail-\u003ethread_name_str !\u003d NULL)"},{"line_number":2477,"context_line":"\t\t\t\txml_printf(\u0026retval, \u0026thread_list, \u0026pos, \u0026size,"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"a7eaeb39_87ccd201","line":2474,"updated":"2022-01-30 15:14:31.000000000","message":"For readability, may I suggest a different style?\nif (thread_detail-\u003ethread_name_str)\n    xml_printf(..., \"\u003cthread id\u003d... name\u003d...\u003e\", ...);\nelse\n    xml_printf(..., \"\u003cthread id\u003d...\u003e\", ...);","commit_id":"ec686d0a9ac2a37b42b368075d02bf33a6c0a764"},{"author":{"_account_id":1001958,"name":"Ben McMorran","email":"bemcmorr@microsoft.com","username":"benmcmorran"},"change_message_id":"821d1946ce6719289118ee1a77285977beaa2957","unresolved":false,"context_lines":[{"line_number":2471,"context_line":"\t\t\t\txml_printf(\u0026retval, \u0026thread_list, \u0026pos, \u0026size,"},{"line_number":2472,"context_line":"\t\t\t\t\t   \" name\u003d\\\"%s\\\"\", thread_detail-\u003ethread_name_str);"},{"line_number":2473,"context_line":""},{"line_number":2474,"context_line":"\t\t\txml_printf(\u0026retval, \u0026thread_list, \u0026pos, \u0026size, \"\u003e\");"},{"line_number":2475,"context_line":""},{"line_number":2476,"context_line":"\t\t\tif (thread_detail-\u003ethread_name_str !\u003d NULL)"},{"line_number":2477,"context_line":"\t\t\t\txml_printf(\u0026retval, \u0026thread_list, \u0026pos, \u0026size,"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"8da9b50a_aa4d9c93","line":2474,"in_reply_to":"a7eaeb39_87ccd201","updated":"2022-01-31 17:52:27.000000000","message":"Done","commit_id":"ec686d0a9ac2a37b42b368075d02bf33a6c0a764"}]}