)]}'
{"id":"openocd~master~If476410f870eebfbdaccdb1366ba2e9254e2fdf6","project":"openocd","branch":"master","topic":"keepalive","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2022-03-19 09:04:19.000000000","reason":"Change was submitted"},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2022-02-27 06:41:24.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"If476410f870eebfbdaccdb1366ba2e9254e2fdf6","subject":"server: fix: remove kept_alive() from server loop","status":"MERGED","created":"2022-02-03 22:39:35.000000000","updated":"2022-03-19 09:04:19.000000000","submitted":"2022-03-19 09:04:19.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6836-keepalive","meta_rev_id":"b09afba611d2ab89486ad12277cc74361eb9497e","_number":6836,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-03-19 09:04:19.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-03-19 09:04:19.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-03-19 09:04:19.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-02-04 00:53:16.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-02-25 22:27:22.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"CC"},{"updated":"2022-02-27 06:41:24.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"}],"messages":[{"id":"4179ea1eb61ad079471a5bfdd90310e43faeee33","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-02-03 22:39:35.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2d909df91842f5a3cbfcf3337a0e4c8566e97ba2","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-02-04 00:53:16.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15833/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/15045/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"27105fa3c569a9a320d513db2d4c84dbdc8770f4","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-02-25 22:27:22.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"c63ce06bdbcfac71b1e37cad2f684017b7d1d4d0","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-02-25 22:33:25.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"5656be163727eaae3b40f6824b37da69f4ae98cf","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-02-26 15:59:59.000000000","message":"Uploaded patch set 2: Code-Review+1.","accounts_in_message":[],"_revision_number":2},{"id":"2934c41a8acb16cc5879f6f0b71e5dd104fc220f","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-02-26 20:08:56.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15897/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/15115/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"6fc2e02b7db14784879e9ead6134830c60ab919b","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-02-27 06:41:24.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"b09afba611d2ab89486ad12277cc74361eb9497e","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-03-19 09:04:19.000000000","message":"Change has been successfully cherry-picked as 15a72fa644739633ccd071fab840876971228f05","accounts_in_message":[],"_revision_number":3}],"current_revision":"15a72fa644739633ccd071fab840876971228f05","revisions":{"9d48e88093b5fb5f7d449f011902870aa34d3227":{"kind":"REWORK","_number":1,"created":"2022-02-03 22:39:35.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/36/6836/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/36/6836/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/36/6836/1 \u0026\u0026 git checkout -b change-6836 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/36/6836/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/36/6836/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/36/6836/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/36/6836/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/36/6836/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"dbbac5f11d662ab0827a997aa5d173fd62c51708","subject":"semihosting: use open mode flags from GDB, not from sys/stat.h"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-01-30 22:57:38.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-01-31 16:36:18.000000000","tz":60},"subject":"server: fix: remove kept_alive() from server loop","message":"server: fix: remove kept_alive() from server loop\n\nThe kept_alive() action is specific of a server that enjoyed an\nunscheduled keep_alive and want to communicate it to the keep\nalive logic to reschedule next keep_alive().\nIn server loop we are not expected to call kept_alive().\nRemove it!\n\nThis call was erroneously added in commit 94e75e0c06c4.\nLater, commit 7442b26d45dc properly added the same call in\ngdb_put_packet(), but incorrectly left the older in place.\n\nChange-Id: If476410f870eebfbdaccdb1366ba2e9254e2fdf6\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"15a72fa644739633ccd071fab840876971228f05":{"kind":"REWORK","_number":3,"created":"2022-03-19 09:04:19.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/36/6836/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/36/6836/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/36/6836/3 \u0026\u0026 git checkout -b change-6836 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/36/6836/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/36/6836/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/36/6836/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/36/6836/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/36/6836/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"be0d68eb66b513ef406ffa83102f89a8f4602914","subject":"Remove all occurrences of \u0027mem2array\u0027 and \u0027array2mem\u0027"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-01-30 22:57:38.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-03-19 09:04:19.000000000","tz":0},"subject":"server: fix: remove kept_alive() from server loop","message":"server: fix: remove kept_alive() from server loop\n\nThe kept_alive() action is specific of a server that enjoyed an\nunscheduled keep_alive and want to communicate it to the keep\nalive logic to reschedule next keep_alive().\nIn server loop we are not expected to call kept_alive().\nRemove it!\n\nThis call was erroneously added in commit 94e75e0c06c4.\nLater, commit 7442b26d45dc properly added the same call in\ngdb_put_packet(), but incorrectly left the older in place.\n\nChange-Id: If476410f870eebfbdaccdb1366ba2e9254e2fdf6\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6836\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nTested-by: jenkins\n"}},"984ce7f7aa3f6583710069da3c6c210f8fa10cba":{"kind":"REWORK","_number":2,"created":"2022-02-26 15:59:59.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/36/6836/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/36/6836/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/36/6836/2 \u0026\u0026 git checkout -b change-6836 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/36/6836/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/36/6836/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/36/6836/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/36/6836/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/36/6836/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"103b1d68db5038edd9e8878c798525715590f4e1","subject":"gdb_server: check target examined while combining reg list"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-01-30 22:57:38.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-02-26 15:48:42.000000000","tz":60},"subject":"server: fix: remove kept_alive() from server loop","message":"server: fix: remove kept_alive() from server loop\n\nThe kept_alive() action is specific of a server that enjoyed an\nunscheduled keep_alive and want to communicate it to the keep\nalive logic to reschedule next keep_alive().\nIn server loop we are not expected to call kept_alive().\nRemove it!\n\nThis call was erroneously added in commit 94e75e0c06c4.\nLater, commit 7442b26d45dc properly added the same call in\ngdb_put_packet(), but incorrectly left the older in place.\n\nChange-Id: If476410f870eebfbdaccdb1366ba2e9254e2fdf6\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}