)]}'
{"id":"openocd~master~I2b5e7140db95021f6e7201e9d631ee340c60b453","project":"openocd","branch":"master","topic":"keepalive","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2022-03-07 10:45:45.000000000","reason":"Antonio Borneo replied on the change"},"1000863":{"account":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"last_update":"2022-03-19 09:05:27.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I2b5e7140db95021f6e7201e9d631ee340c60b453","subject":"server: change prototype of add_service()","status":"MERGED","created":"2022-02-03 22:39:35.000000000","updated":"2022-03-19 09:05:27.000000000","submitted":"2022-03-19 09:05:27.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":7,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"6838-keepalive","meta_rev_id":"02ddd63d86a0bf8a27344bcf2ffb51faf139511a","_number":6838,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-03-19 09:05:27.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-03-19 09:05:27.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-03-19 09:05:27.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"}],"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-02-04 01:35:46.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-02-27 17:01:57.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"},{"updated":"2022-03-04 20:06:55.000000000","updated_by":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"reviewer":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"state":"CC"}],"messages":[{"id":"9c723d6a7e7962f3b3d9a31c0c35365d8cf38fdf","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-02-03 22:39:35.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"61a4fb848700ececab6ec8685d65509bea585e46","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-02-04 01:35:46.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15835/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/15047/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"c3121e57fc44c441cb79d24e51566cbdb869ce76","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-02-26 15:59:59.000000000","message":"Uploaded patch set 2: Code-Review+1: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"64f907bf62babe4e28bfb9c992fda72ea1fef355","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-02-26 16:50:45.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15899/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/15110/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"16c3e91f2de6d574c53e749bfbdec6d2b74a0864","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-02-27 17:01:57.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"38e44017c3864ef1230c2358215949a0d9e16637","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2022-03-04 20:06:55.000000000","message":"Patch Set 2:\n\n(3 comments)","accounts_in_message":[],"_revision_number":2},{"id":"a66166570ff98c1d08bc31e6a540b7dc988f26a5","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-03-04 22:35:06.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"512cf3402ea3cfc1c62090b60654e0751aebff6a","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2022-03-07 10:08:28.000000000","message":"Patch Set 2:\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"0add66ce12a77aa50a97cd0a3cf146c1c0a5966a","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-03-07 10:45:45.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"02ddd63d86a0bf8a27344bcf2ffb51faf139511a","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-03-19 09:05:27.000000000","message":"Change has been successfully cherry-picked as 99c77806fea2625dfa2b5a3234267634d0342388","accounts_in_message":[],"_revision_number":3}],"current_revision":"99c77806fea2625dfa2b5a3234267634d0342388","revisions":{"48fe8e7be5a5d6d1fccb1cf5f26702a1820567b1":{"kind":"REWORK","_number":1,"created":"2022-02-03 22:39:35.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/38/6838/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/38/6838/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/38/6838/1 \u0026\u0026 git checkout -b change-6838 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/38/6838/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/38/6838/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/38/6838/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/38/6838/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/38/6838/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ed6b861b254a1911876ea13a6c7adc4973dca4f4","subject":"log: drop global current_time"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-01-30 17:42:33.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-02-03 22:03:18.000000000","tz":60},"subject":"server: change prototype of add_service()","message":"server: change prototype of add_service()\n\nTo easily add new methods to a service, pass all the methods\nthrough a struct.\nWhile there, drop the typedef for the methods and add currently\nunused new methods to support keep-alive and connections during\nkeep-alive.\n\nNo change in functionality.\n\nChange-Id: I2b5e7140db95021f6e7201e9d631ee340c60b453\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"99c77806fea2625dfa2b5a3234267634d0342388":{"kind":"REWORK","_number":3,"created":"2022-03-19 09:05:27.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/38/6838/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/38/6838/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/38/6838/3 \u0026\u0026 git checkout -b change-6838 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/38/6838/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/38/6838/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/38/6838/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/38/6838/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/38/6838/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"36e29f49e1582c4fe32e3e02600c8a49129551e5","subject":"log: drop global current_time"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-01-30 17:42:33.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-03-19 09:05:27.000000000","tz":0},"subject":"server: change prototype of add_service()","message":"server: change prototype of add_service()\n\nTo easily add new methods to a service, pass all the methods\nthrough a struct.\nWhile there, drop the typedef for the methods and add currently\nunused new methods to support keep-alive and connections during\nkeep-alive.\n\nNo change in functionality.\n\nChange-Id: I2b5e7140db95021f6e7201e9d631ee340c60b453\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6838\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nTested-by: jenkins\n"}},"39593bb47c93ac5ea60c95cb2a89589eed4346fe":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2022-02-26 15:59:59.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/38/6838/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/38/6838/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/38/6838/2 \u0026\u0026 git checkout -b change-6838 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/38/6838/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/38/6838/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/38/6838/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/38/6838/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/38/6838/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1da34eb0ac05f3c6decbbe0a63f057bb254395c3","subject":"log: drop global current_time"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-01-30 17:42:33.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-02-26 15:49:21.000000000","tz":60},"subject":"server: change prototype of add_service()","message":"server: change prototype of add_service()\n\nTo easily add new methods to a service, pass all the methods\nthrough a struct.\nWhile there, drop the typedef for the methods and add currently\nunused new methods to support keep-alive and connections during\nkeep-alive.\n\nNo change in functionality.\n\nChange-Id: I2b5e7140db95021f6e7201e9d631ee340c60b453\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}