)]}'
{"id":"openocd~master~I072d3c6928dedfd0cef0abe7acf9bdd4b89dbf5b","project":"openocd","branch":"master","topic":"keepalive","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2022-03-19 09:10:17.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I072d3c6928dedfd0cef0abe7acf9bdd4b89dbf5b","subject":"gdb_server: simplify logic to enable/disable gdb_log_callback()","status":"MERGED","created":"2022-02-03 22:39:35.000000000","updated":"2022-03-19 09:10:17.000000000","submitted":"2022-03-19 09:10:17.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6839-keepalive","meta_rev_id":"72734878e78595b2ce41ba040d5686ac4c44008d","_number":6839,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-03-19 09:10:17.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-03-19 09:10:17.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-03-19 09:10:17.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-02-04 01:49:22.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-02-27 17:02:12.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"}],"messages":[{"id":"0581a4b22e8e26e7b4934a44efeb1198aec60f34","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-02-03 22:39:35.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"fab39541d6ade8f042f957e487fb8d66f9874b3c","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-02-04 01:49:22.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15836/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/15048/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"d27bf5ab00ca7d2fce9e61ee96724e91b92b5cb6","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-02-26 15:59:59.000000000","message":"Uploaded patch set 2: Code-Review+1: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"72b97fe9a80dd0e06f58bfae6941bd57d5458380","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-02-26 18:01:56.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15900/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/15111/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"81cddbb86f97e12ebcdcb651af3c70d0f914b921","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-02-27 17:02:12.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"72734878e78595b2ce41ba040d5686ac4c44008d","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-03-19 09:10:17.000000000","message":"Change has been successfully cherry-picked as 5c26fd7ab8916d25cb876487d39ec45e3c936d55","accounts_in_message":[],"_revision_number":3}],"current_revision":"5c26fd7ab8916d25cb876487d39ec45e3c936d55","revisions":{"a60a5da9d10cb93e53721e7ac3224ac2f9ab5827":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2022-02-26 15:59:59.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/39/6839/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/39/6839/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/39/6839/2 \u0026\u0026 git checkout -b change-6839 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/39/6839/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/39/6839/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/39/6839/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/39/6839/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/39/6839/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"39593bb47c93ac5ea60c95cb2a89589eed4346fe","subject":"server: change prototype of add_service()"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-01-31 09:08:29.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-02-26 15:49:28.000000000","tz":60},"subject":"gdb_server: simplify logic to enable/disable gdb_log_callback()","message":"gdb_server: simplify logic to enable/disable gdb_log_callback()\n\nGDB client cannot always display generic messages from OpenOCD.\nThe callback gdb_log_callback() is continuously added and removed\nto follow the GDB status and thus enabling/disabling sending the\nOpenOCD output to GDB.\nWhile this is a nice stress test for log_{add,remove}_callback(),\nit is also a waste of computational resources that could impact\nthe speed of OpenOCD during GDB user interactions.\n\nAdd a connection-level flag to enable/disable the log callback and\nsimply change the flag instead of adding/removing the callback.\n\nUse an enum for the flag instead of a bool. This improves code\nreadability and allows setting other states, e.g. keep-alive\nthrough asynchronous notification https://review.openocd.org/4828/\n\nChange-Id: I072d3c6928dedfd0cef0abe7acf9bdd4b89dbf5b\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"5c26fd7ab8916d25cb876487d39ec45e3c936d55":{"kind":"REWORK","_number":3,"created":"2022-03-19 09:10:17.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/39/6839/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/39/6839/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/39/6839/3 \u0026\u0026 git checkout -b change-6839 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/39/6839/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/39/6839/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/39/6839/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/39/6839/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/39/6839/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"99c77806fea2625dfa2b5a3234267634d0342388","subject":"server: change prototype of add_service()"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-01-31 09:08:29.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-03-19 09:10:17.000000000","tz":0},"subject":"gdb_server: simplify logic to enable/disable gdb_log_callback()","message":"gdb_server: simplify logic to enable/disable gdb_log_callback()\n\nGDB client cannot always display generic messages from OpenOCD.\nThe callback gdb_log_callback() is continuously added and removed\nto follow the GDB status and thus enabling/disabling sending the\nOpenOCD output to GDB.\nWhile this is a nice stress test for log_{add,remove}_callback(),\nit is also a waste of computational resources that could impact\nthe speed of OpenOCD during GDB user interactions.\n\nAdd a connection-level flag to enable/disable the log callback and\nsimply change the flag instead of adding/removing the callback.\n\nUse an enum for the flag instead of a bool. This improves code\nreadability and allows setting other states, e.g. keep-alive\nthrough asynchronous notification https://review.openocd.org/4828/\n\nChange-Id: I072d3c6928dedfd0cef0abe7acf9bdd4b89dbf5b\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6839\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nTested-by: jenkins\n"}},"307f1fc058d48e9afa6935eb660929773d7d47a8":{"kind":"REWORK","_number":1,"created":"2022-02-03 22:39:35.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/39/6839/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/39/6839/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/39/6839/1 \u0026\u0026 git checkout -b change-6839 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/39/6839/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/39/6839/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/39/6839/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/39/6839/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/39/6839/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"48fe8e7be5a5d6d1fccb1cf5f26702a1820567b1","subject":"server: change prototype of add_service()"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-01-31 09:08:29.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-02-03 22:03:29.000000000","tz":60},"subject":"gdb_server: simplify logic to enable/disable gdb_log_callback()","message":"gdb_server: simplify logic to enable/disable gdb_log_callback()\n\nGDB client cannot always display generic messages from OpenOCD.\nThe callback gdb_log_callback() is continuously added and removed\nto follow the GDB status and thus enabling/disabling sending the\nOpenOCD output to GDB.\nWhile this is a nice stress test for log_{add,remove}_callback(),\nit is also a waste of computational resources that could impact\nthe speed of OpenOCD during GDB user interactions.\n\nAdd a connection-level flag to enable/disable the log callback and\nsimply change the flag instead of adding/removing the callback.\n\nUse an enum for the flag instead of a bool. This improves code\nreadability and allows setting other states, e.g. keep-alive\nthrough asynchronous notification https://review.openocd.org/4828/\n\nChange-Id: I072d3c6928dedfd0cef0abe7acf9bdd4b89dbf5b\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}