)]}'
{"id":"openocd~master~Iebb00b00fb74b3c9665d9e1ddd3c055275bfbd43","project":"openocd","branch":"master","topic":"keepalive","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2022-03-19 09:10:39.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Iebb00b00fb74b3c9665d9e1ddd3c055275bfbd43","subject":"keep-alive: drop link with log framework","status":"MERGED","created":"2022-02-03 22:39:35.000000000","updated":"2022-03-19 09:10:39.000000000","submitted":"2022-03-19 09:10:39.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6840-keepalive","meta_rev_id":"2bbaa80031e0eceba0346e57e3453c22c8b0a76e","_number":6840,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-03-19 09:10:39.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-03-19 09:10:39.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-03-19 09:10:39.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-02-04 02:08:01.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-02-27 17:02:43.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"}],"messages":[{"id":"4586fd328d2052ffaf0d9796bf31492a51687b39","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-02-03 22:39:35.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5fe3b5d66a336380e5c4ad09be9035b0758d805c","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-02-04 02:08:01.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15837/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/15049/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"ba3fb84c8b23e8e794574df64ca8a599a1fe50eb","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-02-26 15:59:59.000000000","message":"Uploaded patch set 2: Code-Review+1: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"bb2cef57bf9c8a0827ba5ae7baeb0d369dbacc01","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-02-26 19:54:56.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15902/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/15114/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"f79a1019ab236b7e48e8089c6cfab718cb31b39f","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-02-27 17:02:43.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"2bbaa80031e0eceba0346e57e3453c22c8b0a76e","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-03-19 09:10:39.000000000","message":"Change has been successfully cherry-picked as 4e5dbecd9b1ac780181e04f8b51a4cd133c4cdbe","accounts_in_message":[],"_revision_number":3}],"current_revision":"4e5dbecd9b1ac780181e04f8b51a4cd133c4cdbe","revisions":{"72a78983cf12e3a2a1c04d51f8ab2f566fbc5642":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2022-02-26 15:59:59.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/40/6840/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/40/6840/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/40/6840/2 \u0026\u0026 git checkout -b change-6840 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/40/6840/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/40/6840/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/40/6840/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/40/6840/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/40/6840/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a60a5da9d10cb93e53721e7ac3224ac2f9ab5827","subject":"gdb_server: simplify logic to enable/disable gdb_log_callback()"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-01-31 09:51:49.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-02-26 15:49:35.000000000","tz":60},"subject":"keep-alive: drop link with log framework","message":"keep-alive: drop link with log framework\n\nOpenOCD implements the GDB keep-alive by sending empty strings as\noutput for GDB client. This has been implemented as part of the\nlog framework, creating an odd dependency.\n\nMove the keep-alive notifications out of log framework.\nFor the moment, keep keep_alive() inside log.c, but it should be\nmoved in server.c\n\nThis should also fix an old issue with KDE Konsole when tab alert\nfor activity is enabled. The empty strings is sent to all the\nconnections, including telnet, and causes the tab running OpenOCD\ntelnet to continuously show activity even when no new text is\nprinted. Anyway, I cannot replicate this issue anymore.\n\nChange-Id: Iebb00b00fb74b3c9665d9e1ddd3c055275bfbd43\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"4e5dbecd9b1ac780181e04f8b51a4cd133c4cdbe":{"kind":"REWORK","_number":3,"created":"2022-03-19 09:10:39.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/40/6840/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/40/6840/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/40/6840/3 \u0026\u0026 git checkout -b change-6840 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/40/6840/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/40/6840/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/40/6840/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/40/6840/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/40/6840/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"5c26fd7ab8916d25cb876487d39ec45e3c936d55","subject":"gdb_server: simplify logic to enable/disable gdb_log_callback()"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-01-31 09:51:49.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-03-19 09:10:39.000000000","tz":0},"subject":"keep-alive: drop link with log framework","message":"keep-alive: drop link with log framework\n\nOpenOCD implements the GDB keep-alive by sending empty strings as\noutput for GDB client. This has been implemented as part of the\nlog framework, creating an odd dependency.\n\nMove the keep-alive notifications out of log framework.\nFor the moment, keep keep_alive() inside log.c, but it should be\nmoved in server.c\n\nThis should also fix an old issue with KDE Konsole when tab alert\nfor activity is enabled. The empty strings is sent to all the\nconnections, including telnet, and causes the tab running OpenOCD\ntelnet to continuously show activity even when no new text is\nprinted. Anyway, I cannot replicate this issue anymore.\n\nChange-Id: Iebb00b00fb74b3c9665d9e1ddd3c055275bfbd43\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6840\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nTested-by: jenkins\n"}},"7546b2c992104cba0f919efa99e58469405bc52d":{"kind":"REWORK","_number":1,"created":"2022-02-03 22:39:35.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/40/6840/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/40/6840/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/40/6840/1 \u0026\u0026 git checkout -b change-6840 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/40/6840/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/40/6840/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/40/6840/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/40/6840/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/40/6840/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"307f1fc058d48e9afa6935eb660929773d7d47a8","subject":"gdb_server: simplify logic to enable/disable gdb_log_callback()"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-01-31 09:51:49.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-02-03 22:37:32.000000000","tz":60},"subject":"keep-alive: drop link with log framework","message":"keep-alive: drop link with log framework\n\nOpenOCD implements the GDB keep-alive by sending empty strings as\noutput for GDB client. This has been implemented as part of the\nlog framework, creating an odd dependency.\n\nMove the keep-alive notifications out of log framework.\nFor the moment, keep keep_alive() inside log.c, but it should be\nmoved in server.c\n\nThis should also fix an old issue with KDE Konsole when tab alert\nfor activity is enabled. The empty strings is sent to all the\nconnections, including telnet, and causes the tab running OpenOCD\ntelnet to continuously show activity even when no new text is\nprinted. Anyway, I cannot replicate this issue anymore.\n\nChange-Id: Iebb00b00fb74b3c9665d9e1ddd3c055275bfbd43\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}