)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"change_message_id":"c17918097a7fdc950b295459d7363deba0bfbb11","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6b881dea_a8978724","updated":"2022-03-02 07:26:26.000000000","message":"Antonio, thanks for reviewing the code.\n\nI\u0027ve addressed your points. \n\nWhile at it, I have cleaned up few more items in jtag_vpi. Commit msg updated accordingly.","commit_id":"b3cc8e0c1b91f3f71c596136b60bf6a1f51c09ec"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"d4b35e7916787c44f8200c71c6b4c946db1f4699","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"552c084f_6b5f7e67","updated":"2022-03-02 09:29:29.000000000","message":"Thanks!","commit_id":"b3cc8e0c1b91f3f71c596136b60bf6a1f51c09ec"}],"src/jtag/drivers/jtag_vpi.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"41f03879884bec3e4078dc04d73c9b36c6c14f49","unresolved":true,"context_lines":[{"line_number":605,"context_line":"COMMAND_HANDLER(jtag_vpi_set_port)"},{"line_number":606,"context_line":"{"},{"line_number":607,"context_line":"\tif (CMD_ARGC \u003d\u003d 0)"},{"line_number":608,"context_line":"\t\tLOG_ERROR(\"Command \\\"jtag_vpi set_port\\\" expects 1 argument (TCP port number)\");"},{"line_number":609,"context_line":"\telse"},{"line_number":610,"context_line":"\t\tCOMMAND_PARSE_NUMBER(int, CMD_ARGV[0], server_port);"},{"line_number":611,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"c00eca9e_b4271177","line":608,"updated":"2022-03-01 15:19:42.000000000","message":"Agree this is an error case, but LOG_ERROR() should be associated with returning an error code, in this case it should be ERROR_COMMAND_SYNTAX_ERROR","commit_id":"6c394300bb627698a19a6aba94c9c68de183d743"},{"author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"change_message_id":"c17918097a7fdc950b295459d7363deba0bfbb11","unresolved":false,"context_lines":[{"line_number":605,"context_line":"COMMAND_HANDLER(jtag_vpi_set_port)"},{"line_number":606,"context_line":"{"},{"line_number":607,"context_line":"\tif (CMD_ARGC \u003d\u003d 0)"},{"line_number":608,"context_line":"\t\tLOG_ERROR(\"Command \\\"jtag_vpi set_port\\\" expects 1 argument (TCP port number)\");"},{"line_number":609,"context_line":"\telse"},{"line_number":610,"context_line":"\t\tCOMMAND_PARSE_NUMBER(int, CMD_ARGV[0], server_port);"},{"line_number":611,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"f366dc76_4c9e5f8a","line":608,"in_reply_to":"c00eca9e_b4271177","updated":"2022-03-02 07:26:26.000000000","message":"Thanks - fixed.","commit_id":"6c394300bb627698a19a6aba94c9c68de183d743"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"41f03879884bec3e4078dc04d73c9b36c6c14f49","unresolved":true,"context_lines":[{"line_number":611,"context_line":""},{"line_number":612,"context_line":"\tLOG_INFO(\"jtag_vpi: server port set to %u\", server_port);"},{"line_number":613,"context_line":""},{"line_number":614,"context_line":"\treturn ERROR_OK;"},{"line_number":615,"context_line":"}"},{"line_number":616,"context_line":""},{"line_number":617,"context_line":"COMMAND_HANDLER(jtag_vpi_set_address)"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"a5d90bfa_493b898e","line":614,"updated":"2022-03-01 15:19:42.000000000","message":"but here always return ERROR_OK","commit_id":"6c394300bb627698a19a6aba94c9c68de183d743"},{"author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"change_message_id":"c17918097a7fdc950b295459d7363deba0bfbb11","unresolved":false,"context_lines":[{"line_number":611,"context_line":""},{"line_number":612,"context_line":"\tLOG_INFO(\"jtag_vpi: server port set to %u\", server_port);"},{"line_number":613,"context_line":""},{"line_number":614,"context_line":"\treturn ERROR_OK;"},{"line_number":615,"context_line":"}"},{"line_number":616,"context_line":""},{"line_number":617,"context_line":"COMMAND_HANDLER(jtag_vpi_set_address)"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"90bf1618_962c6288","line":614,"in_reply_to":"a5d90bfa_493b898e","updated":"2022-03-02 07:26:26.000000000","message":"Done","commit_id":"6c394300bb627698a19a6aba94c9c68de183d743"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"41f03879884bec3e4078dc04d73c9b36c6c14f49","unresolved":true,"context_lines":[{"line_number":619,"context_line":"\tfree(server_address);"},{"line_number":620,"context_line":""},{"line_number":621,"context_line":"\tif (CMD_ARGC \u003d\u003d 0) {"},{"line_number":622,"context_line":"\t\tLOG_ERROR(\"Command \\\"jtag_vpi set_address\\\" expects 1 argument (IP address)\");"},{"line_number":623,"context_line":"\t\tserver_address \u003d strdup(SERVER_ADDRESS);"},{"line_number":624,"context_line":"\t} else"},{"line_number":625,"context_line":"\t\tserver_address \u003d strdup(CMD_ARGV[0]);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"fef7eaed_5a5a41a5","line":622,"updated":"2022-03-01 15:19:42.000000000","message":"same here","commit_id":"6c394300bb627698a19a6aba94c9c68de183d743"},{"author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"change_message_id":"c17918097a7fdc950b295459d7363deba0bfbb11","unresolved":false,"context_lines":[{"line_number":619,"context_line":"\tfree(server_address);"},{"line_number":620,"context_line":""},{"line_number":621,"context_line":"\tif (CMD_ARGC \u003d\u003d 0) {"},{"line_number":622,"context_line":"\t\tLOG_ERROR(\"Command \\\"jtag_vpi set_address\\\" expects 1 argument (IP address)\");"},{"line_number":623,"context_line":"\t\tserver_address \u003d strdup(SERVER_ADDRESS);"},{"line_number":624,"context_line":"\t} else"},{"line_number":625,"context_line":"\t\tserver_address \u003d strdup(CMD_ARGV[0]);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"1830e1c6_c842d1e9","line":622,"in_reply_to":"fef7eaed_5a5a41a5","updated":"2022-03-02 07:26:26.000000000","message":"Fixed, too.","commit_id":"6c394300bb627698a19a6aba94c9c68de183d743"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"41f03879884bec3e4078dc04d73c9b36c6c14f49","unresolved":true,"context_lines":[{"line_number":633,"context_line":"{"},{"line_number":634,"context_line":"\tif (CMD_ARGC !\u003d 1) {"},{"line_number":635,"context_line":"\t\tLOG_ERROR(\"Command \\\"jtag_vpi stop_sim_on_exit\\\" expects 1 argument (on|off)\");"},{"line_number":636,"context_line":"\t\treturn ERROR_COMMAND_SYNTAX_ERROR;"},{"line_number":637,"context_line":"\t} else {"},{"line_number":638,"context_line":"\t\tCOMMAND_PARSE_ON_OFF(CMD_ARGV[0], stop_sim_on_exit);"},{"line_number":639,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"069cf985_c0c1fa73","line":636,"updated":"2022-03-01 15:19:42.000000000","message":"as it\u0027s correctly done here","commit_id":"6c394300bb627698a19a6aba94c9c68de183d743"},{"author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"change_message_id":"c17918097a7fdc950b295459d7363deba0bfbb11","unresolved":false,"context_lines":[{"line_number":633,"context_line":"{"},{"line_number":634,"context_line":"\tif (CMD_ARGC !\u003d 1) {"},{"line_number":635,"context_line":"\t\tLOG_ERROR(\"Command \\\"jtag_vpi stop_sim_on_exit\\\" expects 1 argument (on|off)\");"},{"line_number":636,"context_line":"\t\treturn ERROR_COMMAND_SYNTAX_ERROR;"},{"line_number":637,"context_line":"\t} else {"},{"line_number":638,"context_line":"\t\tCOMMAND_PARSE_ON_OFF(CMD_ARGV[0], stop_sim_on_exit);"},{"line_number":639,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"281325ff_23d9f050","line":636,"in_reply_to":"069cf985_c0c1fa73","updated":"2022-03-02 07:26:26.000000000","message":"Done","commit_id":"6c394300bb627698a19a6aba94c9c68de183d743"}]}