)]}'
{"id":"openocd~master~Ibe386403a179adab5edb69c77fa408aef55701bd","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1001667":{"account":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"last_update":"2022-03-12 09:43:26.000000000","reason":"Change was submitted"},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2022-03-02 09:29:29.000000000","reason":"Antonio Borneo replied on the change"}},"hashtags":[],"change_id":"Ibe386403a179adab5edb69c77fa408aef55701bd","subject":"jtag_vpi: Minor cleanup in jtag_vpi driver","status":"MERGED","created":"2022-02-04 13:46:45.000000000","updated":"2022-03-12 09:43:26.000000000","submitted":"2022-03-12 09:43:26.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":10,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6845","meta_rev_id":"acd84fd942d3482f373a7bc2570a97c6775f68e1","_number":6845,"owner":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-03-12 09:43:26.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-03-12 09:43:26.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-03-12 09:43:26.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-02-04 14:05:08.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-03-01 13:42:31.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"},{"updated":"2022-03-01 15:19:42.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"CC"},{"updated":"2022-03-02 09:29:29.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"e805ae6c9862e057355d4084bc14e69d3e6f5087","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2022-02-04 13:46:45.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1ca4a2db86faa93a0cc1e30ece36c687a9dc0f28","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-02-04 14:05:08.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15845/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/15057/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"08e0f48d5e35472a95da5290b58461ae1507227e","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-03-01 13:42:31.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"41f03879884bec3e4078dc04d73c9b36c6c14f49","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-03-01 15:19:42.000000000","message":"Patch Set 1:\n\n(4 comments)","accounts_in_message":[],"_revision_number":1},{"id":"b358118cb359a9e049756a31af17d60aaddf51ae","tag":"autogenerated:gerrit:deleteVote","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-03-01 15:28:55.000000000","message":"Removed Code-Review+2 by Tomas Vanek \u003cvanekt@fbl.cz\u003e\n","accounts_in_message":[],"_revision_number":1},{"id":"4fe07c96ed9490876ae0ce33f16e2c5036129e23","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2022-03-02 07:23:21.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"c17918097a7fdc950b295459d7363deba0bfbb11","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2022-03-02 07:26:26.000000000","message":"Patch Set 2:\n\n(5 comments)","accounts_in_message":[],"_revision_number":2},{"id":"2743bee631652f9fc544212d13c4ba24a08de08b","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-03-02 07:42:01.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15931/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/15141/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"d4b35e7916787c44f8200c71c6b4c946db1f4699","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-03-02 09:29:29.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"0fa44ab99564f647122d5d1c8e13d0ce6a2fa782","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-03-02 10:21:52.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"acd84fd942d3482f373a7bc2570a97c6775f68e1","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-03-12 09:43:26.000000000","message":"Change has been successfully cherry-picked as 6883567d5f734040a40c4b2c2d739fa432132cb2","accounts_in_message":[],"_revision_number":3}],"current_revision":"6883567d5f734040a40c4b2c2d739fa432132cb2","revisions":{"6c394300bb627698a19a6aba94c9c68de183d743":{"kind":"REWORK","_number":1,"created":"2022-02-04 13:46:45.000000000","uploader":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"ref":"refs/changes/45/6845/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/45/6845/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/45/6845/1 \u0026\u0026 git checkout -b change-6845 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/45/6845/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/45/6845/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/45/6845/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/45/6845/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/45/6845/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"dbbac5f11d662ab0827a997aa5d173fd62c51708","subject":"semihosting: use open mode flags from GDB, not from sys/stat.h"}],"author":{"name":"Jan Matyas","email":"matyas@codasip.com","date":"2022-02-04 13:44:24.000000000","tz":60},"committer":{"name":"Jan Matyas","email":"matyas@codasip.com","date":"2022-02-04 13:44:24.000000000","tz":60},"subject":"jtag_vpi: Minor update to several log prints","message":"jtag_vpi: Minor update to several log prints\n\nSeveral log prints in the \"jtag_vpi\" driver were adjusted\nto make them more clear to the user.\n\nNo change in functionality - just the prints.\n\nChange-Id: Ibe386403a179adab5edb69c77fa408aef55701bd\nSigned-off-by: Jan Matyas \u003cmatyas@codasip.com\u003e\n"}},"6883567d5f734040a40c4b2c2d739fa432132cb2":{"kind":"REWORK","_number":3,"created":"2022-03-12 09:43:26.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/45/6845/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/45/6845/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/45/6845/3 \u0026\u0026 git checkout -b change-6845 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/45/6845/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/45/6845/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/45/6845/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/45/6845/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/45/6845/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9a6417e03595e1194f125ca33d2b60b8eac9a512","subject":"tcl: don\u0027t use \u0027set\u0027 to retrieve the value of a variable"}],"author":{"name":"Jan Matyas","email":"matyas@codasip.com","date":"2022-02-04 13:44:24.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-03-12 09:43:26.000000000","tz":0},"subject":"jtag_vpi: Minor cleanup in jtag_vpi driver","message":"jtag_vpi: Minor cleanup in jtag_vpi driver\n\nMultiple smaller items addressed in jtag_vpi:\n\n- Several log prints adjusted to make them more clear to the user.\n\n- Ensured that command handlers return ERROR_COMMAND_SYNTAX_ERROR\n  on incorrect number of arguments.\n\n- Fix in \"jtag_vpi set_address\": Leave the previously set address\n  intact on error. Do not revert it to default.\n\n- Minor update of help messages for the TCL commands.\n\n- Updated macro names: SERVER_ADDRESS --\u003e DEFAULT_SERVER_ADDRESS,\n  the same for SERVER_PORT\n\nChange-Id: Ibe386403a179adab5edb69c77fa408aef55701bd\nSigned-off-by: Jan Matyas \u003cmatyas@codasip.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6845\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"b3cc8e0c1b91f3f71c596136b60bf6a1f51c09ec":{"kind":"REWORK","_number":2,"created":"2022-03-02 07:23:21.000000000","uploader":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"ref":"refs/changes/45/6845/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/45/6845/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/45/6845/2 \u0026\u0026 git checkout -b change-6845 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/45/6845/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/45/6845/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/45/6845/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/45/6845/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/45/6845/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"dbbac5f11d662ab0827a997aa5d173fd62c51708","subject":"semihosting: use open mode flags from GDB, not from sys/stat.h"}],"author":{"name":"Jan Matyas","email":"matyas@codasip.com","date":"2022-02-04 13:44:24.000000000","tz":60},"committer":{"name":"Jan Matyas","email":"matyas@codasip.com","date":"2022-03-02 07:22:09.000000000","tz":60},"subject":"jtag_vpi: Minor cleanup in jtag_vpi driver","message":"jtag_vpi: Minor cleanup in jtag_vpi driver\n\nMultiple smaller items addressed in jtag_vpi:\n\n- Several log prints adjusted to make them more clear to the user.\n\n- Ensured that command handlers return ERROR_COMMAND_SYNTAX_ERROR\n  on incorrect number of arguments.\n\n- Fix in \"jtag_vpi set_address\": Leave the previously set address\n  intact on error. Do not revert it to default.\n\n- Minor update of help messages for the TCL commands.\n\n- Updated macro names: SERVER_ADDRESS --\u003e DEFAULT_SERVER_ADDRESS,\n  the same for SERVER_PORT\n\nChange-Id: Ibe386403a179adab5edb69c77fa408aef55701bd\nSigned-off-by: Jan Matyas \u003cmatyas@codasip.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}