)]}'
{"id":"openocd~master~I1b725292d8a11274d03af5313dc83678e10e944c","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2022-02-26 15:36:09.000000000","reason":"removed on reply"},"1001960":{"account":{"_account_id":1001960,"name":"sean-anderson-seco","email":"sean.anderson@seco.com","username":"sean-anderson-seco"},"last_update":"2022-02-26 15:36:16.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I1b725292d8a11274d03af5313dc83678e10e944c","subject":"target: ls1088a: Add service processor","status":"MERGED","created":"2022-02-14 23:08:00.000000000","updated":"2022-02-26 15:36:16.000000000","submitted":"2022-02-26 15:36:16.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6850","meta_rev_id":"d392a73bfed0425d5a1630305319eb84e7b6e29a","_number":6850,"owner":{"_account_id":1001960,"name":"sean-anderson-seco","email":"sean.anderson@seco.com","username":"sean-anderson-seco"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-02-26 15:36:16.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-02-26 15:36:16.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-02-15 00:02:22.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-02-15 08:54:10.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"75d98847518ab97950a88e06a89e49e9b3ece4e1","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001960,"name":"sean-anderson-seco","email":"sean.anderson@seco.com","username":"sean-anderson-seco"},"real_author":{"_account_id":1001960,"name":"sean-anderson-seco","email":"sean.anderson@seco.com","username":"sean-anderson-seco"},"date":"2022-02-14 23:08:00.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1628cc1886abdf10e95be62af4591f650e391e09","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-02-15 00:02:22.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15867/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/15079/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"3196adc4525cc4d0ede5ccf1f9badfc0108fd362","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-02-15 08:54:10.000000000","message":"Patch Set 1: Code-Review+1\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"c05c9dd35f1583ed3b6b38e4374cbb70916b88d4","author":{"_account_id":1001960,"name":"sean-anderson-seco","email":"sean.anderson@seco.com","username":"sean-anderson-seco"},"real_author":{"_account_id":1001960,"name":"sean-anderson-seco","email":"sean.anderson@seco.com","username":"sean-anderson-seco"},"date":"2022-02-15 16:08:21.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"c0f5a9e1977d6e52ecbe9c1417407ad64124ee42","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-02-26 15:36:09.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"d392a73bfed0425d5a1630305319eb84e7b6e29a","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-02-26 15:36:16.000000000","message":"Change has been successfully cherry-picked as d1278660afcb3315fe74def3c2ca51cf28424963","accounts_in_message":[],"_revision_number":2}],"current_revision":"d1278660afcb3315fe74def3c2ca51cf28424963","revisions":{"0468b8c96a75c7d6b311b06f79c3b6e61ed5129c":{"kind":"REWORK","_number":1,"created":"2022-02-14 23:08:00.000000000","uploader":{"_account_id":1001960,"name":"sean-anderson-seco","email":"sean.anderson@seco.com","username":"sean-anderson-seco"},"ref":"refs/changes/50/6850/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/50/6850/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/50/6850/1 \u0026\u0026 git checkout -b change-6850 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/50/6850/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/50/6850/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/50/6850/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/50/6850/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/50/6850/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c0592f01030f026268a645a80d18252e8a44719d","subject":"target: Add support for ls1088a"}],"author":{"name":"Sean Anderson","email":"sean.anderson@seco.com","date":"2022-02-14 22:53:11.000000000","tz":-300},"committer":{"name":"Sean Anderson","email":"sean.anderson@seco.com","date":"2022-02-14 23:05:48.000000000","tz":-300},"subject":"target: ls1088a: Add service processor","message":"target: ls1088a: Add service processor\n\nNormally the service processor is not necessary for debugging. However,\nif you are using the hard-coded RCW or your boot source is otherwise\ncorrupt, then the general purpose processors will never be released from\nhold-off. This will cause GDB to become confused if it tries to attach,\nsince they will appear to be running arm32 processors. To deal with\nthis, we can release the CPUs manually with the BRRL register. This\nregister cannot be written to from the axi target, so we need to do it\nfrom the service processor target. This involves halting the service\nprocessor, modifying the register, and then resuming it again. We try\nand determine what state the service processor was in to avoid resuming\nit if it was already halted.\n\nThe reset vector for the general purpose processors is determined by the\nboot logation pointer registers in the device configuration unit.\nNormally these are set using pre-boot initialization commands, but if\nthey are not set then they default to 0. This will cause the CPU to\nalmost immediately hit an illegal instruction. This is fine because we\nwill almost certainly want to attach to the processor and load a program\nanyway.\n\nI considered adding this as an event handler for either gdb-attach or\nreset-init. However, this command shouldn\u0027t be necessary most of the\ntime, and so I don\u0027t think we should run it automatically.\n\nSigned-off-by: Sean Anderson \u003csean.anderson@seco.com\u003e\nChange-Id: I1b725292d8a11274d03af5313dc83678e10e944c\n"}},"d1278660afcb3315fe74def3c2ca51cf28424963":{"kind":"REWORK","_number":2,"created":"2022-02-26 15:36:16.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/50/6850/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/50/6850/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/50/6850/2 \u0026\u0026 git checkout -b change-6850 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/50/6850/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/50/6850/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/50/6850/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/50/6850/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/50/6850/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3fcfe4f196f6c333ee0ba2078af9cfa3eb896761","subject":"target: Add support for ls1088a"}],"author":{"name":"Sean Anderson","email":"sean.anderson@seco.com","date":"2022-02-14 22:53:11.000000000","tz":-300},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-02-26 15:36:16.000000000","tz":0},"subject":"target: ls1088a: Add service processor","message":"target: ls1088a: Add service processor\n\nNormally the service processor is not necessary for debugging. However,\nif you are using the hard-coded RCW or your boot source is otherwise\ncorrupt, then the general purpose processors will never be released from\nhold-off. This will cause GDB to become confused if it tries to attach,\nsince they will appear to be running arm32 processors. To deal with\nthis, we can release the CPUs manually with the BRRL register. This\nregister cannot be written to from the axi target, so we need to do it\nfrom the service processor target. This involves halting the service\nprocessor, modifying the register, and then resuming it again. We try\nand determine what state the service processor was in to avoid resuming\nit if it was already halted.\n\nThe reset vector for the general purpose processors is determined by the\nboot logation pointer registers in the device configuration unit.\nNormally these are set using pre-boot initialization commands, but if\nthey are not set then they default to 0. This will cause the CPU to\nalmost immediately hit an illegal instruction. This is fine because we\nwill almost certainly want to attach to the processor and load a program\nanyway.\n\nI considered adding this as an event handler for either gdb-attach or\nreset-init. However, this command shouldn\u0027t be necessary most of the\ntime, and so I don\u0027t think we should run it automatically.\n\nSigned-off-by: Sean Anderson \u003csean.anderson@seco.com\u003e\nChange-Id: I1b725292d8a11274d03af5313dc83678e10e944c\nReviewed-on: https://review.openocd.org/c/openocd/+/6850\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}