)]}'
{"id":"openocd~master~I8609815c3d5144790fb05a870cb0c931540aef8a","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1001891":{"account":{"_account_id":1001891,"name":"Michele Bisogno","email":"michele.bisogno.ct@renesas.com","username":"MicBiso"},"last_update":"2022-02-19 18:26:01.000000000","reason":"Michele Bisogno replied on the change"},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2022-02-26 15:37:30.000000000","reason":"removed on reply"},"1001242":{"account":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"last_update":"2022-02-21 17:25:25.000000000","reason":"Tim Newsome replied on the change"}},"hashtags":[],"change_id":"I8609815c3d5144790fb05a870cb0c931540aef8a","subject":"gdb_server: check target examined while combining reg list","status":"MERGED","created":"2022-02-19 16:05:13.000000000","updated":"2022-02-26 15:37:34.000000000","submitted":"2022-02-26 15:37:34.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6853","meta_rev_id":"0ba6594cc93d25e40a4b1f6ea1166e0b6fdac70a","_number":6853,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1001891,"name":"Michele Bisogno","email":"michele.bisogno.ct@renesas.com","username":"MicBiso"},{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-02-26 15:37:34.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-02-26 15:37:34.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1001891,"name":"Michele Bisogno","email":"michele.bisogno.ct@renesas.com","username":"MicBiso"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-02-26 15:37:34.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-02-26 15:37:34.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},{"_account_id":1001891,"name":"Michele Bisogno","email":"michele.bisogno.ct@renesas.com","username":"MicBiso"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-02-19 16:05:13.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"state":"REVIEWER"},{"updated":"2022-02-19 16:05:13.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1001891,"name":"Michele Bisogno","email":"michele.bisogno.ct@renesas.com","username":"MicBiso"},"state":"REVIEWER"},{"updated":"2022-02-19 16:54:42.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"092385f9e06c66ed210a38a9f04bced7e561ab0d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-02-19 16:05:13.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8d1d61af7c63e856148d8c7ccf9292daf6089928","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-02-19 16:54:42.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15871/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/15083/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"8ce93ebef1ec1709a5c0cc127d507d99ef8343c3","author":{"_account_id":1001891,"name":"Michele Bisogno","email":"michele.bisogno.ct@renesas.com","username":"MicBiso"},"real_author":{"_account_id":1001891,"name":"Michele Bisogno","email":"michele.bisogno.ct@renesas.com","username":"MicBiso"},"date":"2022-02-19 18:26:01.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"62b08ce35ce04f8ae6b7014f31ee28985a456867","author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"real_author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"date":"2022-02-21 17:25:25.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"a72bce289e6651d8cd9360ec629f592d9351f135","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-02-26 15:37:30.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"0ba6594cc93d25e40a4b1f6ea1166e0b6fdac70a","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-02-26 15:37:34.000000000","message":"Change has been successfully cherry-picked as 103b1d68db5038edd9e8878c798525715590f4e1","accounts_in_message":[],"_revision_number":2}],"current_revision":"103b1d68db5038edd9e8878c798525715590f4e1","revisions":{"103b1d68db5038edd9e8878c798525715590f4e1":{"kind":"REWORK","_number":2,"created":"2022-02-26 15:37:34.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/53/6853/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/53/6853/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/53/6853/2 \u0026\u0026 git checkout -b change-6853 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/53/6853/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/53/6853/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/53/6853/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/53/6853/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/53/6853/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"bc50b8f1b299991851d4ff3eb30f583ed6aa530b","subject":"gdb_server: fix double free"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-02-19 15:56:42.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-02-26 15:37:34.000000000","tz":0},"subject":"gdb_server: check target examined while combining reg list","message":"gdb_server: check target examined while combining reg list\n\nCommit 6541233aa78d (\"Combine register lists of smp targets.\")\nassumes that all the targets in the SMP cluster are already\nexamined and unconditionally call target_get_gdb_reg_list_noread()\nthat will in turn return error if the target is not examined yet.\n\nSkip targets not examined yet.\nAdd an additional check in case the register list cannot be built,\ne.g. because no target in the SMP cluster is examined. This should\nnever happen, but it\u0027s better to play safe.\n\nChange-Id: I8609815c3d5144790fb05a870cb0c931540aef8a\nFixes: 6541233aa78d (\"Combine register lists of smp targets.\")\nReported-by: Michele Bisogno \u003cmichele.bisogno.ct@renesas.com\u003e\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6853\nTested-by: jenkins\nReviewed-by: Michele Bisogno \u003cmichele.bisogno.ct@renesas.com\u003e\nReviewed-by: Tim Newsome \u003ctim@sifive.com\u003e\n"}},"7b81bf1e1616b6b164a792e42640d35225f81efe":{"kind":"REWORK","_number":1,"created":"2022-02-19 16:05:13.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/53/6853/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/53/6853/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/53/6853/1 \u0026\u0026 git checkout -b change-6853 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/53/6853/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/53/6853/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/53/6853/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/53/6853/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/53/6853/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"0a377bd7c446f9fc0a58cc410c946188a1dcee4d","subject":"gdb_server: fix double free"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-02-19 15:56:42.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-02-19 15:56:42.000000000","tz":60},"subject":"gdb_server: check target examined while combining reg list","message":"gdb_server: check target examined while combining reg list\n\nCommit 6541233aa78d (\"Combine register lists of smp targets.\")\nassumes that all the targets in the SMP cluster are already\nexamined and unconditionally call target_get_gdb_reg_list_noread()\nthat will in turn return error if the target is not examined yet.\n\nSkip targets not examined yet.\nAdd an additional check in case the register list cannot be built,\ne.g. because no target in the SMP cluster is examined. This should\nnever happen, but it\u0027s better to play safe.\n\nChange-Id: I8609815c3d5144790fb05a870cb0c931540aef8a\nFixes: 6541233aa78d (\"Combine register lists of smp targets.\")\nReported-by: Michele Bisogno \u003cmichele.bisogno.ct@renesas.com\u003e\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}