)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1001960,"name":"sean-anderson-seco","email":"sean.anderson@seco.com","username":"sean-anderson-seco"},"change_message_id":"e47d739f6f2a3b8a80c2b36acbc362e4990cbc28","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2c7fa31d_b5df8420","updated":"2022-02-21 20:05:38.000000000","message":"Add Antonio as a reviewer.","commit_id":"7b510c1cc2d4d1e4d7639070b2de2687883107a5"},{"author":{"_account_id":1001960,"name":"sean-anderson-seco","email":"sean.anderson@seco.com","username":"sean-anderson-seco"},"change_message_id":"baef1509a1ced0912e2f16b098e90aa8881c4eda","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b4da3c7b_3309ecff","updated":"2022-03-03 21:03:02.000000000","message":"Since I originally uploaded these patches I\u0027ve had a chance to play around with this board more. I initially thought that this board was similar to the ls1088a, in that none of the cores were released when booting from the hard-coded RCW. However, it turned out that I was just using the wrong rst_cfg_src. This target is actually more like the ZynqMP, where some CPUs may not be released on boot (but the bootloader should take care of starting them). To handle this, I\u0027ve borrowed the -defer-examine + cpu_up combination.","commit_id":"a050cac2d91d313eb1d196f321736a853762dd27"}],"tcl/target/ls1046a.cfg":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"e91f8f466b57b6c8bee9435cc7b4803775c23c08","unresolved":true,"context_lines":[{"line_number":46,"context_line":"target create $_CHIPNAME.sap ls1_sap -chain-position $_CHIPNAME.sap -endian big"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"proc core_up { args } {"},{"line_number":49,"context_line":"    foreach { core } [set args] {"},{"line_number":50,"context_line":"        $::_CHIPNAME.cpu$core arp_examine"},{"line_number":51,"context_line":"    }"},{"line_number":52,"context_line":"}"}],"source_content_type":"text/x-ttcn-cfg","patch_set":2,"id":"94550053_38c943a5","line":49,"updated":"2022-03-04 14:24:43.000000000","message":"please use:\nforeach core $args {","commit_id":"a050cac2d91d313eb1d196f321736a853762dd27"},{"author":{"_account_id":1001960,"name":"sean-anderson-seco","email":"sean.anderson@seco.com","username":"sean-anderson-seco"},"change_message_id":"936e9a073e62d44ec4e9c4ee37186d36a22f8db3","unresolved":false,"context_lines":[{"line_number":46,"context_line":"target create $_CHIPNAME.sap ls1_sap -chain-position $_CHIPNAME.sap -endian big"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"proc core_up { args } {"},{"line_number":49,"context_line":"    foreach { core } [set args] {"},{"line_number":50,"context_line":"        $::_CHIPNAME.cpu$core arp_examine"},{"line_number":51,"context_line":"    }"},{"line_number":52,"context_line":"}"}],"source_content_type":"text/x-ttcn-cfg","patch_set":2,"id":"ffb218a0_10b5c52e","line":49,"in_reply_to":"94550053_38c943a5","updated":"2022-03-04 17:30:43.000000000","message":"Fixed. Note that this is copied from the ZynqMP script (so that should probably be updated as well).","commit_id":"a050cac2d91d313eb1d196f321736a853762dd27"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"77b4a12190162197a9810801b56550ee9bbd61d0","unresolved":false,"context_lines":[{"line_number":46,"context_line":"target create $_CHIPNAME.sap ls1_sap -chain-position $_CHIPNAME.sap -endian big"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"proc core_up { args } {"},{"line_number":49,"context_line":"    foreach { core } [set args] {"},{"line_number":50,"context_line":"        $::_CHIPNAME.cpu$core arp_examine"},{"line_number":51,"context_line":"    }"},{"line_number":52,"context_line":"}"}],"source_content_type":"text/x-ttcn-cfg","patch_set":2,"id":"5b1f5ad0_838af953","line":49,"in_reply_to":"ffb218a0_10b5c52e","updated":"2022-03-04 22:47:53.000000000","message":"Already changed in https://review.openocd.org/6863/","commit_id":"a050cac2d91d313eb1d196f321736a853762dd27"}]}
