)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"131faf83ada2fec91a43f6cd7bcfd02c5ccb9a63","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"62e90a27_e0fd7e10","updated":"2022-02-25 22:24:58.000000000","message":"apart for the missing contrib/rpc_examples/ocd_rpc_example.py the patch looks ok.\nReading all these changes I think it could be interesting to improve read_memory to make \u0027count\u0027 optional and default to 1. Maybe in the future ...","commit_id":"d8acad3440eadbe81945c9d23ffba4c4b760678c"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"9fc4f186494982ff14df66fd51febdc30b65b85f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fabd5cd8_74579cc3","updated":"2022-02-25 15:02:03.000000000","message":"not reviewed yet, but misses contrib/rpc_examples/ocd_rpc_example.py","commit_id":"d8acad3440eadbe81945c9d23ffba4c4b760678c"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"1fb91ed2ba141d0996b9654cdab498cd53d67482","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0b39b8ce_45f1bf08","updated":"2022-03-02 14:26:16.000000000","message":"Great simplification in python code, cool!","commit_id":"6435f7e0ce38560d95ceee75192c6f09fc1c0ff2"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"819e7b0468d784c79dea9bb33e1400f2a2a4a73d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"aec0eaff_077f58af","updated":"2022-03-04 11:55:30.000000000","message":"TODO: We should use mrw instead of all these peek32, read_register, mread32 etc...","commit_id":"0a984ffbf80d3cb6c279b9c297cd9ef84bca7dc8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"62d511fa6ace2df2c7d07aec85ae6a77065578cc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"81bfe40d_0c24593c","updated":"2022-03-03 09:20:14.000000000","message":"thanks","commit_id":"0a984ffbf80d3cb6c279b9c297cd9ef84bca7dc8"},{"author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"change_message_id":"dac611a1c6812f9283243fb296d15111f60da83a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3b1584f7_802d45dd","updated":"2025-06-18 13:39:08.000000000","message":"Hey, this was a nice clean up!\n\nHoweever later https://review.openocd.org/c/openocd/+/6975 was merged so there\u0027s still one occurence left currently.","commit_id":"be0d68eb66b513ef406ffa83102f89a8f4602914"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"0f9bade7b189036fcf38683e55af903064eabdca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ee529e1d_5b73b888","in_reply_to":"3b1584f7_802d45dd","updated":"2025-06-19 08:32:10.000000000","message":"Thanks, fixed in https://review.openocd.org/c/openocd/+/8962 !","commit_id":"be0d68eb66b513ef406ffa83102f89a8f4602914"}],"tcl/board/at91cap7a-stk-sdram.cfg":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"131faf83ada2fec91a43f6cd7bcfd02c5ccb9a63","unresolved":true,"context_lines":[{"line_number":32,"context_line":"}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"proc peek32 {address} {"},{"line_number":35,"context_line":"\tread_memory $address 32 1"},{"line_number":36,"context_line":"}"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"# Wait for an expression to be true with a timeout"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"b34df8d2_36fdf20f","line":35,"updated":"2022-02-25 22:24:58.000000000","message":"it is correct, because without \u0027return\u0027 the proc returns the result of last operation. But I personally find this way less readable.\nAn explicit \u0027return\u0027 makes clear that the purpose of this proc is to return the value it read.\nBut just a personal opinion!","commit_id":"d8acad3440eadbe81945c9d23ffba4c4b760678c"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"806a5ff2efb277895fc5ec7f4b7cbf3b9712330e","unresolved":false,"context_lines":[{"line_number":32,"context_line":"}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"proc peek32 {address} {"},{"line_number":35,"context_line":"\tread_memory $address 32 1"},{"line_number":36,"context_line":"}"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"# Wait for an expression to be true with a timeout"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"f923a118_a6c3c624","line":35,"in_reply_to":"78229021_f4e8ed8e","updated":"2022-03-02 20:18:38.000000000","message":"Oups, I thought there is only a single one. Will change it tomorrow. I also prefer the explicit \"return\" statement.","commit_id":"d8acad3440eadbe81945c9d23ffba4c4b760678c"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"1fb91ed2ba141d0996b9654cdab498cd53d67482","unresolved":false,"context_lines":[{"line_number":32,"context_line":"}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"proc peek32 {address} {"},{"line_number":35,"context_line":"\tread_memory $address 32 1"},{"line_number":36,"context_line":"}"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"# Wait for an expression to be true with a timeout"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"78229021_f4e8ed8e","line":35,"in_reply_to":"b34df8d2_36fdf20f","updated":"2022-03-02 14:26:16.000000000","message":"My comment was in general on all the changes in this patch that generates procs that implicitly return the result of last tcl command. This line was just one of them.\nBut again, personal taste, no need to change everything.","commit_id":"d8acad3440eadbe81945c9d23ffba4c4b760678c"}]}