)]}'
{"id":"openocd~master~I897c40c5d2233f50a5385d251ebfa536023e5cf7","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2022-03-01 08:36:13.000000000","reason":"removed on reply"},"1000863":{"account":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"last_update":"2022-03-01 08:36:52.000000000","reason":"Change was submitted"},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2022-03-01 08:04:22.000000000","reason":"Tomas Vanek replied on the change"}},"hashtags":[],"change_id":"I897c40c5d2233f50a5385d251ebfa536023e5cf7","subject":"flash/stm32l4x: fix maybe-uninitialized compiler error","status":"MERGED","created":"2022-02-28 09:32:40.000000000","updated":"2022-03-01 10:48:41.000000000","submitted":"2022-03-01 08:36:52.000000000","submitter":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6861","meta_rev_id":"a25da2c47dfa94bae1e6bf447100336be761c097","_number":6861,"owner":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-03-01 08:36:52.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-03-01 08:36:52.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-03-01 08:36:52.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-02-28 09:33:47.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-02-28 10:44:04.000000000","updated_by":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"},{"updated":"2022-02-28 10:44:04.000000000","updated_by":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"}],"messages":[{"id":"4b143d275843a402e637f4b56875c6c24865d601","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2022-02-28 09:32:40.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"90960cbc8e64ba29a1abbd931b9038a4e99c504b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2022-02-28 09:33:41.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"49e50351bbfc062ae3757cb996a97d0511204a81","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-02-28 09:33:47.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit/15910/ : ABORTED\n\nhttps://build.openocd.org/job/openocd-gerrit-build/15122/ : ABORTED","accounts_in_message":[],"_revision_number":1},{"id":"5c3d614c8e9ff1b23100ff92e81c3064e20e94e7","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-02-28 09:50:55.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15911/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/15123/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"5b318b2f36534ad3b6ad9fcf234c6b9064e2bdef","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-03-01 08:04:22.000000000","message":"Patch Set 2: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"e368fe5231fbcbf48441fa622bf75f7440e194b7","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-03-01 08:36:13.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"2b2c65b61a20ed6ad12adfecfc9bbf8112c214d5","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-03-01 08:36:52.000000000","message":"Change has been successfully cherry-picked as 8b740af10dd37b08c27588f34942154b817bf6fc","accounts_in_message":[],"_revision_number":3},{"id":"a25da2c47dfa94bae1e6bf447100336be761c097","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-03-01 10:48:41.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3}],"current_revision":"8b740af10dd37b08c27588f34942154b817bf6fc","revisions":{"db1c34842bdd8c82e7198ab4d02e6f392635e3ed":{"kind":"REWORK","_number":1,"created":"2022-02-28 09:32:40.000000000","uploader":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"ref":"refs/changes/61/6861/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/61/6861/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/61/6861/1 \u0026\u0026 git checkout -b change-6861 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/61/6861/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/61/6861/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/61/6861/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/61/6861/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/61/6861/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"103b1d68db5038edd9e8878c798525715590f4e1","subject":"gdb_server: check target examined while combining reg list"}],"author":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2022-02-28 09:29:44.000000000","tz":60},"committer":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2022-02-28 09:31:48.000000000","tz":60},"subject":"flash/stm32l4x: fix maybe-uninitialized variable error","message":"flash/stm32l4x: fix maybe-uninitialized variable error\n\nusing gcc (Ubuntu 9.3.0-17ubuntu1~20.04) 9.3.0 we get:\nerror: ‘retval’ may be used uninitialized in this function\n\nfixes: 13cd75b6ecfd (flash/nor/stm32xx: fix segfault accessing Cortex-M part number)\nChange-Id: I897c40c5d2233f50a5385d251ebfa536023e5cf7\nSigned-off-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\n"}},"8b740af10dd37b08c27588f34942154b817bf6fc":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2022-03-01 08:36:52.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/61/6861/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/61/6861/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/61/6861/3 \u0026\u0026 git checkout -b change-6861 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/61/6861/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/61/6861/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/61/6861/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/61/6861/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/61/6861/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"103b1d68db5038edd9e8878c798525715590f4e1","subject":"gdb_server: check target examined while combining reg list"}],"author":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2022-02-28 09:29:44.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-03-01 08:36:52.000000000","tz":0},"subject":"flash/stm32l4x: fix maybe-uninitialized compiler error","message":"flash/stm32l4x: fix maybe-uninitialized compiler error\n\nusing gcc (Ubuntu 9.3.0-17ubuntu1~20.04) 9.3.0 we get:\nerror: ‘retval’ may be used uninitialized in this function\n\nfixes: 13cd75b6ecfd (flash/nor/stm32xx: fix segfault accessing Cortex-M part number)\nChange-Id: I897c40c5d2233f50a5385d251ebfa536023e5cf7\nSigned-off-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6861\nTested-by: jenkins\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"987172538600a4b5175c1c958116d71e5c25dbf4":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2022-02-28 09:33:41.000000000","uploader":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"ref":"refs/changes/61/6861/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/61/6861/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/61/6861/2 \u0026\u0026 git checkout -b change-6861 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/61/6861/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/61/6861/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/61/6861/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/61/6861/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/61/6861/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"103b1d68db5038edd9e8878c798525715590f4e1","subject":"gdb_server: check target examined while combining reg list"}],"author":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2022-02-28 09:29:44.000000000","tz":60},"committer":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2022-02-28 09:33:36.000000000","tz":60},"subject":"flash/stm32l4x: fix maybe-uninitialized compiler error","message":"flash/stm32l4x: fix maybe-uninitialized compiler error\n\nusing gcc (Ubuntu 9.3.0-17ubuntu1~20.04) 9.3.0 we get:\nerror: ‘retval’ may be used uninitialized in this function\n\nfixes: 13cd75b6ecfd (flash/nor/stm32xx: fix segfault accessing Cortex-M part number)\nChange-Id: I897c40c5d2233f50a5385d251ebfa536023e5cf7\nSigned-off-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}