)]}'
{"id":"openocd~master~I27310e8c05afe56ea8bd0e41d4ae2c34447b725c","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2022-03-12 09:43:00.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I27310e8c05afe56ea8bd0e41d4ae2c34447b725c","subject":"tcl: don\u0027t use \u0027set\u0027 to retrieve the value of a variable","status":"MERGED","created":"2022-03-01 22:46:03.000000000","updated":"2022-03-12 09:43:00.000000000","submitted":"2022-03-12 09:43:00.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6863","meta_rev_id":"b6ed8d62eb53f09011817e83937e6a22cca9eb9d","_number":6863,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-03-12 09:43:00.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-03-12 09:43:00.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-03-01 23:05:09.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-03-02 05:26:58.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"}],"messages":[{"id":"8ea56e4112acc574c4b6254159ea2a795a1e424b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-03-01 22:46:03.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"0ff7447434ae0dc1a2af5dea38f659f820ca9805","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-03-01 23:05:09.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15930/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/15140/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"a6c04cbdef90fdb439815e5b346f3990212d5684","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-03-02 05:26:58.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"b6ed8d62eb53f09011817e83937e6a22cca9eb9d","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-03-12 09:43:00.000000000","message":"Change has been successfully cherry-picked as 9a6417e03595e1194f125ca33d2b60b8eac9a512","accounts_in_message":[],"_revision_number":2}],"current_revision":"9a6417e03595e1194f125ca33d2b60b8eac9a512","revisions":{"af696b4d6e918c0d6032586d005b4f9af659f23b":{"kind":"REWORK","_number":1,"created":"2022-03-01 22:46:03.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/63/6863/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/63/6863/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/63/6863/1 \u0026\u0026 git checkout -b change-6863 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/63/6863/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/63/6863/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/63/6863/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/63/6863/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/63/6863/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"8b740af10dd37b08c27588f34942154b817bf6fc","subject":"flash/stm32l4x: fix maybe-uninitialized compiler error"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-03-01 22:21:20.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-03-01 22:37:02.000000000","tz":60},"subject":"tcl: don\u0027t use \u0027set\u0027 to retrieve the value of a variable","message":"tcl: don\u0027t use \u0027set\u0027 to retrieve the value of a variable\n\nOriginal TLC syntax uses \u0027set varname\u0027 to retrieve the value of\nvariable \u0027varname\u0027. Such archaic syntax is still valid, but the\nshorter \u0027$varname\u0027 makes the code easier to read.\n\nReplace \u0027set varname\u0027 with \u0027$varname\u0027.\nWhile there, remove some useless curly brackets.\n\nChange-Id: I27310e8c05afe56ea8bd0e41d4ae2c34447b725c\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"9a6417e03595e1194f125ca33d2b60b8eac9a512":{"kind":"REWORK","_number":2,"created":"2022-03-12 09:43:00.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/63/6863/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/63/6863/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/63/6863/2 \u0026\u0026 git checkout -b change-6863 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/63/6863/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/63/6863/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/63/6863/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/63/6863/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/63/6863/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"5ffc397278b877000f88dbe0f750b0a1611338a4","subject":"tcl/board: Add AM625 EVM basic support"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-03-01 22:21:20.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-03-12 09:43:00.000000000","tz":0},"subject":"tcl: don\u0027t use \u0027set\u0027 to retrieve the value of a variable","message":"tcl: don\u0027t use \u0027set\u0027 to retrieve the value of a variable\n\nOriginal TLC syntax uses \u0027set varname\u0027 to retrieve the value of\nvariable \u0027varname\u0027. Such archaic syntax is still valid, but the\nshorter \u0027$varname\u0027 makes the code easier to read.\n\nReplace \u0027set varname\u0027 with \u0027$varname\u0027.\nWhile there, remove some useless curly brackets.\n\nChange-Id: I27310e8c05afe56ea8bd0e41d4ae2c34447b725c\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6863\nTested-by: jenkins\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}