)]}'
{"src/flash/nor/stm32l4x.c":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"f6f91526f00cb7cc62d54d4ed39941700bc8dd77","unresolved":true,"context_lines":[{"line_number":987,"context_line":"\t * registers for option bytes programming */"},{"line_number":988,"context_line":"\tconst uint32_t *saved_flash_regs \u003d stm32l4_info-\u003eflash_regs;"},{"line_number":989,"context_line":"\tif (stm32l4_info-\u003epart_info-\u003eflags \u0026 F_HAS_L5_FLASH_REGS)"},{"line_number":990,"context_line":"\t\tstm32l4_info-\u003eflash_regs \u003d stm32l5_ns_flash_regs;"},{"line_number":991,"context_line":""},{"line_number":992,"context_line":"\tretval \u003d stm32l4_unlock_reg(bank);"},{"line_number":993,"context_line":"\tif (retval !\u003d ERROR_OK)"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"fbb553fa_3e2dca55","line":990,"range":{"start_line":990,"start_character":1,"end_line":990,"end_character":51},"updated":"2022-03-02 14:31:10.000000000","message":"Can you recheck this, if STM32L5_REGS_SEC_OFFSET should not be removed as well?\nAsking just for the case, haven\u0027t experienced any problem.","commit_id":"6dd95a69e2ba983263bc3ac3d73212e6c51fd5c9"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"f6f91526f00cb7cc62d54d4ed39941700bc8dd77","unresolved":true,"context_lines":[{"line_number":2053,"context_line":"\t\t/* for devices with TrustZone, use NS flash registers to read OPTR */"},{"line_number":2054,"context_line":"\t\tif (stm32l4_info-\u003epart_info-\u003eflags \u0026 F_HAS_L5_FLASH_REGS) {"},{"line_number":2055,"context_line":"\t\t\tstm32l4_info-\u003eflash_regs_base \u0026\u003d ~STM32L5_REGS_SEC_OFFSET;"},{"line_number":2056,"context_line":"\t\t\tstm32l4_info-\u003eflash_regs \u003d stm32l5_ns_flash_regs;"},{"line_number":2057,"context_line":"\t\t}"},{"line_number":2058,"context_line":""},{"line_number":2059,"context_line":"\t\t/* read flash option register and re-probe if optr value is changed */"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"dacbcc6d_f5396618","line":2056,"range":{"start_line":2056,"start_character":3,"end_line":2056,"end_character":52},"updated":"2022-03-02 14:31:10.000000000","message":"Switching flash_regs to ns (and saving them) doesn\u0027t seem necessary.\nOPTR has no distinct secure and nonsecure versions, removing STM32L5_REGS_SEC_OFFSET does the job","commit_id":"6dd95a69e2ba983263bc3ac3d73212e6c51fd5c9"},{"author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"change_message_id":"56ea287293f20324a8bc92d63f1b465507466f43","unresolved":false,"context_lines":[{"line_number":2053,"context_line":"\t\t/* for devices with TrustZone, use NS flash registers to read OPTR */"},{"line_number":2054,"context_line":"\t\tif (stm32l4_info-\u003epart_info-\u003eflags \u0026 F_HAS_L5_FLASH_REGS) {"},{"line_number":2055,"context_line":"\t\t\tstm32l4_info-\u003eflash_regs_base \u0026\u003d ~STM32L5_REGS_SEC_OFFSET;"},{"line_number":2056,"context_line":"\t\t\tstm32l4_info-\u003eflash_regs \u003d stm32l5_ns_flash_regs;"},{"line_number":2057,"context_line":"\t\t}"},{"line_number":2058,"context_line":""},{"line_number":2059,"context_line":"\t\t/* read flash option register and re-probe if optr value is changed */"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"140bee2b_8794f2db","line":2056,"range":{"start_line":2056,"start_character":3,"end_line":2056,"end_character":52},"in_reply_to":"a58ac91a_f87514ad","updated":"2022-03-02 15:06:04.000000000","message":"Done","commit_id":"6dd95a69e2ba983263bc3ac3d73212e6c51fd5c9"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"0aec6efba6e227efda054b70e2b6ea133dde3c64","unresolved":true,"context_lines":[{"line_number":2053,"context_line":"\t\t/* for devices with TrustZone, use NS flash registers to read OPTR */"},{"line_number":2054,"context_line":"\t\tif (stm32l4_info-\u003epart_info-\u003eflags \u0026 F_HAS_L5_FLASH_REGS) {"},{"line_number":2055,"context_line":"\t\t\tstm32l4_info-\u003eflash_regs_base \u0026\u003d ~STM32L5_REGS_SEC_OFFSET;"},{"line_number":2056,"context_line":"\t\t\tstm32l4_info-\u003eflash_regs \u003d stm32l5_ns_flash_regs;"},{"line_number":2057,"context_line":"\t\t}"},{"line_number":2058,"context_line":""},{"line_number":2059,"context_line":"\t\t/* read flash option register and re-probe if optr value is changed */"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"a58ac91a_f87514ad","line":2056,"range":{"start_line":2056,"start_character":3,"end_line":2056,"end_character":52},"in_reply_to":"d474c3ef_7bf5fa4e","updated":"2022-03-02 14:54:20.000000000","message":"Yes please. The code is complicated more than enough...","commit_id":"6dd95a69e2ba983263bc3ac3d73212e6c51fd5c9"},{"author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"change_message_id":"fe2bd55fb93d6be41009ee6104745400020e529f","unresolved":true,"context_lines":[{"line_number":2053,"context_line":"\t\t/* for devices with TrustZone, use NS flash registers to read OPTR */"},{"line_number":2054,"context_line":"\t\tif (stm32l4_info-\u003epart_info-\u003eflags \u0026 F_HAS_L5_FLASH_REGS) {"},{"line_number":2055,"context_line":"\t\t\tstm32l4_info-\u003eflash_regs_base \u0026\u003d ~STM32L5_REGS_SEC_OFFSET;"},{"line_number":2056,"context_line":"\t\t\tstm32l4_info-\u003eflash_regs \u003d stm32l5_ns_flash_regs;"},{"line_number":2057,"context_line":"\t\t}"},{"line_number":2058,"context_line":""},{"line_number":2059,"context_line":"\t\t/* read flash option register and re-probe if optr value is changed */"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"d474c3ef_7bf5fa4e","line":2056,"range":{"start_line":2056,"start_character":3,"end_line":2056,"end_character":52},"in_reply_to":"dacbcc6d_f5396618","updated":"2022-03-02 14:42:49.000000000","message":"I confirm, it\u0027s not necessary. I have tested both cases.\n\nI have added flash_regs save/restore for code readability, and to be aligned with the first probe behavior.\n\nWe can remove it, if you feel that we should do.","commit_id":"6dd95a69e2ba983263bc3ac3d73212e6c51fd5c9"}]}