)]}'
{"id":"openocd~master~I296aa633972b0c410b927488c999584a07b912d3","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000863":{"account":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"last_update":"2022-03-19 09:13:55.000000000","reason":"Change was submitted"},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2022-03-02 15:14:21.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I296aa633972b0c410b927488c999584a07b912d3","subject":"flash/stm32l4x: fix auto-probe when RDP is promoted from 0 to 0.5","status":"MERGED","created":"2022-03-02 09:19:02.000000000","updated":"2022-03-19 09:13:55.000000000","submitted":"2022-03-19 09:13:55.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":5,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"6864","meta_rev_id":"af5b0f7161b03b5ec1c858bd97fff18f2ff66aa2","_number":6864,"owner":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-03-19 09:13:55.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-03-19 09:13:55.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-03-19 09:13:55.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-03-02 09:32:39.000000000","updated_by":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"},{"updated":"2022-03-02 09:43:51.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-03-19 09:13:55.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"61668436201b4b311a376e7924644a678b2c8b86","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2022-03-02 09:19:02.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"607c01230e0138ca5e68100d8ab3f2a276524369","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-03-02 09:43:51.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15933/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/15143/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"f6f91526f00cb7cc62d54d4ed39941700bc8dd77","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-03-02 14:31:10.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"fe2bd55fb93d6be41009ee6104745400020e529f","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2022-03-02 14:42:49.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"0aec6efba6e227efda054b70e2b6ea133dde3c64","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-03-02 14:54:20.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"112c1255bffb02072be73a3333eae06f1e8a170a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2022-03-02 15:05:24.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"56ea287293f20324a8bc92d63f1b465507466f43","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2022-03-02 15:06:04.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"8ca4b29093e27886f58af2ef1961927fa286fa5c","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-03-02 15:14:21.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"1cef0d3b9cacfda64ce8b346849ae5a43f0543b0","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-03-02 15:26:20.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15937/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/15147/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"af5b0f7161b03b5ec1c858bd97fff18f2ff66aa2","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-03-19 09:13:55.000000000","message":"Change has been successfully cherry-picked as ab43721be6ff7470ff8b9771c95c1d5661a5a689","accounts_in_message":[],"_revision_number":3}],"current_revision":"ab43721be6ff7470ff8b9771c95c1d5661a5a689","revisions":{"6dd95a69e2ba983263bc3ac3d73212e6c51fd5c9":{"kind":"REWORK","_number":1,"created":"2022-03-02 09:19:02.000000000","uploader":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"ref":"refs/changes/64/6864/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/64/6864/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/64/6864/1 \u0026\u0026 git checkout -b change-6864 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/64/6864/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/64/6864/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/64/6864/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/64/6864/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/64/6864/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"987172538600a4b5175c1c958116d71e5c25dbf4","subject":"flash/stm32l4x: fix maybe-uninitialized compiler error"}],"author":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2022-02-28 12:55:26.000000000","tz":60},"committer":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2022-03-02 09:12:14.000000000","tz":60},"subject":"flash/stm32l4x: fix auto-probe when RDP is promoted from 0 to 0.5","message":"flash/stm32l4x: fix auto-probe when RDP is promoted from 0 to 0.5\n\nConsidering this use case: (using STM32 L5 or U5)\n 1- first probe : TZEN enabled, RDP level 0\n    flash_regs_base |\u003d STM32L5_REGS_SEC_OFFSET \u003d\u003e 0x50022000\n 2- the user promotes the RDP to level 0.5\n 3- the second probe, fails to read OPTR using secure flags_regs_base:\n    used OPTR address is 0x50022040\n\nStep 3 fails because when RDP is level 0.5, we should use Non-Secure\nflash registers.\nTo fix this, always use NS flash regs to read OPTR in probe functions.\n\nFixes: 80d323c6e82b (flash/stm32l4x: introduce auto-probe when OPTR is changed)\nChange-Id: I296aa633972b0c410b927488c999584a07b912d3\nSigned-off-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\n"}},"84324cb9007b11a92c859c3000bd581fcd8fc144":{"kind":"REWORK","_number":2,"created":"2022-03-02 15:05:24.000000000","uploader":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"ref":"refs/changes/64/6864/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/64/6864/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/64/6864/2 \u0026\u0026 git checkout -b change-6864 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/64/6864/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/64/6864/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/64/6864/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/64/6864/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/64/6864/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"987172538600a4b5175c1c958116d71e5c25dbf4","subject":"flash/stm32l4x: fix maybe-uninitialized compiler error"}],"author":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2022-02-28 12:55:26.000000000","tz":60},"committer":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2022-03-02 15:04:50.000000000","tz":60},"subject":"flash/stm32l4x: fix auto-probe when RDP is promoted from 0 to 0.5","message":"flash/stm32l4x: fix auto-probe when RDP is promoted from 0 to 0.5\n\nConsidering this use case: (using STM32 L5 or U5)\n 1- first probe : TZEN enabled, RDP level 0\n    flash_regs_base |\u003d STM32L5_REGS_SEC_OFFSET \u003d\u003e 0x50022000\n 2- the user promotes the RDP to level 0.5\n 3- the second probe, fails to read OPTR using secure flags_regs_base:\n    used OPTR address is 0x50022040\n\nStep 3 fails because when RDP is level 0.5, we should use Non-Secure\nflash registers.\nTo fix this, always use NS flash regs to read OPTR in probe functions.\n\nFixes: 80d323c6e82b (flash/stm32l4x: introduce auto-probe when OPTR is changed)\nChange-Id: I296aa633972b0c410b927488c999584a07b912d3\nSigned-off-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\n"}},"ab43721be6ff7470ff8b9771c95c1d5661a5a689":{"kind":"REWORK","_number":3,"created":"2022-03-19 09:13:55.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/64/6864/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/64/6864/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/64/6864/3 \u0026\u0026 git checkout -b change-6864 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/64/6864/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/64/6864/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/64/6864/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/64/6864/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/64/6864/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9cdbe61aab418bdf75bc443b16ce4cdf96732e3e","subject":"tcl/stm32u5x: fix clock config used at \u0027reset init\u0027"}],"author":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2022-02-28 12:55:26.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-03-19 09:13:55.000000000","tz":0},"subject":"flash/stm32l4x: fix auto-probe when RDP is promoted from 0 to 0.5","message":"flash/stm32l4x: fix auto-probe when RDP is promoted from 0 to 0.5\n\nConsidering this use case: (using STM32 L5 or U5)\n 1- first probe : TZEN enabled, RDP level 0\n    flash_regs_base |\u003d STM32L5_REGS_SEC_OFFSET \u003d\u003e 0x50022000\n 2- the user promotes the RDP to level 0.5\n 3- the second probe, fails to read OPTR using secure flags_regs_base:\n    used OPTR address is 0x50022040\n\nStep 3 fails because when RDP is level 0.5, we should use Non-Secure\nflash registers.\nTo fix this, always use NS flash regs to read OPTR in probe functions.\n\nFixes: 80d323c6e82b (flash/stm32l4x: introduce auto-probe when OPTR is changed)\nChange-Id: I296aa633972b0c410b927488c999584a07b912d3\nSigned-off-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6864\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nTested-by: jenkins\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}