)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"fc0911bec97ec5b0fc7c4d0765990b1aa6537469","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Jose Borja Castillo \u003cjoscassan@uma.es\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-03-04 15:14:44 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Added XVC (TCP) driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added new XVC TCP driver based on Xilinx\u0027s specs. Coding style is"},{"line_number":10,"context_line":"heavily influenced by bitbang.c and jlink.c, credits to the corresponding authors."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"2c8da110_f4981abf","line":7,"updated":"2022-03-05 17:54:00.000000000","message":"Please change the title to something like:\ndriver: add Xilinx XVC TCP","commit_id":"477be1c0753a0cfc1409ef835964bf0aad8130cb"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"2a20549d12156ecd7063d4064038a8de2ef1b7fa","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Jose Borja Castillo \u003cjoscassan@uma.es\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-03-04 15:14:44 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Added XVC (TCP) driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added new XVC TCP driver based on Xilinx\u0027s specs. Coding style is"},{"line_number":10,"context_line":"heavily influenced by bitbang.c and jlink.c, credits to the corresponding authors."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5c97aae8_a82577f1","line":7,"in_reply_to":"2c8da110_f4981abf","updated":"2022-03-07 11:15:12.000000000","message":"Done","commit_id":"477be1c0753a0cfc1409ef835964bf0aad8130cb"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"fc0911bec97ec5b0fc7c4d0765990b1aa6537469","unresolved":true,"context_lines":[{"line_number":12,"context_line":"using pre-defined messages, like \u0027shift\u0027."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Signed-off-by: Jose Borja Castillo \u003cjoscassan@uma.es\u003e"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"XVC: sorted style, added documentation"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Avoiding whitespaces and zero-initialization in static variables."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"cdddaf1d_2237f82b","line":15,"updated":"2022-03-05 17:54:00.000000000","message":"remove the lines after this, but keep the Change-Id: below","commit_id":"477be1c0753a0cfc1409ef835964bf0aad8130cb"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"2a20549d12156ecd7063d4064038a8de2ef1b7fa","unresolved":false,"context_lines":[{"line_number":12,"context_line":"using pre-defined messages, like \u0027shift\u0027."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Signed-off-by: Jose Borja Castillo \u003cjoscassan@uma.es\u003e"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"XVC: sorted style, added documentation"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Avoiding whitespaces and zero-initialization in static variables."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fb31329b_1b21dd15","line":15,"in_reply_to":"cdddaf1d_2237f82b","updated":"2022-03-07 11:15:12.000000000","message":"Done","commit_id":"477be1c0753a0cfc1409ef835964bf0aad8130cb"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"81eea0324bdd4f2eb21835b40377596e08ba9a57","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Jose Borja Castillo \u003cjoscassan@uma.es\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-03-11 14:05:10 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add Xilinx XVC TCP"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added new XVC TCP driver based on Xilinx\u0027s specs. Coding style is"},{"line_number":10,"context_line":"heavily influenced by bitbang.c and jlink.c, credits to the corresponding authors."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"c62faa63_7897f9c6","line":7,"updated":"2022-05-01 22:22:00.000000000","message":"please change the title as:\njtag/drivers: add Xilinx XVC TCP","commit_id":"02deec68dd383f6c9632b1845134fc1faa94a4ad"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"5a72491c4d44dc1ba22c485a441d0344e60c3bab","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Jose Borja Castillo \u003cjoscassan@uma.es\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-03-11 14:05:10 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add Xilinx XVC TCP"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added new XVC TCP driver based on Xilinx\u0027s specs. Coding style is"},{"line_number":10,"context_line":"heavily influenced by bitbang.c and jlink.c, credits to the corresponding authors."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"c9021d0e_0bc65b53","line":7,"in_reply_to":"c62faa63_7897f9c6","updated":"2022-05-03 11:26:18.000000000","message":"Done","commit_id":"02deec68dd383f6c9632b1845134fc1faa94a4ad"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"ee1d6ecf43bdc7e022aa64016b53207176b4f8d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"07cd2e89_1a28d964","updated":"2022-03-04 13:06:00.000000000","message":"Please put together, in a single patch, this and https://review.openocd.org/6865/\nUse \"git rebase -i 8b740af\", on the second line replace \"pick\" with \"s\", then when squashing the two commit messages keep the \"Change-Id:\" of this patch only,\nChange-Id: I59d61f9acca6b41bdf1e9d689ef3c4a026dded4c\nand remove the \"Change-Id:\" of https://review.openocd.org/6865/\nThen push again in gerrit the result and you can abandon https://review.openocd.org/6865/\n\nIn this way we have a single patch for the whole driver and we keep the history in gerrit.\nWe have already lost the link with https://review.openocd.org/6866/ ... unfortunately","commit_id":"9726d93a022494cf2c1b9ca041354424764755a8"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"5ab1911f0ba4a71e21ec748937dd71e0b3c7e9fc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fb69367b_fc231da0","in_reply_to":"07cd2e89_1a28d964","updated":"2022-03-05 09:36:11.000000000","message":"Done. Thank you very much for your help Antonio. I am sorry for my previous mistakes, I am a newbie with gerrit. I\u0027ve addressed the issues you pointed out in your comments. Best regards.","commit_id":"9726d93a022494cf2c1b9ca041354424764755a8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"fc0911bec97ec5b0fc7c4d0765990b1aa6537469","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3c3a4a4b_8ddff8af","updated":"2022-03-05 17:54:00.000000000","message":"It\u0027s getting nicer and nicer! Thanks.\nDon\u0027t worry about the issues with gerrit, that\u0027s usual headache.\nWhat instead makes me worry is that again gerrit, for at least the second time, did not started the autobuild and did not added a +/-1 score!\nAnyway, there is still something to fix, so let\u0027s see if it will build at next round.\nI have not checked carefully all the code, sorry, I will put more effort next time.","commit_id":"477be1c0753a0cfc1409ef835964bf0aad8130cb"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"5ab1911f0ba4a71e21ec748937dd71e0b3c7e9fc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"af230508_bb1f8ba3","updated":"2022-03-05 09:36:11.000000000","message":"Resolved comments. Thank you very much for your help Antonio. I am sorry for my previous mistakes, I am a newbie with gerrit. I\u0027ve addressed the issues you pointed out in your comments. Best regards.","commit_id":"477be1c0753a0cfc1409ef835964bf0aad8130cb"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"735fabddcfa9d36538f18f9a90c3f1d521ad702d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"73eb4a62_7224177e","updated":"2022-03-10 23:38:59.000000000","message":"Another round! I stop here for today, too late.\n\nOther topic: we have this ticket https://sourceforge.net/p/openocd/tickets/215/\nIt\u0027s long time I think we should have in openocd the \"server side\" of these jtag TCP protocols like xvc, remote-bitbang, ...\nThe idea is that we could test the driver side without the Xilinx server with:\n- openocd1 using adapter driver xvc, connected to:\n- openocd2 running server xvc and using any jtag adapter driver, e.g. cmsis-dap, connected to:\n- cmsis-dap adapter, connected to one target.\nIf we need to modify the adapter driver framework, we can modify openocd1 and run it with a not-modified openocd2. This will test if openocd1 get broken.\nAlso for endianess issues, we can run openocd1 on a big-endian PC and openocd2 on a little endian one.\nSince you have the fresh knowledge of xvc protocol, would you be interested in implementing the server side too?","commit_id":"abab47cd742d48a95e510774143284399ccfe20d"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"2a20549d12156ecd7063d4064038a8de2ef1b7fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"dfab9b97_507ebc9c","updated":"2022-03-07 11:15:12.000000000","message":"Hello Antonio, \n\nThank you again for your comments. I have performed all the changes you suggested. \nI hope jenkins works this time. I have noticed that you are in the \u0027CC\u0027 field, but, not in the \u0027reviewers\u0027 one. Is there any reason for it? Should I change it?\n\nThank you in advance.","commit_id":"abab47cd742d48a95e510774143284399ccfe20d"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"12e553efad2f26a632ec23a1f57cf00d6b7456e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"49b7a50e_a36348d4","in_reply_to":"73eb4a62_7224177e","updated":"2022-03-11 13:12:13.000000000","message":"We have developed a low-cost bitbanging JTAG device based on a microcontroller that implements the XVC Server. We have also used an open-source XVC server implementaton for the Raspberry Pi to test the OpenOCD driver. \nWe would gladly contribute to develop an XVC Server module for OpenOCD.\n\nI will have a look at the OpenOCD Server code. Any tips on where to start or what to look here?","commit_id":"abab47cd742d48a95e510774143284399ccfe20d"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"12e553efad2f26a632ec23a1f57cf00d6b7456e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f3368b4c_ddacb7fa","updated":"2022-03-11 13:12:13.000000000","message":"Hello back Antonio,\n\nThank you again for your comments. I have performed all the changes you suggested. \n\nCheers.","commit_id":"02deec68dd383f6c9632b1845134fc1faa94a4ad"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"5a72491c4d44dc1ba22c485a441d0344e60c3bab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"62c91eb1_95ecb277","updated":"2022-05-03 11:26:18.000000000","message":"Hello back Antonio,\n\nWe have made all the suggested changes.\n\nThank you for your time.\n\nBest regards","commit_id":"02deec68dd383f6c9632b1845134fc1faa94a4ad"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"cbe11953b13f93a1f8993018963d3801aa4b1415","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"67ebb70f_96d885b3","updated":"2022-03-25 15:18:10.000000000","message":"Hi Antonio, \n\nWe did all the changes two weeks ago and we have not received further feedback. Did we do something wrong again? Is everything OK? Should we do any further changes or just wait?\n\nCurrently there is nobody marked as a reviewer, is this normal?\n\nThank you,kind regards.","commit_id":"02deec68dd383f6c9632b1845134fc1faa94a4ad"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"81eea0324bdd4f2eb21835b40377596e08ba9a57","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3783a4fd_45035f56","updated":"2022-05-01 22:22:00.000000000","message":"sorry, too busy to return on this review earlier\nI will return later on this","commit_id":"02deec68dd383f6c9632b1845134fc1faa94a4ad"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"5a72491c4d44dc1ba22c485a441d0344e60c3bab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d4b0e07d_26ae88f1","in_reply_to":"3783a4fd_45035f56","updated":"2022-05-03 11:26:18.000000000","message":"\u003e sorry, too busy to return on this review earlier\n\u003e I will return later on this\n\nComments resolved. Thank you for your suggestions.","commit_id":"02deec68dd383f6c9632b1845134fc1faa94a4ad"},{"author":{"_account_id":1002021,"name":"Augusto Fraga Giachero","email":"afg@augustofg.net","username":"Palmitoxico"},"change_message_id":"11b3b8adec251e55a1f0036edce70d573f558e1c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"52d0722f_5d47407b","updated":"2022-08-17 11:04:28.000000000","message":"Hello,\n\nThere are any pending issues with this pull request? I having been testing it over last months and seems to be stable enough.","commit_id":"5c43675291340f79ac45dfb1622d1719342f845e"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"bd0513ffb7f97f5c9ed9b4f0dfa1d97cb0c6e7e9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3d797b4f_ec4129db","updated":"2023-01-10 14:57:16.000000000","message":"Hi, \n\nAs far as I\u0027m concerned, no new issues have appeared since last patch. \n\nRegards.","commit_id":"5c43675291340f79ac45dfb1622d1719342f845e"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3e3a2d99541495334c133a5abf70cd89d7dcd945","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f4ecdd7b_210dcc9f","updated":"2023-08-24 15:14:54.000000000","message":"Sorry for the long delay. This patch was lost in my inbox and I missed it in gerrit too!\nI have some minor comments  below, plus gerrit reports it cannot be merged anymore due to some conflict.\nWould you mind rebasing the patch on current HEAD of master branch?","commit_id":"5c43675291340f79ac45dfb1622d1719342f845e"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"bd0513ffb7f97f5c9ed9b4f0dfa1d97cb0c6e7e9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"fb0e4209_78eb533e","in_reply_to":"52d0722f_5d47407b","updated":"2023-01-10 14:57:16.000000000","message":"Hi, \n\nAs far as I\u0027m concerned, no new issues have appeared since last patch. \n\nRegards.","commit_id":"5c43675291340f79ac45dfb1622d1719342f845e"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"8eecdbf10770bb1e7cdb3d0f2f01712a034fb51f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"10e8a59b_208400a5","in_reply_to":"f4ecdd7b_210dcc9f","updated":"2023-12-22 13:18:42.000000000","message":"\u003e Sorry for the long delay. This patch was lost in my inbox and I missed it in gerrit too!\n\u003e I have some minor comments  below, plus gerrit reports it cannot be merged anymore due to some conflict.\n\u003e Would you mind rebasing the patch on current HEAD of master branch?\n\nDone, I hope it has been done the correct way. Sorry about the delay.","commit_id":"5c43675291340f79ac45dfb1622d1719342f845e"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"55a482d80ef46139fd10cb87c90ed872522a32a7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"032ccbd4_a8d9affc","updated":"2023-12-22 13:27:04.000000000","message":"Updated from patch #5","commit_id":"91c0fe854ffd62c39d80d1aea53a429905b6eee8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"ca0ad591b519469b89003821b14ff82b68be5b3a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"71438f42_13240977","updated":"2023-12-28 15:56:02.000000000","message":"Please notice that there are two comments on Patchset 5 that looks not replied.","commit_id":"b3875e3a2ea7777eec246d5bdeab9d23b8f01cc5"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"52ee2db12efa011fa01208cd7ac1c5a26b6c6a49","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"b3d5e3f2_f488d88a","updated":"2023-12-22 13:48:34.000000000","message":"Sorry, I did not realize documentation was not being built. Should be OK now","commit_id":"b3875e3a2ea7777eec246d5bdeab9d23b8f01cc5"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"0ee476617c076811187856a5e1f23cc527746e32","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"5fab7fcb_3550a675","updated":"2024-02-12 23:15:10.000000000","message":"Few more comments. Mainly, one API has changed recently and this will not compile on current master branch","commit_id":"a6b4f4fc2b0cfae25a4386978dac8a6c8541b3f3"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"c74d2a12932dbbf27db9d6364608977df480ce66","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"f899a65f_a326ee70","in_reply_to":"5fab7fcb_3550a675","updated":"2024-02-14 15:47:59.000000000","message":"Got it, it should be OK now.","commit_id":"a6b4f4fc2b0cfae25a4386978dac8a6c8541b3f3"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"9a92fe7eaea278bf6d8d5991b56682e97bee4858","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"9d329e7d_9d063335","updated":"2024-02-26 18:10:39.000000000","message":"I think you have sent out an incorrect version as patchset 10, as few comment are not fixed yet","commit_id":"6ace20621d16462051d2ddcdd3116c0e1d000ebd"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"fbc613b8829b0055db996a05926aaa5daf1b20b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"efdcadcd_e4be2cce","updated":"2024-02-27 17:57:25.000000000","message":"Changed return statement + re-updated changes suggested on patchset #10","commit_id":"19225a8ee530f5acb73d3a27367e11b23a4b8347"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"cd8c01ab8d7d087df5afcc98e179e2bbedf09f9e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"25fe8755_45362468","updated":"2024-07-16 22:00:35.000000000","message":"Thanks for the contribution Jose! There are some issues with the code that need to be fixed before we can merge this patch.\n\nAlso, you have some stray line breaks in your Git commit message that should be fixed.","commit_id":"b094e21223faf5f2dcb741dc0ae6bb73c5e8f32d"},{"author":{"_account_id":1002021,"name":"Augusto Fraga Giachero","email":"afg@augustofg.net","username":"Palmitoxico"},"change_message_id":"d761507ab28b4d55c14ac5dd150ffbc3b5313d29","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"d800ec14_570ba7d2","updated":"2024-07-16 15:50:59.000000000","message":"We have been using this over more than a year now, from what I see, all comments from Antonio have been addressed. Can this be merged?","commit_id":"b094e21223faf5f2dcb741dc0ae6bb73c5e8f32d"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"7947c200a75c7f5ae73a1088ffb809206a85c1e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"059ad7ad_5c8c3c54","in_reply_to":"25fe8755_45362468","updated":"2024-07-24 11:49:05.000000000","message":"Dear Marc, \n\nThank you for your feedback! A new patch has just been submitted.\n\nRegards,","commit_id":"b094e21223faf5f2dcb741dc0ae6bb73c5e8f32d"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"7947c200a75c7f5ae73a1088ffb809206a85c1e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"bafefb68_ecdc0bdb","updated":"2024-07-24 11:49:05.000000000","message":"Dear Marc,\n\nThank you for your feedback! A new patch has just been submitted.\n\nRegards,","commit_id":"c107aabe537f5fe98b03d08e71a4aab26e59a654"},{"author":{"_account_id":1002404,"name":"Anthony Donlon","username":"donlon"},"change_message_id":"d6ddbdf47531c80fe71b9efb5d9aa67dea72d871","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"ee06dd2a_e697f8d3","updated":"2025-05-12 11:57:50.000000000","message":"Hi, I\u0027m quite interested in this new XVC adapter. Are there any updates on this? Thank you!\n\nKind regards.","commit_id":"c107aabe537f5fe98b03d08e71a4aab26e59a654"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"74ac502b86d70113137142c67aefaf4ba254cf21","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"4c2eb6b1_248719c6","updated":"2025-05-13 06:44:41.000000000","message":"Some more review from my side, mostly coding style issues. Also, make the comment style consistent (see style guide), please.\n\n@Anthony, do you have a minimum working setup you can share to test this driver?","commit_id":"c107aabe537f5fe98b03d08e71a4aab26e59a654"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"ae3b3768331c9b83391a30ef99f9dfb18b2cf9a4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"fa7a4d27_ade28b0d","in_reply_to":"ee06dd2a_e697f8d3","updated":"2025-05-16 08:22:39.000000000","message":"Hi Anthony,\n\nI am pleased to hear that! In case you are willing to test it out, I am attaching the repository for the server side: https://github.com/DIANA-IoT/XVC-server-ESP32\n\nKind regards.","commit_id":"c107aabe537f5fe98b03d08e71a4aab26e59a654"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"ae3b3768331c9b83391a30ef99f9dfb18b2cf9a4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"a04cfa9d_e2db692b","updated":"2025-05-16 08:22:39.000000000","message":"Dear Marc,\n\nI hope all the styling issues are solved now. Code has been tested against latest changes in the API, working fine.\n\nKind regards.","commit_id":"6aded56e662ad9ee4085ad5a6c9795bc11c6bb21"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"494aad863615265c56a35c50e5f9783d8397af22","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"ef7f5b13_c39f3631","updated":"2025-06-21 08:38:05.000000000","message":"Sorry for not having time to return on this code.\nI have added few more comments. The rest looks ok.","commit_id":"6aded56e662ad9ee4085ad5a6c9795bc11c6bb21"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"dd9f2bedf9077b57608cbdf3aeb37ba6b957aef6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"1b26e2e1_3449f3e5","in_reply_to":"ef7f5b13_c39f3631","updated":"2025-06-24 13:06:48.000000000","message":"Thanks for the comments.","commit_id":"6aded56e662ad9ee4085ad5a6c9795bc11c6bb21"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"8cb073886ca53653df51801e4d79ddc628b6f90f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"32ce3070_eb9b9b69","updated":"2025-06-25 11:49:08.000000000","message":"The error you got from the ACI is crap.\n```\nIn file included from ./src/helper/system.h:15,\n                 from ./src/helper/replacements.h:18,\n                 from ./src/helper/bits.h:16,\n                 from src/jtag/drivers/xvc.c:23:\n/usr/share/mingw-w64/include/winsock2.h:15:2: error: #warning Please include winsock2.h before windows.h [-Werror\u003dcpp]\n   15 | #warning Please include winsock2.h before windows.h\n```\n\nIt is caused by the line\n`#include \u003cwinsock.h\u003e`\nthat defines `_WINSOCKAPI_`.\nThen when `winsock2.h` gets included it check for that macro already defined and claims it is caused by `windows.h` !\n\nI don\u0027t know if you really need to include `winsock.h`, you can try what happens dropping it.\nAnyway, moving it after the other includes could fix the build","commit_id":"7cb1b382400705b1c2c01cbf6b9454eb712cd1b3"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"cd675060b3644b7e8db6cee33b7f72e2ca2ef63d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"a265cc24_f4f29eb0","updated":"2025-06-26 14:02:15.000000000","message":"Last comment, I hope, below!\nThanks","commit_id":"fc557e79b624b05a7c1923e4e12b9aac96327572"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"d5287260026f7cd6cacc71e5f8b7903810256eee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"e47747db_519c07e5","updated":"2025-08-11 18:53:20.000000000","message":"Always beneficial to test on real hardware! Your code has a few memory access violations. Please check your code with `valgrind`. One example is given below.\n\nTested with an own XVC implementation on a Raspberry Pi.","commit_id":"3503281d1ad2fd078e9f3f6d7125aa1ac78dcb34"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b8645f98582d4edd2a239b676cc457f76014bf93","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"e05c72cf_0a92340e","updated":"2025-07-02 21:51:10.000000000","message":"Done!\nBut gerrit already say \"merge conflict\", I think due to\nhttps://review.openocd.org/c/openocd/+/8950\nIf you can, please rebase it on top of current master branch.","commit_id":"3503281d1ad2fd078e9f3f6d7125aa1ac78dcb34"},{"author":{"_account_id":1002431,"name":"stridge-tnp","username":"stridge-tnp"},"change_message_id":"fffec9790b8ba43031d5c42dfb7d1c571bce5aa6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"21be1351_a53b9373","updated":"2025-08-07 23:51:35.000000000","message":"I have used this patch with real hardware and have verified it. Thanks for the patch!","commit_id":"3503281d1ad2fd078e9f3f6d7125aa1ac78dcb34"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"d22f68dc3992579ce78fe44b3d451e85a7ec9a1f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"66d107db_081d548d","updated":"2025-07-02 22:14:28.000000000","message":"Thanks, let me try to test the driver on real hardware.","commit_id":"3503281d1ad2fd078e9f3f6d7125aa1ac78dcb34"},{"author":{"_account_id":1002431,"name":"stridge-tnp","username":"stridge-tnp"},"change_message_id":"47ebdbdef013ee128bf20a5f024becc42df3c5eb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"dd7355bd_16ef5097","in_reply_to":"0b2d3d80_90a1e87a","updated":"2025-08-17 11:08:59.000000000","message":"I have a RISCV core on a U50 FPGA. I used an AXI to JTAG block to attach to the riscv. I ended up making my own XVC server bc i wanted to use XDMA not XRT using this as reference: https://github.com/BerkeleyLab/XVC-FTDI-JTAG/blob/master/ftdiJTAG.c.\n\nMy config was as follows:\nadapter driver xvc\nadapter speed 100\n\nxvc host 127.0.0.1\nxvc port 2542\n\nreset_config none\n\ntransport select jtag\nset _CHIPNAME riscv\njtag newtap $_CHIPNAME tap -irlen 5 -expected-id 0x1babe247\n\nset _TARGETNAME riscv\ntarget create $_TARGETNAME.0 riscv -chain-position $_CHIPNAME.tap\n\nriscv.0 configure -work-area-phys 0x80000000 -work-area-size 524288\n\nriscv set_mem_access sysbus progbuf\n\ninit\n\nI can connect with GDB and compiled/run a few things. Everything is working as expected.","commit_id":"3503281d1ad2fd078e9f3f6d7125aa1ac78dcb34"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"32a3761967a145ff720d9df9bd869c00332a4efc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"0b2d3d80_90a1e87a","in_reply_to":"21be1351_a53b9373","updated":"2025-08-08 07:07:41.000000000","message":"What hardware did you use? I tried a few software/server solutions for RPi but they did not work. The software / server part, not OpenOCD. Next I will try the ESP32.","commit_id":"3503281d1ad2fd078e9f3f6d7125aa1ac78dcb34"},{"author":{"_account_id":1002431,"name":"stridge-tnp","username":"stridge-tnp"},"change_message_id":"b8e51fda00e297819a980a838b96d7ce9405db05","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"ff891121_3b05a290","in_reply_to":"dd7355bd_16ef5097","updated":"2025-08-17 11:11:18.000000000","message":"Also FYI it wasn\u0027t exactly this patch :p i applied it to the riscv version of openocd: https://github.com/riscv-collab/riscv-openocd/pull/1283","commit_id":"3503281d1ad2fd078e9f3f6d7125aa1ac78dcb34"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"b5e2640bb355173ab03f9497ef061ea9dd36d066","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"bdedf7ad_d353c6eb","updated":"2025-10-14 09:08:54.000000000","message":"\u003e I hope the code meets management standards. Since March 2022, we have made an effort to support and correct this patch, despite several API changes and some contradictory reviews in between. Thus, we hope there will be a revision before the next API change.\n\nThat is indeed an unusually long time, sorry for that. I\u0027m just trying to ensure that the code quality, especially for new code, meets a certain minimum standard. I hope these are the last change requests.\n\nThanks for all your changes so far.","commit_id":"a9ad0c0ca28eded67b36f031ed32df0ef9227a7d"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"f93f27e2b49eddf4cbe4f06e3388d7b4e9159821","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"7465253e_589ce8b3","updated":"2025-09-05 12:25:10.000000000","message":"I hope the code meets management standards. Since March 2022, we have made an effort to support and correct this patch, despite several API changes and some contradictory reviews in between. Thus, we hope there will be a revision before the next API change.\n\nThank you for your time.","commit_id":"a9ad0c0ca28eded67b36f031ed32df0ef9227a7d"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"6a3b1ae39749ac684839dd9888ee23620dcd77da","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"eb3de01e_823a4ede","in_reply_to":"bdedf7ad_d353c6eb","updated":"2025-10-15 08:32:30.000000000","message":"Thank you for your feedback and suggestions to improve code quality.","commit_id":"a9ad0c0ca28eded67b36f031ed32df0ef9227a7d"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"6a3b1ae39749ac684839dd9888ee23620dcd77da","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"a86ecfdb_fb6bfb9f","updated":"2025-10-15 08:32:30.000000000","message":"Thank you for your feedback and suggestions to improve code quality. New patch uploaded","commit_id":"6956008370dfd5d5959bebe61ca2b9759533215e"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"d593c5398f35cc76a1276e804c339744d2eeca21","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"3f38795f_d563cb6b","updated":"2025-10-15 09:07:38.000000000","message":"Updated patch","commit_id":"ed969c3410e0130ac2cda0d8759c42ad2ce0a78f"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"a40cd71b967334df72b17e629ab7f965a995a4a4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"10479447_af434164","updated":"2026-04-19 11:47:07.000000000","message":"Rebased the patch. To keep things moving, I\u0027ve pushed a few patches that address the most urgent issues in this one.\n\nI also released the XVC implementation that I used for testing: https://pypi.org/project/xvc-gpiod/","commit_id":"81a44212151591555572dc45f657d9fd6d7f541d"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"478b8c5909c4f81ba1c7c2ac3877f05151ef27ef","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":26,"id":"b9f5fd46_e83f9cea","in_reply_to":"10479447_af434164","updated":"2026-04-21 07:33:08.000000000","message":"Thanks!\nI also have this pending in my branch of patches to follow.\nWhat about adding a link to `xvc-gpiod` project in the doc? Maybe in a separate patch!","commit_id":"81a44212151591555572dc45f657d9fd6d7f541d"}],"configure.ac":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"fc0911bec97ec5b0fc7c4d0765990b1aa6537469","unresolved":true,"context_lines":[{"line_number":111,"context_line":"m4_define([USB1_ADAPTERS],"},{"line_number":112,"context_line":"\t[[[ftdi], [MPSSE mode of FTDI based devices], [FTDI]],"},{"line_number":113,"context_line":"\t[[stlink], [ST-Link Programmer], [HLADAPTER_STLINK]],"},{"line_number":114,"context_line":"\t[[xvc], [XVC Driver], [xvc]],"},{"line_number":115,"context_line":"\t[[ti_icdi], [TI ICDI JTAG Programmer], [HLADAPTER_ICDI]],"},{"line_number":116,"context_line":"\t[[ulink], [Keil ULINK JTAG Programmer], [ULINK]],"},{"line_number":117,"context_line":"\t[[usb_blaster_2], [Altera USB-Blaster II Compatible], [USB_BLASTER_2]],"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"6b1653c3_b70c2b93","line":114,"updated":"2022-03-05 17:54:00.000000000","message":"The second part will be printed in the summary at the end of \"./configure\". Write:\n[Xilinx XVC TCP]","commit_id":"477be1c0753a0cfc1409ef835964bf0aad8130cb"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"2a20549d12156ecd7063d4064038a8de2ef1b7fa","unresolved":false,"context_lines":[{"line_number":111,"context_line":"m4_define([USB1_ADAPTERS],"},{"line_number":112,"context_line":"\t[[[ftdi], [MPSSE mode of FTDI based devices], [FTDI]],"},{"line_number":113,"context_line":"\t[[stlink], [ST-Link Programmer], [HLADAPTER_STLINK]],"},{"line_number":114,"context_line":"\t[[xvc], [XVC Driver], [xvc]],"},{"line_number":115,"context_line":"\t[[ti_icdi], [TI ICDI JTAG Programmer], [HLADAPTER_ICDI]],"},{"line_number":116,"context_line":"\t[[ulink], [Keil ULINK JTAG Programmer], [ULINK]],"},{"line_number":117,"context_line":"\t[[usb_blaster_2], [Altera USB-Blaster II Compatible], [USB_BLASTER_2]],"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"8403f88f_0fc6d47a","line":114,"in_reply_to":"6b1653c3_b70c2b93","updated":"2022-03-07 11:15:12.000000000","message":"Done","commit_id":"477be1c0753a0cfc1409ef835964bf0aad8130cb"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"fc0911bec97ec5b0fc7c4d0765990b1aa6537469","unresolved":true,"context_lines":[{"line_number":365,"context_line":"  [build_remote_bitbang\u003d$enableval], [build_remote_bitbang\u003dno])"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"AC_ARG_ENABLE([xvc],"},{"line_number":368,"context_line":"  AS_HELP_STRING([--enable-xvc], [Enable building support for the XVC jtag driver]),"},{"line_number":369,"context_line":"  [build_xvc\u003d$enableval], [build_xvc\u003dyes])"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"AS_CASE([\"${host_cpu}\"],"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"16af740e_a42db5ef","line":368,"updated":"2022-03-05 17:54:00.000000000","message":"This text will be printed with \"./configure --help\". Write:\nEnable building support for the Xilinx XVC TCP jtag driver","commit_id":"477be1c0753a0cfc1409ef835964bf0aad8130cb"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"2a20549d12156ecd7063d4064038a8de2ef1b7fa","unresolved":false,"context_lines":[{"line_number":365,"context_line":"  [build_remote_bitbang\u003d$enableval], [build_remote_bitbang\u003dno])"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"AC_ARG_ENABLE([xvc],"},{"line_number":368,"context_line":"  AS_HELP_STRING([--enable-xvc], [Enable building support for the XVC jtag driver]),"},{"line_number":369,"context_line":"  [build_xvc\u003d$enableval], [build_xvc\u003dyes])"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"AS_CASE([\"${host_cpu}\"],"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"301a7a18_17c96e27","line":368,"in_reply_to":"16af740e_a42db5ef","updated":"2022-03-07 11:15:12.000000000","message":"Done","commit_id":"477be1c0753a0cfc1409ef835964bf0aad8130cb"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"ca0ad591b519469b89003821b14ff82b68be5b3a","unresolved":true,"context_lines":[{"line_number":116,"context_line":"m4_define([USB1_ADAPTERS],"},{"line_number":117,"context_line":"\t[[[ftdi], [MPSSE mode of FTDI based devices], [FTDI]],"},{"line_number":118,"context_line":"\t[[stlink], [ST-Link Programmer], [HLADAPTER_STLINK]],"},{"line_number":119,"context_line":"\t[[xvc], [Xilinx XVC TCP], [xvc]],"},{"line_number":120,"context_line":"\t[[ti_icdi], [TI ICDI JTAG Programmer], [HLADAPTER_ICDI]],"},{"line_number":121,"context_line":"\t[[ulink], [Keil ULINK JTAG Programmer], [ULINK]],"},{"line_number":122,"context_line":"\t[[angie], [ANGIE Adapter], [ANGIE]],"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"349d3c08_468317b7","line":119,"updated":"2023-12-28 15:56:02.000000000","message":"sorry I haven\u0027t noticed this before.\nThe driver xvc doesn\u0027t use USB, so it\u0027s incorrect o place it here in the list of drivers that depends on USB libraries.\nThis xvc driver has no dependencies to check (network is supposed to be always present in modern OS)\nThere is the driver \u0027buspirate\u0027 that is based on serial port and also has no dependencies.\nYou can create a new group NETWORK_ADAPTERS by copying what is present around SERIAL_PORT_ADAPTERS in this file (just search SERIAL_PORT_ADAPTERS) and add xvc to the new group NETWORK_ADAPTERS","commit_id":"b3875e3a2ea7777eec246d5bdeab9d23b8f01cc5"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"9044a6ef1e155ebc2e4150761f3faa004604f70d","unresolved":false,"context_lines":[{"line_number":116,"context_line":"m4_define([USB1_ADAPTERS],"},{"line_number":117,"context_line":"\t[[[ftdi], [MPSSE mode of FTDI based devices], [FTDI]],"},{"line_number":118,"context_line":"\t[[stlink], [ST-Link Programmer], [HLADAPTER_STLINK]],"},{"line_number":119,"context_line":"\t[[xvc], [Xilinx XVC TCP], [xvc]],"},{"line_number":120,"context_line":"\t[[ti_icdi], [TI ICDI JTAG Programmer], [HLADAPTER_ICDI]],"},{"line_number":121,"context_line":"\t[[ulink], [Keil ULINK JTAG Programmer], [ULINK]],"},{"line_number":122,"context_line":"\t[[angie], [ANGIE Adapter], [ANGIE]],"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"679c9116_f91aeb95","line":119,"in_reply_to":"349d3c08_468317b7","updated":"2024-01-25 10:45:02.000000000","message":"You are right. Should be in its correct category now.","commit_id":"b3875e3a2ea7777eec246d5bdeab9d23b8f01cc5"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"0ee476617c076811187856a5e1f23cc527746e32","unresolved":true,"context_lines":[{"line_number":864,"context_line":"\tLIBFTDI_USB1_ADAPTERS,"},{"line_number":865,"context_line":"\tLIBGPIOD_ADAPTERS,"},{"line_number":866,"context_line":"\tLIBJAYLINK_ADAPTERS, PCIE_ADAPTERS, SERIAL_PORT_ADAPTERS,"},{"line_number":867,"context_line":"  NETWORK_ADAPTERS,"},{"line_number":868,"context_line":"\tOPTIONAL_LIBRARIES],"},{"line_number":869,"context_line":"\t[s\u003dm4_format([\"%-40s\"], ADAPTER_DESC([adapter]))"},{"line_number":870,"context_line":"\tAS_CASE([$ADAPTER_VAR([adapter])],"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"3538ecdd_a4d97848","line":867,"updated":"2024-02-12 23:15:10.000000000","message":"the other entries in this list are indented through a single TAB.\nPlease use the same indentation","commit_id":"a6b4f4fc2b0cfae25a4386978dac8a6c8541b3f3"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"c74d2a12932dbbf27db9d6364608977df480ce66","unresolved":false,"context_lines":[{"line_number":864,"context_line":"\tLIBFTDI_USB1_ADAPTERS,"},{"line_number":865,"context_line":"\tLIBGPIOD_ADAPTERS,"},{"line_number":866,"context_line":"\tLIBJAYLINK_ADAPTERS, PCIE_ADAPTERS, SERIAL_PORT_ADAPTERS,"},{"line_number":867,"context_line":"  NETWORK_ADAPTERS,"},{"line_number":868,"context_line":"\tOPTIONAL_LIBRARIES],"},{"line_number":869,"context_line":"\t[s\u003dm4_format([\"%-40s\"], ADAPTER_DESC([adapter]))"},{"line_number":870,"context_line":"\tAS_CASE([$ADAPTER_VAR([adapter])],"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"c53a1557_dc1d0914","line":867,"in_reply_to":"3538ecdd_a4d97848","updated":"2024-02-14 15:47:59.000000000","message":"Done","commit_id":"a6b4f4fc2b0cfae25a4386978dac8a6c8541b3f3"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"244504ea04b93c88a3d428962a13f84ff8b974bf","unresolved":false,"context_lines":[{"line_number":864,"context_line":"\tLIBFTDI_USB1_ADAPTERS,"},{"line_number":865,"context_line":"\tLIBGPIOD_ADAPTERS,"},{"line_number":866,"context_line":"\tLIBJAYLINK_ADAPTERS, PCIE_ADAPTERS, SERIAL_PORT_ADAPTERS,"},{"line_number":867,"context_line":"  NETWORK_ADAPTERS,"},{"line_number":868,"context_line":"\tOPTIONAL_LIBRARIES],"},{"line_number":869,"context_line":"\t[s\u003dm4_format([\"%-40s\"], ADAPTER_DESC([adapter]))"},{"line_number":870,"context_line":"\tAS_CASE([$ADAPTER_VAR([adapter])],"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"ae78fb10_e7d3d1e0","line":867,"in_reply_to":"a139e37c_d5d8a390","updated":"2024-02-27 17:39:47.000000000","message":"Done","commit_id":"a6b4f4fc2b0cfae25a4386978dac8a6c8541b3f3"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"9a92fe7eaea278bf6d8d5991b56682e97bee4858","unresolved":true,"context_lines":[{"line_number":864,"context_line":"\tLIBFTDI_USB1_ADAPTERS,"},{"line_number":865,"context_line":"\tLIBGPIOD_ADAPTERS,"},{"line_number":866,"context_line":"\tLIBJAYLINK_ADAPTERS, PCIE_ADAPTERS, SERIAL_PORT_ADAPTERS,"},{"line_number":867,"context_line":"  NETWORK_ADAPTERS,"},{"line_number":868,"context_line":"\tOPTIONAL_LIBRARIES],"},{"line_number":869,"context_line":"\t[s\u003dm4_format([\"%-40s\"], ADAPTER_DESC([adapter]))"},{"line_number":870,"context_line":"\tAS_CASE([$ADAPTER_VAR([adapter])],"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"a139e37c_d5d8a390","line":867,"in_reply_to":"c53a1557_dc1d0914","updated":"2024-02-26 18:10:39.000000000","message":"This is still not properly indented.\nUse a TAB instead of 2 spaces at the beginning of the line","commit_id":"a6b4f4fc2b0cfae25a4386978dac8a6c8541b3f3"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"494aad863615265c56a35c50e5f9783d8397af22","unresolved":true,"context_lines":[{"line_number":180,"context_line":"\t[[[buspirate], [Bus Pirate], [BUS_PIRATE]]])"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"m4_define([NETWORK_ADAPTERS],"},{"line_number":183,"context_line":"\t[[[xvc], [Xilinx XVC TCP], [xvc]]])"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"m4_define([LINUXSPIDEV_ADAPTER],"},{"line_number":186,"context_line":"\t[[[linuxspidev], [Linux spidev driver], [LINUXSPIDEV]]])"}],"source_content_type":"application/octet-stream","patch_set":15,"id":"5da6be6e_9f5bee3e","line":183,"updated":"2025-06-21 08:38:05.000000000","message":"`[[[xvc], [Xilinx XVC TCP], [XVC]]])`\nwith last value uppercase, so it will define automatically `BUILD_XVC`","commit_id":"6aded56e662ad9ee4085ad5a6c9795bc11c6bb21"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"dd9f2bedf9077b57608cbdf3aeb37ba6b957aef6","unresolved":false,"context_lines":[{"line_number":180,"context_line":"\t[[[buspirate], [Bus Pirate], [BUS_PIRATE]]])"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"m4_define([NETWORK_ADAPTERS],"},{"line_number":183,"context_line":"\t[[[xvc], [Xilinx XVC TCP], [xvc]]])"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"m4_define([LINUXSPIDEV_ADAPTER],"},{"line_number":186,"context_line":"\t[[[linuxspidev], [Linux spidev driver], [LINUXSPIDEV]]])"}],"source_content_type":"application/octet-stream","patch_set":15,"id":"2e2470f9_5fd08c2b","line":183,"in_reply_to":"5da6be6e_9f5bee3e","updated":"2025-06-24 13:06:48.000000000","message":"Done","commit_id":"6aded56e662ad9ee4085ad5a6c9795bc11c6bb21"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"494aad863615265c56a35c50e5f9783d8397af22","unresolved":true,"context_lines":[{"line_number":422,"context_line":"  [Enable building internal libjaylink]),"},{"line_number":423,"context_line":"  [use_internal_libjaylink\u003d$enableval], [use_internal_libjaylink\u003dno])"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"AC_ARG_ENABLE([xvc],"},{"line_number":426,"context_line":"  AS_HELP_STRING([--enable-xvc], [Enable building support for the Xilinx XVC TCP jtag driver]),"},{"line_number":427,"context_line":"  [build_xvc\u003d$enableval], [build_xvc\u003dyes])"},{"line_number":428,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":15,"id":"5ecec796_f07f7caf","line":425,"updated":"2025-06-21 08:38:05.000000000","message":"there are several changes in `configure.ac` upstream\nPlease rebase the patch.\nThis part of the patch should be dropped","commit_id":"6aded56e662ad9ee4085ad5a6c9795bc11c6bb21"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"dd9f2bedf9077b57608cbdf3aeb37ba6b957aef6","unresolved":false,"context_lines":[{"line_number":422,"context_line":"  [Enable building internal libjaylink]),"},{"line_number":423,"context_line":"  [use_internal_libjaylink\u003d$enableval], [use_internal_libjaylink\u003dno])"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"AC_ARG_ENABLE([xvc],"},{"line_number":426,"context_line":"  AS_HELP_STRING([--enable-xvc], [Enable building support for the Xilinx XVC TCP jtag driver]),"},{"line_number":427,"context_line":"  [build_xvc\u003d$enableval], [build_xvc\u003dyes])"},{"line_number":428,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":15,"id":"afc7cf3e_a9de2954","line":425,"in_reply_to":"5ecec796_f07f7caf","updated":"2025-06-24 13:06:48.000000000","message":"Done","commit_id":"6aded56e662ad9ee4085ad5a6c9795bc11c6bb21"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"494aad863615265c56a35c50e5f9783d8397af22","unresolved":true,"context_lines":[{"line_number":608,"context_line":"  ])"},{"line_number":609,"context_line":"])"},{"line_number":610,"context_line":""},{"line_number":611,"context_line":"AS_IF([test \"x$build_remote_bitbang\" \u003d \"xyes\"], ["},{"line_number":612,"context_line":"  build_bitbang\u003dyes"},{"line_number":613,"context_line":"  AC_DEFINE([BUILD_REMOTE_BITBANG], [1], [1 if you want the Remote Bitbang driver.])"},{"line_number":614,"context_line":"], ["}],"source_content_type":"application/octet-stream","patch_set":15,"id":"7f121725_fe5d1887","line":611,"updated":"2025-06-21 08:38:05.000000000","message":"all this part of your patch to be removed, as has been dropped upstream","commit_id":"6aded56e662ad9ee4085ad5a6c9795bc11c6bb21"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"dd9f2bedf9077b57608cbdf3aeb37ba6b957aef6","unresolved":false,"context_lines":[{"line_number":608,"context_line":"  ])"},{"line_number":609,"context_line":"])"},{"line_number":610,"context_line":""},{"line_number":611,"context_line":"AS_IF([test \"x$build_remote_bitbang\" \u003d \"xyes\"], ["},{"line_number":612,"context_line":"  build_bitbang\u003dyes"},{"line_number":613,"context_line":"  AC_DEFINE([BUILD_REMOTE_BITBANG], [1], [1 if you want the Remote Bitbang driver.])"},{"line_number":614,"context_line":"], ["}],"source_content_type":"application/octet-stream","patch_set":15,"id":"2c7ddc78_5e4a07a6","line":611,"in_reply_to":"7f121725_fe5d1887","updated":"2025-06-24 13:06:48.000000000","message":"Done","commit_id":"6aded56e662ad9ee4085ad5a6c9795bc11c6bb21"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"494aad863615265c56a35c50e5f9783d8397af22","unresolved":true,"context_lines":[{"line_number":739,"context_line":"PROCESS_ADAPTERS([JTAG_VPI_ADAPTER], [true], [unused])"},{"line_number":740,"context_line":"PROCESS_ADAPTERS([RSHIM_ADAPTER], [\"x$can_build_rshim\" \u003d \"xyes\"],"},{"line_number":741,"context_line":"                                  [internal error: validation should happen beforehand])"},{"line_number":742,"context_line":"PROCESS_ADAPTERS([AMTJTAGACCEL_ADAPTER], [true], [unused])"},{"line_number":743,"context_line":"PROCESS_ADAPTERS([DUMMY_ADAPTER], [true], [unused])"},{"line_number":744,"context_line":""},{"line_number":745,"context_line":"AS_IF([test \"x$enable_linuxgpiod\" !\u003d \"xno\"], ["}],"source_content_type":"application/octet-stream","patch_set":15,"id":"883a7457_c8f66bcc","line":742,"updated":"2025-06-21 08:38:05.000000000","message":"somewhere in this part of code add:\n`PROCESS_ADAPTERS([NETWORK_ADAPTERS], [true], [unused])`","commit_id":"6aded56e662ad9ee4085ad5a6c9795bc11c6bb21"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"dd9f2bedf9077b57608cbdf3aeb37ba6b957aef6","unresolved":false,"context_lines":[{"line_number":739,"context_line":"PROCESS_ADAPTERS([JTAG_VPI_ADAPTER], [true], [unused])"},{"line_number":740,"context_line":"PROCESS_ADAPTERS([RSHIM_ADAPTER], [\"x$can_build_rshim\" \u003d \"xyes\"],"},{"line_number":741,"context_line":"                                  [internal error: validation should happen beforehand])"},{"line_number":742,"context_line":"PROCESS_ADAPTERS([AMTJTAGACCEL_ADAPTER], [true], [unused])"},{"line_number":743,"context_line":"PROCESS_ADAPTERS([DUMMY_ADAPTER], [true], [unused])"},{"line_number":744,"context_line":""},{"line_number":745,"context_line":"AS_IF([test \"x$enable_linuxgpiod\" !\u003d \"xno\"], ["}],"source_content_type":"application/octet-stream","patch_set":15,"id":"f0c79d29_a15ff66b","line":742,"in_reply_to":"883a7457_c8f66bcc","updated":"2025-06-24 13:06:48.000000000","message":"Done","commit_id":"6aded56e662ad9ee4085ad5a6c9795bc11c6bb21"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"494aad863615265c56a35c50e5f9783d8397af22","unresolved":true,"context_lines":[{"line_number":753,"context_line":"AS_IF([test \"x$enable_remote_bitbang\" !\u003d \"xno\"], ["},{"line_number":754,"context_line":"  build_bitbang\u003dyes"},{"line_number":755,"context_line":"])"},{"line_number":756,"context_line":""},{"line_number":757,"context_line":"AS_IF([test \"x$enable_stlink\" !\u003d \"xno\" -o \"x$enable_ti_icdi\" !\u003d \"xno\" -o \"x$enable_nulink\" !\u003d \"xno\"], ["},{"line_number":758,"context_line":"\tAC_DEFINE([BUILD_HLADAPTER], [1], [1 if you want the High Level JTAG driver.])"},{"line_number":759,"context_line":"\tAM_CONDITIONAL([HLADAPTER], [true])"}],"source_content_type":"application/octet-stream","patch_set":15,"id":"6c5f07e2_4c0c7a0f","line":756,"updated":"2025-06-21 08:38:05.000000000","message":"Here add:\n```\nAS_IF([test \"x$enable_xvc\" !\u003d \"xno\"], [\n  build_bitbang\u003dyes\n]}\n```","commit_id":"6aded56e662ad9ee4085ad5a6c9795bc11c6bb21"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"dd9f2bedf9077b57608cbdf3aeb37ba6b957aef6","unresolved":false,"context_lines":[{"line_number":753,"context_line":"AS_IF([test \"x$enable_remote_bitbang\" !\u003d \"xno\"], ["},{"line_number":754,"context_line":"  build_bitbang\u003dyes"},{"line_number":755,"context_line":"])"},{"line_number":756,"context_line":""},{"line_number":757,"context_line":"AS_IF([test \"x$enable_stlink\" !\u003d \"xno\" -o \"x$enable_ti_icdi\" !\u003d \"xno\" -o \"x$enable_nulink\" !\u003d \"xno\"], ["},{"line_number":758,"context_line":"\tAC_DEFINE([BUILD_HLADAPTER], [1], [1 if you want the High Level JTAG driver.])"},{"line_number":759,"context_line":"\tAM_CONDITIONAL([HLADAPTER], [true])"}],"source_content_type":"application/octet-stream","patch_set":15,"id":"9e23c778_1fb451a5","line":756,"in_reply_to":"6c5f07e2_4c0c7a0f","updated":"2025-06-24 13:06:48.000000000","message":"Done","commit_id":"6aded56e662ad9ee4085ad5a6c9795bc11c6bb21"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"494aad863615265c56a35c50e5f9783d8397af22","unresolved":true,"context_lines":[{"line_number":809,"context_line":"AM_CONDITIONAL([USE_LIBJAYLINK], [test \"x$use_libjaylink\" \u003d \"xyes\"])"},{"line_number":810,"context_line":"AM_CONDITIONAL([DMEM], [test \"x$build_dmem\" \u003d \"xyes\"])"},{"line_number":811,"context_line":"AM_CONDITIONAL([HAVE_CAPSTONE], [test \"x$enable_capstone\" !\u003d \"xno\"])"},{"line_number":812,"context_line":"AM_CONDITIONAL([XVC], [test \"x$build_xvc\" \u003d \"xyes\"])"},{"line_number":813,"context_line":""},{"line_number":814,"context_line":"AM_CONDITIONAL([INTERNAL_JIMTCL], [test \"x$use_internal_jimtcl\" \u003d \"xyes\"])"},{"line_number":815,"context_line":"AM_CONDITIONAL([HAVE_JIMTCL_PKG_CONFIG], [test \"x$have_jimtcl_pkg_config\" \u003d \"xyes\"])"}],"source_content_type":"application/octet-stream","patch_set":15,"id":"3030e439_47046381","line":812,"updated":"2025-06-21 08:38:05.000000000","message":"No need for this, already covered inside `PROCESS_ADAPTERS`","commit_id":"6aded56e662ad9ee4085ad5a6c9795bc11c6bb21"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"dd9f2bedf9077b57608cbdf3aeb37ba6b957aef6","unresolved":false,"context_lines":[{"line_number":809,"context_line":"AM_CONDITIONAL([USE_LIBJAYLINK], [test \"x$use_libjaylink\" \u003d \"xyes\"])"},{"line_number":810,"context_line":"AM_CONDITIONAL([DMEM], [test \"x$build_dmem\" \u003d \"xyes\"])"},{"line_number":811,"context_line":"AM_CONDITIONAL([HAVE_CAPSTONE], [test \"x$enable_capstone\" !\u003d \"xno\"])"},{"line_number":812,"context_line":"AM_CONDITIONAL([XVC], [test \"x$build_xvc\" \u003d \"xyes\"])"},{"line_number":813,"context_line":""},{"line_number":814,"context_line":"AM_CONDITIONAL([INTERNAL_JIMTCL], [test \"x$use_internal_jimtcl\" \u003d \"xyes\"])"},{"line_number":815,"context_line":"AM_CONDITIONAL([HAVE_JIMTCL_PKG_CONFIG], [test \"x$have_jimtcl_pkg_config\" \u003d \"xyes\"])"}],"source_content_type":"application/octet-stream","patch_set":15,"id":"ea8f8a31_e2ee246f","line":812,"in_reply_to":"3030e439_47046381","updated":"2025-06-24 13:06:48.000000000","message":"Done","commit_id":"6aded56e662ad9ee4085ad5a6c9795bc11c6bb21"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"cd675060b3644b7e8db6cee33b7f72e2ca2ef63d","unresolved":true,"context_lines":[{"line_number":422,"context_line":"  [Enable building internal libjaylink]),"},{"line_number":423,"context_line":"  [use_internal_libjaylink\u003d$enableval], [use_internal_libjaylink\u003dno])"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"AC_ARG_ENABLE([xvc],"},{"line_number":426,"context_line":"  AS_HELP_STRING([--enable-xvc], [Enable building support for the Xilinx XVC TCP jtag driver]),"},{"line_number":427,"context_line":"  [build_xvc\u003d$enableval], [build_xvc\u003dyes])"},{"line_number":428,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":21,"id":"49c283ae_3666fa03","line":425,"updated":"2025-06-26 14:02:15.000000000","message":"This part of the patch is not needed.\nAlready removed, it suddenly reappeared!","commit_id":"fc557e79b624b05a7c1923e4e12b9aac96327572"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"f93f27e2b49eddf4cbe4f06e3388d7b4e9159821","unresolved":false,"context_lines":[{"line_number":422,"context_line":"  [Enable building internal libjaylink]),"},{"line_number":423,"context_line":"  [use_internal_libjaylink\u003d$enableval], [use_internal_libjaylink\u003dno])"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"AC_ARG_ENABLE([xvc],"},{"line_number":426,"context_line":"  AS_HELP_STRING([--enable-xvc], [Enable building support for the Xilinx XVC TCP jtag driver]),"},{"line_number":427,"context_line":"  [build_xvc\u003d$enableval], [build_xvc\u003dyes])"},{"line_number":428,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":21,"id":"39185413_87500073","line":425,"in_reply_to":"49c283ae_3666fa03","updated":"2025-09-05 12:25:10.000000000","message":"Done","commit_id":"fc557e79b624b05a7c1923e4e12b9aac96327572"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b8645f98582d4edd2a239b676cc457f76014bf93","unresolved":false,"context_lines":[{"line_number":422,"context_line":"  [Enable building internal libjaylink]),"},{"line_number":423,"context_line":"  [use_internal_libjaylink\u003d$enableval], [use_internal_libjaylink\u003dno])"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"AC_ARG_ENABLE([xvc],"},{"line_number":426,"context_line":"  AS_HELP_STRING([--enable-xvc], [Enable building support for the Xilinx XVC TCP jtag driver]),"},{"line_number":427,"context_line":"  [build_xvc\u003d$enableval], [build_xvc\u003dyes])"},{"line_number":428,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":21,"id":"7801b3d5_623ddc8c","line":425,"in_reply_to":"49c283ae_3666fa03","updated":"2025-07-02 21:51:10.000000000","message":"Done","commit_id":"fc557e79b624b05a7c1923e4e12b9aac96327572"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"cd675060b3644b7e8db6cee33b7f72e2ca2ef63d","unresolved":true,"context_lines":[{"line_number":609,"context_line":"])"},{"line_number":610,"context_line":""},{"line_number":611,"context_line":""},{"line_number":612,"context_line":""},{"line_number":613,"context_line":"PKG_CHECK_MODULES([LIBUSB1], [libusb-1.0], ["},{"line_number":614,"context_line":"\tuse_libusb1\u003dyes"},{"line_number":615,"context_line":"\tAC_DEFINE([HAVE_LIBUSB1], [1], [Define if you have libusb-1.x])"}],"source_content_type":"application/octet-stream","patch_set":21,"id":"dd331fd9_a754492e","line":612,"updated":"2025-06-26 14:02:15.000000000","message":"drop these empty line added in the patch","commit_id":"fc557e79b624b05a7c1923e4e12b9aac96327572"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b8645f98582d4edd2a239b676cc457f76014bf93","unresolved":false,"context_lines":[{"line_number":609,"context_line":"])"},{"line_number":610,"context_line":""},{"line_number":611,"context_line":""},{"line_number":612,"context_line":""},{"line_number":613,"context_line":"PKG_CHECK_MODULES([LIBUSB1], [libusb-1.0], ["},{"line_number":614,"context_line":"\tuse_libusb1\u003dyes"},{"line_number":615,"context_line":"\tAC_DEFINE([HAVE_LIBUSB1], [1], [Define if you have libusb-1.x])"}],"source_content_type":"application/octet-stream","patch_set":21,"id":"10e962bd_01bcf660","line":612,"in_reply_to":"dd331fd9_a754492e","updated":"2025-07-02 21:51:10.000000000","message":"Done","commit_id":"fc557e79b624b05a7c1923e4e12b9aac96327572"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"f93f27e2b49eddf4cbe4f06e3388d7b4e9159821","unresolved":false,"context_lines":[{"line_number":609,"context_line":"])"},{"line_number":610,"context_line":""},{"line_number":611,"context_line":""},{"line_number":612,"context_line":""},{"line_number":613,"context_line":"PKG_CHECK_MODULES([LIBUSB1], [libusb-1.0], ["},{"line_number":614,"context_line":"\tuse_libusb1\u003dyes"},{"line_number":615,"context_line":"\tAC_DEFINE([HAVE_LIBUSB1], [1], [Define if you have libusb-1.x])"}],"source_content_type":"application/octet-stream","patch_set":21,"id":"9d771452_8f81823b","line":612,"in_reply_to":"dd331fd9_a754492e","updated":"2025-09-05 12:25:10.000000000","message":"Done","commit_id":"fc557e79b624b05a7c1923e4e12b9aac96327572"}],"doc/openocd.texi":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"fc0911bec97ec5b0fc7c4d0765990b1aa6537469","unresolved":true,"context_lines":[{"line_number":3487,"context_line":""},{"line_number":3488,"context_line":"@deffn {Config Command} {xvc_tck} @var{number}"},{"line_number":3489,"context_line":"Sets TCK clock period in ns."},{"line_number":3490,"context_line":"@end deffn"},{"line_number":3491,"context_line":""},{"line_number":3492,"context_line":"@deffn {Config Command} {xvc_stats} @var{path}"},{"line_number":3493,"context_line":"This is meant only for debugging purposes. If there is a path"}],"source_content_type":"text/x-texinfo","patch_set":2,"id":"a5d28be0_c176d334","line":3490,"updated":"2022-03-05 17:54:00.000000000","message":"I think this command should be removed. We have a \"standard\" command \"adapter speed\" that provides the TCK speed in kHz. You should use the value from that command to compute the period\u0027s value used by the protocol.","commit_id":"477be1c0753a0cfc1409ef835964bf0aad8130cb"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"2a20549d12156ecd7063d4064038a8de2ef1b7fa","unresolved":false,"context_lines":[{"line_number":3487,"context_line":""},{"line_number":3488,"context_line":"@deffn {Config Command} {xvc_tck} @var{number}"},{"line_number":3489,"context_line":"Sets TCK clock period in ns."},{"line_number":3490,"context_line":"@end deffn"},{"line_number":3491,"context_line":""},{"line_number":3492,"context_line":"@deffn {Config Command} {xvc_stats} @var{path}"},{"line_number":3493,"context_line":"This is meant only for debugging purposes. If there is a path"}],"source_content_type":"text/x-texinfo","patch_set":2,"id":"3e88fe2a_e147897b","line":3490,"in_reply_to":"a5d28be0_c176d334","updated":"2022-03-07 11:15:12.000000000","message":"Done","commit_id":"477be1c0753a0cfc1409ef835964bf0aad8130cb"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"735fabddcfa9d36538f18f9a90c3f1d521ad702d","unresolved":true,"context_lines":[{"line_number":3477,"context_line":""},{"line_number":3478,"context_line":"@deffn {Config Command} {xvc_host} @var{hostname}"},{"line_number":3479,"context_line":"Specifies the hostname of the remote debugger to connect to. Albeit"},{"line_number":3480,"context_line":"it is possible to use UNIX sockets, it is not recommended."},{"line_number":3481,"context_line":"@end deffn"},{"line_number":3482,"context_line":""},{"line_number":3483,"context_line":"@deffn {Config Command} {xvc_port} @var{number}"}],"source_content_type":"text/x-texinfo","patch_set":3,"id":"1fd1eb98_95f5a63a","line":3480,"updated":"2022-03-10 23:38:59.000000000","message":"Just for my curiosity, why UNIX sockets are not recommended?","commit_id":"abab47cd742d48a95e510774143284399ccfe20d"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"12e553efad2f26a632ec23a1f57cf00d6b7456e0","unresolved":false,"context_lines":[{"line_number":3477,"context_line":""},{"line_number":3478,"context_line":"@deffn {Config Command} {xvc_host} @var{hostname}"},{"line_number":3479,"context_line":"Specifies the hostname of the remote debugger to connect to. Albeit"},{"line_number":3480,"context_line":"it is possible to use UNIX sockets, it is not recommended."},{"line_number":3481,"context_line":"@end deffn"},{"line_number":3482,"context_line":""},{"line_number":3483,"context_line":"@deffn {Config Command} {xvc_port} @var{number}"}],"source_content_type":"text/x-texinfo","patch_set":3,"id":"eb100cf4_7bc3db3f","line":3480,"in_reply_to":"1fd1eb98_95f5a63a","updated":"2022-03-11 13:12:13.000000000","message":"As you know, UNIX sockets are mostly meant to be used locally, so that is the reason we did not recommended it. It could also be trimmed both from the code and the manual.","commit_id":"abab47cd742d48a95e510774143284399ccfe20d"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"81eea0324bdd4f2eb21835b40377596e08ba9a57","unresolved":true,"context_lines":[{"line_number":3467,"context_line":""},{"line_number":3468,"context_line":"@deffn {Interface Driver} {xvc}"},{"line_number":3469,"context_line":"This driver implements bitbang mode of JTAG devices"},{"line_number":3470,"context_line":"using Xilinx Virtual Cable messages over TCP/IP."},{"line_number":3471,"context_line":"Example configuration:"},{"line_number":3472,"context_line":""},{"line_number":3473,"context_line":"@example"}],"source_content_type":"text/x-texinfo","patch_set":4,"id":"9b33175a_cd014eb3","line":3470,"updated":"2022-05-01 22:22:00.000000000","message":"This implementation is XVC protocol 1.0 only. Does not support 1.1 extension. Please add this in the description.\nAdd also a link to protocol description https://github.com/Xilinx/XilinxVirtualCable","commit_id":"02deec68dd383f6c9632b1845134fc1faa94a4ad"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"5a72491c4d44dc1ba22c485a441d0344e60c3bab","unresolved":false,"context_lines":[{"line_number":3467,"context_line":""},{"line_number":3468,"context_line":"@deffn {Interface Driver} {xvc}"},{"line_number":3469,"context_line":"This driver implements bitbang mode of JTAG devices"},{"line_number":3470,"context_line":"using Xilinx Virtual Cable messages over TCP/IP."},{"line_number":3471,"context_line":"Example configuration:"},{"line_number":3472,"context_line":""},{"line_number":3473,"context_line":"@example"}],"source_content_type":"text/x-texinfo","patch_set":4,"id":"0067eee8_fd24d72d","line":3470,"in_reply_to":"9b33175a_cd014eb3","updated":"2022-05-03 11:26:18.000000000","message":"Done","commit_id":"02deec68dd383f6c9632b1845134fc1faa94a4ad"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"7a7f64bc0d1db3fbd6e60bb4883b0290d43b1fd5","unresolved":true,"context_lines":[{"line_number":3468,"context_line":"@deffn {Interface Driver} {xvc}"},{"line_number":3469,"context_line":"This driver implements bitbang mode of JTAG devices"},{"line_number":3470,"context_line":"using Xilinx Virtual Cable messages over TCP/IP."},{"line_number":3471,"context_line":"This implementation is XVC protocol 1.0 only, does not support 1.1 extension."},{"line_number":3472,"context_line":"Example configuration:"},{"line_number":3473,"context_line":""},{"line_number":3474,"context_line":"@example"}],"source_content_type":"text/x-texinfo","patch_set":5,"id":"c3cc8428_ef2506ad","line":3471,"updated":"2023-08-24 15:22:16.000000000","message":"Humm, looking at\nhttps://github.com/Xilinx/XilinxVirtualCable/\nit reports that 1.1 is backward compatible with 1.0, adding 2 extra messages \"mrd\" and \"mwr\".\nSo, this implementation can work on XVC 1.1 but does not uses the extension.\nCan the code and the doc be modified to support a server XVC 1.1?","commit_id":"5c43675291340f79ac45dfb1622d1719342f845e"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"8eecdbf10770bb1e7cdb3d0f2f01712a034fb51f","unresolved":false,"context_lines":[{"line_number":3468,"context_line":"@deffn {Interface Driver} {xvc}"},{"line_number":3469,"context_line":"This driver implements bitbang mode of JTAG devices"},{"line_number":3470,"context_line":"using Xilinx Virtual Cable messages over TCP/IP."},{"line_number":3471,"context_line":"This implementation is XVC protocol 1.0 only, does not support 1.1 extension."},{"line_number":3472,"context_line":"Example configuration:"},{"line_number":3473,"context_line":""},{"line_number":3474,"context_line":"@example"}],"source_content_type":"text/x-texinfo","patch_set":5,"id":"69a5c303_da49cb91","line":3471,"in_reply_to":"1889e607_159b3c50","updated":"2023-12-22 13:18:42.000000000","message":"Done","commit_id":"5c43675291340f79ac45dfb1622d1719342f845e"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"9044a6ef1e155ebc2e4150761f3faa004604f70d","unresolved":false,"context_lines":[{"line_number":3468,"context_line":"@deffn {Interface Driver} {xvc}"},{"line_number":3469,"context_line":"This driver implements bitbang mode of JTAG devices"},{"line_number":3470,"context_line":"using Xilinx Virtual Cable messages over TCP/IP."},{"line_number":3471,"context_line":"This implementation is XVC protocol 1.0 only, does not support 1.1 extension."},{"line_number":3472,"context_line":"Example configuration:"},{"line_number":3473,"context_line":""},{"line_number":3474,"context_line":"@example"}],"source_content_type":"text/x-texinfo","patch_set":5,"id":"751aab66_220a68e6","line":3471,"in_reply_to":"318677c5_4534a011","updated":"2024-01-25 10:45:02.000000000","message":"Done","commit_id":"5c43675291340f79ac45dfb1622d1719342f845e"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"ca0ad591b519469b89003821b14ff82b68be5b3a","unresolved":true,"context_lines":[{"line_number":3468,"context_line":"@deffn {Interface Driver} {xvc}"},{"line_number":3469,"context_line":"This driver implements bitbang mode of JTAG devices"},{"line_number":3470,"context_line":"using Xilinx Virtual Cable messages over TCP/IP."},{"line_number":3471,"context_line":"This implementation is XVC protocol 1.0 only, does not support 1.1 extension."},{"line_number":3472,"context_line":"Example configuration:"},{"line_number":3473,"context_line":""},{"line_number":3474,"context_line":"@example"}],"source_content_type":"text/x-texinfo","patch_set":5,"id":"318677c5_4534a011","line":3471,"in_reply_to":"69a5c303_da49cb91","updated":"2023-12-28 15:56:02.000000000","message":"You forget to reply on part of my comment that say 1.1 is supported because is 1.0 compatible, but the extensions are not supported.","commit_id":"5c43675291340f79ac45dfb1622d1719342f845e"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"2624d0adca1b97f94ac8d9439350985dc7ae4f5d","unresolved":true,"context_lines":[{"line_number":3468,"context_line":"@deffn {Interface Driver} {xvc}"},{"line_number":3469,"context_line":"This driver implements bitbang mode of JTAG devices"},{"line_number":3470,"context_line":"using Xilinx Virtual Cable messages over TCP/IP."},{"line_number":3471,"context_line":"This implementation is XVC protocol 1.0 only, does not support 1.1 extension."},{"line_number":3472,"context_line":"Example configuration:"},{"line_number":3473,"context_line":""},{"line_number":3474,"context_line":"@example"}],"source_content_type":"text/x-texinfo","patch_set":5,"id":"1889e607_159b3c50","line":3471,"in_reply_to":"c3cc8428_ef2506ad","updated":"2023-08-24 15:36:10.000000000","message":"It would also be nice to add the link to github in this section","commit_id":"5c43675291340f79ac45dfb1622d1719342f845e"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"cd8c01ab8d7d087df5afcc98e179e2bbedf09f9e","unresolved":true,"context_lines":[{"line_number":3701,"context_line":"@end deffn"},{"line_number":3702,"context_line":""},{"line_number":3703,"context_line":"@deffn {Config Command} {xvc_port} @var{number}"},{"line_number":3704,"context_line":"Specifies the port of the remote process to connect to."},{"line_number":3705,"context_line":"@end deffn"},{"line_number":3706,"context_line":""},{"line_number":3707,"context_line":"@end deffn"}],"source_content_type":"text/x-texinfo","patch_set":13,"id":"492b447e_8492d3f0","line":3704,"updated":"2024-07-16 22:00:35.000000000","message":"Mention the UNIX socket special case for port number 0 here.","commit_id":"b094e21223faf5f2dcb741dc0ae6bb73c5e8f32d"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"7947c200a75c7f5ae73a1088ffb809206a85c1e3","unresolved":false,"context_lines":[{"line_number":3701,"context_line":"@end deffn"},{"line_number":3702,"context_line":""},{"line_number":3703,"context_line":"@deffn {Config Command} {xvc_port} @var{number}"},{"line_number":3704,"context_line":"Specifies the port of the remote process to connect to."},{"line_number":3705,"context_line":"@end deffn"},{"line_number":3706,"context_line":""},{"line_number":3707,"context_line":"@end deffn"}],"source_content_type":"text/x-texinfo","patch_set":13,"id":"2f5af4b4_7af5e88c","line":3704,"in_reply_to":"492b447e_8492d3f0","updated":"2024-07-24 11:49:05.000000000","message":"Done","commit_id":"b094e21223faf5f2dcb741dc0ae6bb73c5e8f32d"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"cd675060b3644b7e8db6cee33b7f72e2ca2ef63d","unresolved":true,"context_lines":[{"line_number":3771,"context_line":"using Xilinx Virtual Cable messages over TCP/IP."},{"line_number":3772,"context_line":"This implementation is XVC protocol 1.0/1.1 compatible. However, \u0027mrd\u0027 and \u0027mwr\u0027"},{"line_number":3773,"context_line":"extensions introduced in version 1.1 are not supported. Refer to:"},{"line_number":3774,"context_line":"@url{https://github.com/Xilinx/XilinxVirtualCable} for protocol specification."},{"line_number":3775,"context_line":""},{"line_number":3776,"context_line":"Example configuration:"},{"line_number":3777,"context_line":""}],"source_content_type":"text/x-texinfo","patch_set":21,"id":"4abb99cb_e44157b8","line":3774,"updated":"2025-06-26 14:02:15.000000000","message":"Please add the link also in a comment in the driver\u0027s code.\nPeople reading the driver will find it easily.","commit_id":"fc557e79b624b05a7c1923e4e12b9aac96327572"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"f93f27e2b49eddf4cbe4f06e3388d7b4e9159821","unresolved":false,"context_lines":[{"line_number":3771,"context_line":"using Xilinx Virtual Cable messages over TCP/IP."},{"line_number":3772,"context_line":"This implementation is XVC protocol 1.0/1.1 compatible. However, \u0027mrd\u0027 and \u0027mwr\u0027"},{"line_number":3773,"context_line":"extensions introduced in version 1.1 are not supported. Refer to:"},{"line_number":3774,"context_line":"@url{https://github.com/Xilinx/XilinxVirtualCable} for protocol specification."},{"line_number":3775,"context_line":""},{"line_number":3776,"context_line":"Example configuration:"},{"line_number":3777,"context_line":""}],"source_content_type":"text/x-texinfo","patch_set":21,"id":"a9b933d0_9944e237","line":3774,"in_reply_to":"4abb99cb_e44157b8","updated":"2025-09-05 12:25:10.000000000","message":"Done","commit_id":"fc557e79b624b05a7c1923e4e12b9aac96327572"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b8645f98582d4edd2a239b676cc457f76014bf93","unresolved":false,"context_lines":[{"line_number":3771,"context_line":"using Xilinx Virtual Cable messages over TCP/IP."},{"line_number":3772,"context_line":"This implementation is XVC protocol 1.0/1.1 compatible. However, \u0027mrd\u0027 and \u0027mwr\u0027"},{"line_number":3773,"context_line":"extensions introduced in version 1.1 are not supported. Refer to:"},{"line_number":3774,"context_line":"@url{https://github.com/Xilinx/XilinxVirtualCable} for protocol specification."},{"line_number":3775,"context_line":""},{"line_number":3776,"context_line":"Example configuration:"},{"line_number":3777,"context_line":""}],"source_content_type":"text/x-texinfo","patch_set":21,"id":"f00b9c6b_25b8f82a","line":3774,"in_reply_to":"4abb99cb_e44157b8","updated":"2025-07-02 21:51:10.000000000","message":"Done","commit_id":"fc557e79b624b05a7c1923e4e12b9aac96327572"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"cd675060b3644b7e8db6cee33b7f72e2ca2ef63d","unresolved":true,"context_lines":[{"line_number":3782,"context_line":"@end deffn"},{"line_number":3783,"context_line":""},{"line_number":3784,"context_line":"@deffn {Config Command} {xvc host} @var{hostname}"},{"line_number":3785,"context_line":"Specifies the hostname of the remote debugger to connect to."},{"line_number":3786,"context_line":"@end deffn"},{"line_number":3787,"context_line":""},{"line_number":3788,"context_line":"@deffn {Config Command} {xvc port} @var{number}"}],"source_content_type":"text/x-texinfo","patch_set":21,"id":"a1474643_b95a93b8","line":3785,"updated":"2025-06-26 14:02:15.000000000","message":"This can contain the unix socket too.\nPlease add the description","commit_id":"fc557e79b624b05a7c1923e4e12b9aac96327572"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"f93f27e2b49eddf4cbe4f06e3388d7b4e9159821","unresolved":false,"context_lines":[{"line_number":3782,"context_line":"@end deffn"},{"line_number":3783,"context_line":""},{"line_number":3784,"context_line":"@deffn {Config Command} {xvc host} @var{hostname}"},{"line_number":3785,"context_line":"Specifies the hostname of the remote debugger to connect to."},{"line_number":3786,"context_line":"@end deffn"},{"line_number":3787,"context_line":""},{"line_number":3788,"context_line":"@deffn {Config Command} {xvc port} @var{number}"}],"source_content_type":"text/x-texinfo","patch_set":21,"id":"5cec2396_4cbff820","line":3785,"in_reply_to":"a1474643_b95a93b8","updated":"2025-09-05 12:25:10.000000000","message":"Done","commit_id":"fc557e79b624b05a7c1923e4e12b9aac96327572"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b8645f98582d4edd2a239b676cc457f76014bf93","unresolved":false,"context_lines":[{"line_number":3782,"context_line":"@end deffn"},{"line_number":3783,"context_line":""},{"line_number":3784,"context_line":"@deffn {Config Command} {xvc host} @var{hostname}"},{"line_number":3785,"context_line":"Specifies the hostname of the remote debugger to connect to."},{"line_number":3786,"context_line":"@end deffn"},{"line_number":3787,"context_line":""},{"line_number":3788,"context_line":"@deffn {Config Command} {xvc port} @var{number}"}],"source_content_type":"text/x-texinfo","patch_set":21,"id":"a07a4498_bfff11c1","line":3785,"in_reply_to":"a1474643_b95a93b8","updated":"2025-07-02 21:51:10.000000000","message":"Done","commit_id":"fc557e79b624b05a7c1923e4e12b9aac96327572"}],"src/jtag/drivers/xvc.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"ee1d6ecf43bdc7e022aa64016b53207176b4f8d3","unresolved":true,"context_lines":[{"line_number":161,"context_line":""},{"line_number":162,"context_line":"enum block_bool { NO_BLOCK, BLOCK };"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"enum { NO_FLUSH, FLUSH_SEND_BUF } flush_bool_t;"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"static int xvc_queue(const uint8_t *tms, unsigned int tms_offset, const uint8_t *tdi,"},{"line_number":167,"context_line":"\t\tunsigned int tdi_offset, uint8_t *tdo, unsigned int tdo_offset, unsigned int length)"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"02d10220_c0e75da5","line":164,"updated":"2022-03-04 13:06:00.000000000","message":"syntax should be\nenum flush_bool { NO_FLUSH, FLUSH_SEND_BUF };\nAnd, no need for suffix \"_t\" that was there before for the typeof","commit_id":"9726d93a022494cf2c1b9ca041354424764755a8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"32f1eb4f316806d26ae3f9faf7f5a55b6b458b8f","unresolved":true,"context_lines":[{"line_number":161,"context_line":""},{"line_number":162,"context_line":"enum block_bool { NO_BLOCK, BLOCK };"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"enum { NO_FLUSH, FLUSH_SEND_BUF } flush_bool_t;"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"static int xvc_queue(const uint8_t *tms, unsigned int tms_offset, const uint8_t *tdi,"},{"line_number":167,"context_line":"\t\tunsigned int tdi_offset, uint8_t *tdo, unsigned int tdo_offset, unsigned int length)"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"072bb5b3_0134799f","line":164,"in_reply_to":"02d10220_c0e75da5","updated":"2022-03-04 13:08:23.000000000","message":"Checking further, both these enum are unused and should be removed.","commit_id":"9726d93a022494cf2c1b9ca041354424764755a8"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"5ab1911f0ba4a71e21ec748937dd71e0b3c7e9fc","unresolved":false,"context_lines":[{"line_number":161,"context_line":""},{"line_number":162,"context_line":"enum block_bool { NO_BLOCK, BLOCK };"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"enum { NO_FLUSH, FLUSH_SEND_BUF } flush_bool_t;"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"static int xvc_queue(const uint8_t *tms, unsigned int tms_offset, const uint8_t *tdi,"},{"line_number":167,"context_line":"\t\tunsigned int tdi_offset, uint8_t *tdo, unsigned int tdo_offset, unsigned int length)"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"0d31d82d_af124056","line":164,"in_reply_to":"072bb5b3_0134799f","updated":"2022-03-05 09:36:11.000000000","message":"Done","commit_id":"9726d93a022494cf2c1b9ca041354424764755a8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"ee1d6ecf43bdc7e022aa64016b53207176b4f8d3","unresolved":true,"context_lines":[{"line_number":403,"context_line":"{"},{"line_number":404,"context_line":"\tif (CMD_ARGC !\u003d 1)"},{"line_number":405,"context_line":"\t\txvc_stats_enabled \u003d false;"},{"line_number":406,"context_line":"\tint len \u003d strlen(CMD_ARGV[0]);"},{"line_number":407,"context_line":"\tif (len \u003e 0) {"},{"line_number":408,"context_line":"\t\txvc_stats_enabled \u003d true;"},{"line_number":409,"context_line":"\t\tfile_path \u003d malloc(len);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"e43b4d0c_39ef9ba6","line":406,"updated":"2022-03-04 13:06:00.000000000","message":"if CMD_ARGC\u003d\u003d0, then here there should be a segmentation fault.\nI think the implementation in https://review.openocd.org/6866/ was correct","commit_id":"9726d93a022494cf2c1b9ca041354424764755a8"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"5ab1911f0ba4a71e21ec748937dd71e0b3c7e9fc","unresolved":false,"context_lines":[{"line_number":403,"context_line":"{"},{"line_number":404,"context_line":"\tif (CMD_ARGC !\u003d 1)"},{"line_number":405,"context_line":"\t\txvc_stats_enabled \u003d false;"},{"line_number":406,"context_line":"\tint len \u003d strlen(CMD_ARGV[0]);"},{"line_number":407,"context_line":"\tif (len \u003e 0) {"},{"line_number":408,"context_line":"\t\txvc_stats_enabled \u003d true;"},{"line_number":409,"context_line":"\t\tfile_path \u003d malloc(len);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"3951e7cc_e2596d04","line":406,"in_reply_to":"e43b4d0c_39ef9ba6","updated":"2022-03-05 09:36:11.000000000","message":"Done","commit_id":"9726d93a022494cf2c1b9ca041354424764755a8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"fc0911bec97ec5b0fc7c4d0765990b1aa6537469","unresolved":true,"context_lines":[{"line_number":217,"context_line":"\t\t}"},{"line_number":218,"context_line":"\t\txvc_max_vector_size \u003d xvc_max_usable_vector_size + 10;"},{"line_number":219,"context_line":"\t\tLOG_DEBUG(\"Maximum vector size set to: %u\\n\", xvc_max_vector_size);"},{"line_number":220,"context_line":"\t\t/**Usable size: maximum vector size determined by the server minus the"},{"line_number":221,"context_line":"sizeof the command, 10 bytes in worst-case (6 bytes from shift: and 4"},{"line_number":222,"context_line":"additional ones for bit_length).*/"},{"line_number":223,"context_line":"\t\t/* Updates TX Buffer sizes: */"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"41084a1c_73aac2f4","line":220,"updated":"2022-03-05 17:54:00.000000000","message":"fix the indentation of this comment.\nAlso, comments that starts with \"/**\" are used by Doxygen, but this doesn\u0027t seem specific for it. Eventually, try the result of \"make doxygen\" to see the result.\nI see several comments starting with \u0027/**\u0027 below","commit_id":"477be1c0753a0cfc1409ef835964bf0aad8130cb"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"2a20549d12156ecd7063d4064038a8de2ef1b7fa","unresolved":false,"context_lines":[{"line_number":217,"context_line":"\t\t}"},{"line_number":218,"context_line":"\t\txvc_max_vector_size \u003d xvc_max_usable_vector_size + 10;"},{"line_number":219,"context_line":"\t\tLOG_DEBUG(\"Maximum vector size set to: %u\\n\", xvc_max_vector_size);"},{"line_number":220,"context_line":"\t\t/**Usable size: maximum vector size determined by the server minus the"},{"line_number":221,"context_line":"sizeof the command, 10 bytes in worst-case (6 bytes from shift: and 4"},{"line_number":222,"context_line":"additional ones for bit_length).*/"},{"line_number":223,"context_line":"\t\t/* Updates TX Buffer sizes: */"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"6622b078_211160d5","line":220,"in_reply_to":"41084a1c_73aac2f4","updated":"2022-03-07 11:15:12.000000000","message":"Done","commit_id":"477be1c0753a0cfc1409ef835964bf0aad8130cb"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"fc0911bec97ec5b0fc7c4d0765990b1aa6537469","unresolved":true,"context_lines":[{"line_number":221,"context_line":"sizeof the command, 10 bytes in worst-case (6 bytes from shift: and 4"},{"line_number":222,"context_line":"additional ones for bit_length).*/"},{"line_number":223,"context_line":"\t\t/* Updates TX Buffer sizes: */"},{"line_number":224,"context_line":"\t\txvc_send_buf \u003d (uint8_t *)malloc(xvc_max_vector_size * sizeof(uint8_t));"},{"line_number":225,"context_line":"\t\txvc_tms_buf \u003d"},{"line_number":226,"context_line":"\t\t\t\t(uint8_t *)malloc(xvc_max_usable_vector_size / 2 * sizeof(uint8_t));"},{"line_number":227,"context_line":"\t\txvc_tdi_buf \u003d"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"96dcfab7_28b2a998","line":224,"updated":"2022-03-05 17:54:00.000000000","message":"There is no need for a cast. malloc returns a (void *) that can be assigned with no problem.\nEvery malloc should be checked for return non-NULL and exit with error.\nyou can simply add at the end of this set of malloc:\nif (!xvc_send_buf || !xvc_tms_buf || !xvc_tdi_buf || !xvc_tdo_buf) {\n    LOG_ERROR(\"Out of memory\");\n    free(xvc_send_buf);\n    free(xvc_tms_buf);\n    free(xvc_tdi_buf);\n    free(xvc_tdo_buf);\n    return ERROR_FAIL;\n}","commit_id":"477be1c0753a0cfc1409ef835964bf0aad8130cb"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"2a20549d12156ecd7063d4064038a8de2ef1b7fa","unresolved":false,"context_lines":[{"line_number":221,"context_line":"sizeof the command, 10 bytes in worst-case (6 bytes from shift: and 4"},{"line_number":222,"context_line":"additional ones for bit_length).*/"},{"line_number":223,"context_line":"\t\t/* Updates TX Buffer sizes: */"},{"line_number":224,"context_line":"\t\txvc_send_buf \u003d (uint8_t *)malloc(xvc_max_vector_size * sizeof(uint8_t));"},{"line_number":225,"context_line":"\t\txvc_tms_buf \u003d"},{"line_number":226,"context_line":"\t\t\t\t(uint8_t *)malloc(xvc_max_usable_vector_size / 2 * sizeof(uint8_t));"},{"line_number":227,"context_line":"\t\txvc_tdi_buf \u003d"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"e2fa8cee_e94bb8d9","line":224,"in_reply_to":"96dcfab7_28b2a998","updated":"2022-03-07 11:15:12.000000000","message":"Done","commit_id":"477be1c0753a0cfc1409ef835964bf0aad8130cb"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"fc0911bec97ec5b0fc7c4d0765990b1aa6537469","unresolved":true,"context_lines":[{"line_number":240,"context_line":"\t/**Creates the command:"},{"line_number":241,"context_line":"\t * copies the header and appends the value."},{"line_number":242,"context_line":"\t * */"},{"line_number":243,"context_line":"\tchar *settck \u003d malloc(12 * sizeof(char));"},{"line_number":244,"context_line":"\tconst char *header \u003d \"settck:\";"},{"line_number":245,"context_line":"\tmemcpy(settck, header, 7);"},{"line_number":246,"context_line":"\tmemcpy(settck + 7, \u0026xvc_tck, 4);"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"1b3a197f_52b965ac","line":243,"updated":"2022-03-05 17:54:00.000000000","message":"if you use malloc() you need to check if it returns NULL.\nHere the size is small and constant. Why not using:\nchar settck[12];","commit_id":"477be1c0753a0cfc1409ef835964bf0aad8130cb"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"2a20549d12156ecd7063d4064038a8de2ef1b7fa","unresolved":false,"context_lines":[{"line_number":240,"context_line":"\t/**Creates the command:"},{"line_number":241,"context_line":"\t * copies the header and appends the value."},{"line_number":242,"context_line":"\t * */"},{"line_number":243,"context_line":"\tchar *settck \u003d malloc(12 * sizeof(char));"},{"line_number":244,"context_line":"\tconst char *header \u003d \"settck:\";"},{"line_number":245,"context_line":"\tmemcpy(settck, header, 7);"},{"line_number":246,"context_line":"\tmemcpy(settck + 7, \u0026xvc_tck, 4);"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"232fade0_b5ba0228","line":243,"in_reply_to":"1b3a197f_52b965ac","updated":"2022-03-07 11:15:12.000000000","message":"Done","commit_id":"477be1c0753a0cfc1409ef835964bf0aad8130cb"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"fc0911bec97ec5b0fc7c4d0765990b1aa6537469","unresolved":true,"context_lines":[{"line_number":243,"context_line":"\tchar *settck \u003d malloc(12 * sizeof(char));"},{"line_number":244,"context_line":"\tconst char *header \u003d \"settck:\";"},{"line_number":245,"context_line":"\tmemcpy(settck, header, 7);"},{"line_number":246,"context_line":"\tmemcpy(settck + 7, \u0026xvc_tck, 4);"},{"line_number":247,"context_line":"\t/* Writes the request */"},{"line_number":248,"context_line":"\tssize_t written \u003d write_socket(xvc_fd, settck, 11);"},{"line_number":249,"context_line":"\tif (written !\u003d 11)"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"75aafef7_f57173e2","line":246,"updated":"2022-03-05 17:54:00.000000000","message":"Oooops! this line depends on the endianess of the PC! Are you using an intel/AMD little endian x86?\nUse h_u32_to_le() to convert a host\u0027s endian uint32_t to a little endian buffer.","commit_id":"477be1c0753a0cfc1409ef835964bf0aad8130cb"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"2a20549d12156ecd7063d4064038a8de2ef1b7fa","unresolved":false,"context_lines":[{"line_number":243,"context_line":"\tchar *settck \u003d malloc(12 * sizeof(char));"},{"line_number":244,"context_line":"\tconst char *header \u003d \"settck:\";"},{"line_number":245,"context_line":"\tmemcpy(settck, header, 7);"},{"line_number":246,"context_line":"\tmemcpy(settck + 7, \u0026xvc_tck, 4);"},{"line_number":247,"context_line":"\t/* Writes the request */"},{"line_number":248,"context_line":"\tssize_t written \u003d write_socket(xvc_fd, settck, 11);"},{"line_number":249,"context_line":"\tif (written !\u003d 11)"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"309a8be8_294d6059","line":246,"in_reply_to":"75aafef7_f57173e2","updated":"2022-03-07 11:15:12.000000000","message":"Done","commit_id":"477be1c0753a0cfc1409ef835964bf0aad8130cb"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"fc0911bec97ec5b0fc7c4d0765990b1aa6537469","unresolved":true,"context_lines":[{"line_number":260,"context_line":"\tLOG_DEBUG(\"settck: replied %.4s\\n\", tck_recv_buf);"},{"line_number":261,"context_line":"\t/* Copies the entire buffer, regardless of machine\u0027s endianess. */"},{"line_number":262,"context_line":"\tuint32_t xvc_tck_period_ns;"},{"line_number":263,"context_line":"\tmemcpy(\u0026xvc_tck_period_ns, tck_recv_buf, 4);"},{"line_number":264,"context_line":"\tLOG_INFO(\"XVC tck period ns: %u\", xvc_tck_period_ns);"},{"line_number":265,"context_line":"\treturn ERROR_OK;"},{"line_number":266,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"4278cb0d_b678403c","line":263,"updated":"2022-03-05 17:54:00.000000000","message":"also here host endianess dependency. Use le_to_h_u32()?","commit_id":"477be1c0753a0cfc1409ef835964bf0aad8130cb"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"2a20549d12156ecd7063d4064038a8de2ef1b7fa","unresolved":false,"context_lines":[{"line_number":260,"context_line":"\tLOG_DEBUG(\"settck: replied %.4s\\n\", tck_recv_buf);"},{"line_number":261,"context_line":"\t/* Copies the entire buffer, regardless of machine\u0027s endianess. */"},{"line_number":262,"context_line":"\tuint32_t xvc_tck_period_ns;"},{"line_number":263,"context_line":"\tmemcpy(\u0026xvc_tck_period_ns, tck_recv_buf, 4);"},{"line_number":264,"context_line":"\tLOG_INFO(\"XVC tck period ns: %u\", xvc_tck_period_ns);"},{"line_number":265,"context_line":"\treturn ERROR_OK;"},{"line_number":266,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"98a7c93d_8c1de1e5","line":263,"in_reply_to":"4278cb0d_b678403c","updated":"2022-03-07 11:15:12.000000000","message":"Done","commit_id":"477be1c0753a0cfc1409ef835964bf0aad8130cb"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"fc0911bec97ec5b0fc7c4d0765990b1aa6537469","unresolved":true,"context_lines":[{"line_number":422,"context_line":" * help: displays some useful help"},{"line_number":423,"context_line":" * usage: prints the correct usage."},{"line_number":424,"context_line":" * */"},{"line_number":425,"context_line":"const struct command_registration xvc_command_handlers[] \u003d {"},{"line_number":426,"context_line":"\t\t{"},{"line_number":427,"context_line":"\t\t\t\t.name \u003d \"xvc_port\","},{"line_number":428,"context_line":"\t\t\t\t.handler \u003d xvc_handle_port_command,"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"8b4cf013_c3fd3890","line":425,"updated":"2022-03-05 17:54:00.000000000","message":"static const struct ...","commit_id":"477be1c0753a0cfc1409ef835964bf0aad8130cb"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"2a20549d12156ecd7063d4064038a8de2ef1b7fa","unresolved":false,"context_lines":[{"line_number":422,"context_line":" * help: displays some useful help"},{"line_number":423,"context_line":" * usage: prints the correct usage."},{"line_number":424,"context_line":" * */"},{"line_number":425,"context_line":"const struct command_registration xvc_command_handlers[] \u003d {"},{"line_number":426,"context_line":"\t\t{"},{"line_number":427,"context_line":"\t\t\t\t.name \u003d \"xvc_port\","},{"line_number":428,"context_line":"\t\t\t\t.handler \u003d xvc_handle_port_command,"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"91c77c29_04d68e8e","line":425,"in_reply_to":"8b4cf013_c3fd3890","updated":"2022-03-07 11:15:12.000000000","message":"Done","commit_id":"477be1c0753a0cfc1409ef835964bf0aad8130cb"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"fc0911bec97ec5b0fc7c4d0765990b1aa6537469","unresolved":true,"context_lines":[{"line_number":423,"context_line":" * usage: prints the correct usage."},{"line_number":424,"context_line":" * */"},{"line_number":425,"context_line":"const struct command_registration xvc_command_handlers[] \u003d {"},{"line_number":426,"context_line":"\t\t{"},{"line_number":427,"context_line":"\t\t\t\t.name \u003d \"xvc_port\","},{"line_number":428,"context_line":"\t\t\t\t.handler \u003d xvc_handle_port_command,"},{"line_number":429,"context_line":"\t\t\t\t.mode \u003d COMMAND_CONFIG,"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"855b3f8f_116a9e4b","line":426,"updated":"2022-03-05 17:54:00.000000000","message":"strange indentation. use one tab only and two tabs in next line","commit_id":"477be1c0753a0cfc1409ef835964bf0aad8130cb"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"2a20549d12156ecd7063d4064038a8de2ef1b7fa","unresolved":false,"context_lines":[{"line_number":423,"context_line":" * usage: prints the correct usage."},{"line_number":424,"context_line":" * */"},{"line_number":425,"context_line":"const struct command_registration xvc_command_handlers[] \u003d {"},{"line_number":426,"context_line":"\t\t{"},{"line_number":427,"context_line":"\t\t\t\t.name \u003d \"xvc_port\","},{"line_number":428,"context_line":"\t\t\t\t.handler \u003d xvc_handle_port_command,"},{"line_number":429,"context_line":"\t\t\t\t.mode \u003d COMMAND_CONFIG,"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"c43a0dfd_bf5ba8d5","line":426,"in_reply_to":"855b3f8f_116a9e4b","updated":"2022-03-07 11:15:12.000000000","message":"Done","commit_id":"477be1c0753a0cfc1409ef835964bf0aad8130cb"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"fc0911bec97ec5b0fc7c4d0765990b1aa6537469","unresolved":true,"context_lines":[{"line_number":430,"context_line":"\t\t\t\t.help \u003d"},{"line_number":431,"context_line":"\t\t\t\t\t\t\"Set the port to use to connect to the XVC remote server.\\n\""},{"line_number":432,"context_line":"\t\t\t\t\t\t\" If 0 or unset, use unix sockets to connect to the remote server.\","},{"line_number":433,"context_line":"\t\t\t\t\t\t.usage \u003d \"port_number\","},{"line_number":434,"context_line":"\t\t},"},{"line_number":435,"context_line":"\t\t{"},{"line_number":436,"context_line":"\t\t\t\t.name \u003d \"xvc_host\","}],"source_content_type":"text/x-csrc","patch_set":2,"id":"5b667e39_cd4b5d64","line":433,"updated":"2022-03-05 17:54:00.000000000","message":"this line aligned with .help","commit_id":"477be1c0753a0cfc1409ef835964bf0aad8130cb"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"2a20549d12156ecd7063d4064038a8de2ef1b7fa","unresolved":false,"context_lines":[{"line_number":430,"context_line":"\t\t\t\t.help \u003d"},{"line_number":431,"context_line":"\t\t\t\t\t\t\"Set the port to use to connect to the XVC remote server.\\n\""},{"line_number":432,"context_line":"\t\t\t\t\t\t\" If 0 or unset, use unix sockets to connect to the remote server.\","},{"line_number":433,"context_line":"\t\t\t\t\t\t.usage \u003d \"port_number\","},{"line_number":434,"context_line":"\t\t},"},{"line_number":435,"context_line":"\t\t{"},{"line_number":436,"context_line":"\t\t\t\t.name \u003d \"xvc_host\","}],"source_content_type":"text/x-csrc","patch_set":2,"id":"1389c91b_f406bc91","line":433,"in_reply_to":"5b667e39_cd4b5d64","updated":"2022-03-07 11:15:12.000000000","message":"Done","commit_id":"477be1c0753a0cfc1409ef835964bf0aad8130cb"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"fc0911bec97ec5b0fc7c4d0765990b1aa6537469","unresolved":true,"context_lines":[{"line_number":456,"context_line":"\t\t\t\t\t\t\"To enable the stats, type a valid file path and name\","},{"line_number":457,"context_line":"\t\t\t\t\t\t.usage \u003d \" path if desired\","},{"line_number":458,"context_line":"\t\t},"},{"line_number":459,"context_line":"\t\tCOMMAND_REGISTRATION_DONE};"},{"line_number":460,"context_line":""},{"line_number":461,"context_line":"static int xvc_init(void)"},{"line_number":462,"context_line":"{"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"bb691961_365240e9","line":459,"updated":"2022-03-05 17:54:00.000000000","message":"put \"};\" at new line","commit_id":"477be1c0753a0cfc1409ef835964bf0aad8130cb"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"2a20549d12156ecd7063d4064038a8de2ef1b7fa","unresolved":false,"context_lines":[{"line_number":456,"context_line":"\t\t\t\t\t\t\"To enable the stats, type a valid file path and name\","},{"line_number":457,"context_line":"\t\t\t\t\t\t.usage \u003d \" path if desired\","},{"line_number":458,"context_line":"\t\t},"},{"line_number":459,"context_line":"\t\tCOMMAND_REGISTRATION_DONE};"},{"line_number":460,"context_line":""},{"line_number":461,"context_line":"static int xvc_init(void)"},{"line_number":462,"context_line":"{"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"88b5d03d_9fd3b008","line":459,"in_reply_to":"bb691961_365240e9","updated":"2022-03-07 11:15:12.000000000","message":"Done","commit_id":"477be1c0753a0cfc1409ef835964bf0aad8130cb"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"fc0911bec97ec5b0fc7c4d0765990b1aa6537469","unresolved":true,"context_lines":[{"line_number":723,"context_line":""},{"line_number":724,"context_line":"\twhile (cmd) {"},{"line_number":725,"context_line":"\t\tswitch (cmd-\u003etype) {"},{"line_number":726,"context_line":"\t\tcase JTAG_RESET:"},{"line_number":727,"context_line":"\t\t\tLOG_DEBUG_IO(\"reset trst: %i srst %i\", cmd-\u003ecmd.reset-\u003etrst,"},{"line_number":728,"context_line":"\t\t\t\t\tcmd-\u003ecmd.reset-\u003esrst);"},{"line_number":729,"context_line":"\t\t\tif ((cmd-\u003ecmd.reset-\u003etrst \u003d\u003d 1) ||"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"62e5c2e4_e7592bf8","line":726,"updated":"2022-03-05 17:54:00.000000000","message":"We are moving away from queuing JTAG_RESET in order to have a single interface for JTAG, SWD, SWIM, whatever else will arrive.\nThere is a \"reset\" field in struct adapter_driver.\nSeveral drivers are already ported, but not all. Check one of these\nat91rm9200 bcm2835gpio buspirate cmsis_dap dummy ep93xx ftdi imx_gpio jlink jtag_dpi kitprog linuxgpiod nulink_usb parport presto remote_bitbang rshim stlink_usb sysfsgpio ti_icdi_usb vdebug vsllink xds110","commit_id":"477be1c0753a0cfc1409ef835964bf0aad8130cb"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"2a20549d12156ecd7063d4064038a8de2ef1b7fa","unresolved":false,"context_lines":[{"line_number":723,"context_line":""},{"line_number":724,"context_line":"\twhile (cmd) {"},{"line_number":725,"context_line":"\t\tswitch (cmd-\u003etype) {"},{"line_number":726,"context_line":"\t\tcase JTAG_RESET:"},{"line_number":727,"context_line":"\t\t\tLOG_DEBUG_IO(\"reset trst: %i srst %i\", cmd-\u003ecmd.reset-\u003etrst,"},{"line_number":728,"context_line":"\t\t\t\t\tcmd-\u003ecmd.reset-\u003esrst);"},{"line_number":729,"context_line":"\t\t\tif ((cmd-\u003ecmd.reset-\u003etrst \u003d\u003d 1) ||"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"71d8ac31_43e8aee2","line":726,"in_reply_to":"62e5c2e4_e7592bf8","updated":"2022-03-07 11:15:12.000000000","message":"Done","commit_id":"477be1c0753a0cfc1409ef835964bf0aad8130cb"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"fc0911bec97ec5b0fc7c4d0765990b1aa6537469","unresolved":true,"context_lines":[{"line_number":732,"context_line":"\t\t\t\ttap_set_state(TAP_RESET);"},{"line_number":733,"context_line":"\t\t\tif (xvc_reset(cmd-\u003ecmd.reset-\u003etrst, cmd-\u003ecmd.reset-\u003esrst) !\u003d ERROR_OK)"},{"line_number":734,"context_line":"\t\t\t\treturn ERROR_FAIL;"},{"line_number":735,"context_line":"\t\t\txvc_stats_print(JTAG_RESET, 1, chunk_count, chunk_element);"},{"line_number":736,"context_line":"\t\t\tbreak;"},{"line_number":737,"context_line":"\t\tcase JTAG_RUNTEST:"},{"line_number":738,"context_line":"\t\t\tLOG_DEBUG_IO(\"runtest %i cycles, end in %s\", cmd-\u003ecmd.runtest-\u003enum_cycles,"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"4b504eba_e45b8384","line":735,"updated":"2022-03-05 17:54:00.000000000","message":"Do you really need an extra logging mechanism?\nLOG_DEBUG_IO is already present (enabled with \"debug_level 4\"), log to file is available with \"log_output filename\". Only difference is that time is logged in 3th column with ms granularity instead of us of this print and is relative to OpenOCD start time.","commit_id":"477be1c0753a0cfc1409ef835964bf0aad8130cb"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"2a20549d12156ecd7063d4064038a8de2ef1b7fa","unresolved":false,"context_lines":[{"line_number":732,"context_line":"\t\t\t\ttap_set_state(TAP_RESET);"},{"line_number":733,"context_line":"\t\t\tif (xvc_reset(cmd-\u003ecmd.reset-\u003etrst, cmd-\u003ecmd.reset-\u003esrst) !\u003d ERROR_OK)"},{"line_number":734,"context_line":"\t\t\t\treturn ERROR_FAIL;"},{"line_number":735,"context_line":"\t\t\txvc_stats_print(JTAG_RESET, 1, chunk_count, chunk_element);"},{"line_number":736,"context_line":"\t\t\tbreak;"},{"line_number":737,"context_line":"\t\tcase JTAG_RUNTEST:"},{"line_number":738,"context_line":"\t\t\tLOG_DEBUG_IO(\"runtest %i cycles, end in %s\", cmd-\u003ecmd.runtest-\u003enum_cycles,"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"a7f959f8_4264eb07","line":735,"in_reply_to":"4b504eba_e45b8384","updated":"2022-03-07 11:15:12.000000000","message":"Done","commit_id":"477be1c0753a0cfc1409ef835964bf0aad8130cb"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"fc0911bec97ec5b0fc7c4d0765990b1aa6537469","unresolved":true,"context_lines":[{"line_number":806,"context_line":"}"},{"line_number":807,"context_line":""},{"line_number":808,"context_line":"static struct jtag_interface xvc_interface \u003d {"},{"line_number":809,"context_line":"\t\t.execute_queue \u003d \u0026xvc_tap_execute_queue,"},{"line_number":810,"context_line":"};"},{"line_number":811,"context_line":""},{"line_number":812,"context_line":"struct adapter_driver xvc_driver \u003d {"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"b63f2006_d5d7822c","line":809,"updated":"2022-03-05 17:54:00.000000000","message":"this driver supports JTAG_TMS (line 786), so here you should add:\n.supported \u003d DEBUG_CAP_TMS_SEQ,","commit_id":"477be1c0753a0cfc1409ef835964bf0aad8130cb"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"2a20549d12156ecd7063d4064038a8de2ef1b7fa","unresolved":false,"context_lines":[{"line_number":806,"context_line":"}"},{"line_number":807,"context_line":""},{"line_number":808,"context_line":"static struct jtag_interface xvc_interface \u003d {"},{"line_number":809,"context_line":"\t\t.execute_queue \u003d \u0026xvc_tap_execute_queue,"},{"line_number":810,"context_line":"};"},{"line_number":811,"context_line":""},{"line_number":812,"context_line":"struct adapter_driver xvc_driver \u003d {"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"99f1b97a_eb0b6956","line":809,"in_reply_to":"b63f2006_d5d7822c","updated":"2022-03-07 11:15:12.000000000","message":"Done","commit_id":"477be1c0753a0cfc1409ef835964bf0aad8130cb"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"735fabddcfa9d36538f18f9a90c3f1d521ad702d","unresolved":true,"context_lines":[{"line_number":89,"context_line":"{"},{"line_number":90,"context_line":"\t/* Converts TCK speed in kHz to ns. */"},{"line_number":91,"context_line":"\txvc_tck \u003d 1000000 / speed;"},{"line_number":92,"context_line":"\t/* Changes defult speed to adapter speed */"},{"line_number":93,"context_line":"\treturn xvc_settck();"},{"line_number":94,"context_line":"}"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":3,"id":"7c8599f8_2ffc9380","line":92,"updated":"2022-03-10 23:38:59.000000000","message":"typo s/defult/default/","commit_id":"abab47cd742d48a95e510774143284399ccfe20d"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"12e553efad2f26a632ec23a1f57cf00d6b7456e0","unresolved":false,"context_lines":[{"line_number":89,"context_line":"{"},{"line_number":90,"context_line":"\t/* Converts TCK speed in kHz to ns. */"},{"line_number":91,"context_line":"\txvc_tck \u003d 1000000 / speed;"},{"line_number":92,"context_line":"\t/* Changes defult speed to adapter speed */"},{"line_number":93,"context_line":"\treturn xvc_settck();"},{"line_number":94,"context_line":"}"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":3,"id":"d1a23c4e_5b3784fd","line":92,"in_reply_to":"7c8599f8_2ffc9380","updated":"2022-03-11 13:12:13.000000000","message":"Ack","commit_id":"abab47cd742d48a95e510774143284399ccfe20d"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"cbe11953b13f93a1f8993018963d3801aa4b1415","unresolved":false,"context_lines":[{"line_number":89,"context_line":"{"},{"line_number":90,"context_line":"\t/* Converts TCK speed in kHz to ns. */"},{"line_number":91,"context_line":"\txvc_tck \u003d 1000000 / speed;"},{"line_number":92,"context_line":"\t/* Changes defult speed to adapter speed */"},{"line_number":93,"context_line":"\treturn xvc_settck();"},{"line_number":94,"context_line":"}"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":3,"id":"eb79a8dd_508d236e","line":92,"in_reply_to":"d1a23c4e_5b3784fd","updated":"2022-03-25 15:18:10.000000000","message":"Done","commit_id":"abab47cd742d48a95e510774143284399ccfe20d"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"735fabddcfa9d36538f18f9a90c3f1d521ad702d","unresolved":true,"context_lines":[{"line_number":118,"context_line":"\t\t\tptr +\u003d state;"},{"line_number":119,"context_line":"\t\t\ti -\u003d state;"},{"line_number":120,"context_line":"\t\t} else {"},{"line_number":121,"context_line":"\t\t\tLOG_ERROR(\"read_frame\");"},{"line_number":122,"context_line":"\t\t\treturn state;"},{"line_number":123,"context_line":"\t\t}"},{"line_number":124,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"e122376b_44234558","line":121,"updated":"2022-03-10 23:38:59.000000000","message":"make the error message more clear, like \"read error from xvc socket\". The name of the function is printed in the log with log_level 3","commit_id":"abab47cd742d48a95e510774143284399ccfe20d"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"cbe11953b13f93a1f8993018963d3801aa4b1415","unresolved":false,"context_lines":[{"line_number":118,"context_line":"\t\t\tptr +\u003d state;"},{"line_number":119,"context_line":"\t\t\ti -\u003d state;"},{"line_number":120,"context_line":"\t\t} else {"},{"line_number":121,"context_line":"\t\t\tLOG_ERROR(\"read_frame\");"},{"line_number":122,"context_line":"\t\t\treturn state;"},{"line_number":123,"context_line":"\t\t}"},{"line_number":124,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"92247c9e_b619c5f7","line":121,"in_reply_to":"00bba59b_2e3bb331","updated":"2022-03-25 15:18:10.000000000","message":"Done","commit_id":"abab47cd742d48a95e510774143284399ccfe20d"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"12e553efad2f26a632ec23a1f57cf00d6b7456e0","unresolved":false,"context_lines":[{"line_number":118,"context_line":"\t\t\tptr +\u003d state;"},{"line_number":119,"context_line":"\t\t\ti -\u003d state;"},{"line_number":120,"context_line":"\t\t} else {"},{"line_number":121,"context_line":"\t\t\tLOG_ERROR(\"read_frame\");"},{"line_number":122,"context_line":"\t\t\treturn state;"},{"line_number":123,"context_line":"\t\t}"},{"line_number":124,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"00bba59b_2e3bb331","line":121,"in_reply_to":"e122376b_44234558","updated":"2022-03-11 13:12:13.000000000","message":"Ack","commit_id":"abab47cd742d48a95e510774143284399ccfe20d"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"735fabddcfa9d36538f18f9a90c3f1d521ad702d","unresolved":true,"context_lines":[{"line_number":145,"context_line":"\t/* Updates the offset. */"},{"line_number":146,"context_line":"\tcp_offset +\u003d shift_len;"},{"line_number":147,"context_line":"\t/* Copies number of bytes. */"},{"line_number":148,"context_line":"\tmemcpy(xvc_send_buf + cp_offset, \u0026xvc_used_bits, sizeof(xvc_used_bits));"},{"line_number":149,"context_line":"\tcp_offset +\u003d sizeof(xvc_used_bits);"},{"line_number":150,"context_line":"\t/* Copies TMS vector */"},{"line_number":151,"context_line":"\tmemcpy(xvc_send_buf + cp_offset, xvc_tms_buf, number_of_bytes);"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"10d66823_de0445de","line":148,"updated":"2022-03-10 23:38:59.000000000","message":"again endianess issue.\nh_u32_to_le(xvc_send_buf + cp_offset, xvc_used_bits);","commit_id":"abab47cd742d48a95e510774143284399ccfe20d"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"12e553efad2f26a632ec23a1f57cf00d6b7456e0","unresolved":false,"context_lines":[{"line_number":145,"context_line":"\t/* Updates the offset. */"},{"line_number":146,"context_line":"\tcp_offset +\u003d shift_len;"},{"line_number":147,"context_line":"\t/* Copies number of bytes. */"},{"line_number":148,"context_line":"\tmemcpy(xvc_send_buf + cp_offset, \u0026xvc_used_bits, sizeof(xvc_used_bits));"},{"line_number":149,"context_line":"\tcp_offset +\u003d sizeof(xvc_used_bits);"},{"line_number":150,"context_line":"\t/* Copies TMS vector */"},{"line_number":151,"context_line":"\tmemcpy(xvc_send_buf + cp_offset, xvc_tms_buf, number_of_bytes);"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"fa6bfd58_b179d5e8","line":148,"in_reply_to":"10d66823_de0445de","updated":"2022-03-11 13:12:13.000000000","message":"Ack","commit_id":"abab47cd742d48a95e510774143284399ccfe20d"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"cbe11953b13f93a1f8993018963d3801aa4b1415","unresolved":false,"context_lines":[{"line_number":145,"context_line":"\t/* Updates the offset. */"},{"line_number":146,"context_line":"\tcp_offset +\u003d shift_len;"},{"line_number":147,"context_line":"\t/* Copies number of bytes. */"},{"line_number":148,"context_line":"\tmemcpy(xvc_send_buf + cp_offset, \u0026xvc_used_bits, sizeof(xvc_used_bits));"},{"line_number":149,"context_line":"\tcp_offset +\u003d sizeof(xvc_used_bits);"},{"line_number":150,"context_line":"\t/* Copies TMS vector */"},{"line_number":151,"context_line":"\tmemcpy(xvc_send_buf + cp_offset, xvc_tms_buf, number_of_bytes);"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"5917be75_e8203d5a","line":148,"in_reply_to":"fa6bfd58_b179d5e8","updated":"2022-03-25 15:18:10.000000000","message":"Done","commit_id":"abab47cd742d48a95e510774143284399ccfe20d"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"735fabddcfa9d36538f18f9a90c3f1d521ad702d","unresolved":true,"context_lines":[{"line_number":160,"context_line":"\tssize_t written \u003d write_socket(xvc_fd, xvc_send_buf, cp_offset);"},{"line_number":161,"context_line":"\tif (written !\u003d cp_offset) {"},{"line_number":162,"context_line":"\t\tLOG_ERROR(\"write_socket \");"},{"line_number":163,"context_line":"\t\tLOG_ERROR(\"xvc_putc\");"},{"line_number":164,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":165,"context_line":"\t}"},{"line_number":166,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":3,"id":"092ff54e_10f5608f","line":163,"updated":"2022-03-10 23:38:59.000000000","message":"two error messages? we are not in xvc_putc!\nMake the message more clear \"write error to xvc socket\"","commit_id":"abab47cd742d48a95e510774143284399ccfe20d"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"12e553efad2f26a632ec23a1f57cf00d6b7456e0","unresolved":false,"context_lines":[{"line_number":160,"context_line":"\tssize_t written \u003d write_socket(xvc_fd, xvc_send_buf, cp_offset);"},{"line_number":161,"context_line":"\tif (written !\u003d cp_offset) {"},{"line_number":162,"context_line":"\t\tLOG_ERROR(\"write_socket \");"},{"line_number":163,"context_line":"\t\tLOG_ERROR(\"xvc_putc\");"},{"line_number":164,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":165,"context_line":"\t}"},{"line_number":166,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":3,"id":"7d3d1183_0f54c8e7","line":163,"in_reply_to":"092ff54e_10f5608f","updated":"2022-03-11 13:12:13.000000000","message":"Ack","commit_id":"abab47cd742d48a95e510774143284399ccfe20d"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"cbe11953b13f93a1f8993018963d3801aa4b1415","unresolved":false,"context_lines":[{"line_number":160,"context_line":"\tssize_t written \u003d write_socket(xvc_fd, xvc_send_buf, cp_offset);"},{"line_number":161,"context_line":"\tif (written !\u003d cp_offset) {"},{"line_number":162,"context_line":"\t\tLOG_ERROR(\"write_socket \");"},{"line_number":163,"context_line":"\t\tLOG_ERROR(\"xvc_putc\");"},{"line_number":164,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":165,"context_line":"\t}"},{"line_number":166,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":3,"id":"c99c5813_826d95e5","line":163,"in_reply_to":"7d3d1183_0f54c8e7","updated":"2022-03-25 15:18:10.000000000","message":"Done","commit_id":"abab47cd742d48a95e510774143284399ccfe20d"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"735fabddcfa9d36538f18f9a90c3f1d521ad702d","unresolved":true,"context_lines":[{"line_number":218,"context_line":"\t\tLOG_ERROR(\"xvc_getinfo: write\");"},{"line_number":219,"context_line":"\tchar info_recv_buf[20];"},{"line_number":220,"context_line":"\t/* Potentially waits until response gets received. */"},{"line_number":221,"context_line":"\tssize_t read \u003d read_socket(xvc_fd, \u0026info_recv_buf, 20);"},{"line_number":222,"context_line":"\tif (read \u003c 0)"},{"line_number":223,"context_line":"\t\tLOG_ERROR(\"xvc_getinfo: read\");"},{"line_number":224,"context_line":"\tLOG_INFO(\"XVC HW server version: %.19s\", info_recv_buf);"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"f3cf3603_593752ba","line":221,"updated":"2022-03-10 23:38:59.000000000","message":"Please test this code under valgrind!\nHere should be without \"\u0026\"\nssize_t read \u003d read_socket(xvc_fd, info_recv_buf, 20);","commit_id":"abab47cd742d48a95e510774143284399ccfe20d"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"cbe11953b13f93a1f8993018963d3801aa4b1415","unresolved":false,"context_lines":[{"line_number":218,"context_line":"\t\tLOG_ERROR(\"xvc_getinfo: write\");"},{"line_number":219,"context_line":"\tchar info_recv_buf[20];"},{"line_number":220,"context_line":"\t/* Potentially waits until response gets received. */"},{"line_number":221,"context_line":"\tssize_t read \u003d read_socket(xvc_fd, \u0026info_recv_buf, 20);"},{"line_number":222,"context_line":"\tif (read \u003c 0)"},{"line_number":223,"context_line":"\t\tLOG_ERROR(\"xvc_getinfo: read\");"},{"line_number":224,"context_line":"\tLOG_INFO(\"XVC HW server version: %.19s\", info_recv_buf);"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"2b190dad_75f2311d","line":221,"in_reply_to":"238bfbc5_00056292","updated":"2022-03-25 15:18:10.000000000","message":"Done","commit_id":"abab47cd742d48a95e510774143284399ccfe20d"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"12e553efad2f26a632ec23a1f57cf00d6b7456e0","unresolved":false,"context_lines":[{"line_number":218,"context_line":"\t\tLOG_ERROR(\"xvc_getinfo: write\");"},{"line_number":219,"context_line":"\tchar info_recv_buf[20];"},{"line_number":220,"context_line":"\t/* Potentially waits until response gets received. */"},{"line_number":221,"context_line":"\tssize_t read \u003d read_socket(xvc_fd, \u0026info_recv_buf, 20);"},{"line_number":222,"context_line":"\tif (read \u003c 0)"},{"line_number":223,"context_line":"\t\tLOG_ERROR(\"xvc_getinfo: read\");"},{"line_number":224,"context_line":"\tLOG_INFO(\"XVC HW server version: %.19s\", info_recv_buf);"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"238bfbc5_00056292","line":221,"in_reply_to":"f3cf3603_593752ba","updated":"2022-03-11 13:12:13.000000000","message":"Ack\n\nSince this variable is an array and not a pointer, both options returns the address of the first element in the array, so I think both are valid. Nevertheless, for the sake of clarity, I will take you suggestion into account and remove \u0027\u0026\u0027.","commit_id":"abab47cd742d48a95e510774143284399ccfe20d"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"735fabddcfa9d36538f18f9a90c3f1d521ad702d","unresolved":true,"context_lines":[{"line_number":220,"context_line":"\t/* Potentially waits until response gets received. */"},{"line_number":221,"context_line":"\tssize_t read \u003d read_socket(xvc_fd, \u0026info_recv_buf, 20);"},{"line_number":222,"context_line":"\tif (read \u003c 0)"},{"line_number":223,"context_line":"\t\tLOG_ERROR(\"xvc_getinfo: read\");"},{"line_number":224,"context_line":"\tLOG_INFO(\"XVC HW server version: %.19s\", info_recv_buf);"},{"line_number":225,"context_line":"\tif (strncmp((char *)\u0026info_recv_buf, \"xvcServer_v1.0:\", 15) \u003d\u003d 0) {"},{"line_number":226,"context_line":"\t\txvc_max_usable_vector_size \u003d strtoul(\u0026info_recv_buf[15], NULL, 10);"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"a0415479_0e66b1dc","line":223,"updated":"2022-03-10 23:38:59.000000000","message":"should return error?","commit_id":"abab47cd742d48a95e510774143284399ccfe20d"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"cbe11953b13f93a1f8993018963d3801aa4b1415","unresolved":false,"context_lines":[{"line_number":220,"context_line":"\t/* Potentially waits until response gets received. */"},{"line_number":221,"context_line":"\tssize_t read \u003d read_socket(xvc_fd, \u0026info_recv_buf, 20);"},{"line_number":222,"context_line":"\tif (read \u003c 0)"},{"line_number":223,"context_line":"\t\tLOG_ERROR(\"xvc_getinfo: read\");"},{"line_number":224,"context_line":"\tLOG_INFO(\"XVC HW server version: %.19s\", info_recv_buf);"},{"line_number":225,"context_line":"\tif (strncmp((char *)\u0026info_recv_buf, \"xvcServer_v1.0:\", 15) \u003d\u003d 0) {"},{"line_number":226,"context_line":"\t\txvc_max_usable_vector_size \u003d strtoul(\u0026info_recv_buf[15], NULL, 10);"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"518446c2_787a3c2d","line":223,"in_reply_to":"9f4233bd_d04a88af","updated":"2022-03-25 15:18:10.000000000","message":"Done","commit_id":"abab47cd742d48a95e510774143284399ccfe20d"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"12e553efad2f26a632ec23a1f57cf00d6b7456e0","unresolved":false,"context_lines":[{"line_number":220,"context_line":"\t/* Potentially waits until response gets received. */"},{"line_number":221,"context_line":"\tssize_t read \u003d read_socket(xvc_fd, \u0026info_recv_buf, 20);"},{"line_number":222,"context_line":"\tif (read \u003c 0)"},{"line_number":223,"context_line":"\t\tLOG_ERROR(\"xvc_getinfo: read\");"},{"line_number":224,"context_line":"\tLOG_INFO(\"XVC HW server version: %.19s\", info_recv_buf);"},{"line_number":225,"context_line":"\tif (strncmp((char *)\u0026info_recv_buf, \"xvcServer_v1.0:\", 15) \u003d\u003d 0) {"},{"line_number":226,"context_line":"\t\txvc_max_usable_vector_size \u003d strtoul(\u0026info_recv_buf[15], NULL, 10);"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"9f4233bd_d04a88af","line":223,"in_reply_to":"a0415479_0e66b1dc","updated":"2022-03-11 13:12:13.000000000","message":"Ack","commit_id":"abab47cd742d48a95e510774143284399ccfe20d"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"735fabddcfa9d36538f18f9a90c3f1d521ad702d","unresolved":true,"context_lines":[{"line_number":222,"context_line":"\tif (read \u003c 0)"},{"line_number":223,"context_line":"\t\tLOG_ERROR(\"xvc_getinfo: read\");"},{"line_number":224,"context_line":"\tLOG_INFO(\"XVC HW server version: %.19s\", info_recv_buf);"},{"line_number":225,"context_line":"\tif (strncmp((char *)\u0026info_recv_buf, \"xvcServer_v1.0:\", 15) \u003d\u003d 0) {"},{"line_number":226,"context_line":"\t\txvc_max_usable_vector_size \u003d strtoul(\u0026info_recv_buf[15], NULL, 10);"},{"line_number":227,"context_line":"\t\tif (xvc_max_usable_vector_size \u003e 32757) {"},{"line_number":228,"context_line":"\t\t\tLOG_DEBUG(\"Exceeded maximum vector size, outputting to 32757 bytes\");"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"743e05d3_072a4d34","line":225,"updated":"2022-03-10 23:38:59.000000000","message":"to reduce the indentation of the code below, invert the condition:\nif (strncmp(info_recv_buf, \"xvcServer_v1.0:\", 15) !\u003d 0) {\n   /* We got something unexpected. */\n   LOG_ERROR(\"Unexpected response from XVC server\");\n   return ERROR_FAIL;\n}\nRemoved the cast, as info_recv_buf is alread a (char *). The error is that you added \"\u0026\". This is the kind of errors that get hide by cast. Cast should be avoided.","commit_id":"abab47cd742d48a95e510774143284399ccfe20d"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"cbe11953b13f93a1f8993018963d3801aa4b1415","unresolved":false,"context_lines":[{"line_number":222,"context_line":"\tif (read \u003c 0)"},{"line_number":223,"context_line":"\t\tLOG_ERROR(\"xvc_getinfo: read\");"},{"line_number":224,"context_line":"\tLOG_INFO(\"XVC HW server version: %.19s\", info_recv_buf);"},{"line_number":225,"context_line":"\tif (strncmp((char *)\u0026info_recv_buf, \"xvcServer_v1.0:\", 15) \u003d\u003d 0) {"},{"line_number":226,"context_line":"\t\txvc_max_usable_vector_size \u003d strtoul(\u0026info_recv_buf[15], NULL, 10);"},{"line_number":227,"context_line":"\t\tif (xvc_max_usable_vector_size \u003e 32757) {"},{"line_number":228,"context_line":"\t\t\tLOG_DEBUG(\"Exceeded maximum vector size, outputting to 32757 bytes\");"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"2418758c_71dcab69","line":225,"in_reply_to":"5e27315e_c29d30e6","updated":"2022-03-25 15:18:10.000000000","message":"Done","commit_id":"abab47cd742d48a95e510774143284399ccfe20d"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"12e553efad2f26a632ec23a1f57cf00d6b7456e0","unresolved":false,"context_lines":[{"line_number":222,"context_line":"\tif (read \u003c 0)"},{"line_number":223,"context_line":"\t\tLOG_ERROR(\"xvc_getinfo: read\");"},{"line_number":224,"context_line":"\tLOG_INFO(\"XVC HW server version: %.19s\", info_recv_buf);"},{"line_number":225,"context_line":"\tif (strncmp((char *)\u0026info_recv_buf, \"xvcServer_v1.0:\", 15) \u003d\u003d 0) {"},{"line_number":226,"context_line":"\t\txvc_max_usable_vector_size \u003d strtoul(\u0026info_recv_buf[15], NULL, 10);"},{"line_number":227,"context_line":"\t\tif (xvc_max_usable_vector_size \u003e 32757) {"},{"line_number":228,"context_line":"\t\t\tLOG_DEBUG(\"Exceeded maximum vector size, outputting to 32757 bytes\");"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"5e27315e_c29d30e6","line":225,"in_reply_to":"743e05d3_072a4d34","updated":"2022-03-11 13:12:13.000000000","message":"Ack","commit_id":"abab47cd742d48a95e510774143284399ccfe20d"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"735fabddcfa9d36538f18f9a90c3f1d521ad702d","unresolved":true,"context_lines":[{"line_number":261,"context_line":"\tchar settck[12];"},{"line_number":262,"context_line":"\tconst char *header \u003d \"settck:\";"},{"line_number":263,"context_line":"\tmemcpy(settck, header, 7);"},{"line_number":264,"context_line":"\th_u32_to_le((uint8_t *)settck + 7, xvc_tck);"},{"line_number":265,"context_line":"\t/* Writes the request */"},{"line_number":266,"context_line":"\tssize_t written \u003d write_socket(xvc_fd, settck, 11);"},{"line_number":267,"context_line":"\tif (written !\u003d 11)"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"8df2e331_48a4116e","line":264,"updated":"2022-03-10 23:38:59.000000000","message":"Use\nuint8_t settck[12];\nso here you do not need to cast (uint8_t *)","commit_id":"abab47cd742d48a95e510774143284399ccfe20d"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"cbe11953b13f93a1f8993018963d3801aa4b1415","unresolved":false,"context_lines":[{"line_number":261,"context_line":"\tchar settck[12];"},{"line_number":262,"context_line":"\tconst char *header \u003d \"settck:\";"},{"line_number":263,"context_line":"\tmemcpy(settck, header, 7);"},{"line_number":264,"context_line":"\th_u32_to_le((uint8_t *)settck + 7, xvc_tck);"},{"line_number":265,"context_line":"\t/* Writes the request */"},{"line_number":266,"context_line":"\tssize_t written \u003d write_socket(xvc_fd, settck, 11);"},{"line_number":267,"context_line":"\tif (written !\u003d 11)"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"00cabdfe_5c18c64b","line":264,"in_reply_to":"5d92be9b_1ec0c2b8","updated":"2022-03-25 15:18:10.000000000","message":"Done","commit_id":"abab47cd742d48a95e510774143284399ccfe20d"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"12e553efad2f26a632ec23a1f57cf00d6b7456e0","unresolved":false,"context_lines":[{"line_number":261,"context_line":"\tchar settck[12];"},{"line_number":262,"context_line":"\tconst char *header \u003d \"settck:\";"},{"line_number":263,"context_line":"\tmemcpy(settck, header, 7);"},{"line_number":264,"context_line":"\th_u32_to_le((uint8_t *)settck + 7, xvc_tck);"},{"line_number":265,"context_line":"\t/* Writes the request */"},{"line_number":266,"context_line":"\tssize_t written \u003d write_socket(xvc_fd, settck, 11);"},{"line_number":267,"context_line":"\tif (written !\u003d 11)"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"5d92be9b_1ec0c2b8","line":264,"in_reply_to":"8df2e331_48a4116e","updated":"2022-03-11 13:12:13.000000000","message":"Ack","commit_id":"abab47cd742d48a95e510774143284399ccfe20d"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"735fabddcfa9d36538f18f9a90c3f1d521ad702d","unresolved":true,"context_lines":[{"line_number":265,"context_line":"\t/* Writes the request */"},{"line_number":266,"context_line":"\tssize_t written \u003d write_socket(xvc_fd, settck, 11);"},{"line_number":267,"context_line":"\tif (written !\u003d 11)"},{"line_number":268,"context_line":"\t\tLOG_ERROR(\"xvc_settck: write\");"},{"line_number":269,"context_line":"\tchar tck_recv_buf[4];"},{"line_number":270,"context_line":"\t/* Potentially waits for a response. */"},{"line_number":271,"context_line":"\tssize_t read \u003d read_socket(xvc_fd, \u0026tck_recv_buf, 4);"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"e799f569_7dd39ac2","line":268,"updated":"2022-03-10 23:38:59.000000000","message":"exit with error?","commit_id":"abab47cd742d48a95e510774143284399ccfe20d"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"cbe11953b13f93a1f8993018963d3801aa4b1415","unresolved":false,"context_lines":[{"line_number":265,"context_line":"\t/* Writes the request */"},{"line_number":266,"context_line":"\tssize_t written \u003d write_socket(xvc_fd, settck, 11);"},{"line_number":267,"context_line":"\tif (written !\u003d 11)"},{"line_number":268,"context_line":"\t\tLOG_ERROR(\"xvc_settck: write\");"},{"line_number":269,"context_line":"\tchar tck_recv_buf[4];"},{"line_number":270,"context_line":"\t/* Potentially waits for a response. */"},{"line_number":271,"context_line":"\tssize_t read \u003d read_socket(xvc_fd, \u0026tck_recv_buf, 4);"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"4b3a86d4_90b630bd","line":268,"in_reply_to":"c36cca51_2a2fcde2","updated":"2022-03-25 15:18:10.000000000","message":"Done","commit_id":"abab47cd742d48a95e510774143284399ccfe20d"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"12e553efad2f26a632ec23a1f57cf00d6b7456e0","unresolved":false,"context_lines":[{"line_number":265,"context_line":"\t/* Writes the request */"},{"line_number":266,"context_line":"\tssize_t written \u003d write_socket(xvc_fd, settck, 11);"},{"line_number":267,"context_line":"\tif (written !\u003d 11)"},{"line_number":268,"context_line":"\t\tLOG_ERROR(\"xvc_settck: write\");"},{"line_number":269,"context_line":"\tchar tck_recv_buf[4];"},{"line_number":270,"context_line":"\t/* Potentially waits for a response. */"},{"line_number":271,"context_line":"\tssize_t read \u003d read_socket(xvc_fd, \u0026tck_recv_buf, 4);"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"c36cca51_2a2fcde2","line":268,"in_reply_to":"e799f569_7dd39ac2","updated":"2022-03-11 13:12:13.000000000","message":"Ack","commit_id":"abab47cd742d48a95e510774143284399ccfe20d"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"735fabddcfa9d36538f18f9a90c3f1d521ad702d","unresolved":true,"context_lines":[{"line_number":274,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":275,"context_line":"\t}"},{"line_number":276,"context_line":"\t/* Prints raw message, as an ASCII array. */"},{"line_number":277,"context_line":"\tLOG_DEBUG(\"settck: replied %.4s\\n\", tck_recv_buf);"},{"line_number":278,"context_line":"\t/* Copies the entire buffer, regardless of machine\u0027s endianess. */"},{"line_number":279,"context_line":"\tuint32_t xvc_tck_period_ns;"},{"line_number":280,"context_line":"\txvc_tck_period_ns \u003d le_to_h_u32((uint8_t *)tck_recv_buf);"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"aa604b3e_da79b0c1","line":277,"updated":"2022-03-10 23:38:59.000000000","message":"tck_recv_buf has been read as 4 bytes. Are you sure it is a zero terminated string?\nIf the 4th byte is not zero, this is going to print the whole memory until a zero byte is found.\nPlus, below you convert it in a 32 bits integer. For me this is not a string.\nWe have buf_to_hex_str(), if you want to print a buffer in hexadecimal","commit_id":"abab47cd742d48a95e510774143284399ccfe20d"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"cbe11953b13f93a1f8993018963d3801aa4b1415","unresolved":false,"context_lines":[{"line_number":274,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":275,"context_line":"\t}"},{"line_number":276,"context_line":"\t/* Prints raw message, as an ASCII array. */"},{"line_number":277,"context_line":"\tLOG_DEBUG(\"settck: replied %.4s\\n\", tck_recv_buf);"},{"line_number":278,"context_line":"\t/* Copies the entire buffer, regardless of machine\u0027s endianess. */"},{"line_number":279,"context_line":"\tuint32_t xvc_tck_period_ns;"},{"line_number":280,"context_line":"\txvc_tck_period_ns \u003d le_to_h_u32((uint8_t *)tck_recv_buf);"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"71c19114_bd1e369a","line":277,"in_reply_to":"65805e25_d1cd41ed","updated":"2022-03-25 15:18:10.000000000","message":"Done","commit_id":"abab47cd742d48a95e510774143284399ccfe20d"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"12e553efad2f26a632ec23a1f57cf00d6b7456e0","unresolved":false,"context_lines":[{"line_number":274,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":275,"context_line":"\t}"},{"line_number":276,"context_line":"\t/* Prints raw message, as an ASCII array. */"},{"line_number":277,"context_line":"\tLOG_DEBUG(\"settck: replied %.4s\\n\", tck_recv_buf);"},{"line_number":278,"context_line":"\t/* Copies the entire buffer, regardless of machine\u0027s endianess. */"},{"line_number":279,"context_line":"\tuint32_t xvc_tck_period_ns;"},{"line_number":280,"context_line":"\txvc_tck_period_ns \u003d le_to_h_u32((uint8_t *)tck_recv_buf);"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"65805e25_d1cd41ed","line":277,"in_reply_to":"aa604b3e_da79b0c1","updated":"2022-03-11 13:12:13.000000000","message":"Ack","commit_id":"abab47cd742d48a95e510774143284399ccfe20d"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"735fabddcfa9d36538f18f9a90c3f1d521ad702d","unresolved":true,"context_lines":[{"line_number":285,"context_line":"static void xvc_fill_buffer(void)"},{"line_number":286,"context_line":"{"},{"line_number":287,"context_line":"\tif (read_frame(xvc_fd, xvc_tdo_buf, (7 + last_used_bits) / 8) \u003c 0)"},{"line_number":288,"context_line":"\t\tLOG_ERROR(\"Read_frame\");"},{"line_number":289,"context_line":"\tfor (int i \u003d 0; i \u003c pending_shift_results; i++) {"},{"line_number":290,"context_line":"\t\tstruct shift_result *shift_result \u003d \u0026shift_result_buffer[i];"},{"line_number":291,"context_line":"\t\tbuf_set_buf(xvc_tdo_buf, shift_result-\u003efirst, shift_result-\u003ebuffer,"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"937ed693_4ef66886","line":288,"updated":"2022-03-10 23:38:59.000000000","message":"I think here we should return error","commit_id":"abab47cd742d48a95e510774143284399ccfe20d"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"cbe11953b13f93a1f8993018963d3801aa4b1415","unresolved":false,"context_lines":[{"line_number":285,"context_line":"static void xvc_fill_buffer(void)"},{"line_number":286,"context_line":"{"},{"line_number":287,"context_line":"\tif (read_frame(xvc_fd, xvc_tdo_buf, (7 + last_used_bits) / 8) \u003c 0)"},{"line_number":288,"context_line":"\t\tLOG_ERROR(\"Read_frame\");"},{"line_number":289,"context_line":"\tfor (int i \u003d 0; i \u003c pending_shift_results; i++) {"},{"line_number":290,"context_line":"\t\tstruct shift_result *shift_result \u003d \u0026shift_result_buffer[i];"},{"line_number":291,"context_line":"\t\tbuf_set_buf(xvc_tdo_buf, shift_result-\u003efirst, shift_result-\u003ebuffer,"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"2e3f3378_2a296602","line":288,"in_reply_to":"34c74839_eabe930c","updated":"2022-03-25 15:18:10.000000000","message":"Done","commit_id":"abab47cd742d48a95e510774143284399ccfe20d"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"12e553efad2f26a632ec23a1f57cf00d6b7456e0","unresolved":false,"context_lines":[{"line_number":285,"context_line":"static void xvc_fill_buffer(void)"},{"line_number":286,"context_line":"{"},{"line_number":287,"context_line":"\tif (read_frame(xvc_fd, xvc_tdo_buf, (7 + last_used_bits) / 8) \u003c 0)"},{"line_number":288,"context_line":"\t\tLOG_ERROR(\"Read_frame\");"},{"line_number":289,"context_line":"\tfor (int i \u003d 0; i \u003c pending_shift_results; i++) {"},{"line_number":290,"context_line":"\t\tstruct shift_result *shift_result \u003d \u0026shift_result_buffer[i];"},{"line_number":291,"context_line":"\t\tbuf_set_buf(xvc_tdo_buf, shift_result-\u003efirst, shift_result-\u003ebuffer,"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"34c74839_eabe930c","line":288,"in_reply_to":"937ed693_4ef66886","updated":"2022-03-11 13:12:13.000000000","message":"Ack","commit_id":"abab47cd742d48a95e510774143284399ccfe20d"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"735fabddcfa9d36538f18f9a90c3f1d521ad702d","unresolved":true,"context_lines":[{"line_number":295,"context_line":"\tpending_shift_results \u003d 0;"},{"line_number":296,"context_line":"}"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"static int xvc_reset(int trst, int srst)"},{"line_number":299,"context_line":"{"},{"line_number":300,"context_line":"\t/*XVC does not have dedicated Reset lines. */"},{"line_number":301,"context_line":"\treturn ERROR_OK;"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"7073fc5b_c87869ed","line":298,"range":{"start_line":298,"start_character":11,"end_line":298,"end_character":20},"updated":"2022-03-10 23:38:59.000000000","message":"I haven\u0027t noticed, before, that there are no reset lines. Add:\nstatic bool once \u003d false;\nif (!once)\n LOG_WARNING(\"Adapter has no reset lines. Fix \\\"reset_config\\\" command in config file\");\nonce \u003d true;","commit_id":"abab47cd742d48a95e510774143284399ccfe20d"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"cbe11953b13f93a1f8993018963d3801aa4b1415","unresolved":false,"context_lines":[{"line_number":295,"context_line":"\tpending_shift_results \u003d 0;"},{"line_number":296,"context_line":"}"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"static int xvc_reset(int trst, int srst)"},{"line_number":299,"context_line":"{"},{"line_number":300,"context_line":"\t/*XVC does not have dedicated Reset lines. */"},{"line_number":301,"context_line":"\treturn ERROR_OK;"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"b16534ed_01458ff3","line":298,"range":{"start_line":298,"start_character":11,"end_line":298,"end_character":20},"in_reply_to":"490d5b60_4a3693d4","updated":"2022-03-25 15:18:10.000000000","message":"Done","commit_id":"abab47cd742d48a95e510774143284399ccfe20d"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"12e553efad2f26a632ec23a1f57cf00d6b7456e0","unresolved":false,"context_lines":[{"line_number":295,"context_line":"\tpending_shift_results \u003d 0;"},{"line_number":296,"context_line":"}"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"static int xvc_reset(int trst, int srst)"},{"line_number":299,"context_line":"{"},{"line_number":300,"context_line":"\t/*XVC does not have dedicated Reset lines. */"},{"line_number":301,"context_line":"\treturn ERROR_OK;"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"490d5b60_4a3693d4","line":298,"range":{"start_line":298,"start_character":11,"end_line":298,"end_character":20},"in_reply_to":"7073fc5b_c87869ed","updated":"2022-03-11 13:12:13.000000000","message":"Ack","commit_id":"abab47cd742d48a95e510774143284399ccfe20d"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"735fabddcfa9d36538f18f9a90c3f1d521ad702d","unresolved":true,"context_lines":[{"line_number":527,"context_line":"\t\telse if (tap_state_transition(tap_get_state(), true) \u003d\u003d"},{"line_number":528,"context_line":"\t\t\t\tcmd-\u003epath[state_count])"},{"line_number":529,"context_line":"\t\t\txvc_queue(\u0026tms, 0, NULL, 0, NULL, 0, 1);"},{"line_number":530,"context_line":"\t\telse {"},{"line_number":531,"context_line":"\t\t\tLOG_ERROR(\"BUG: %s -\u003e %s isn\u0027t a valid TAP transition\","},{"line_number":532,"context_line":"\t\t\t\t\ttap_state_name(tap_get_state()),"},{"line_number":533,"context_line":"\t\t\t\t\ttap_state_name(cmd-\u003epath[state_count]));"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"39cecc98_35c97535","line":530,"updated":"2022-03-10 23:38:59.000000000","message":"if one branch of it/then/else require {}, then all the branches must have {}","commit_id":"abab47cd742d48a95e510774143284399ccfe20d"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"cbe11953b13f93a1f8993018963d3801aa4b1415","unresolved":false,"context_lines":[{"line_number":527,"context_line":"\t\telse if (tap_state_transition(tap_get_state(), true) \u003d\u003d"},{"line_number":528,"context_line":"\t\t\t\tcmd-\u003epath[state_count])"},{"line_number":529,"context_line":"\t\t\txvc_queue(\u0026tms, 0, NULL, 0, NULL, 0, 1);"},{"line_number":530,"context_line":"\t\telse {"},{"line_number":531,"context_line":"\t\t\tLOG_ERROR(\"BUG: %s -\u003e %s isn\u0027t a valid TAP transition\","},{"line_number":532,"context_line":"\t\t\t\t\ttap_state_name(tap_get_state()),"},{"line_number":533,"context_line":"\t\t\t\t\ttap_state_name(cmd-\u003epath[state_count]));"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"b491f150_d5148eb0","line":530,"in_reply_to":"33592eba_6bd1f5ab","updated":"2022-03-25 15:18:10.000000000","message":"Done","commit_id":"abab47cd742d48a95e510774143284399ccfe20d"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"12e553efad2f26a632ec23a1f57cf00d6b7456e0","unresolved":false,"context_lines":[{"line_number":527,"context_line":"\t\telse if (tap_state_transition(tap_get_state(), true) \u003d\u003d"},{"line_number":528,"context_line":"\t\t\t\tcmd-\u003epath[state_count])"},{"line_number":529,"context_line":"\t\t\txvc_queue(\u0026tms, 0, NULL, 0, NULL, 0, 1);"},{"line_number":530,"context_line":"\t\telse {"},{"line_number":531,"context_line":"\t\t\tLOG_ERROR(\"BUG: %s -\u003e %s isn\u0027t a valid TAP transition\","},{"line_number":532,"context_line":"\t\t\t\t\ttap_state_name(tap_get_state()),"},{"line_number":533,"context_line":"\t\t\t\t\ttap_state_name(cmd-\u003epath[state_count]));"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"33592eba_6bd1f5ab","line":530,"in_reply_to":"39cecc98_35c97535","updated":"2022-03-11 13:12:13.000000000","message":"Ack","commit_id":"abab47cd742d48a95e510774143284399ccfe20d"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"735fabddcfa9d36538f18f9a90c3f1d521ad702d","unresolved":true,"context_lines":[{"line_number":545,"context_line":""},{"line_number":546,"context_line":"static int xvc_tap_stableclocks(int num_cycles)"},{"line_number":547,"context_line":"{"},{"line_number":548,"context_line":"\tint i;"},{"line_number":549,"context_line":"\tuint8_t tms \u003d (tap_get_state() \u003d\u003d TAP_RESET ? 0xff : 0);"},{"line_number":550,"context_line":""},{"line_number":551,"context_line":"\tfor (i \u003d 0; i \u003c num_cycles; i++)"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"4377dfd6_57594901","line":548,"updated":"2022-03-10 23:38:59.000000000","message":"move the declaration of \"i\" inside the for(int i \u003d 0;...)","commit_id":"abab47cd742d48a95e510774143284399ccfe20d"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"12e553efad2f26a632ec23a1f57cf00d6b7456e0","unresolved":false,"context_lines":[{"line_number":545,"context_line":""},{"line_number":546,"context_line":"static int xvc_tap_stableclocks(int num_cycles)"},{"line_number":547,"context_line":"{"},{"line_number":548,"context_line":"\tint i;"},{"line_number":549,"context_line":"\tuint8_t tms \u003d (tap_get_state() \u003d\u003d TAP_RESET ? 0xff : 0);"},{"line_number":550,"context_line":""},{"line_number":551,"context_line":"\tfor (i \u003d 0; i \u003c num_cycles; i++)"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"a87c2310_c0b1ed7c","line":548,"in_reply_to":"4377dfd6_57594901","updated":"2022-03-11 13:12:13.000000000","message":"Ack","commit_id":"abab47cd742d48a95e510774143284399ccfe20d"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"cbe11953b13f93a1f8993018963d3801aa4b1415","unresolved":false,"context_lines":[{"line_number":545,"context_line":""},{"line_number":546,"context_line":"static int xvc_tap_stableclocks(int num_cycles)"},{"line_number":547,"context_line":"{"},{"line_number":548,"context_line":"\tint i;"},{"line_number":549,"context_line":"\tuint8_t tms \u003d (tap_get_state() \u003d\u003d TAP_RESET ? 0xff : 0);"},{"line_number":550,"context_line":""},{"line_number":551,"context_line":"\tfor (i \u003d 0; i \u003c num_cycles; i++)"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"9cfbeec4_b6f212e1","line":548,"in_reply_to":"a87c2310_c0b1ed7c","updated":"2022-03-25 15:18:10.000000000","message":"Done","commit_id":"abab47cd742d48a95e510774143284399ccfe20d"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"735fabddcfa9d36538f18f9a90c3f1d521ad702d","unresolved":true,"context_lines":[{"line_number":657,"context_line":""},{"line_number":658,"context_line":"\twhile (cmd) {"},{"line_number":659,"context_line":"\t\tswitch (cmd-\u003etype) {"},{"line_number":660,"context_line":"\t\t\tcase JTAG_RUNTEST:"},{"line_number":661,"context_line":"\t\t\t\tLOG_DEBUG_IO(\"runtest %i cycles, end in %s\", cmd-\u003ecmd.runtest-\u003enum_cycles,"},{"line_number":662,"context_line":"\t\t\t\t\t\ttap_state_name(cmd-\u003ecmd.runtest-\u003eend_state));"},{"line_number":663,"context_line":"\t\t\t\txvc_tap_end_state(cmd-\u003ecmd.runtest-\u003eend_state);"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"8211ddef_31996109","line":660,"updated":"2022-03-10 23:38:59.000000000","message":"indentation. \"case\" should be at the same indentation level as \"switch\".\nCheck doc/manual/style.txt","commit_id":"abab47cd742d48a95e510774143284399ccfe20d"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"cbe11953b13f93a1f8993018963d3801aa4b1415","unresolved":false,"context_lines":[{"line_number":657,"context_line":""},{"line_number":658,"context_line":"\twhile (cmd) {"},{"line_number":659,"context_line":"\t\tswitch (cmd-\u003etype) {"},{"line_number":660,"context_line":"\t\t\tcase JTAG_RUNTEST:"},{"line_number":661,"context_line":"\t\t\t\tLOG_DEBUG_IO(\"runtest %i cycles, end in %s\", cmd-\u003ecmd.runtest-\u003enum_cycles,"},{"line_number":662,"context_line":"\t\t\t\t\t\ttap_state_name(cmd-\u003ecmd.runtest-\u003eend_state));"},{"line_number":663,"context_line":"\t\t\t\txvc_tap_end_state(cmd-\u003ecmd.runtest-\u003eend_state);"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"ff9d8429_4075ceae","line":660,"in_reply_to":"6bc3b8a3_1e38b411","updated":"2022-03-25 15:18:10.000000000","message":"Done","commit_id":"abab47cd742d48a95e510774143284399ccfe20d"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"12e553efad2f26a632ec23a1f57cf00d6b7456e0","unresolved":false,"context_lines":[{"line_number":657,"context_line":""},{"line_number":658,"context_line":"\twhile (cmd) {"},{"line_number":659,"context_line":"\t\tswitch (cmd-\u003etype) {"},{"line_number":660,"context_line":"\t\t\tcase JTAG_RUNTEST:"},{"line_number":661,"context_line":"\t\t\t\tLOG_DEBUG_IO(\"runtest %i cycles, end in %s\", cmd-\u003ecmd.runtest-\u003enum_cycles,"},{"line_number":662,"context_line":"\t\t\t\t\t\ttap_state_name(cmd-\u003ecmd.runtest-\u003eend_state));"},{"line_number":663,"context_line":"\t\t\t\txvc_tap_end_state(cmd-\u003ecmd.runtest-\u003eend_state);"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"6bc3b8a3_1e38b411","line":660,"in_reply_to":"8211ddef_31996109","updated":"2022-03-11 13:12:13.000000000","message":"Ack","commit_id":"abab47cd742d48a95e510774143284399ccfe20d"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"735fabddcfa9d36538f18f9a90c3f1d521ad702d","unresolved":true,"context_lines":[{"line_number":695,"context_line":"\t\t\t\tjtag_sleep(cmd-\u003ecmd.sleep-\u003eus);"},{"line_number":696,"context_line":"\t\t\t\tbreak;"},{"line_number":697,"context_line":"\t\t\tcase JTAG_TMS:"},{"line_number":698,"context_line":"\t\t\t\tretval \u003d xvc_tap_execute_tms(cmd);"},{"line_number":699,"context_line":"\t\t\t\tbreak;"},{"line_number":700,"context_line":"\t\t\tdefault:"},{"line_number":701,"context_line":"\t\t\t\tLOG_ERROR(\"BUG: unknown JTAG command type encountered\");"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"8b4f71a5_5f81e0a9","line":698,"updated":"2022-03-10 23:38:59.000000000","message":"This is the only place in this function where you assign retval.\nShould it be here also\nif (retval !\u003d ERROR_OK)\n   return retval;\n?\nIn this case the variable retval could be removed!","commit_id":"abab47cd742d48a95e510774143284399ccfe20d"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"12e553efad2f26a632ec23a1f57cf00d6b7456e0","unresolved":false,"context_lines":[{"line_number":695,"context_line":"\t\t\t\tjtag_sleep(cmd-\u003ecmd.sleep-\u003eus);"},{"line_number":696,"context_line":"\t\t\t\tbreak;"},{"line_number":697,"context_line":"\t\t\tcase JTAG_TMS:"},{"line_number":698,"context_line":"\t\t\t\tretval \u003d xvc_tap_execute_tms(cmd);"},{"line_number":699,"context_line":"\t\t\t\tbreak;"},{"line_number":700,"context_line":"\t\t\tdefault:"},{"line_number":701,"context_line":"\t\t\t\tLOG_ERROR(\"BUG: unknown JTAG command type encountered\");"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"8ea51fcc_70ea9ac9","line":698,"in_reply_to":"8b4f71a5_5f81e0a9","updated":"2022-03-11 13:12:13.000000000","message":"Ack","commit_id":"abab47cd742d48a95e510774143284399ccfe20d"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"cbe11953b13f93a1f8993018963d3801aa4b1415","unresolved":false,"context_lines":[{"line_number":695,"context_line":"\t\t\t\tjtag_sleep(cmd-\u003ecmd.sleep-\u003eus);"},{"line_number":696,"context_line":"\t\t\t\tbreak;"},{"line_number":697,"context_line":"\t\t\tcase JTAG_TMS:"},{"line_number":698,"context_line":"\t\t\t\tretval \u003d xvc_tap_execute_tms(cmd);"},{"line_number":699,"context_line":"\t\t\t\tbreak;"},{"line_number":700,"context_line":"\t\t\tdefault:"},{"line_number":701,"context_line":"\t\t\t\tLOG_ERROR(\"BUG: unknown JTAG command type encountered\");"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"5a7bd823_973c565a","line":698,"in_reply_to":"8ea51fcc_70ea9ac9","updated":"2022-03-25 15:18:10.000000000","message":"Done","commit_id":"abab47cd742d48a95e510774143284399ccfe20d"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"735fabddcfa9d36538f18f9a90c3f1d521ad702d","unresolved":true,"context_lines":[{"line_number":704,"context_line":"\t\tcmd \u003d cmd-\u003enext;"},{"line_number":705,"context_line":"\t}"},{"line_number":706,"context_line":""},{"line_number":707,"context_line":"\txvc_flush();"},{"line_number":708,"context_line":"\txvc_fill_buffer();"},{"line_number":709,"context_line":""},{"line_number":710,"context_line":"\treturn retval;"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"8eb45cee_2a27f154","line":707,"updated":"2022-03-10 23:38:59.000000000","message":"this can return error. Should be checked","commit_id":"abab47cd742d48a95e510774143284399ccfe20d"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"cbe11953b13f93a1f8993018963d3801aa4b1415","unresolved":false,"context_lines":[{"line_number":704,"context_line":"\t\tcmd \u003d cmd-\u003enext;"},{"line_number":705,"context_line":"\t}"},{"line_number":706,"context_line":""},{"line_number":707,"context_line":"\txvc_flush();"},{"line_number":708,"context_line":"\txvc_fill_buffer();"},{"line_number":709,"context_line":""},{"line_number":710,"context_line":"\treturn retval;"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"175bd2b2_10ae416f","line":707,"in_reply_to":"00b4b9e8_1b735b23","updated":"2022-03-25 15:18:10.000000000","message":"Done","commit_id":"abab47cd742d48a95e510774143284399ccfe20d"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"12e553efad2f26a632ec23a1f57cf00d6b7456e0","unresolved":false,"context_lines":[{"line_number":704,"context_line":"\t\tcmd \u003d cmd-\u003enext;"},{"line_number":705,"context_line":"\t}"},{"line_number":706,"context_line":""},{"line_number":707,"context_line":"\txvc_flush();"},{"line_number":708,"context_line":"\txvc_fill_buffer();"},{"line_number":709,"context_line":""},{"line_number":710,"context_line":"\treturn retval;"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"00b4b9e8_1b735b23","line":707,"in_reply_to":"8eb45cee_2a27f154","updated":"2022-03-11 13:12:13.000000000","message":"Ack","commit_id":"abab47cd742d48a95e510774143284399ccfe20d"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"81eea0324bdd4f2eb21835b40377596e08ba9a57","unresolved":true,"context_lines":[{"line_number":1,"context_line":"/***************************************************************************"},{"line_number":2,"context_line":" *   Copyright (C) 2021 by Jose Borja Castillo, DTE-UMA                    *"},{"line_number":3,"context_line":" *   joscassan@uma.es                                                      *"},{"line_number":4,"context_line":" *                                                                         *"},{"line_number":5,"context_line":" *   Some parts of the code are inspired on both bitbang.c and jlink.c     *"},{"line_number":6,"context_line":" *   by Øyvind Harboe and Paul Fertser, respectively.                      *"},{"line_number":7,"context_line":" *                                                                         *"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"90e0b979_0002a559","line":4,"updated":"2022-05-01 22:22:00.000000000","message":"Please add in the comment that this code implements XVC protocol 1.0.\nAdd also a link to protocol description https://github.com/Xilinx/XilinxVirtualCable","commit_id":"02deec68dd383f6c9632b1845134fc1faa94a4ad"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"5a72491c4d44dc1ba22c485a441d0344e60c3bab","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/***************************************************************************"},{"line_number":2,"context_line":" *   Copyright (C) 2021 by Jose Borja Castillo, DTE-UMA                    *"},{"line_number":3,"context_line":" *   joscassan@uma.es                                                      *"},{"line_number":4,"context_line":" *                                                                         *"},{"line_number":5,"context_line":" *   Some parts of the code are inspired on both bitbang.c and jlink.c     *"},{"line_number":6,"context_line":" *   by Øyvind Harboe and Paul Fertser, respectively.                      *"},{"line_number":7,"context_line":" *                                                                         *"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"25e46562_536880d3","line":4,"in_reply_to":"90e0b979_0002a559","updated":"2022-05-03 11:26:18.000000000","message":"Done","commit_id":"02deec68dd383f6c9632b1845134fc1faa94a4ad"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"81eea0324bdd4f2eb21835b40377596e08ba9a57","unresolved":true,"context_lines":[{"line_number":78,"context_line":"static int xvc_quit(void);"},{"line_number":79,"context_line":"static int xvc_settck(void);"},{"line_number":80,"context_line":"static int xvc_tap_execute_queue(void);"},{"line_number":81,"context_line":"static int xvc_fill_buffer(void);"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"static unsigned int xvc_bits_to_bytes(unsigned int bits)"},{"line_number":84,"context_line":"{"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"7e3ace50_4be6e3b9","line":81,"updated":"2022-05-01 22:22:00.000000000","message":"The declarations of xvc_init, xvc_quit and xvc_tap_execute_queue are useless, can be removed.\nIf you reorder the code of xvc_settck and xvc_fill_buffer, also these last two declarations can be removed.","commit_id":"02deec68dd383f6c9632b1845134fc1faa94a4ad"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"5a72491c4d44dc1ba22c485a441d0344e60c3bab","unresolved":false,"context_lines":[{"line_number":78,"context_line":"static int xvc_quit(void);"},{"line_number":79,"context_line":"static int xvc_settck(void);"},{"line_number":80,"context_line":"static int xvc_tap_execute_queue(void);"},{"line_number":81,"context_line":"static int xvc_fill_buffer(void);"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"static unsigned int xvc_bits_to_bytes(unsigned int bits)"},{"line_number":84,"context_line":"{"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"6b08713b_b0ea16b8","line":81,"in_reply_to":"7e3ace50_4be6e3b9","updated":"2022-05-03 11:26:18.000000000","message":"Done","commit_id":"02deec68dd383f6c9632b1845134fc1faa94a4ad"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"81eea0324bdd4f2eb21835b40377596e08ba9a57","unresolved":true,"context_lines":[{"line_number":107,"context_line":"\treturn ERROR_OK;"},{"line_number":108,"context_line":"}"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"static int32_t read_frame(int sock_id, unsigned char *ptr, int32_t size)"},{"line_number":111,"context_line":"{"},{"line_number":112,"context_line":"\tint32_t state, i;"},{"line_number":113,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":4,"id":"b0086b17_d3281a63","line":110,"updated":"2022-05-01 22:22:00.000000000","message":"why you have int32_t for \"size\" and returned value?\nCan be return \"int\" and \"unsigned int size\"?","commit_id":"02deec68dd383f6c9632b1845134fc1faa94a4ad"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"5a72491c4d44dc1ba22c485a441d0344e60c3bab","unresolved":false,"context_lines":[{"line_number":107,"context_line":"\treturn ERROR_OK;"},{"line_number":108,"context_line":"}"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"static int32_t read_frame(int sock_id, unsigned char *ptr, int32_t size)"},{"line_number":111,"context_line":"{"},{"line_number":112,"context_line":"\tint32_t state, i;"},{"line_number":113,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":4,"id":"25ece4fd_a714d7e0","line":110,"in_reply_to":"b0086b17_d3281a63","updated":"2022-05-03 11:26:18.000000000","message":"Done","commit_id":"02deec68dd383f6c9632b1845134fc1faa94a4ad"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"81eea0324bdd4f2eb21835b40377596e08ba9a57","unresolved":true,"context_lines":[{"line_number":111,"context_line":"{"},{"line_number":112,"context_line":"\tint32_t state, i;"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"\ti \u003d size;"},{"line_number":115,"context_line":"\twhile (i \u003e 0) {"},{"line_number":116,"context_line":"\t\tstate \u003d read_socket(sock_id, ptr, i);"},{"line_number":117,"context_line":"\t\tif (state \u003e 0) {"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"2791b73a_cfec4e9c","line":114,"updated":"2022-05-01 22:22:00.000000000","message":"int32_t i \u003d size;\nor, in case, \"unsigned int\" (or maybe \"int\", due to signed/unsigned operations below)","commit_id":"02deec68dd383f6c9632b1845134fc1faa94a4ad"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"5a72491c4d44dc1ba22c485a441d0344e60c3bab","unresolved":false,"context_lines":[{"line_number":111,"context_line":"{"},{"line_number":112,"context_line":"\tint32_t state, i;"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"\ti \u003d size;"},{"line_number":115,"context_line":"\twhile (i \u003e 0) {"},{"line_number":116,"context_line":"\t\tstate \u003d read_socket(sock_id, ptr, i);"},{"line_number":117,"context_line":"\t\tif (state \u003e 0) {"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"d6919429_6d57a9f6","line":114,"in_reply_to":"2791b73a_cfec4e9c","updated":"2022-05-03 11:26:18.000000000","message":"Done","commit_id":"02deec68dd383f6c9632b1845134fc1faa94a4ad"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"81eea0324bdd4f2eb21835b40377596e08ba9a57","unresolved":true,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"\ti \u003d size;"},{"line_number":115,"context_line":"\twhile (i \u003e 0) {"},{"line_number":116,"context_line":"\t\tstate \u003d read_socket(sock_id, ptr, i);"},{"line_number":117,"context_line":"\t\tif (state \u003e 0) {"},{"line_number":118,"context_line":"\t\t\tptr +\u003d state;"},{"line_number":119,"context_line":"\t\t\ti -\u003d state;"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"1d16182b_1f267102","line":116,"updated":"2022-05-01 22:22:00.000000000","message":"int32_t state \u003d ...\nor, in case, \"int\"","commit_id":"02deec68dd383f6c9632b1845134fc1faa94a4ad"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"5a72491c4d44dc1ba22c485a441d0344e60c3bab","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"\ti \u003d size;"},{"line_number":115,"context_line":"\twhile (i \u003e 0) {"},{"line_number":116,"context_line":"\t\tstate \u003d read_socket(sock_id, ptr, i);"},{"line_number":117,"context_line":"\t\tif (state \u003e 0) {"},{"line_number":118,"context_line":"\t\t\tptr +\u003d state;"},{"line_number":119,"context_line":"\t\t\ti -\u003d state;"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"1ebe8205_e2278334","line":116,"in_reply_to":"1d16182b_1f267102","updated":"2022-05-03 11:26:18.000000000","message":"Done","commit_id":"02deec68dd383f6c9632b1845134fc1faa94a4ad"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"81eea0324bdd4f2eb21835b40377596e08ba9a57","unresolved":true,"context_lines":[{"line_number":278,"context_line":"\t\tLOG_ERROR(\"xvc_settck: read\");"},{"line_number":279,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":280,"context_line":"\t}"},{"line_number":281,"context_line":"\t/* Prints response, regardless of machine\u0027s endianess. */"},{"line_number":282,"context_line":"\tuint32_t xvc_tck_period_ns;"},{"line_number":283,"context_line":"\txvc_tck_period_ns \u003d le_to_h_u32((uint8_t *)\u0026tck_recv_buf);"},{"line_number":284,"context_line":"\tLOG_INFO(\"XVC tck period ns: %u\", xvc_tck_period_ns);"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"28f9e773_7dd69d92","line":281,"updated":"2022-05-01 22:22:00.000000000","message":"typo s/endianess/endianness/","commit_id":"02deec68dd383f6c9632b1845134fc1faa94a4ad"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"5a72491c4d44dc1ba22c485a441d0344e60c3bab","unresolved":false,"context_lines":[{"line_number":278,"context_line":"\t\tLOG_ERROR(\"xvc_settck: read\");"},{"line_number":279,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":280,"context_line":"\t}"},{"line_number":281,"context_line":"\t/* Prints response, regardless of machine\u0027s endianess. */"},{"line_number":282,"context_line":"\tuint32_t xvc_tck_period_ns;"},{"line_number":283,"context_line":"\txvc_tck_period_ns \u003d le_to_h_u32((uint8_t *)\u0026tck_recv_buf);"},{"line_number":284,"context_line":"\tLOG_INFO(\"XVC tck period ns: %u\", xvc_tck_period_ns);"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"5829b67f_f8347cf7","line":281,"in_reply_to":"28f9e773_7dd69d92","updated":"2022-05-03 11:26:18.000000000","message":"Done","commit_id":"02deec68dd383f6c9632b1845134fc1faa94a4ad"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"81eea0324bdd4f2eb21835b40377596e08ba9a57","unresolved":true,"context_lines":[{"line_number":423,"context_line":" * mode: possible values are COMMAND_EXEC, COMMAND_CONFIG, COMMAND_ANY."},{"line_number":424,"context_line":" * help: displays some useful help"},{"line_number":425,"context_line":" * usage: prints the correct usage."},{"line_number":426,"context_line":" * */"},{"line_number":427,"context_line":"static const struct command_registration xvc_command_handlers[] \u003d {"},{"line_number":428,"context_line":"{"},{"line_number":429,"context_line":"\t.name \u003d \"xvc_port\","}],"source_content_type":"text/x-csrc","patch_set":4,"id":"a2eba6e7_0b93d06c","line":426,"updated":"2022-05-01 22:22:00.000000000","message":"I think this comment can be removed","commit_id":"02deec68dd383f6c9632b1845134fc1faa94a4ad"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"5a72491c4d44dc1ba22c485a441d0344e60c3bab","unresolved":false,"context_lines":[{"line_number":423,"context_line":" * mode: possible values are COMMAND_EXEC, COMMAND_CONFIG, COMMAND_ANY."},{"line_number":424,"context_line":" * help: displays some useful help"},{"line_number":425,"context_line":" * usage: prints the correct usage."},{"line_number":426,"context_line":" * */"},{"line_number":427,"context_line":"static const struct command_registration xvc_command_handlers[] \u003d {"},{"line_number":428,"context_line":"{"},{"line_number":429,"context_line":"\t.name \u003d \"xvc_port\","}],"source_content_type":"text/x-csrc","patch_set":4,"id":"ebd6b208_f29befa8","line":426,"in_reply_to":"a2eba6e7_0b93d06c","updated":"2022-05-03 11:26:18.000000000","message":"Done","commit_id":"02deec68dd383f6c9632b1845134fc1faa94a4ad"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"81eea0324bdd4f2eb21835b40377596e08ba9a57","unresolved":true,"context_lines":[{"line_number":425,"context_line":" * usage: prints the correct usage."},{"line_number":426,"context_line":" * */"},{"line_number":427,"context_line":"static const struct command_registration xvc_command_handlers[] \u003d {"},{"line_number":428,"context_line":"{"},{"line_number":429,"context_line":"\t.name \u003d \"xvc_port\","},{"line_number":430,"context_line":"\t.handler \u003d xvc_handle_port_command,"},{"line_number":431,"context_line":"\t.mode \u003d COMMAND_CONFIG,"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"1e0f49a5_d5e80c73","line":428,"updated":"2022-05-01 22:22:00.000000000","message":"increment the indentation of one TAB","commit_id":"02deec68dd383f6c9632b1845134fc1faa94a4ad"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"5a72491c4d44dc1ba22c485a441d0344e60c3bab","unresolved":false,"context_lines":[{"line_number":425,"context_line":" * usage: prints the correct usage."},{"line_number":426,"context_line":" * */"},{"line_number":427,"context_line":"static const struct command_registration xvc_command_handlers[] \u003d {"},{"line_number":428,"context_line":"{"},{"line_number":429,"context_line":"\t.name \u003d \"xvc_port\","},{"line_number":430,"context_line":"\t.handler \u003d xvc_handle_port_command,"},{"line_number":431,"context_line":"\t.mode \u003d COMMAND_CONFIG,"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"044843e5_703e05b9","line":428,"in_reply_to":"1e0f49a5_d5e80c73","updated":"2022-05-03 11:26:18.000000000","message":"Done","commit_id":"02deec68dd383f6c9632b1845134fc1faa94a4ad"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"81eea0324bdd4f2eb21835b40377596e08ba9a57","unresolved":true,"context_lines":[{"line_number":439,"context_line":"\t.handler \u003d xvc_handle_host_command,"},{"line_number":440,"context_line":"\t.mode \u003d COMMAND_CONFIG,"},{"line_number":441,"context_line":"\t.help \u003d \"Set the host to use to connect to the remote XVC server.\\n\""},{"line_number":442,"context_line":"\t\t\t\" If port is 0 or unset, this is the name of the unix socket \""},{"line_number":443,"context_line":"\t\t\t\"to use.\","},{"line_number":444,"context_line":"\t.usage \u003d \"host_name\","},{"line_number":445,"context_line":"},"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"5eb70810_70ac1be3","line":442,"updated":"2022-05-01 22:22:00.000000000","message":"this is the help for host, not for port!","commit_id":"02deec68dd383f6c9632b1845134fc1faa94a4ad"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"5a72491c4d44dc1ba22c485a441d0344e60c3bab","unresolved":false,"context_lines":[{"line_number":439,"context_line":"\t.handler \u003d xvc_handle_host_command,"},{"line_number":440,"context_line":"\t.mode \u003d COMMAND_CONFIG,"},{"line_number":441,"context_line":"\t.help \u003d \"Set the host to use to connect to the remote XVC server.\\n\""},{"line_number":442,"context_line":"\t\t\t\" If port is 0 or unset, this is the name of the unix socket \""},{"line_number":443,"context_line":"\t\t\t\"to use.\","},{"line_number":444,"context_line":"\t.usage \u003d \"host_name\","},{"line_number":445,"context_line":"},"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"d7bb5d0d_4055a850","line":442,"in_reply_to":"5eb70810_70ac1be3","updated":"2022-05-03 11:26:18.000000000","message":"Done","commit_id":"02deec68dd383f6c9632b1845134fc1faa94a4ad"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"81eea0324bdd4f2eb21835b40377596e08ba9a57","unresolved":true,"context_lines":[{"line_number":587,"context_line":"\treturn ERROR_OK;"},{"line_number":588,"context_line":"}"},{"line_number":589,"context_line":""},{"line_number":590,"context_line":"static int xvc_tap_scan_write(struct scan_command cmd, bool *read_required)"},{"line_number":591,"context_line":"{"},{"line_number":592,"context_line":"\t/* Make sure there are no trailing fields with num_bits \u003d\u003d 0, or the logic"},{"line_number":593,"context_line":"\t * below will fail. */"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"395c799b_823db59d","line":590,"updated":"2022-05-01 22:22:00.000000000","message":"What is \"read_required\" used for? Not used by either caller not called function.\nCan be removed?\n\nAnd no, please, don\u0027t pass a struct as argument of a function! It will \"copy\" the struct in stack!\nAlways pass the pointer! In this case it can be:\n static int xvc_tap_scan_write(struct jtag_command *cmd)\nand below the caller becomes\n xvc_tap_scan_write(cmd)","commit_id":"02deec68dd383f6c9632b1845134fc1faa94a4ad"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"5a72491c4d44dc1ba22c485a441d0344e60c3bab","unresolved":false,"context_lines":[{"line_number":587,"context_line":"\treturn ERROR_OK;"},{"line_number":588,"context_line":"}"},{"line_number":589,"context_line":""},{"line_number":590,"context_line":"static int xvc_tap_scan_write(struct scan_command cmd, bool *read_required)"},{"line_number":591,"context_line":"{"},{"line_number":592,"context_line":"\t/* Make sure there are no trailing fields with num_bits \u003d\u003d 0, or the logic"},{"line_number":593,"context_line":"\t * below will fail. */"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"76921d4d_1da947bb","line":590,"in_reply_to":"395c799b_823db59d","updated":"2022-05-03 11:26:18.000000000","message":"Done.","commit_id":"02deec68dd383f6c9632b1845134fc1faa94a4ad"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"81eea0324bdd4f2eb21835b40377596e08ba9a57","unresolved":true,"context_lines":[{"line_number":615,"context_line":"\txvc_tap_end_state(cmd.end_state);"},{"line_number":616,"context_line":""},{"line_number":617,"context_line":"\tfor (int i \u003d 0; i \u003c cmd.num_fields; i++) {"},{"line_number":618,"context_line":"\t\tif (cmd.fields[i].in_value)"},{"line_number":619,"context_line":"\t\t\t*read_required \u003d true;"},{"line_number":620,"context_line":""},{"line_number":621,"context_line":"\t\t/*"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"3da554bc_ef47e255","line":618,"updated":"2022-05-01 22:22:00.000000000","message":"as in jlink code, use something like:\n struct scan_field *field \u003d cmd.fields;\n for (int i \u003d 0; i \u003c cmd.num_fields; i++, field++) {\n   if (field-\u003ein_value)\nand always use \"field-\u003ewhatever\". This will greatly speed up the execution by removing reading from pointer of pointer.","commit_id":"02deec68dd383f6c9632b1845134fc1faa94a4ad"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"5a72491c4d44dc1ba22c485a441d0344e60c3bab","unresolved":false,"context_lines":[{"line_number":615,"context_line":"\txvc_tap_end_state(cmd.end_state);"},{"line_number":616,"context_line":""},{"line_number":617,"context_line":"\tfor (int i \u003d 0; i \u003c cmd.num_fields; i++) {"},{"line_number":618,"context_line":"\t\tif (cmd.fields[i].in_value)"},{"line_number":619,"context_line":"\t\t\t*read_required \u003d true;"},{"line_number":620,"context_line":""},{"line_number":621,"context_line":"\t\t/*"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"9417d7c0_685cdc72","line":618,"in_reply_to":"3da554bc_ef47e255","updated":"2022-05-03 11:26:18.000000000","message":"Done","commit_id":"02deec68dd383f6c9632b1845134fc1faa94a4ad"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"81eea0324bdd4f2eb21835b40377596e08ba9a57","unresolved":true,"context_lines":[{"line_number":722,"context_line":"}"},{"line_number":723,"context_line":""},{"line_number":724,"context_line":"static struct jtag_interface xvc_interface \u003d {"},{"line_number":725,"context_line":"\t\t.execute_queue \u003d \u0026xvc_tap_execute_queue,"},{"line_number":726,"context_line":"\t\t.supported \u003d DEBUG_CAP_TMS_SEQ,"},{"line_number":727,"context_line":"};"},{"line_number":728,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":4,"id":"2f0f60dc_6714ec81","line":725,"updated":"2022-05-01 22:22:00.000000000","message":"single TAB indentation","commit_id":"02deec68dd383f6c9632b1845134fc1faa94a4ad"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"5a72491c4d44dc1ba22c485a441d0344e60c3bab","unresolved":false,"context_lines":[{"line_number":722,"context_line":"}"},{"line_number":723,"context_line":""},{"line_number":724,"context_line":"static struct jtag_interface xvc_interface \u003d {"},{"line_number":725,"context_line":"\t\t.execute_queue \u003d \u0026xvc_tap_execute_queue,"},{"line_number":726,"context_line":"\t\t.supported \u003d DEBUG_CAP_TMS_SEQ,"},{"line_number":727,"context_line":"};"},{"line_number":728,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":4,"id":"ab329fed_f8a3fb4e","line":725,"in_reply_to":"2f0f60dc_6714ec81","updated":"2022-05-03 11:26:18.000000000","message":"Done","commit_id":"02deec68dd383f6c9632b1845134fc1faa94a4ad"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"81eea0324bdd4f2eb21835b40377596e08ba9a57","unresolved":true,"context_lines":[{"line_number":727,"context_line":"};"},{"line_number":728,"context_line":""},{"line_number":729,"context_line":"struct adapter_driver xvc_driver \u003d {"},{"line_number":730,"context_line":"\t\t.name \u003d \"xvc\","},{"line_number":731,"context_line":"\t\t.transports \u003d jtag_only,"},{"line_number":732,"context_line":"\t\t.commands \u003d xvc_command_handlers,"},{"line_number":733,"context_line":"\t\t.init \u003d xvc_init,"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"fbb3dacb_9ee0627d","line":730,"updated":"2022-05-01 22:22:00.000000000","message":"single TAB indentation","commit_id":"02deec68dd383f6c9632b1845134fc1faa94a4ad"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"5a72491c4d44dc1ba22c485a441d0344e60c3bab","unresolved":false,"context_lines":[{"line_number":727,"context_line":"};"},{"line_number":728,"context_line":""},{"line_number":729,"context_line":"struct adapter_driver xvc_driver \u003d {"},{"line_number":730,"context_line":"\t\t.name \u003d \"xvc\","},{"line_number":731,"context_line":"\t\t.transports \u003d jtag_only,"},{"line_number":732,"context_line":"\t\t.commands \u003d xvc_command_handlers,"},{"line_number":733,"context_line":"\t\t.init \u003d xvc_init,"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"eb87945e_ec377bfb","line":730,"in_reply_to":"fbb3dacb_9ee0627d","updated":"2022-05-03 11:26:18.000000000","message":"Done","commit_id":"02deec68dd383f6c9632b1845134fc1faa94a4ad"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3e3a2d99541495334c133a5abf70cd89d7dcd945","unresolved":true,"context_lines":[{"line_number":1,"context_line":"/***************************************************************************"},{"line_number":2,"context_line":" *   Copyright (C) 2021 by Jose Borja Castillo, DTE-UMA                    *"},{"line_number":3,"context_line":" *   joscassan@uma.es                                                      *"},{"line_number":4,"context_line":" *                                                                         *"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"168fa006_2e561bce","line":1,"updated":"2023-08-24 15:14:54.000000000","message":"we have switched to SPDX tags for the license.\nPlease add as very first line:\n// SPDX-License-Identifier: GPL-2.0-or-later","commit_id":"5c43675291340f79ac45dfb1622d1719342f845e"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"8eecdbf10770bb1e7cdb3d0f2f01712a034fb51f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/***************************************************************************"},{"line_number":2,"context_line":" *   Copyright (C) 2021 by Jose Borja Castillo, DTE-UMA                    *"},{"line_number":3,"context_line":" *   joscassan@uma.es                                                      *"},{"line_number":4,"context_line":" *                                                                         *"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"bcc01d3c_0af9ae24","line":1,"in_reply_to":"168fa006_2e561bce","updated":"2023-12-22 13:18:42.000000000","message":"Done","commit_id":"5c43675291340f79ac45dfb1622d1719342f845e"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3e3a2d99541495334c133a5abf70cd89d7dcd945","unresolved":true,"context_lines":[{"line_number":7,"context_line":" *   Some parts of the code are inspired on both bitbang.c and jlink.c     *"},{"line_number":8,"context_line":" *   by Øyvind Harboe and Paul Fertser, respectively.                      *"},{"line_number":9,"context_line":" *                                                                         *"},{"line_number":10,"context_line":" *   This program is free software; you can redistribute it and/or modify  *"},{"line_number":11,"context_line":" *   it under the terms of the GNU General Public License as published by  *"},{"line_number":12,"context_line":" *   the Free Software Foundation; either version 2 of the License, or     *"},{"line_number":13,"context_line":" *   (at your option) any later version.                                   *"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"3677c024_73a10e54","line":10,"updated":"2023-08-24 15:14:54.000000000","message":"With the added SPDX tag, all the text from this line till the end of this comment at line 21 can be dropped.","commit_id":"5c43675291340f79ac45dfb1622d1719342f845e"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"8eecdbf10770bb1e7cdb3d0f2f01712a034fb51f","unresolved":false,"context_lines":[{"line_number":7,"context_line":" *   Some parts of the code are inspired on both bitbang.c and jlink.c     *"},{"line_number":8,"context_line":" *   by Øyvind Harboe and Paul Fertser, respectively.                      *"},{"line_number":9,"context_line":" *                                                                         *"},{"line_number":10,"context_line":" *   This program is free software; you can redistribute it and/or modify  *"},{"line_number":11,"context_line":" *   it under the terms of the GNU General Public License as published by  *"},{"line_number":12,"context_line":" *   the Free Software Foundation; either version 2 of the License, or     *"},{"line_number":13,"context_line":" *   (at your option) any later version.                                   *"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"dafcf377_1623b383","line":10,"in_reply_to":"3677c024_73a10e54","updated":"2023-12-22 13:18:42.000000000","message":"Done","commit_id":"5c43675291340f79ac45dfb1622d1719342f845e"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3e3a2d99541495334c133a5abf70cd89d7dcd945","unresolved":true,"context_lines":[{"line_number":82,"context_line":"/* Auxiliary and TCL helper functions*/"},{"line_number":83,"context_line":"static unsigned int xvc_bits_to_bytes(unsigned int bits)"},{"line_number":84,"context_line":"{"},{"line_number":85,"context_line":"\treturn (bits + 7) / 8;"},{"line_number":86,"context_line":"}"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"static int xvc_speed(int speed)"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"ce2a8794_b4849940","line":85,"updated":"2023-08-24 15:14:54.000000000","message":"return DIV_ROUND_UP(bits, 8);","commit_id":"5c43675291340f79ac45dfb1622d1719342f845e"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"8eecdbf10770bb1e7cdb3d0f2f01712a034fb51f","unresolved":false,"context_lines":[{"line_number":82,"context_line":"/* Auxiliary and TCL helper functions*/"},{"line_number":83,"context_line":"static unsigned int xvc_bits_to_bytes(unsigned int bits)"},{"line_number":84,"context_line":"{"},{"line_number":85,"context_line":"\treturn (bits + 7) / 8;"},{"line_number":86,"context_line":"}"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"static int xvc_speed(int speed)"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"ec25b182_f6a1af26","line":85,"in_reply_to":"ce2a8794_b4849940","updated":"2023-12-22 13:18:42.000000000","message":"Done","commit_id":"5c43675291340f79ac45dfb1622d1719342f845e"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3e3a2d99541495334c133a5abf70cd89d7dcd945","unresolved":true,"context_lines":[{"line_number":428,"context_line":"\t\t.name \u003d \"xvc_host\","},{"line_number":429,"context_line":"\t\t.handler \u003d xvc_handle_host_command,"},{"line_number":430,"context_line":"\t\t.mode \u003d COMMAND_CONFIG,"},{"line_number":431,"context_line":"\t\t.help \u003d \"Set the host to use to connect to the remote XVC server.\\n\","},{"line_number":432,"context_line":"\t\t.usage \u003d \"host_name\","},{"line_number":433,"context_line":"\t},"},{"line_number":434,"context_line":"\tCOMMAND_REGISTRATION_DONE"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"5d2ee16c_a3359a54","line":431,"updated":"2023-08-24 15:14:54.000000000","message":"please remove the \"\\n\" at the end of the string","commit_id":"5c43675291340f79ac45dfb1622d1719342f845e"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"8eecdbf10770bb1e7cdb3d0f2f01712a034fb51f","unresolved":false,"context_lines":[{"line_number":428,"context_line":"\t\t.name \u003d \"xvc_host\","},{"line_number":429,"context_line":"\t\t.handler \u003d xvc_handle_host_command,"},{"line_number":430,"context_line":"\t\t.mode \u003d COMMAND_CONFIG,"},{"line_number":431,"context_line":"\t\t.help \u003d \"Set the host to use to connect to the remote XVC server.\\n\","},{"line_number":432,"context_line":"\t\t.usage \u003d \"host_name\","},{"line_number":433,"context_line":"\t},"},{"line_number":434,"context_line":"\tCOMMAND_REGISTRATION_DONE"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"757b906b_ad8a9fef","line":431,"in_reply_to":"5d2ee16c_a3359a54","updated":"2023-12-22 13:18:42.000000000","message":"Done","commit_id":"5c43675291340f79ac45dfb1622d1719342f845e"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3e3a2d99541495334c133a5abf70cd89d7dcd945","unresolved":true,"context_lines":[{"line_number":683,"context_line":"\t\t\tbreak;"},{"line_number":684,"context_line":"\t\tcase JTAG_SLEEP:"},{"line_number":685,"context_line":"\t\t\tLOG_DEBUG_IO(\"sleep %\" PRIi32, cmd-\u003ecmd.sleep-\u003eus);"},{"line_number":686,"context_line":"\t\t\tjtag_sleep(cmd-\u003ecmd.sleep-\u003eus);"},{"line_number":687,"context_line":"\t\t\tbreak;"},{"line_number":688,"context_line":"\t\tcase JTAG_TMS:"},{"line_number":689,"context_line":"\t\t\tif (xvc_tap_execute_tms(cmd) !\u003d ERROR_OK)"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"d65aa194_82bff870","line":686,"updated":"2023-08-24 15:14:54.000000000","message":"JTAG_SLEEP is a way to ask the adapter to insert a delay between two JTAG commands.\nXVC doesn\u0027t know how to add a delay, so it calls jtag_sleep(). OK!\nBut you are handling a FIFO, so you need to flush the FIFO before jtag_sleep(), otherwise you risk to have previous and next JTAG command injected in the FIFO with a delay in between, but executed with no delay in between when you flush the FIFO later on.","commit_id":"5c43675291340f79ac45dfb1622d1719342f845e"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"ca0ad591b519469b89003821b14ff82b68be5b3a","unresolved":true,"context_lines":[{"line_number":683,"context_line":"\t\t\tbreak;"},{"line_number":684,"context_line":"\t\tcase JTAG_SLEEP:"},{"line_number":685,"context_line":"\t\t\tLOG_DEBUG_IO(\"sleep %\" PRIi32, cmd-\u003ecmd.sleep-\u003eus);"},{"line_number":686,"context_line":"\t\t\tjtag_sleep(cmd-\u003ecmd.sleep-\u003eus);"},{"line_number":687,"context_line":"\t\t\tbreak;"},{"line_number":688,"context_line":"\t\tcase JTAG_TMS:"},{"line_number":689,"context_line":"\t\t\tif (xvc_tap_execute_tms(cmd) !\u003d ERROR_OK)"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"b13737b4_3ebeb43b","line":686,"in_reply_to":"44d9903f_a94c7309","updated":"2023-12-28 15:56:02.000000000","message":"you haven\u0027t added the FIFO flush before calling jtag_sleep()\nAm I missing it?","commit_id":"5c43675291340f79ac45dfb1622d1719342f845e"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"9044a6ef1e155ebc2e4150761f3faa004604f70d","unresolved":false,"context_lines":[{"line_number":683,"context_line":"\t\t\tbreak;"},{"line_number":684,"context_line":"\t\tcase JTAG_SLEEP:"},{"line_number":685,"context_line":"\t\t\tLOG_DEBUG_IO(\"sleep %\" PRIi32, cmd-\u003ecmd.sleep-\u003eus);"},{"line_number":686,"context_line":"\t\t\tjtag_sleep(cmd-\u003ecmd.sleep-\u003eus);"},{"line_number":687,"context_line":"\t\t\tbreak;"},{"line_number":688,"context_line":"\t\tcase JTAG_TMS:"},{"line_number":689,"context_line":"\t\t\tif (xvc_tap_execute_tms(cmd) !\u003d ERROR_OK)"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"de0a66a6_72e6a5b3","line":686,"in_reply_to":"b13737b4_3ebeb43b","updated":"2024-01-25 10:45:02.000000000","message":"You are right, I forgot to change it. Sorry for this.","commit_id":"5c43675291340f79ac45dfb1622d1719342f845e"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"8eecdbf10770bb1e7cdb3d0f2f01712a034fb51f","unresolved":false,"context_lines":[{"line_number":683,"context_line":"\t\t\tbreak;"},{"line_number":684,"context_line":"\t\tcase JTAG_SLEEP:"},{"line_number":685,"context_line":"\t\t\tLOG_DEBUG_IO(\"sleep %\" PRIi32, cmd-\u003ecmd.sleep-\u003eus);"},{"line_number":686,"context_line":"\t\t\tjtag_sleep(cmd-\u003ecmd.sleep-\u003eus);"},{"line_number":687,"context_line":"\t\t\tbreak;"},{"line_number":688,"context_line":"\t\tcase JTAG_TMS:"},{"line_number":689,"context_line":"\t\t\tif (xvc_tap_execute_tms(cmd) !\u003d ERROR_OK)"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"44d9903f_a94c7309","line":686,"in_reply_to":"d65aa194_82bff870","updated":"2023-12-22 13:18:42.000000000","message":"Ack","commit_id":"5c43675291340f79ac45dfb1622d1719342f845e"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"ca0ad591b519469b89003821b14ff82b68be5b3a","unresolved":true,"context_lines":[{"line_number":3,"context_line":" *   Copyright (C) 2021 by Jose Borja Castillo, DTE-UMA                    *"},{"line_number":4,"context_line":" *   joscassan@uma.es                                                      *"},{"line_number":5,"context_line":" *                                                                         *"},{"line_number":6,"context_line":" *   This implementation is XVC protocol 1.0 only, does not support        *"},{"line_number":7,"context_line":" *   1.1 extension.                                                        *"},{"line_number":8,"context_line":" *   Some parts of the code are inspired on both bitbang and jlink         *"},{"line_number":9,"context_line":" *   by Øyvind Harboe and Paul Fertser, respectively.                      *"}],"source_content_type":"text/x-csrc","patch_set":8,"id":"b6c62285_1c52d005","line":6,"updated":"2023-12-28 15:56:02.000000000","message":"also here, look for a way to say that it works with both 1.0 and 1.1 servers, even if it does not use nor support the 1.1 extensions","commit_id":"b3875e3a2ea7777eec246d5bdeab9d23b8f01cc5"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"9044a6ef1e155ebc2e4150761f3faa004604f70d","unresolved":false,"context_lines":[{"line_number":3,"context_line":" *   Copyright (C) 2021 by Jose Borja Castillo, DTE-UMA                    *"},{"line_number":4,"context_line":" *   joscassan@uma.es                                                      *"},{"line_number":5,"context_line":" *                                                                         *"},{"line_number":6,"context_line":" *   This implementation is XVC protocol 1.0 only, does not support        *"},{"line_number":7,"context_line":" *   1.1 extension.                                                        *"},{"line_number":8,"context_line":" *   Some parts of the code are inspired on both bitbang and jlink         *"},{"line_number":9,"context_line":" *   by Øyvind Harboe and Paul Fertser, respectively.                      *"}],"source_content_type":"text/x-csrc","patch_set":8,"id":"d93d32bd_29d4b564","line":6,"in_reply_to":"b6c62285_1c52d005","updated":"2024-01-25 10:45:02.000000000","message":"Done","commit_id":"b3875e3a2ea7777eec246d5bdeab9d23b8f01cc5"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"ca0ad591b519469b89003821b14ff82b68be5b3a","unresolved":true,"context_lines":[{"line_number":95,"context_line":"\treturn ERROR_OK;"},{"line_number":96,"context_line":"}"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"static int read_frame(int sock_id, unsigned char *ptr, int32_t size)"},{"line_number":99,"context_line":"{"},{"line_number":100,"context_line":"\tint32_t i \u003d size;"},{"line_number":101,"context_line":"\twhile (i \u003e 0) {"}],"source_content_type":"text/x-csrc","patch_set":8,"id":"4608157f_e47c5972","line":98,"updated":"2023-12-28 15:56:02.000000000","message":"We use int32_t and similar types only when the OpenOCD variable has to match the size of a value on the target of in some register.\nHere \u0027size\u0027 can be int","commit_id":"b3875e3a2ea7777eec246d5bdeab9d23b8f01cc5"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"9044a6ef1e155ebc2e4150761f3faa004604f70d","unresolved":false,"context_lines":[{"line_number":95,"context_line":"\treturn ERROR_OK;"},{"line_number":96,"context_line":"}"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"static int read_frame(int sock_id, unsigned char *ptr, int32_t size)"},{"line_number":99,"context_line":"{"},{"line_number":100,"context_line":"\tint32_t i \u003d size;"},{"line_number":101,"context_line":"\twhile (i \u003e 0) {"}],"source_content_type":"text/x-csrc","patch_set":8,"id":"88d9b48a_04c7a607","line":98,"in_reply_to":"4608157f_e47c5972","updated":"2024-01-25 10:45:02.000000000","message":"I don\u0027t think this should be harmful but now it is changed to \u0027int\u0027.","commit_id":"b3875e3a2ea7777eec246d5bdeab9d23b8f01cc5"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"ca0ad591b519469b89003821b14ff82b68be5b3a","unresolved":true,"context_lines":[{"line_number":211,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":212,"context_line":"\t}"},{"line_number":213,"context_line":"\tLOG_INFO(\"XVC HW server version: %.19s\", info_recv_buf);"},{"line_number":214,"context_line":"\tif (strncmp(info_recv_buf, \"xvcServer_v1.0:\", 15) !\u003d 0) {"},{"line_number":215,"context_line":"\t\t/* We got something unexpected. */"},{"line_number":216,"context_line":"\t\tLOG_ERROR(\"Unexpected response from XVC server\");"},{"line_number":217,"context_line":"\t\treturn ERROR_FAIL;"}],"source_content_type":"text/x-csrc","patch_set":8,"id":"c2ca59f8_ccbb8738","line":214,"updated":"2023-12-28 15:56:02.000000000","message":"Your code supports talking with server v1.1\nShould this check be improved?","commit_id":"b3875e3a2ea7777eec246d5bdeab9d23b8f01cc5"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"9044a6ef1e155ebc2e4150761f3faa004604f70d","unresolved":false,"context_lines":[{"line_number":211,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":212,"context_line":"\t}"},{"line_number":213,"context_line":"\tLOG_INFO(\"XVC HW server version: %.19s\", info_recv_buf);"},{"line_number":214,"context_line":"\tif (strncmp(info_recv_buf, \"xvcServer_v1.0:\", 15) !\u003d 0) {"},{"line_number":215,"context_line":"\t\t/* We got something unexpected. */"},{"line_number":216,"context_line":"\t\tLOG_ERROR(\"Unexpected response from XVC server\");"},{"line_number":217,"context_line":"\t\treturn ERROR_FAIL;"}],"source_content_type":"text/x-csrc","patch_set":8,"id":"7b04c2e7_294ec5b9","line":214,"in_reply_to":"c2ca59f8_ccbb8738","updated":"2024-01-25 10:45:02.000000000","message":"Done","commit_id":"b3875e3a2ea7777eec246d5bdeab9d23b8f01cc5"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"ca0ad591b519469b89003821b14ff82b68be5b3a","unresolved":true,"context_lines":[{"line_number":218,"context_line":"\t}"},{"line_number":219,"context_line":"\txvc_max_usable_vector_size \u003d strtoul(\u0026info_recv_buf[15], NULL, 10);"},{"line_number":220,"context_line":"\tif (xvc_max_usable_vector_size \u003e 32757) {"},{"line_number":221,"context_line":"\t\tLOG_DEBUG(\"Exceeded maximum vector size, outputting to 32757 bytes\");"},{"line_number":222,"context_line":"\t\txvc_max_usable_vector_size \u003d 32757;"},{"line_number":223,"context_line":"\t}"},{"line_number":224,"context_line":"\txvc_max_vector_size \u003d xvc_max_usable_vector_size + 10;"}],"source_content_type":"text/x-csrc","patch_set":8,"id":"f16d1be5_53529b84","line":221,"updated":"2023-12-28 15:56:02.000000000","message":"what about \u0027limit it to 32757\u0027 ?","commit_id":"b3875e3a2ea7777eec246d5bdeab9d23b8f01cc5"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"9044a6ef1e155ebc2e4150761f3faa004604f70d","unresolved":false,"context_lines":[{"line_number":218,"context_line":"\t}"},{"line_number":219,"context_line":"\txvc_max_usable_vector_size \u003d strtoul(\u0026info_recv_buf[15], NULL, 10);"},{"line_number":220,"context_line":"\tif (xvc_max_usable_vector_size \u003e 32757) {"},{"line_number":221,"context_line":"\t\tLOG_DEBUG(\"Exceeded maximum vector size, outputting to 32757 bytes\");"},{"line_number":222,"context_line":"\t\txvc_max_usable_vector_size \u003d 32757;"},{"line_number":223,"context_line":"\t}"},{"line_number":224,"context_line":"\txvc_max_vector_size \u003d xvc_max_usable_vector_size + 10;"}],"source_content_type":"text/x-csrc","patch_set":8,"id":"c3ea9875_dd9eb5ce","line":221,"in_reply_to":"f16d1be5_53529b84","updated":"2024-01-25 10:45:02.000000000","message":"This was a moreless arbitrary limit in the sense of \u0027it does not make sense to have a buffer larger than that if the target probe is likely to be a microcontroller\u0027. However, just like it is now commented in the code, OpenOCD write_socket functions accept a 16/32 bit long size parameter. In this case, it also makes sense to have a limit around this value.","commit_id":"b3875e3a2ea7777eec246d5bdeab9d23b8f01cc5"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"ca0ad591b519469b89003821b14ff82b68be5b3a","unresolved":true,"context_lines":[{"line_number":273,"context_line":""},{"line_number":274,"context_line":"static int xvc_fill_buffer(void)"},{"line_number":275,"context_line":"{"},{"line_number":276,"context_line":"\tif (read_frame(xvc_fd, xvc_tdo_buf, (7 + last_used_bits) / 8) \u003c 0) {"},{"line_number":277,"context_line":"\t\tLOG_ERROR(\"Read_frame\");"},{"line_number":278,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":279,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":8,"id":"57cb1b76_e3eae351","line":276,"updated":"2023-12-28 15:56:02.000000000","message":"if (read_frame(xvc_fd, xvc_tdo_buf, DIV_ROUND_UP(last_used_bits, 8)) \u003c 0) {","commit_id":"b3875e3a2ea7777eec246d5bdeab9d23b8f01cc5"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"9044a6ef1e155ebc2e4150761f3faa004604f70d","unresolved":false,"context_lines":[{"line_number":273,"context_line":""},{"line_number":274,"context_line":"static int xvc_fill_buffer(void)"},{"line_number":275,"context_line":"{"},{"line_number":276,"context_line":"\tif (read_frame(xvc_fd, xvc_tdo_buf, (7 + last_used_bits) / 8) \u003c 0) {"},{"line_number":277,"context_line":"\t\tLOG_ERROR(\"Read_frame\");"},{"line_number":278,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":279,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":8,"id":"e445c8ea_e60ab530","line":276,"in_reply_to":"57cb1b76_e3eae351","updated":"2024-01-25 10:45:02.000000000","message":"Done","commit_id":"b3875e3a2ea7777eec246d5bdeab9d23b8f01cc5"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"ca0ad591b519469b89003821b14ff82b68be5b3a","unresolved":true,"context_lines":[{"line_number":441,"context_line":"\txvc_getinfo();"},{"line_number":442,"context_line":"\txvc_settck();"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"\tLOG_INFO(\"XVC driver initialized\");"},{"line_number":445,"context_line":""},{"line_number":446,"context_line":"\treturn ERROR_OK;"},{"line_number":447,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":8,"id":"1335ac3f_1b9dd2fb","line":444,"updated":"2023-12-28 15:56:02.000000000","message":"Not really useful to have LOG_INFO() both at beginning and at the end of this function.\nWhat about changing this with LOG_DEBUG() ?","commit_id":"b3875e3a2ea7777eec246d5bdeab9d23b8f01cc5"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"9044a6ef1e155ebc2e4150761f3faa004604f70d","unresolved":false,"context_lines":[{"line_number":441,"context_line":"\txvc_getinfo();"},{"line_number":442,"context_line":"\txvc_settck();"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"\tLOG_INFO(\"XVC driver initialized\");"},{"line_number":445,"context_line":""},{"line_number":446,"context_line":"\treturn ERROR_OK;"},{"line_number":447,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":8,"id":"78d930d3_458c9fb3","line":444,"in_reply_to":"1335ac3f_1b9dd2fb","updated":"2024-01-25 10:45:02.000000000","message":"Done","commit_id":"b3875e3a2ea7777eec246d5bdeab9d23b8f01cc5"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"0ee476617c076811187856a5e1f23cc527746e32","unresolved":true,"context_lines":[{"line_number":107,"context_line":"\tunsigned int i \u003d size;"},{"line_number":108,"context_line":"\twhile (i \u003e 0) {"},{"line_number":109,"context_line":"\t\tint state \u003d read_socket(sock_id, ptr, i);"},{"line_number":110,"context_line":"\t\tif (state \u003e 0) {"},{"line_number":111,"context_line":"\t\t\tptr +\u003d state;"},{"line_number":112,"context_line":"\t\t\ti -\u003d state;"},{"line_number":113,"context_line":"\t\t} else {"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"a42be0a7_2fb12603","line":110,"updated":"2024-02-12 23:15:10.000000000","message":"On possible return value of read_socket() is zero, when no data is available yet in the input queue.\nWith state\u003d0, this function logs an error and return state, so returns zero.\nThe only caller of this function considers an error if the returned value is \u003c0.\nWith returned value zero, the caller considers the buffer as completely received, while it\u0027s not true.","commit_id":"a6b4f4fc2b0cfae25a4386978dac8a6c8541b3f3"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"c74d2a12932dbbf27db9d6364608977df480ce66","unresolved":false,"context_lines":[{"line_number":107,"context_line":"\tunsigned int i \u003d size;"},{"line_number":108,"context_line":"\twhile (i \u003e 0) {"},{"line_number":109,"context_line":"\t\tint state \u003d read_socket(sock_id, ptr, i);"},{"line_number":110,"context_line":"\t\tif (state \u003e 0) {"},{"line_number":111,"context_line":"\t\t\tptr +\u003d state;"},{"line_number":112,"context_line":"\t\t\ti -\u003d state;"},{"line_number":113,"context_line":"\t\t} else {"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"f9cbb1b6_0b53c745","line":110,"in_reply_to":"a42be0a7_2fb12603","updated":"2024-02-14 15:47:59.000000000","message":"You are right, I didn\u0027t notice that.","commit_id":"a6b4f4fc2b0cfae25a4386978dac8a6c8541b3f3"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"244504ea04b93c88a3d428962a13f84ff8b974bf","unresolved":false,"context_lines":[{"line_number":107,"context_line":"\tunsigned int i \u003d size;"},{"line_number":108,"context_line":"\twhile (i \u003e 0) {"},{"line_number":109,"context_line":"\t\tint state \u003d read_socket(sock_id, ptr, i);"},{"line_number":110,"context_line":"\t\tif (state \u003e 0) {"},{"line_number":111,"context_line":"\t\t\tptr +\u003d state;"},{"line_number":112,"context_line":"\t\t\ti -\u003d state;"},{"line_number":113,"context_line":"\t\t} else {"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"c908c466_f082b953","line":110,"in_reply_to":"dc8a820d_4e79676a","updated":"2024-02-27 17:39:47.000000000","message":"Done","commit_id":"a6b4f4fc2b0cfae25a4386978dac8a6c8541b3f3"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"9a92fe7eaea278bf6d8d5991b56682e97bee4858","unresolved":true,"context_lines":[{"line_number":107,"context_line":"\tunsigned int i \u003d size;"},{"line_number":108,"context_line":"\twhile (i \u003e 0) {"},{"line_number":109,"context_line":"\t\tint state \u003d read_socket(sock_id, ptr, i);"},{"line_number":110,"context_line":"\t\tif (state \u003e 0) {"},{"line_number":111,"context_line":"\t\t\tptr +\u003d state;"},{"line_number":112,"context_line":"\t\t\ti -\u003d state;"},{"line_number":113,"context_line":"\t\t} else {"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"dc8a820d_4e79676a","line":110,"in_reply_to":"f9cbb1b6_0b53c745","updated":"2024-02-26 18:10:39.000000000","message":"not solved","commit_id":"a6b4f4fc2b0cfae25a4386978dac8a6c8541b3f3"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"0ee476617c076811187856a5e1f23cc527746e32","unresolved":true,"context_lines":[{"line_number":385,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":386,"context_line":"\t}"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"\treturn fd;"},{"line_number":389,"context_line":"}"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"/*"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"dfb83d7e_ddb3f201","line":388,"updated":"2024-02-12 23:15:10.000000000","message":"I cannot find this info in the coding style, but in OpenOCD either a function returns only ERROR_OK/ERROR_XXX, or it returns a value with a special value for error.\nMixing returning ERROR_FAIL with a file descriptor is not welcome.\nMy preferred way would be to change the prototype to\n```static int xvc_init_unix(int *fd)```\nand returns only ERROR_OK/ERROR_XXX, while ```*fd``` is used in the function body.\nSame for the function above xvc_init_tcp()","commit_id":"a6b4f4fc2b0cfae25a4386978dac8a6c8541b3f3"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"9a92fe7eaea278bf6d8d5991b56682e97bee4858","unresolved":true,"context_lines":[{"line_number":385,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":386,"context_line":"\t}"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"\treturn fd;"},{"line_number":389,"context_line":"}"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"/*"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"e8eb1d9e_c4f64c55","line":388,"in_reply_to":"2894b960_db4d2649","updated":"2024-02-26 18:10:39.000000000","message":"not solved","commit_id":"a6b4f4fc2b0cfae25a4386978dac8a6c8541b3f3"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"c74d2a12932dbbf27db9d6364608977df480ce66","unresolved":false,"context_lines":[{"line_number":385,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":386,"context_line":"\t}"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"\treturn fd;"},{"line_number":389,"context_line":"}"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"/*"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"2894b960_db4d2649","line":388,"in_reply_to":"dfb83d7e_ddb3f201","updated":"2024-02-14 15:47:59.000000000","message":"I agree","commit_id":"a6b4f4fc2b0cfae25a4386978dac8a6c8541b3f3"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"244504ea04b93c88a3d428962a13f84ff8b974bf","unresolved":false,"context_lines":[{"line_number":385,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":386,"context_line":"\t}"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"\treturn fd;"},{"line_number":389,"context_line":"}"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"/*"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"42350124_d3997dd3","line":388,"in_reply_to":"e8eb1d9e_c4f64c55","updated":"2024-02-27 17:39:47.000000000","message":"Done","commit_id":"a6b4f4fc2b0cfae25a4386978dac8a6c8541b3f3"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"0ee476617c076811187856a5e1f23cc527746e32","unresolved":true,"context_lines":[{"line_number":640,"context_line":"static int xvc_tap_execute_queue(void)"},{"line_number":641,"context_line":"{"},{"line_number":642,"context_line":"\tstruct jtag_command *cmd \u003d"},{"line_number":643,"context_line":"\t\t\tjtag_command_queue; /* currently processed command */"},{"line_number":644,"context_line":""},{"line_number":645,"context_line":"\twhile (cmd) {"},{"line_number":646,"context_line":"\t\tswitch (cmd-\u003etype) {"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"a3473292_33873ec4","line":643,"updated":"2024-02-12 23:15:10.000000000","message":"We have just merged the patch https://review.openocd.org/945\nThis patch changes the way to handle the jtag_command_queue.\nSee this fragment as example:\nhttps://review.openocd.org/c/openocd/+/945/13/src/jtag/drivers/xlnx-pcie-xvc.c\nPlease rebase your patch on top of the current master branch","commit_id":"a6b4f4fc2b0cfae25a4386978dac8a6c8541b3f3"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"9a92fe7eaea278bf6d8d5991b56682e97bee4858","unresolved":false,"context_lines":[{"line_number":640,"context_line":"static int xvc_tap_execute_queue(void)"},{"line_number":641,"context_line":"{"},{"line_number":642,"context_line":"\tstruct jtag_command *cmd \u003d"},{"line_number":643,"context_line":"\t\t\tjtag_command_queue; /* currently processed command */"},{"line_number":644,"context_line":""},{"line_number":645,"context_line":"\twhile (cmd) {"},{"line_number":646,"context_line":"\t\tswitch (cmd-\u003etype) {"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"61cbdce8_309d01f9","line":643,"in_reply_to":"5db44cba_c6100c42","updated":"2024-02-26 18:10:39.000000000","message":"not solved","commit_id":"a6b4f4fc2b0cfae25a4386978dac8a6c8541b3f3"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"c74d2a12932dbbf27db9d6364608977df480ce66","unresolved":false,"context_lines":[{"line_number":640,"context_line":"static int xvc_tap_execute_queue(void)"},{"line_number":641,"context_line":"{"},{"line_number":642,"context_line":"\tstruct jtag_command *cmd \u003d"},{"line_number":643,"context_line":"\t\t\tjtag_command_queue; /* currently processed command */"},{"line_number":644,"context_line":""},{"line_number":645,"context_line":"\twhile (cmd) {"},{"line_number":646,"context_line":"\t\tswitch (cmd-\u003etype) {"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"5db44cba_c6100c42","line":643,"in_reply_to":"a3473292_33873ec4","updated":"2024-02-14 15:47:59.000000000","message":"Thanks for the example. It is changed now","commit_id":"a6b4f4fc2b0cfae25a4386978dac8a6c8541b3f3"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"0efdaae8d56bfe15bcc48177f7a57a4ed1dd423b","unresolved":true,"context_lines":[{"line_number":115,"context_line":"\t\t\t\tmade me do it. */"},{"line_number":116,"context_line":"\t\t\tif (state \u003d\u003d 0) {"},{"line_number":117,"context_line":"\t\t\t\tLOG_ERROR(\"No data available in socket at %s\", __func__);"},{"line_number":118,"context_line":"\t\t\t\treturn ERROR_FAIL;"},{"line_number":119,"context_line":"\t\t\t}"},{"line_number":120,"context_line":"\t\t\t/* If state \u003c 0, socket error */"},{"line_number":121,"context_line":"\t\t\tLOG_ERROR(\"Reading error in %s\", __func__);"}],"source_content_type":"text/x-csrc","patch_set":12,"id":"6fd6a5e0_c76f15b5","line":118,"updated":"2024-03-18 00:05:59.000000000","message":"The caller of read_frame checks if it returns \u003c0. While today ERROR_FAIL is negative, it is required to be checked against ERROR_OK, not on the sign.\nI think this loop should be more readable if written as:\n```\nwhile (i \u003e 0) {\n  int state \u003d read_socket(sock_id, ptr, i);\n  if (state \u003d\u003d 0) {\n    LOG_ERROR(\"No data available in socket at %s\", __func__);\n    return -1; /* report error to the caller */\n  }\n  if (state \u003c 0) {\n    LOG_ERROR(\"Reading error in %s\", __func__);\n    return state;\n  }\n  ptr +\u003d state;\n  i -\u003d state;\n}\n```","commit_id":"19225a8ee530f5acb73d3a27367e11b23a4b8347"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"dde43328233925ca43d95f5b40ba41b88ee835f4","unresolved":false,"context_lines":[{"line_number":115,"context_line":"\t\t\t\tmade me do it. */"},{"line_number":116,"context_line":"\t\t\tif (state \u003d\u003d 0) {"},{"line_number":117,"context_line":"\t\t\t\tLOG_ERROR(\"No data available in socket at %s\", __func__);"},{"line_number":118,"context_line":"\t\t\t\treturn ERROR_FAIL;"},{"line_number":119,"context_line":"\t\t\t}"},{"line_number":120,"context_line":"\t\t\t/* If state \u003c 0, socket error */"},{"line_number":121,"context_line":"\t\t\tLOG_ERROR(\"Reading error in %s\", __func__);"}],"source_content_type":"text/x-csrc","patch_set":12,"id":"d1e1ea22_c4fc82f9","line":118,"in_reply_to":"6fd6a5e0_c76f15b5","updated":"2024-03-18 10:43:19.000000000","message":"Done","commit_id":"19225a8ee530f5acb73d3a27367e11b23a4b8347"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"cd8c01ab8d7d087df5afcc98e179e2bbedf09f9e","unresolved":true,"context_lines":[{"line_number":59,"context_line":"\t/* Offset in the destination buffer. */"},{"line_number":60,"context_line":"\tunsigned int buffer_offset;"},{"line_number":61,"context_line":"};"},{"line_number":62,"context_line":"/* MAX_BUF_SIZE holds the maximum size that internal buffers are allowed to"},{"line_number":63,"context_line":"\tbe allocated. This parameter is limited by the size of an unsigned int"},{"line_number":64,"context_line":"\t(2/4) bytes. Unsigned int types are employed by several functions in OpenOCD,"},{"line_number":65,"context_line":"\tlike \u0027write_socket\u0027. The offset of 11 bytes is set to ensure XVC commands"}],"source_content_type":"text/x-csrc","patch_set":13,"id":"9c601178_ab40758c","line":62,"updated":"2024-07-16 22:00:35.000000000","message":"Use proper comment style, see developer docs or other drivers.","commit_id":"b094e21223faf5f2dcb741dc0ae6bb73c5e8f32d"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"7947c200a75c7f5ae73a1088ffb809206a85c1e3","unresolved":false,"context_lines":[{"line_number":59,"context_line":"\t/* Offset in the destination buffer. */"},{"line_number":60,"context_line":"\tunsigned int buffer_offset;"},{"line_number":61,"context_line":"};"},{"line_number":62,"context_line":"/* MAX_BUF_SIZE holds the maximum size that internal buffers are allowed to"},{"line_number":63,"context_line":"\tbe allocated. This parameter is limited by the size of an unsigned int"},{"line_number":64,"context_line":"\t(2/4) bytes. Unsigned int types are employed by several functions in OpenOCD,"},{"line_number":65,"context_line":"\tlike \u0027write_socket\u0027. The offset of 11 bytes is set to ensure XVC commands"}],"source_content_type":"text/x-csrc","patch_set":13,"id":"a2c475a3_e3745639","line":62,"in_reply_to":"9c601178_ab40758c","updated":"2024-07-24 11:49:05.000000000","message":"Done","commit_id":"b094e21223faf5f2dcb741dc0ae6bb73c5e8f32d"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"cd8c01ab8d7d087df5afcc98e179e2bbedf09f9e","unresolved":true,"context_lines":[{"line_number":68,"context_line":"#define MAX_BUF_SIZE (BIT(16) - 11)"},{"line_number":69,"context_line":"#define MAX_SHIFT_RESULTS 256"},{"line_number":70,"context_line":"static unsigned int last_used_bits;"},{"line_number":71,"context_line":"static int pending_shift_results;"},{"line_number":72,"context_line":"static struct shift_result shift_result_buffer[MAX_SHIFT_RESULTS];"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"static int xvc_settck(void);"}],"source_content_type":"text/x-csrc","patch_set":13,"id":"24622596_c91b83dc","line":71,"updated":"2024-07-16 22:00:35.000000000","message":"Why int and not \u0027unsigned int\u0027?","commit_id":"b094e21223faf5f2dcb741dc0ae6bb73c5e8f32d"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"7947c200a75c7f5ae73a1088ffb809206a85c1e3","unresolved":false,"context_lines":[{"line_number":68,"context_line":"#define MAX_BUF_SIZE (BIT(16) - 11)"},{"line_number":69,"context_line":"#define MAX_SHIFT_RESULTS 256"},{"line_number":70,"context_line":"static unsigned int last_used_bits;"},{"line_number":71,"context_line":"static int pending_shift_results;"},{"line_number":72,"context_line":"static struct shift_result shift_result_buffer[MAX_SHIFT_RESULTS];"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"static int xvc_settck(void);"}],"source_content_type":"text/x-csrc","patch_set":13,"id":"a9311d30_dce16d94","line":71,"in_reply_to":"24622596_c91b83dc","updated":"2024-07-24 11:49:05.000000000","message":"Done","commit_id":"b094e21223faf5f2dcb741dc0ae6bb73c5e8f32d"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"cd8c01ab8d7d087df5afcc98e179e2bbedf09f9e","unresolved":true,"context_lines":[{"line_number":71,"context_line":"static int pending_shift_results;"},{"line_number":72,"context_line":"static struct shift_result shift_result_buffer[MAX_SHIFT_RESULTS];"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"static int xvc_settck(void);"},{"line_number":75,"context_line":"static int xvc_fill_buffer(void);"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"/* Auxiliary and TCL helper functions*/"}],"source_content_type":"text/x-csrc","patch_set":13,"id":"ca215560_2d5728ba","line":74,"updated":"2024-07-16 22:00:35.000000000","message":"Use proper function names, xvc_set_tck(void) in this case (see developer docs).","commit_id":"b094e21223faf5f2dcb741dc0ae6bb73c5e8f32d"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"7947c200a75c7f5ae73a1088ffb809206a85c1e3","unresolved":false,"context_lines":[{"line_number":71,"context_line":"static int pending_shift_results;"},{"line_number":72,"context_line":"static struct shift_result shift_result_buffer[MAX_SHIFT_RESULTS];"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"static int xvc_settck(void);"},{"line_number":75,"context_line":"static int xvc_fill_buffer(void);"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"/* Auxiliary and TCL helper functions*/"}],"source_content_type":"text/x-csrc","patch_set":13,"id":"fd76d296_f146fb97","line":74,"in_reply_to":"ca215560_2d5728ba","updated":"2024-07-24 11:49:05.000000000","message":"Done","commit_id":"b094e21223faf5f2dcb741dc0ae6bb73c5e8f32d"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"cd8c01ab8d7d087df5afcc98e179e2bbedf09f9e","unresolved":true,"context_lines":[{"line_number":109,"context_line":"\t\tint state \u003d read_socket(sock_id, ptr, i);"},{"line_number":110,"context_line":"\t\tif (state \u003d\u003d 0) {"},{"line_number":111,"context_line":"\t\t\tLOG_ERROR(\"No data available in socket at %s\", __func__);"},{"line_number":112,"context_line":"\t\t\treturn -1; /* report error to the caller, perphaps use ERROR_X label? */"},{"line_number":113,"context_line":"\t\t}"},{"line_number":114,"context_line":"\t\tif (state \u003c 0) {"},{"line_number":115,"context_line":"\t\t\tLOG_ERROR(\"Reading error in %s\", __func__);"}],"source_content_type":"text/x-csrc","patch_set":13,"id":"a02ce43a_231e4852","line":112,"updated":"2024-07-16 22:00:35.000000000","message":"Fix this, do not mix ERROR_* return values with other return values.","commit_id":"b094e21223faf5f2dcb741dc0ae6bb73c5e8f32d"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"7947c200a75c7f5ae73a1088ffb809206a85c1e3","unresolved":false,"context_lines":[{"line_number":109,"context_line":"\t\tint state \u003d read_socket(sock_id, ptr, i);"},{"line_number":110,"context_line":"\t\tif (state \u003d\u003d 0) {"},{"line_number":111,"context_line":"\t\t\tLOG_ERROR(\"No data available in socket at %s\", __func__);"},{"line_number":112,"context_line":"\t\t\treturn -1; /* report error to the caller, perphaps use ERROR_X label? */"},{"line_number":113,"context_line":"\t\t}"},{"line_number":114,"context_line":"\t\tif (state \u003c 0) {"},{"line_number":115,"context_line":"\t\t\tLOG_ERROR(\"Reading error in %s\", __func__);"}],"source_content_type":"text/x-csrc","patch_set":13,"id":"575f87fc_190e7c53","line":112,"in_reply_to":"a02ce43a_231e4852","updated":"2024-07-24 11:49:05.000000000","message":"Done","commit_id":"b094e21223faf5f2dcb741dc0ae6bb73c5e8f32d"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"cd8c01ab8d7d087df5afcc98e179e2bbedf09f9e","unresolved":true,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"static int xvc_flush(void)"},{"line_number":125,"context_line":"{"},{"line_number":126,"context_line":"\tif (xvc_used_bits \u003d\u003d 0) {"},{"line_number":127,"context_line":"\t\t/* Nothing to send, so we don\u0027t expect any bit back either */"},{"line_number":128,"context_line":"\t\tlast_used_bits \u003d 0;"},{"line_number":129,"context_line":"\t\tLOG_DEBUG(\"XVC flush: no bits to flush\");"}],"source_content_type":"text/x-csrc","patch_set":13,"id":"b4b967df_b04fcaf8","line":126,"updated":"2024-07-16 22:00:35.000000000","message":"!xvc_used_bits","commit_id":"b094e21223faf5f2dcb741dc0ae6bb73c5e8f32d"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"7947c200a75c7f5ae73a1088ffb809206a85c1e3","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"static int xvc_flush(void)"},{"line_number":125,"context_line":"{"},{"line_number":126,"context_line":"\tif (xvc_used_bits \u003d\u003d 0) {"},{"line_number":127,"context_line":"\t\t/* Nothing to send, so we don\u0027t expect any bit back either */"},{"line_number":128,"context_line":"\t\tlast_used_bits \u003d 0;"},{"line_number":129,"context_line":"\t\tLOG_DEBUG(\"XVC flush: no bits to flush\");"}],"source_content_type":"text/x-csrc","patch_set":13,"id":"969954f9_d1e40054","line":126,"in_reply_to":"b4b967df_b04fcaf8","updated":"2024-07-24 11:49:05.000000000","message":"Done","commit_id":"b094e21223faf5f2dcb741dc0ae6bb73c5e8f32d"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"cd8c01ab8d7d087df5afcc98e179e2bbedf09f9e","unresolved":true,"context_lines":[{"line_number":134,"context_line":"\tunsigned int number_of_bytes \u003d xvc_bits_to_bytes(xvc_used_bits);"},{"line_number":135,"context_line":"\t/* Creates the header. */"},{"line_number":136,"context_line":"\tconst char *shift \u003d \"shift:\";"},{"line_number":137,"context_line":"\tint shift_len \u003d strlen(shift);"},{"line_number":138,"context_line":"\tint cp_offset \u003d 0;"},{"line_number":139,"context_line":"\t/* Copies the header */"},{"line_number":140,"context_line":"\tmemcpy(xvc_send_buf + cp_offset, shift, shift_len);"}],"source_content_type":"text/x-csrc","patch_set":13,"id":"844438da_cd90d37b","line":137,"updated":"2024-07-16 22:00:35.000000000","message":"strlen() returns size_t and cannot be negative, don\u0027t use int!","commit_id":"b094e21223faf5f2dcb741dc0ae6bb73c5e8f32d"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"7947c200a75c7f5ae73a1088ffb809206a85c1e3","unresolved":false,"context_lines":[{"line_number":134,"context_line":"\tunsigned int number_of_bytes \u003d xvc_bits_to_bytes(xvc_used_bits);"},{"line_number":135,"context_line":"\t/* Creates the header. */"},{"line_number":136,"context_line":"\tconst char *shift \u003d \"shift:\";"},{"line_number":137,"context_line":"\tint shift_len \u003d strlen(shift);"},{"line_number":138,"context_line":"\tint cp_offset \u003d 0;"},{"line_number":139,"context_line":"\t/* Copies the header */"},{"line_number":140,"context_line":"\tmemcpy(xvc_send_buf + cp_offset, shift, shift_len);"}],"source_content_type":"text/x-csrc","patch_set":13,"id":"0d8b48c8_a9f05e73","line":137,"in_reply_to":"844438da_cd90d37b","updated":"2024-07-24 11:49:05.000000000","message":"Done.\n\nssize_t depending on the caller function could potentially return -1. In this case, strlen always returns a positive value.","commit_id":"b094e21223faf5f2dcb741dc0ae6bb73c5e8f32d"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"cd8c01ab8d7d087df5afcc98e179e2bbedf09f9e","unresolved":true,"context_lines":[{"line_number":135,"context_line":"\t/* Creates the header. */"},{"line_number":136,"context_line":"\tconst char *shift \u003d \"shift:\";"},{"line_number":137,"context_line":"\tint shift_len \u003d strlen(shift);"},{"line_number":138,"context_line":"\tint cp_offset \u003d 0;"},{"line_number":139,"context_line":"\t/* Copies the header */"},{"line_number":140,"context_line":"\tmemcpy(xvc_send_buf + cp_offset, shift, shift_len);"},{"line_number":141,"context_line":"\t/* Updates the offset. */"}],"source_content_type":"text/x-csrc","patch_set":13,"id":"5855d00a_509cfce3","line":138,"updated":"2024-07-16 22:00:35.000000000","message":"Can cp_offset be negative?","commit_id":"b094e21223faf5f2dcb741dc0ae6bb73c5e8f32d"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"7947c200a75c7f5ae73a1088ffb809206a85c1e3","unresolved":false,"context_lines":[{"line_number":135,"context_line":"\t/* Creates the header. */"},{"line_number":136,"context_line":"\tconst char *shift \u003d \"shift:\";"},{"line_number":137,"context_line":"\tint shift_len \u003d strlen(shift);"},{"line_number":138,"context_line":"\tint cp_offset \u003d 0;"},{"line_number":139,"context_line":"\t/* Copies the header */"},{"line_number":140,"context_line":"\tmemcpy(xvc_send_buf + cp_offset, shift, shift_len);"},{"line_number":141,"context_line":"\t/* Updates the offset. */"}],"source_content_type":"text/x-csrc","patch_set":13,"id":"2dcf53e9_ffedbfd3","line":138,"in_reply_to":"5855d00a_509cfce3","updated":"2024-07-24 11:49:05.000000000","message":"cp_offset shall never be negative, changed its type to unsigned int.","commit_id":"b094e21223faf5f2dcb741dc0ae6bb73c5e8f32d"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"cd8c01ab8d7d087df5afcc98e179e2bbedf09f9e","unresolved":true,"context_lines":[{"line_number":167,"context_line":"\treturn ERROR_OK;"},{"line_number":168,"context_line":"}"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"static int xvc_queue(const uint8_t *tms, unsigned int tms_offset, const uint8_t *tdi,"},{"line_number":171,"context_line":"\t\t\t\t\t unsigned int tdi_offset, uint8_t *tdo, unsigned int tdo_offset, unsigned int length)"},{"line_number":172,"context_line":"{"},{"line_number":173,"context_line":"\tdo {"}],"source_content_type":"text/x-csrc","patch_set":13,"id":"bdf4f682_81c2cebf","line":170,"updated":"2024-07-16 22:00:35.000000000","message":"Indention seems broken, fix it.","commit_id":"b094e21223faf5f2dcb741dc0ae6bb73c5e8f32d"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"7947c200a75c7f5ae73a1088ffb809206a85c1e3","unresolved":false,"context_lines":[{"line_number":167,"context_line":"\treturn ERROR_OK;"},{"line_number":168,"context_line":"}"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"static int xvc_queue(const uint8_t *tms, unsigned int tms_offset, const uint8_t *tdi,"},{"line_number":171,"context_line":"\t\t\t\t\t unsigned int tdi_offset, uint8_t *tdo, unsigned int tdo_offset, unsigned int length)"},{"line_number":172,"context_line":"{"},{"line_number":173,"context_line":"\tdo {"}],"source_content_type":"text/x-csrc","patch_set":13,"id":"d333ff5c_bcd340a2","line":170,"in_reply_to":"bdf4f682_81c2cebf","updated":"2024-07-24 11:49:05.000000000","message":"I am not really sure if you are referring to the whitespace that was after the indents or if I should one or two indentation levels. Removed the whitespace.","commit_id":"b094e21223faf5f2dcb741dc0ae6bb73c5e8f32d"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"cd8c01ab8d7d087df5afcc98e179e2bbedf09f9e","unresolved":true,"context_lines":[{"line_number":206,"context_line":"static int xvc_getinfo(void)"},{"line_number":207,"context_line":"{"},{"line_number":208,"context_line":"\tconst char *getinfo \u003d \"getinfo:\";"},{"line_number":209,"context_line":"\tint len \u003d strlen(getinfo);"},{"line_number":210,"context_line":"\t/* Sends getinfo command */"},{"line_number":211,"context_line":"\tssize_t written \u003d write_socket(xvc_fd, getinfo, len);"},{"line_number":212,"context_line":"\tif (written !\u003d len) {"}],"source_content_type":"text/x-csrc","patch_set":13,"id":"a70dc860_9c21f463","line":209,"updated":"2024-07-16 22:00:35.000000000","message":"Same as above.","commit_id":"b094e21223faf5f2dcb741dc0ae6bb73c5e8f32d"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"7947c200a75c7f5ae73a1088ffb809206a85c1e3","unresolved":false,"context_lines":[{"line_number":206,"context_line":"static int xvc_getinfo(void)"},{"line_number":207,"context_line":"{"},{"line_number":208,"context_line":"\tconst char *getinfo \u003d \"getinfo:\";"},{"line_number":209,"context_line":"\tint len \u003d strlen(getinfo);"},{"line_number":210,"context_line":"\t/* Sends getinfo command */"},{"line_number":211,"context_line":"\tssize_t written \u003d write_socket(xvc_fd, getinfo, len);"},{"line_number":212,"context_line":"\tif (written !\u003d len) {"}],"source_content_type":"text/x-csrc","patch_set":13,"id":"69a3f1f7_f352cac0","line":209,"in_reply_to":"a70dc860_9c21f463","updated":"2024-07-24 11:49:05.000000000","message":"Done","commit_id":"b094e21223faf5f2dcb741dc0ae6bb73c5e8f32d"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"cd8c01ab8d7d087df5afcc98e179e2bbedf09f9e","unresolved":true,"context_lines":[{"line_number":215,"context_line":"\t}"},{"line_number":216,"context_line":"\tchar info_recv_buf[20];"},{"line_number":217,"context_line":"\t/* Potentially waits until response gets received. */"},{"line_number":218,"context_line":"\tssize_t read \u003d read_socket(xvc_fd, info_recv_buf, 20);"},{"line_number":219,"context_line":"\tif (read \u003c 0) {"},{"line_number":220,"context_line":"\t\tLOG_ERROR(\"%s: read\", __func__);"},{"line_number":221,"context_line":"\t\treturn ERROR_FAIL;"}],"source_content_type":"text/x-csrc","patch_set":13,"id":"7c2c5bc2_b635a1b5","line":218,"updated":"2024-07-16 22:00:35.000000000","message":"Use sizeof(info_recv_buf).","commit_id":"b094e21223faf5f2dcb741dc0ae6bb73c5e8f32d"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"7947c200a75c7f5ae73a1088ffb809206a85c1e3","unresolved":false,"context_lines":[{"line_number":215,"context_line":"\t}"},{"line_number":216,"context_line":"\tchar info_recv_buf[20];"},{"line_number":217,"context_line":"\t/* Potentially waits until response gets received. */"},{"line_number":218,"context_line":"\tssize_t read \u003d read_socket(xvc_fd, info_recv_buf, 20);"},{"line_number":219,"context_line":"\tif (read \u003c 0) {"},{"line_number":220,"context_line":"\t\tLOG_ERROR(\"%s: read\", __func__);"},{"line_number":221,"context_line":"\t\treturn ERROR_FAIL;"}],"source_content_type":"text/x-csrc","patch_set":13,"id":"47fb87ce_fe1b5709","line":218,"in_reply_to":"7c2c5bc2_b635a1b5","updated":"2024-07-24 11:49:05.000000000","message":"Done","commit_id":"b094e21223faf5f2dcb741dc0ae6bb73c5e8f32d"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"cd8c01ab8d7d087df5afcc98e179e2bbedf09f9e","unresolved":true,"context_lines":[{"line_number":234,"context_line":"\t\txvc_max_usable_vector_size \u003d MAX_BUF_SIZE;"},{"line_number":235,"context_line":"\t}"},{"line_number":236,"context_line":"\txvc_max_vector_size \u003d xvc_max_usable_vector_size + 10;"},{"line_number":237,"context_line":"\tLOG_DEBUG(\"Maximum vector size set to: %u\\n\", xvc_max_vector_size);"},{"line_number":238,"context_line":"\t/*Usable size: maximum vector size determined by the server minus the"},{"line_number":239,"context_line":"\tsizeof the command, 10 bytes in worst-case (6 bytes from shift: and 4"},{"line_number":240,"context_line":"\tadditional ones for bit_length).*/"}],"source_content_type":"text/x-csrc","patch_set":13,"id":"8591c72c_004b5c79","line":237,"updated":"2024-07-16 22:00:35.000000000","message":"Do not use \u0027\\n\u0027 at the end of a log message.","commit_id":"b094e21223faf5f2dcb741dc0ae6bb73c5e8f32d"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"7947c200a75c7f5ae73a1088ffb809206a85c1e3","unresolved":false,"context_lines":[{"line_number":234,"context_line":"\t\txvc_max_usable_vector_size \u003d MAX_BUF_SIZE;"},{"line_number":235,"context_line":"\t}"},{"line_number":236,"context_line":"\txvc_max_vector_size \u003d xvc_max_usable_vector_size + 10;"},{"line_number":237,"context_line":"\tLOG_DEBUG(\"Maximum vector size set to: %u\\n\", xvc_max_vector_size);"},{"line_number":238,"context_line":"\t/*Usable size: maximum vector size determined by the server minus the"},{"line_number":239,"context_line":"\tsizeof the command, 10 bytes in worst-case (6 bytes from shift: and 4"},{"line_number":240,"context_line":"\tadditional ones for bit_length).*/"}],"source_content_type":"text/x-csrc","patch_set":13,"id":"05ccb262_b9f96a08","line":237,"in_reply_to":"8591c72c_004b5c79","updated":"2024-07-24 11:49:05.000000000","message":"Done","commit_id":"b094e21223faf5f2dcb741dc0ae6bb73c5e8f32d"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"cd8c01ab8d7d087df5afcc98e179e2bbedf09f9e","unresolved":true,"context_lines":[{"line_number":235,"context_line":"\t}"},{"line_number":236,"context_line":"\txvc_max_vector_size \u003d xvc_max_usable_vector_size + 10;"},{"line_number":237,"context_line":"\tLOG_DEBUG(\"Maximum vector size set to: %u\\n\", xvc_max_vector_size);"},{"line_number":238,"context_line":"\t/*Usable size: maximum vector size determined by the server minus the"},{"line_number":239,"context_line":"\tsizeof the command, 10 bytes in worst-case (6 bytes from shift: and 4"},{"line_number":240,"context_line":"\tadditional ones for bit_length).*/"},{"line_number":241,"context_line":"\t/* Updates TX Buffer sizes: */"}],"source_content_type":"text/x-csrc","patch_set":13,"id":"e97b26e7_f3ef6cfb","line":238,"updated":"2024-07-16 22:00:35.000000000","message":"Broken comment style, fix it.","commit_id":"b094e21223faf5f2dcb741dc0ae6bb73c5e8f32d"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"7947c200a75c7f5ae73a1088ffb809206a85c1e3","unresolved":false,"context_lines":[{"line_number":235,"context_line":"\t}"},{"line_number":236,"context_line":"\txvc_max_vector_size \u003d xvc_max_usable_vector_size + 10;"},{"line_number":237,"context_line":"\tLOG_DEBUG(\"Maximum vector size set to: %u\\n\", xvc_max_vector_size);"},{"line_number":238,"context_line":"\t/*Usable size: maximum vector size determined by the server minus the"},{"line_number":239,"context_line":"\tsizeof the command, 10 bytes in worst-case (6 bytes from shift: and 4"},{"line_number":240,"context_line":"\tadditional ones for bit_length).*/"},{"line_number":241,"context_line":"\t/* Updates TX Buffer sizes: */"}],"source_content_type":"text/x-csrc","patch_set":13,"id":"e00a0d5a_9d7a00db","line":238,"in_reply_to":"e97b26e7_f3ef6cfb","updated":"2024-07-24 11:49:05.000000000","message":"Done","commit_id":"b094e21223faf5f2dcb741dc0ae6bb73c5e8f32d"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"cd8c01ab8d7d087df5afcc98e179e2bbedf09f9e","unresolved":true,"context_lines":[{"line_number":256,"context_line":""},{"line_number":257,"context_line":"static int xvc_settck(void)"},{"line_number":258,"context_line":"{"},{"line_number":259,"context_line":"\t/*Creates the command:"},{"line_number":260,"context_line":"\t * copies the header and appends the value."},{"line_number":261,"context_line":"\t * */"},{"line_number":262,"context_line":"\tuint8_t settck[12];"}],"source_content_type":"text/x-csrc","patch_set":13,"id":"d1d7b964_786407a6","line":259,"updated":"2024-07-16 22:00:35.000000000","message":"Broken comment style, fix it.","commit_id":"b094e21223faf5f2dcb741dc0ae6bb73c5e8f32d"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"7947c200a75c7f5ae73a1088ffb809206a85c1e3","unresolved":false,"context_lines":[{"line_number":256,"context_line":""},{"line_number":257,"context_line":"static int xvc_settck(void)"},{"line_number":258,"context_line":"{"},{"line_number":259,"context_line":"\t/*Creates the command:"},{"line_number":260,"context_line":"\t * copies the header and appends the value."},{"line_number":261,"context_line":"\t * */"},{"line_number":262,"context_line":"\tuint8_t settck[12];"}],"source_content_type":"text/x-csrc","patch_set":13,"id":"d3bd288a_ee30ebfc","line":259,"in_reply_to":"d1d7b964_786407a6","updated":"2024-07-24 11:49:05.000000000","message":"Done","commit_id":"b094e21223faf5f2dcb741dc0ae6bb73c5e8f32d"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"cd8c01ab8d7d087df5afcc98e179e2bbedf09f9e","unresolved":true,"context_lines":[{"line_number":259,"context_line":"\t/*Creates the command:"},{"line_number":260,"context_line":"\t * copies the header and appends the value."},{"line_number":261,"context_line":"\t * */"},{"line_number":262,"context_line":"\tuint8_t settck[12];"},{"line_number":263,"context_line":"\tconst char *header \u003d \"settck:\";"},{"line_number":264,"context_line":"\tmemcpy(settck, header, 7);"},{"line_number":265,"context_line":"\th_u32_to_le(settck + 7, xvc_tck);"}],"source_content_type":"text/x-csrc","patch_set":13,"id":"c67a44b3_de2b0d00","line":262,"updated":"2024-07-16 22:00:35.000000000","message":"Use proper variable names (set_tck in this case), see developer docs.","commit_id":"b094e21223faf5f2dcb741dc0ae6bb73c5e8f32d"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"7947c200a75c7f5ae73a1088ffb809206a85c1e3","unresolved":false,"context_lines":[{"line_number":259,"context_line":"\t/*Creates the command:"},{"line_number":260,"context_line":"\t * copies the header and appends the value."},{"line_number":261,"context_line":"\t * */"},{"line_number":262,"context_line":"\tuint8_t settck[12];"},{"line_number":263,"context_line":"\tconst char *header \u003d \"settck:\";"},{"line_number":264,"context_line":"\tmemcpy(settck, header, 7);"},{"line_number":265,"context_line":"\th_u32_to_le(settck + 7, xvc_tck);"}],"source_content_type":"text/x-csrc","patch_set":13,"id":"982f8241_58798b5c","line":262,"in_reply_to":"c67a44b3_de2b0d00","updated":"2024-07-24 11:49:05.000000000","message":"Done","commit_id":"b094e21223faf5f2dcb741dc0ae6bb73c5e8f32d"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"cd8c01ab8d7d087df5afcc98e179e2bbedf09f9e","unresolved":true,"context_lines":[{"line_number":260,"context_line":"\t * copies the header and appends the value."},{"line_number":261,"context_line":"\t * */"},{"line_number":262,"context_line":"\tuint8_t settck[12];"},{"line_number":263,"context_line":"\tconst char *header \u003d \"settck:\";"},{"line_number":264,"context_line":"\tmemcpy(settck, header, 7);"},{"line_number":265,"context_line":"\th_u32_to_le(settck + 7, xvc_tck);"},{"line_number":266,"context_line":"\t/* Writes the request */"}],"source_content_type":"text/x-csrc","patch_set":13,"id":"703915b0_cdd4f9a6","line":263,"updated":"2024-07-16 22:00:35.000000000","message":"Why not using strlen() here?","commit_id":"b094e21223faf5f2dcb741dc0ae6bb73c5e8f32d"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"7947c200a75c7f5ae73a1088ffb809206a85c1e3","unresolved":false,"context_lines":[{"line_number":260,"context_line":"\t * copies the header and appends the value."},{"line_number":261,"context_line":"\t * */"},{"line_number":262,"context_line":"\tuint8_t settck[12];"},{"line_number":263,"context_line":"\tconst char *header \u003d \"settck:\";"},{"line_number":264,"context_line":"\tmemcpy(settck, header, 7);"},{"line_number":265,"context_line":"\th_u32_to_le(settck + 7, xvc_tck);"},{"line_number":266,"context_line":"\t/* Writes the request */"}],"source_content_type":"text/x-csrc","patch_set":13,"id":"c4e1d82f_40e1bcef","line":263,"in_reply_to":"703915b0_cdd4f9a6","updated":"2024-07-24 11:49:05.000000000","message":"Done","commit_id":"b094e21223faf5f2dcb741dc0ae6bb73c5e8f32d"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"cd8c01ab8d7d087df5afcc98e179e2bbedf09f9e","unresolved":true,"context_lines":[{"line_number":302,"context_line":"static int xvc_reset(int trst, int srst)"},{"line_number":303,"context_line":"{"},{"line_number":304,"context_line":"\t/*XVC does not have dedicated Reset lines. */"},{"line_number":305,"context_line":"\tstatic bool first_time \u003d true;"},{"line_number":306,"context_line":"\tif (first_time) {"},{"line_number":307,"context_line":"\t\tLOG_WARNING(\"Adapter has no reset lines. Fix \\\"reset_config\\\" command in \""},{"line_number":308,"context_line":"\t\t\t\t\t\"config file\");"}],"source_content_type":"text/x-csrc","patch_set":13,"id":"f1574a5e_9fc5dc1d","line":305,"updated":"2024-07-16 22:00:35.000000000","message":"Better use a global variable.","commit_id":"b094e21223faf5f2dcb741dc0ae6bb73c5e8f32d"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"74ac502b86d70113137142c67aefaf4ba254cf21","unresolved":false,"context_lines":[{"line_number":302,"context_line":"static int xvc_reset(int trst, int srst)"},{"line_number":303,"context_line":"{"},{"line_number":304,"context_line":"\t/*XVC does not have dedicated Reset lines. */"},{"line_number":305,"context_line":"\tstatic bool first_time \u003d true;"},{"line_number":306,"context_line":"\tif (first_time) {"},{"line_number":307,"context_line":"\t\tLOG_WARNING(\"Adapter has no reset lines. Fix \\\"reset_config\\\" command in \""},{"line_number":308,"context_line":"\t\t\t\t\t\"config file\");"}],"source_content_type":"text/x-csrc","patch_set":13,"id":"9ba076c8_e19a9f64","line":305,"in_reply_to":"dceec035_c69be07d","updated":"2025-05-13 06:44:41.000000000","message":"Okay, this is an OpenOCD bug. Actually it should be handled in the upper layer if reset is not supported.","commit_id":"b094e21223faf5f2dcb741dc0ae6bb73c5e8f32d"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"7947c200a75c7f5ae73a1088ffb809206a85c1e3","unresolved":true,"context_lines":[{"line_number":302,"context_line":"static int xvc_reset(int trst, int srst)"},{"line_number":303,"context_line":"{"},{"line_number":304,"context_line":"\t/*XVC does not have dedicated Reset lines. */"},{"line_number":305,"context_line":"\tstatic bool first_time \u003d true;"},{"line_number":306,"context_line":"\tif (first_time) {"},{"line_number":307,"context_line":"\t\tLOG_WARNING(\"Adapter has no reset lines. Fix \\\"reset_config\\\" command in \""},{"line_number":308,"context_line":"\t\t\t\t\t\"config file\");"}],"source_content_type":"text/x-csrc","patch_set":13,"id":"dceec035_c69be07d","line":305,"in_reply_to":"f1574a5e_9fc5dc1d","updated":"2024-07-24 11:49:05.000000000","message":"\u0027first_time\u0027 variable is not used outside xvc_reset scope. What is the motivation to declare a global variable then? Still, I think it is a reasonable suggestion.","commit_id":"b094e21223faf5f2dcb741dc0ae6bb73c5e8f32d"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"cd8c01ab8d7d087df5afcc98e179e2bbedf09f9e","unresolved":true,"context_lines":[{"line_number":325,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":326,"context_line":"\t}"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"\t/* getaddrinfo() returns a list of address structures."},{"line_number":329,"context_line":"\t Try each address until we successfully connect(2)."},{"line_number":330,"context_line":"\t If socket(2) (or connect(2)) fails, we (close the socket"},{"line_number":331,"context_line":"\t and) try the next address. */"}],"source_content_type":"text/x-csrc","patch_set":13,"id":"eae77256_4d7475e1","line":328,"updated":"2024-07-16 22:00:35.000000000","message":"Fix broken comment style.","commit_id":"b094e21223faf5f2dcb741dc0ae6bb73c5e8f32d"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"7947c200a75c7f5ae73a1088ffb809206a85c1e3","unresolved":false,"context_lines":[{"line_number":325,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":326,"context_line":"\t}"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"\t/* getaddrinfo() returns a list of address structures."},{"line_number":329,"context_line":"\t Try each address until we successfully connect(2)."},{"line_number":330,"context_line":"\t If socket(2) (or connect(2)) fails, we (close the socket"},{"line_number":331,"context_line":"\t and) try the next address. */"}],"source_content_type":"text/x-csrc","patch_set":13,"id":"3c3c1c4d_e158ebb5","line":328,"in_reply_to":"eae77256_4d7475e1","updated":"2024-07-24 11:49:05.000000000","message":"Done","commit_id":"b094e21223faf5f2dcb741dc0ae6bb73c5e8f32d"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"cd8c01ab8d7d087df5afcc98e179e2bbedf09f9e","unresolved":true,"context_lines":[{"line_number":413,"context_line":"\treturn ERROR_OK;"},{"line_number":414,"context_line":"}"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"static const struct command_registration xvc_command_handlers[] \u003d {"},{"line_number":417,"context_line":"\t{"},{"line_number":418,"context_line":"\t\t.name \u003d \"xvc_port\","},{"line_number":419,"context_line":"\t\t.handler \u003d xvc_handle_port_command,"}],"source_content_type":"text/x-csrc","patch_set":13,"id":"a683fdbc_0b19335b","line":416,"updated":"2024-07-16 22:00:35.000000000","message":"Use a \u0027xvc\u0027 command group rather than \u0027xvc_\u0027 prefix, see other drivers (e.g. jlink).","commit_id":"b094e21223faf5f2dcb741dc0ae6bb73c5e8f32d"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"7947c200a75c7f5ae73a1088ffb809206a85c1e3","unresolved":false,"context_lines":[{"line_number":413,"context_line":"\treturn ERROR_OK;"},{"line_number":414,"context_line":"}"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"static const struct command_registration xvc_command_handlers[] \u003d {"},{"line_number":417,"context_line":"\t{"},{"line_number":418,"context_line":"\t\t.name \u003d \"xvc_port\","},{"line_number":419,"context_line":"\t\t.handler \u003d xvc_handle_port_command,"}],"source_content_type":"text/x-csrc","patch_set":13,"id":"4517067c_abceddce","line":416,"in_reply_to":"a683fdbc_0b19335b","updated":"2024-07-24 11:49:05.000000000","message":"Done","commit_id":"b094e21223faf5f2dcb741dc0ae6bb73c5e8f32d"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"cd8c01ab8d7d087df5afcc98e179e2bbedf09f9e","unresolved":true,"context_lines":[{"line_number":440,"context_line":"\t/* Default clock: 1000 ns period */"},{"line_number":441,"context_line":"\txvc_tck \u003d 1000;"},{"line_number":442,"context_line":""},{"line_number":443,"context_line":"\tLOG_INFO(\"Initializing XVC driver\");"},{"line_number":444,"context_line":"\tint err \u003d ERROR_OK;"},{"line_number":445,"context_line":"\tif (!xvc_port)"},{"line_number":446,"context_line":"\t\terr \u003d xvc_init_unix(\u0026xvc_fd);"}],"source_content_type":"text/x-csrc","patch_set":13,"id":"80221677_09875844","line":443,"updated":"2024-07-16 22:00:35.000000000","message":"Can be remove IMO.","commit_id":"b094e21223faf5f2dcb741dc0ae6bb73c5e8f32d"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"7947c200a75c7f5ae73a1088ffb809206a85c1e3","unresolved":false,"context_lines":[{"line_number":440,"context_line":"\t/* Default clock: 1000 ns period */"},{"line_number":441,"context_line":"\txvc_tck \u003d 1000;"},{"line_number":442,"context_line":""},{"line_number":443,"context_line":"\tLOG_INFO(\"Initializing XVC driver\");"},{"line_number":444,"context_line":"\tint err \u003d ERROR_OK;"},{"line_number":445,"context_line":"\tif (!xvc_port)"},{"line_number":446,"context_line":"\t\terr \u003d xvc_init_unix(\u0026xvc_fd);"}],"source_content_type":"text/x-csrc","patch_set":13,"id":"4bcfe738_a2e7de8d","line":443,"in_reply_to":"80221677_09875844","updated":"2024-07-24 11:49:05.000000000","message":"It could be removed. How about changing it to LOG_DEBUG? IMO it makes sense to somehow notify the user which driver is being in use.","commit_id":"b094e21223faf5f2dcb741dc0ae6bb73c5e8f32d"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"cd8c01ab8d7d087df5afcc98e179e2bbedf09f9e","unresolved":true,"context_lines":[{"line_number":469,"context_line":"\tfree(xvc_tdi_buf);"},{"line_number":470,"context_line":"\tfree(xvc_send_buf);"},{"line_number":471,"context_line":"\tfree(xvc_tdo_buf);"},{"line_number":472,"context_line":"\tLOG_INFO(\"XVC interface quit\");"},{"line_number":473,"context_line":"\treturn ERROR_OK;"},{"line_number":474,"context_line":"}"},{"line_number":475,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":13,"id":"0a7a9964_fe069839","line":472,"updated":"2024-07-16 22:00:35.000000000","message":"Not necessary, remove please.","commit_id":"b094e21223faf5f2dcb741dc0ae6bb73c5e8f32d"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"7947c200a75c7f5ae73a1088ffb809206a85c1e3","unresolved":false,"context_lines":[{"line_number":469,"context_line":"\tfree(xvc_tdi_buf);"},{"line_number":470,"context_line":"\tfree(xvc_send_buf);"},{"line_number":471,"context_line":"\tfree(xvc_tdo_buf);"},{"line_number":472,"context_line":"\tLOG_INFO(\"XVC interface quit\");"},{"line_number":473,"context_line":"\treturn ERROR_OK;"},{"line_number":474,"context_line":"}"},{"line_number":475,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":13,"id":"be88980c_2800d87d","line":472,"in_reply_to":"0a7a9964_fe069839","updated":"2024-07-24 11:49:05.000000000","message":"I agree this could be removed.","commit_id":"b094e21223faf5f2dcb741dc0ae6bb73c5e8f32d"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"cd8c01ab8d7d087df5afcc98e179e2bbedf09f9e","unresolved":true,"context_lines":[{"line_number":502,"context_line":""},{"line_number":503,"context_line":"\tLOG_DEBUG_IO(\"TMS: %d bits\", num_bits);"},{"line_number":504,"context_line":""},{"line_number":505,"context_line":"\tuint8_t tms \u003d 0;"},{"line_number":506,"context_line":""},{"line_number":507,"context_line":"\tfor (unsigned int i \u003d 0; i \u003c num_bits; i++) {"},{"line_number":508,"context_line":"\t\ttms \u003d ((bits[i / 8] \u003e\u003e (i % 8)) \u0026 1);"}],"source_content_type":"text/x-csrc","patch_set":13,"id":"b67d59ff_aa9329df","line":505,"updated":"2024-07-16 22:00:35.000000000","message":"Move into for-loop.","commit_id":"b094e21223faf5f2dcb741dc0ae6bb73c5e8f32d"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"7947c200a75c7f5ae73a1088ffb809206a85c1e3","unresolved":false,"context_lines":[{"line_number":502,"context_line":""},{"line_number":503,"context_line":"\tLOG_DEBUG_IO(\"TMS: %d bits\", num_bits);"},{"line_number":504,"context_line":""},{"line_number":505,"context_line":"\tuint8_t tms \u003d 0;"},{"line_number":506,"context_line":""},{"line_number":507,"context_line":"\tfor (unsigned int i \u003d 0; i \u003c num_bits; i++) {"},{"line_number":508,"context_line":"\t\ttms \u003d ((bits[i / 8] \u003e\u003e (i % 8)) \u0026 1);"}],"source_content_type":"text/x-csrc","patch_set":13,"id":"30ad8711_9b512b0f","line":505,"in_reply_to":"b67d59ff_aa9329df","updated":"2024-07-24 11:49:05.000000000","message":"Done","commit_id":"b094e21223faf5f2dcb741dc0ae6bb73c5e8f32d"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"cd8c01ab8d7d087df5afcc98e179e2bbedf09f9e","unresolved":true,"context_lines":[{"line_number":519,"context_line":"\tint state_count;"},{"line_number":520,"context_line":"\tuint8_t tms \u003d 0xff;"},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"\tstate_count \u003d 0;"},{"line_number":523,"context_line":"\twhile (num_states) {"},{"line_number":524,"context_line":"\t\tif (tap_state_transition(tap_get_state(), false) \u003d\u003d cmd-\u003epath[state_count]) {"},{"line_number":525,"context_line":"\t\t\txvc_queue(NULL, 0, NULL, 0, NULL, 0, 1);"}],"source_content_type":"text/x-csrc","patch_set":13,"id":"64b1bf53_ec8750f9","line":522,"updated":"2024-07-16 22:00:35.000000000","message":"Move declaration here, why not unsigned?","commit_id":"b094e21223faf5f2dcb741dc0ae6bb73c5e8f32d"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"7947c200a75c7f5ae73a1088ffb809206a85c1e3","unresolved":false,"context_lines":[{"line_number":519,"context_line":"\tint state_count;"},{"line_number":520,"context_line":"\tuint8_t tms \u003d 0xff;"},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"\tstate_count \u003d 0;"},{"line_number":523,"context_line":"\twhile (num_states) {"},{"line_number":524,"context_line":"\t\tif (tap_state_transition(tap_get_state(), false) \u003d\u003d cmd-\u003epath[state_count]) {"},{"line_number":525,"context_line":"\t\t\txvc_queue(NULL, 0, NULL, 0, NULL, 0, 1);"}],"source_content_type":"text/x-csrc","patch_set":13,"id":"a69f0bf6_203f488f","line":522,"in_reply_to":"64b1bf53_ec8750f9","updated":"2024-07-24 11:49:05.000000000","message":"Done","commit_id":"b094e21223faf5f2dcb741dc0ae6bb73c5e8f32d"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"74ac502b86d70113137142c67aefaf4ba254cf21","unresolved":true,"context_lines":[{"line_number":74,"context_line":"static int xvc_set_tck(void);"},{"line_number":75,"context_line":"static int xvc_fill_buffer(void);"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"/* Auxiliary and TCL helper functions*/"},{"line_number":78,"context_line":"static unsigned int xvc_bits_to_bytes(unsigned int bits)"},{"line_number":79,"context_line":"{"},{"line_number":80,"context_line":"\treturn DIV_ROUND_UP(bits, 8);"}],"source_content_type":"text/x-csrc","patch_set":14,"id":"6957346c_89886410","line":77,"updated":"2025-05-13 06:44:41.000000000","message":"Remove comment, no valuable information and there are no Tcl helper functions.","commit_id":"c107aabe537f5fe98b03d08e71a4aab26e59a654"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"ae3b3768331c9b83391a30ef99f9dfb18b2cf9a4","unresolved":false,"context_lines":[{"line_number":74,"context_line":"static int xvc_set_tck(void);"},{"line_number":75,"context_line":"static int xvc_fill_buffer(void);"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"/* Auxiliary and TCL helper functions*/"},{"line_number":78,"context_line":"static unsigned int xvc_bits_to_bytes(unsigned int bits)"},{"line_number":79,"context_line":"{"},{"line_number":80,"context_line":"\treturn DIV_ROUND_UP(bits, 8);"}],"source_content_type":"text/x-csrc","patch_set":14,"id":"099d794f_a819caf6","line":77,"in_reply_to":"6957346c_89886410","updated":"2025-05-16 08:22:39.000000000","message":"Done","commit_id":"c107aabe537f5fe98b03d08e71a4aab26e59a654"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"74ac502b86d70113137142c67aefaf4ba254cf21","unresolved":true,"context_lines":[{"line_number":109,"context_line":"\t\tint state \u003d read_socket(sock_id, ptr, i);"},{"line_number":110,"context_line":"\t\tif (state \u003d\u003d 0) {"},{"line_number":111,"context_line":"\t\t\tLOG_ERROR(\"No data available in socket at %s\", __func__);"},{"line_number":112,"context_line":"\t\t\treturn ERROR_FAIL; /* report error to the caller */"},{"line_number":113,"context_line":"\t\t}"},{"line_number":114,"context_line":"\t\tif (state \u003c 0) {"},{"line_number":115,"context_line":"\t\t\tLOG_ERROR(\"Reading error in %s\", __func__);"}],"source_content_type":"text/x-csrc","patch_set":14,"id":"e517d5b3_cd643d56","line":112,"updated":"2025-05-13 06:44:41.000000000","message":"Remove comment","commit_id":"c107aabe537f5fe98b03d08e71a4aab26e59a654"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"ae3b3768331c9b83391a30ef99f9dfb18b2cf9a4","unresolved":false,"context_lines":[{"line_number":109,"context_line":"\t\tint state \u003d read_socket(sock_id, ptr, i);"},{"line_number":110,"context_line":"\t\tif (state \u003d\u003d 0) {"},{"line_number":111,"context_line":"\t\t\tLOG_ERROR(\"No data available in socket at %s\", __func__);"},{"line_number":112,"context_line":"\t\t\treturn ERROR_FAIL; /* report error to the caller */"},{"line_number":113,"context_line":"\t\t}"},{"line_number":114,"context_line":"\t\tif (state \u003c 0) {"},{"line_number":115,"context_line":"\t\t\tLOG_ERROR(\"Reading error in %s\", __func__);"}],"source_content_type":"text/x-csrc","patch_set":14,"id":"7537ff44_c0ac06d8","line":112,"in_reply_to":"e517d5b3_cd643d56","updated":"2025-05-16 08:22:39.000000000","message":"Done","commit_id":"c107aabe537f5fe98b03d08e71a4aab26e59a654"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"74ac502b86d70113137142c67aefaf4ba254cf21","unresolved":true,"context_lines":[{"line_number":207,"context_line":"{"},{"line_number":208,"context_line":"\tconst char *getinfo \u003d \"getinfo:\";"},{"line_number":209,"context_line":"\tunsigned int len \u003d strlen(getinfo);"},{"line_number":210,"context_line":"\t/* Sends getinfo command */"},{"line_number":211,"context_line":"\tssize_t written \u003d write_socket(xvc_fd, getinfo, len);"},{"line_number":212,"context_line":"\tif (written !\u003d len) {"},{"line_number":213,"context_line":"\t\tLOG_ERROR(\"%s: write\", __func__);"}],"source_content_type":"text/x-csrc","patch_set":14,"id":"1508f9ee_5d3c50d4","line":210,"updated":"2025-05-13 06:44:41.000000000","message":"Remove comment, obvious.","commit_id":"c107aabe537f5fe98b03d08e71a4aab26e59a654"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"ae3b3768331c9b83391a30ef99f9dfb18b2cf9a4","unresolved":false,"context_lines":[{"line_number":207,"context_line":"{"},{"line_number":208,"context_line":"\tconst char *getinfo \u003d \"getinfo:\";"},{"line_number":209,"context_line":"\tunsigned int len \u003d strlen(getinfo);"},{"line_number":210,"context_line":"\t/* Sends getinfo command */"},{"line_number":211,"context_line":"\tssize_t written \u003d write_socket(xvc_fd, getinfo, len);"},{"line_number":212,"context_line":"\tif (written !\u003d len) {"},{"line_number":213,"context_line":"\t\tLOG_ERROR(\"%s: write\", __func__);"}],"source_content_type":"text/x-csrc","patch_set":14,"id":"310e334c_d3650ecf","line":210,"in_reply_to":"1508f9ee_5d3c50d4","updated":"2025-05-16 08:22:39.000000000","message":"Done","commit_id":"c107aabe537f5fe98b03d08e71a4aab26e59a654"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"74ac502b86d70113137142c67aefaf4ba254cf21","unresolved":true,"context_lines":[{"line_number":214,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":215,"context_line":"\t}"},{"line_number":216,"context_line":"\tchar info_recv_buf[20];"},{"line_number":217,"context_line":"\t/* Potentially waits until response gets received. */"},{"line_number":218,"context_line":"\tssize_t read \u003d read_socket(xvc_fd, info_recv_buf, sizeof(info_recv_buf));"},{"line_number":219,"context_line":"\tif (read \u003c 0) {"},{"line_number":220,"context_line":"\t\tLOG_ERROR(\"%s: read\", __func__);"}],"source_content_type":"text/x-csrc","patch_set":14,"id":"c86c6e7e_19be6c40","line":217,"updated":"2025-05-13 06:44:41.000000000","message":"Remove comment, obvious.","commit_id":"c107aabe537f5fe98b03d08e71a4aab26e59a654"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"ae3b3768331c9b83391a30ef99f9dfb18b2cf9a4","unresolved":false,"context_lines":[{"line_number":214,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":215,"context_line":"\t}"},{"line_number":216,"context_line":"\tchar info_recv_buf[20];"},{"line_number":217,"context_line":"\t/* Potentially waits until response gets received. */"},{"line_number":218,"context_line":"\tssize_t read \u003d read_socket(xvc_fd, info_recv_buf, sizeof(info_recv_buf));"},{"line_number":219,"context_line":"\tif (read \u003c 0) {"},{"line_number":220,"context_line":"\t\tLOG_ERROR(\"%s: read\", __func__);"}],"source_content_type":"text/x-csrc","patch_set":14,"id":"9c410ce9_d7766abf","line":217,"in_reply_to":"c86c6e7e_19be6c40","updated":"2025-05-16 08:22:39.000000000","message":"Done","commit_id":"c107aabe537f5fe98b03d08e71a4aab26e59a654"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"74ac502b86d70113137142c67aefaf4ba254cf21","unresolved":true,"context_lines":[{"line_number":223,"context_line":"\tLOG_INFO(\"XVC HW server version: %.19s\", info_recv_buf);"},{"line_number":224,"context_line":"\tif (strncmp(info_recv_buf, \"xvcServer_v1.0:\", 15) !\u003d 0 \u0026\u0026"},{"line_number":225,"context_line":"\t\tstrncmp(info_recv_buf, \"xvcServer_v1.1:\", 15) !\u003d 0) {"},{"line_number":226,"context_line":"\t\t/* We got something unexpected. */"},{"line_number":227,"context_line":"\t\tLOG_ERROR(\"Unexpected response from XVC server\");"},{"line_number":228,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":229,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":14,"id":"f862d992_bf390ee3","line":226,"updated":"2025-05-13 06:44:41.000000000","message":"Remove comment, obvious from error message.","commit_id":"c107aabe537f5fe98b03d08e71a4aab26e59a654"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"ae3b3768331c9b83391a30ef99f9dfb18b2cf9a4","unresolved":false,"context_lines":[{"line_number":223,"context_line":"\tLOG_INFO(\"XVC HW server version: %.19s\", info_recv_buf);"},{"line_number":224,"context_line":"\tif (strncmp(info_recv_buf, \"xvcServer_v1.0:\", 15) !\u003d 0 \u0026\u0026"},{"line_number":225,"context_line":"\t\tstrncmp(info_recv_buf, \"xvcServer_v1.1:\", 15) !\u003d 0) {"},{"line_number":226,"context_line":"\t\t/* We got something unexpected. */"},{"line_number":227,"context_line":"\t\tLOG_ERROR(\"Unexpected response from XVC server\");"},{"line_number":228,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":229,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":14,"id":"1340fb24_b203aafd","line":226,"in_reply_to":"f862d992_bf390ee3","updated":"2025-05-16 08:22:39.000000000","message":"Done","commit_id":"c107aabe537f5fe98b03d08e71a4aab26e59a654"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"74ac502b86d70113137142c67aefaf4ba254cf21","unresolved":true,"context_lines":[{"line_number":263,"context_line":"\tconst char *header \u003d \"set_tck:\";"},{"line_number":264,"context_line":"\tmemcpy(set_tck, header, strlen(header));"},{"line_number":265,"context_line":"\th_u32_to_le(set_tck + strlen(header), xvc_tck);"},{"line_number":266,"context_line":"\t/* Writes the request */"},{"line_number":267,"context_line":"\tssize_t written \u003d write_socket(xvc_fd, set_tck, 11);"},{"line_number":268,"context_line":"\tif (written !\u003d 11) {"},{"line_number":269,"context_line":"\t\tLOG_ERROR(\"%s: write\", __func__);"}],"source_content_type":"text/x-csrc","patch_set":14,"id":"056ed07a_564203e5","line":266,"updated":"2025-05-13 06:44:41.000000000","message":"Remove comment, obvious.","commit_id":"c107aabe537f5fe98b03d08e71a4aab26e59a654"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"ae3b3768331c9b83391a30ef99f9dfb18b2cf9a4","unresolved":false,"context_lines":[{"line_number":263,"context_line":"\tconst char *header \u003d \"set_tck:\";"},{"line_number":264,"context_line":"\tmemcpy(set_tck, header, strlen(header));"},{"line_number":265,"context_line":"\th_u32_to_le(set_tck + strlen(header), xvc_tck);"},{"line_number":266,"context_line":"\t/* Writes the request */"},{"line_number":267,"context_line":"\tssize_t written \u003d write_socket(xvc_fd, set_tck, 11);"},{"line_number":268,"context_line":"\tif (written !\u003d 11) {"},{"line_number":269,"context_line":"\t\tLOG_ERROR(\"%s: write\", __func__);"}],"source_content_type":"text/x-csrc","patch_set":14,"id":"3861ddf3_b751f41b","line":266,"in_reply_to":"056ed07a_564203e5","updated":"2025-05-16 08:22:39.000000000","message":"Done","commit_id":"c107aabe537f5fe98b03d08e71a4aab26e59a654"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"74ac502b86d70113137142c67aefaf4ba254cf21","unresolved":true,"context_lines":[{"line_number":270,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":271,"context_line":"\t}"},{"line_number":272,"context_line":"\tuint32_t tck_recv_buf;"},{"line_number":273,"context_line":"\t/* Potentially waits for a response. */"},{"line_number":274,"context_line":"\tssize_t read \u003d read_socket(xvc_fd, \u0026tck_recv_buf, sizeof(tck_recv_buf));"},{"line_number":275,"context_line":"\tif (read \u003c 0) {"},{"line_number":276,"context_line":"\t\tLOG_ERROR(\"%s: read\", __func__);"}],"source_content_type":"text/x-csrc","patch_set":14,"id":"61337d2c_84f02755","line":273,"updated":"2025-05-13 06:44:41.000000000","message":"Remove comment, obvious.","commit_id":"c107aabe537f5fe98b03d08e71a4aab26e59a654"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"ae3b3768331c9b83391a30ef99f9dfb18b2cf9a4","unresolved":false,"context_lines":[{"line_number":270,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":271,"context_line":"\t}"},{"line_number":272,"context_line":"\tuint32_t tck_recv_buf;"},{"line_number":273,"context_line":"\t/* Potentially waits for a response. */"},{"line_number":274,"context_line":"\tssize_t read \u003d read_socket(xvc_fd, \u0026tck_recv_buf, sizeof(tck_recv_buf));"},{"line_number":275,"context_line":"\tif (read \u003c 0) {"},{"line_number":276,"context_line":"\t\tLOG_ERROR(\"%s: read\", __func__);"}],"source_content_type":"text/x-csrc","patch_set":14,"id":"2ac103d3_0fd46984","line":273,"in_reply_to":"61337d2c_84f02755","updated":"2025-05-16 08:22:39.000000000","message":"Done","commit_id":"c107aabe537f5fe98b03d08e71a4aab26e59a654"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"74ac502b86d70113137142c67aefaf4ba254cf21","unresolved":true,"context_lines":[{"line_number":330,"context_line":"\t If socket(2) (or connect(2)) fails, we (close the socket"},{"line_number":331,"context_line":"\t and) try the next address. */"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"\tfor (rp \u003d result; rp; rp \u003d rp-\u003eai_next) {"},{"line_number":334,"context_line":"\t\t*fd \u003d socket(rp-\u003eai_family, rp-\u003eai_socktype, rp-\u003eai_protocol);"},{"line_number":335,"context_line":"#ifndef _WIN32"},{"line_number":336,"context_line":"\t\tif (*fd \u003d\u003d -1)"}],"source_content_type":"text/x-csrc","patch_set":14,"id":"4246656d_ffd34cc2","line":333,"updated":"2025-05-13 06:44:41.000000000","message":"Declaration of \u0027rp\u0027 can be moved before the loop.","commit_id":"c107aabe537f5fe98b03d08e71a4aab26e59a654"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"ae3b3768331c9b83391a30ef99f9dfb18b2cf9a4","unresolved":false,"context_lines":[{"line_number":330,"context_line":"\t If socket(2) (or connect(2)) fails, we (close the socket"},{"line_number":331,"context_line":"\t and) try the next address. */"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"\tfor (rp \u003d result; rp; rp \u003d rp-\u003eai_next) {"},{"line_number":334,"context_line":"\t\t*fd \u003d socket(rp-\u003eai_family, rp-\u003eai_socktype, rp-\u003eai_protocol);"},{"line_number":335,"context_line":"#ifndef _WIN32"},{"line_number":336,"context_line":"\t\tif (*fd \u003d\u003d -1)"}],"source_content_type":"text/x-csrc","patch_set":14,"id":"20cd60db_8d7d99aa","line":333,"in_reply_to":"4246656d_ffd34cc2","updated":"2025-05-16 08:22:39.000000000","message":"Done","commit_id":"c107aabe537f5fe98b03d08e71a4aab26e59a654"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"74ac502b86d70113137142c67aefaf4ba254cf21","unresolved":true,"context_lines":[{"line_number":355,"context_line":""},{"line_number":356,"context_line":"\tfreeaddrinfo(result); /* No longer needed */"},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"\tif (!rp) { /* No address succeeded */"},{"line_number":359,"context_line":"\t\tLOG_ERROR(\"Failed to connect\");"},{"line_number":360,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":361,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":14,"id":"770b4fd3_682cee6a","line":358,"updated":"2025-05-13 06:44:41.000000000","message":"Remove or move comment.","commit_id":"c107aabe537f5fe98b03d08e71a4aab26e59a654"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"ae3b3768331c9b83391a30ef99f9dfb18b2cf9a4","unresolved":false,"context_lines":[{"line_number":355,"context_line":""},{"line_number":356,"context_line":"\tfreeaddrinfo(result); /* No longer needed */"},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"\tif (!rp) { /* No address succeeded */"},{"line_number":359,"context_line":"\t\tLOG_ERROR(\"Failed to connect\");"},{"line_number":360,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":361,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":14,"id":"b6c21245_39644c03","line":358,"in_reply_to":"770b4fd3_682cee6a","updated":"2025-05-16 08:22:39.000000000","message":"Done","commit_id":"c107aabe537f5fe98b03d08e71a4aab26e59a654"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"74ac502b86d70113137142c67aefaf4ba254cf21","unresolved":true,"context_lines":[{"line_number":525,"context_line":""},{"line_number":526,"context_line":"static int xvc_tap_path_move(struct pathmove_command *cmd)"},{"line_number":527,"context_line":"{"},{"line_number":528,"context_line":"\tint num_states \u003d cmd-\u003enum_states;"},{"line_number":529,"context_line":"\tunsigned int state_count \u003d 0;"},{"line_number":530,"context_line":"\tuint8_t tms \u003d 0xff;"},{"line_number":531,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":14,"id":"137f53ac_3d94c29d","line":528,"updated":"2025-05-13 06:44:41.000000000","message":"Also \u0027unsigned int\u0027.","commit_id":"c107aabe537f5fe98b03d08e71a4aab26e59a654"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"ae3b3768331c9b83391a30ef99f9dfb18b2cf9a4","unresolved":false,"context_lines":[{"line_number":525,"context_line":""},{"line_number":526,"context_line":"static int xvc_tap_path_move(struct pathmove_command *cmd)"},{"line_number":527,"context_line":"{"},{"line_number":528,"context_line":"\tint num_states \u003d cmd-\u003enum_states;"},{"line_number":529,"context_line":"\tunsigned int state_count \u003d 0;"},{"line_number":530,"context_line":"\tuint8_t tms \u003d 0xff;"},{"line_number":531,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":14,"id":"332a3cf2_5cb09d14","line":528,"in_reply_to":"137f53ac_3d94c29d","updated":"2025-05-16 08:22:39.000000000","message":"Done","commit_id":"c107aabe537f5fe98b03d08e71a4aab26e59a654"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"74ac502b86d70113137142c67aefaf4ba254cf21","unresolved":true,"context_lines":[{"line_number":551,"context_line":"\treturn ERROR_OK;"},{"line_number":552,"context_line":"}"},{"line_number":553,"context_line":""},{"line_number":554,"context_line":"static int xvc_tap_stableclocks(int num_cycles)"},{"line_number":555,"context_line":"{"},{"line_number":556,"context_line":"\tuint8_t tms \u003d (tap_get_state() \u003d\u003d TAP_RESET ? 0xff : 0);"},{"line_number":557,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":14,"id":"1e52af25_29841d41","line":554,"updated":"2025-05-13 06:44:41.000000000","message":"Also \u0027unsigned int\u0027.","commit_id":"c107aabe537f5fe98b03d08e71a4aab26e59a654"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"ae3b3768331c9b83391a30ef99f9dfb18b2cf9a4","unresolved":false,"context_lines":[{"line_number":551,"context_line":"\treturn ERROR_OK;"},{"line_number":552,"context_line":"}"},{"line_number":553,"context_line":""},{"line_number":554,"context_line":"static int xvc_tap_stableclocks(int num_cycles)"},{"line_number":555,"context_line":"{"},{"line_number":556,"context_line":"\tuint8_t tms \u003d (tap_get_state() \u003d\u003d TAP_RESET ? 0xff : 0);"},{"line_number":557,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":14,"id":"9f7168fe_245e4536","line":554,"in_reply_to":"1e52af25_29841d41","updated":"2025-05-16 08:22:39.000000000","message":"Done","commit_id":"c107aabe537f5fe98b03d08e71a4aab26e59a654"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"74ac502b86d70113137142c67aefaf4ba254cf21","unresolved":true,"context_lines":[{"line_number":561,"context_line":"\treturn ERROR_OK;"},{"line_number":562,"context_line":"}"},{"line_number":563,"context_line":""},{"line_number":564,"context_line":"static int xvc_tap_runtest(int num_cycles)"},{"line_number":565,"context_line":"{"},{"line_number":566,"context_line":"\ttap_state_t saved_end_state \u003d tap_get_end_state();"},{"line_number":567,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":14,"id":"e8a359e2_9587167f","line":564,"updated":"2025-05-13 06:44:41.000000000","message":"Should be \u0027unsigned int\u0027, changed in the meantime.","commit_id":"c107aabe537f5fe98b03d08e71a4aab26e59a654"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"ae3b3768331c9b83391a30ef99f9dfb18b2cf9a4","unresolved":false,"context_lines":[{"line_number":561,"context_line":"\treturn ERROR_OK;"},{"line_number":562,"context_line":"}"},{"line_number":563,"context_line":""},{"line_number":564,"context_line":"static int xvc_tap_runtest(int num_cycles)"},{"line_number":565,"context_line":"{"},{"line_number":566,"context_line":"\ttap_state_t saved_end_state \u003d tap_get_end_state();"},{"line_number":567,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":14,"id":"9fbf4d35_45e0e17c","line":564,"in_reply_to":"e8a359e2_9587167f","updated":"2025-05-16 08:22:39.000000000","message":"I kept this line as it is, this function potentially returns ERROR_FAIL. As it is currently coded, ERROR_X codes use signed ints. It might make sense to use unsigned int as type for \u0027num_cycles\u0027. Did you mean to use the \u0027unsigned int\u0027 type for num_cycles?","commit_id":"c107aabe537f5fe98b03d08e71a4aab26e59a654"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"74ac502b86d70113137142c67aefaf4ba254cf21","unresolved":true,"context_lines":[{"line_number":610,"context_line":"\t}"},{"line_number":611,"context_line":"\txvc_tap_end_state(cmd-\u003eend_state);"},{"line_number":612,"context_line":""},{"line_number":613,"context_line":"\tfor (int i \u003d 0; i \u003c cmd-\u003enum_fields; i++) {"},{"line_number":614,"context_line":"\t\t/*"},{"line_number":615,"context_line":"\t\t * Last field"},{"line_number":616,"context_line":"\t\t * */"}],"source_content_type":"text/x-csrc","patch_set":14,"id":"39a4b9e5_b976e64f","line":613,"updated":"2025-05-13 06:44:41.000000000","message":"Should be \u0027unsigned int\u0027, changed in the meantime.","commit_id":"c107aabe537f5fe98b03d08e71a4aab26e59a654"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"ae3b3768331c9b83391a30ef99f9dfb18b2cf9a4","unresolved":false,"context_lines":[{"line_number":610,"context_line":"\t}"},{"line_number":611,"context_line":"\txvc_tap_end_state(cmd-\u003eend_state);"},{"line_number":612,"context_line":""},{"line_number":613,"context_line":"\tfor (int i \u003d 0; i \u003c cmd-\u003enum_fields; i++) {"},{"line_number":614,"context_line":"\t\t/*"},{"line_number":615,"context_line":"\t\t * Last field"},{"line_number":616,"context_line":"\t\t * */"}],"source_content_type":"text/x-csrc","patch_set":14,"id":"7b904482_c6382130","line":613,"in_reply_to":"39a4b9e5_b976e64f","updated":"2025-05-16 08:22:39.000000000","message":"Done","commit_id":"c107aabe537f5fe98b03d08e71a4aab26e59a654"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"74ac502b86d70113137142c67aefaf4ba254cf21","unresolved":true,"context_lines":[{"line_number":650,"context_line":""},{"line_number":651,"context_line":"static int xvc_tap_execute_queue(struct jtag_command *cmd_queue)"},{"line_number":652,"context_line":"{"},{"line_number":653,"context_line":"\tstruct jtag_command *cmd \u003d cmd_queue; /* currently processed command */"},{"line_number":654,"context_line":""},{"line_number":655,"context_line":"\twhile (cmd) {"},{"line_number":656,"context_line":"\t\tswitch (cmd-\u003etype) {"}],"source_content_type":"text/x-csrc","patch_set":14,"id":"f0d960f7_5b975934","line":653,"updated":"2025-05-13 06:44:41.000000000","message":"Remove comment.","commit_id":"c107aabe537f5fe98b03d08e71a4aab26e59a654"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"ae3b3768331c9b83391a30ef99f9dfb18b2cf9a4","unresolved":false,"context_lines":[{"line_number":650,"context_line":""},{"line_number":651,"context_line":"static int xvc_tap_execute_queue(struct jtag_command *cmd_queue)"},{"line_number":652,"context_line":"{"},{"line_number":653,"context_line":"\tstruct jtag_command *cmd \u003d cmd_queue; /* currently processed command */"},{"line_number":654,"context_line":""},{"line_number":655,"context_line":"\twhile (cmd) {"},{"line_number":656,"context_line":"\t\tswitch (cmd-\u003etype) {"}],"source_content_type":"text/x-csrc","patch_set":14,"id":"7e02d9ec_2768fb71","line":653,"in_reply_to":"f0d960f7_5b975934","updated":"2025-05-16 08:22:39.000000000","message":"Done","commit_id":"c107aabe537f5fe98b03d08e71a4aab26e59a654"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"74ac502b86d70113137142c67aefaf4ba254cf21","unresolved":true,"context_lines":[{"line_number":707,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":708,"context_line":"\tif (xvc_fill_buffer() !\u003d ERROR_OK)"},{"line_number":709,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":710,"context_line":"\t/* return ERROR_OK, unless a previous ERROR has been"},{"line_number":711,"context_line":"\t * returned."},{"line_number":712,"context_line":"\t */"},{"line_number":713,"context_line":"\treturn ERROR_OK;"}],"source_content_type":"text/x-csrc","patch_set":14,"id":"c39fd93d_dc3b7681","line":710,"updated":"2025-05-13 06:44:41.000000000","message":"Remove comment.","commit_id":"c107aabe537f5fe98b03d08e71a4aab26e59a654"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"ae3b3768331c9b83391a30ef99f9dfb18b2cf9a4","unresolved":false,"context_lines":[{"line_number":707,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":708,"context_line":"\tif (xvc_fill_buffer() !\u003d ERROR_OK)"},{"line_number":709,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":710,"context_line":"\t/* return ERROR_OK, unless a previous ERROR has been"},{"line_number":711,"context_line":"\t * returned."},{"line_number":712,"context_line":"\t */"},{"line_number":713,"context_line":"\treturn ERROR_OK;"}],"source_content_type":"text/x-csrc","patch_set":14,"id":"3237cd83_15ff2216","line":710,"in_reply_to":"c39fd93d_dc3b7681","updated":"2025-05-16 08:22:39.000000000","message":"Done","commit_id":"c107aabe537f5fe98b03d08e71a4aab26e59a654"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"494aad863615265c56a35c50e5f9783d8397af22","unresolved":true,"context_lines":[{"line_number":112,"context_line":"\t\t}"},{"line_number":113,"context_line":"\t\tif (state \u003c 0) {"},{"line_number":114,"context_line":"\t\t\tLOG_ERROR(\"Reading error in %s\", __func__);"},{"line_number":115,"context_line":"\t\t\treturn state;"},{"line_number":116,"context_line":"\t\t}"},{"line_number":117,"context_line":"\t\tptr +\u003d state;"},{"line_number":118,"context_line":"\t\ti -\u003d state;"}],"source_content_type":"text/x-csrc","patch_set":15,"id":"7dd259b4_4dba6e0d","line":115,"updated":"2025-06-21 08:38:05.000000000","message":"no, don\u0027t mix the returned values.\nThis function already returns `ERROR_FAIL`, `ERROR_OK`.\nIt cannot return the value from `read_socket()` that should be `-1`.\nI think here you can return again `ERROR_FAIL`","commit_id":"6aded56e662ad9ee4085ad5a6c9795bc11c6bb21"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"dd9f2bedf9077b57608cbdf3aeb37ba6b957aef6","unresolved":false,"context_lines":[{"line_number":112,"context_line":"\t\t}"},{"line_number":113,"context_line":"\t\tif (state \u003c 0) {"},{"line_number":114,"context_line":"\t\t\tLOG_ERROR(\"Reading error in %s\", __func__);"},{"line_number":115,"context_line":"\t\t\treturn state;"},{"line_number":116,"context_line":"\t\t}"},{"line_number":117,"context_line":"\t\tptr +\u003d state;"},{"line_number":118,"context_line":"\t\ti -\u003d state;"}],"source_content_type":"text/x-csrc","patch_set":15,"id":"d0519ad4_7a1f2cd2","line":115,"in_reply_to":"7dd259b4_4dba6e0d","updated":"2025-06-24 13:06:48.000000000","message":"Done","commit_id":"6aded56e662ad9ee4085ad5a6c9795bc11c6bb21"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"494aad863615265c56a35c50e5f9783d8397af22","unresolved":true,"context_lines":[{"line_number":337,"context_line":"\t\tif (connect(*fd, rp-\u003eai_addr, rp-\u003eai_addrlen) !\u003d -1)"},{"line_number":338,"context_line":"\t\t\tbreak; /* Success */"},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"\t\tclose(*fd);"},{"line_number":341,"context_line":"\t}"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"\t/* We work hard to collapse the writes into the minimum number, so when"}],"source_content_type":"text/x-csrc","patch_set":15,"id":"fca3c1fd_3280f672","line":340,"updated":"2025-06-21 08:38:05.000000000","message":"I think here you should use `close_socket(*fd);`\nI\u0027m not using windows, I\u0027m not sure","commit_id":"6aded56e662ad9ee4085ad5a6c9795bc11c6bb21"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"dd9f2bedf9077b57608cbdf3aeb37ba6b957aef6","unresolved":false,"context_lines":[{"line_number":337,"context_line":"\t\tif (connect(*fd, rp-\u003eai_addr, rp-\u003eai_addrlen) !\u003d -1)"},{"line_number":338,"context_line":"\t\t\tbreak; /* Success */"},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"\t\tclose(*fd);"},{"line_number":341,"context_line":"\t}"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"\t/* We work hard to collapse the writes into the minimum number, so when"}],"source_content_type":"text/x-csrc","patch_set":15,"id":"e17b61ac_efa93f21","line":340,"in_reply_to":"fca3c1fd_3280f672","updated":"2025-06-24 13:06:48.000000000","message":"Done","commit_id":"6aded56e662ad9ee4085ad5a6c9795bc11c6bb21"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"cd675060b3644b7e8db6cee33b7f72e2ca2ef63d","unresolved":true,"context_lines":[{"line_number":153,"context_line":"\tLOG_DEBUG(\"XVC flush: used_bits: %d\", xvc_used_bits);"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"\tssize_t written \u003d write_socket(xvc_fd, xvc_send_buf, cp_offset);"},{"line_number":156,"context_line":"\tif ((size_t)written !\u003d cp_offset) {"},{"line_number":157,"context_line":"\t\tLOG_ERROR(\"Error writing socket in %s\", __func__);"},{"line_number":158,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":159,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":21,"id":"d07df2ab_3f919b69","line":156,"updated":"2025-06-26 14:02:15.000000000","message":"I have a kind of allergy for the cast.\nSince `write_socket()` returns `int`, we can have\n`int written \u003d write_socket(...);`\nand to avoid cast to compare signed and unsigned, also `cp_offset` can be `int`.","commit_id":"fc557e79b624b05a7c1923e4e12b9aac96327572"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b8645f98582d4edd2a239b676cc457f76014bf93","unresolved":false,"context_lines":[{"line_number":153,"context_line":"\tLOG_DEBUG(\"XVC flush: used_bits: %d\", xvc_used_bits);"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"\tssize_t written \u003d write_socket(xvc_fd, xvc_send_buf, cp_offset);"},{"line_number":156,"context_line":"\tif ((size_t)written !\u003d cp_offset) {"},{"line_number":157,"context_line":"\t\tLOG_ERROR(\"Error writing socket in %s\", __func__);"},{"line_number":158,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":159,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":21,"id":"5fe6c1e3_a67e09c4","line":156,"in_reply_to":"d07df2ab_3f919b69","updated":"2025-07-02 21:51:10.000000000","message":"Done","commit_id":"fc557e79b624b05a7c1923e4e12b9aac96327572"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"f93f27e2b49eddf4cbe4f06e3388d7b4e9159821","unresolved":false,"context_lines":[{"line_number":153,"context_line":"\tLOG_DEBUG(\"XVC flush: used_bits: %d\", xvc_used_bits);"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"\tssize_t written \u003d write_socket(xvc_fd, xvc_send_buf, cp_offset);"},{"line_number":156,"context_line":"\tif ((size_t)written !\u003d cp_offset) {"},{"line_number":157,"context_line":"\t\tLOG_ERROR(\"Error writing socket in %s\", __func__);"},{"line_number":158,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":159,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":21,"id":"9777f238_1c3cf376","line":156,"in_reply_to":"d07df2ab_3f919b69","updated":"2025-09-05 12:25:10.000000000","message":"Done","commit_id":"fc557e79b624b05a7c1923e4e12b9aac96327572"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"cd675060b3644b7e8db6cee33b7f72e2ca2ef63d","unresolved":true,"context_lines":[{"line_number":207,"context_line":"\tconst char *getinfo \u003d \"getinfo:\";"},{"line_number":208,"context_line":"\tunsigned int len \u003d strlen(getinfo);"},{"line_number":209,"context_line":"\tssize_t written \u003d write_socket(xvc_fd, getinfo, len);"},{"line_number":210,"context_line":"\tif ((size_t)written !\u003d len) {"},{"line_number":211,"context_line":"\t\tLOG_ERROR(\"%s: write\", __func__);"},{"line_number":212,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":213,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":21,"id":"0f8edaad_8e3203cb","line":210,"updated":"2025-06-26 14:02:15.000000000","message":"also here, both `written` and `len` can be `int`.","commit_id":"fc557e79b624b05a7c1923e4e12b9aac96327572"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b8645f98582d4edd2a239b676cc457f76014bf93","unresolved":false,"context_lines":[{"line_number":207,"context_line":"\tconst char *getinfo \u003d \"getinfo:\";"},{"line_number":208,"context_line":"\tunsigned int len \u003d strlen(getinfo);"},{"line_number":209,"context_line":"\tssize_t written \u003d write_socket(xvc_fd, getinfo, len);"},{"line_number":210,"context_line":"\tif ((size_t)written !\u003d len) {"},{"line_number":211,"context_line":"\t\tLOG_ERROR(\"%s: write\", __func__);"},{"line_number":212,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":213,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":21,"id":"ced40a6a_f0002ffb","line":210,"in_reply_to":"0f8edaad_8e3203cb","updated":"2025-07-02 21:51:10.000000000","message":"Done","commit_id":"fc557e79b624b05a7c1923e4e12b9aac96327572"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"f93f27e2b49eddf4cbe4f06e3388d7b4e9159821","unresolved":false,"context_lines":[{"line_number":207,"context_line":"\tconst char *getinfo \u003d \"getinfo:\";"},{"line_number":208,"context_line":"\tunsigned int len \u003d strlen(getinfo);"},{"line_number":209,"context_line":"\tssize_t written \u003d write_socket(xvc_fd, getinfo, len);"},{"line_number":210,"context_line":"\tif ((size_t)written !\u003d len) {"},{"line_number":211,"context_line":"\t\tLOG_ERROR(\"%s: write\", __func__);"},{"line_number":212,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":213,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":21,"id":"e6d01a92_59769d22","line":210,"in_reply_to":"0f8edaad_8e3203cb","updated":"2025-09-05 12:25:10.000000000","message":"Done","commit_id":"fc557e79b624b05a7c1923e4e12b9aac96327572"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"cd675060b3644b7e8db6cee33b7f72e2ca2ef63d","unresolved":true,"context_lines":[{"line_number":256,"context_line":"\t * copies the header and appends the value."},{"line_number":257,"context_line":"\t * */"},{"line_number":258,"context_line":"\tuint8_t set_tck[12];"},{"line_number":259,"context_line":"\tconst char *header \u003d \"set_tck:\";"},{"line_number":260,"context_line":"\tmemcpy(set_tck, header, strlen(header));"},{"line_number":261,"context_line":"\th_u32_to_le(set_tck + strlen(header), xvc_tck);"},{"line_number":262,"context_line":"\tssize_t written \u003d write_socket(xvc_fd, set_tck, 11);"}],"source_content_type":"text/x-csrc","patch_set":21,"id":"c7edfed1_704479fd","line":259,"updated":"2025-06-26 14:02:15.000000000","message":"The documentation at\nhttps://github.com/Xilinx/XilinxVirtualCable/blob/master/README.md\nmentions the command `settck:`, not `set_tck:`.\nWhat\u0027s here? I think it\u0027s a wrong key pressed in your editor, as the extra char appears in version 14 of this patch.\nI noticed because `strlen(\"set_tck:\") + sizeof(uint32_t) \u003d\u003d 12` but the `write_socket()` sends only 11 bytes!","commit_id":"fc557e79b624b05a7c1923e4e12b9aac96327572"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b8645f98582d4edd2a239b676cc457f76014bf93","unresolved":false,"context_lines":[{"line_number":256,"context_line":"\t * copies the header and appends the value."},{"line_number":257,"context_line":"\t * */"},{"line_number":258,"context_line":"\tuint8_t set_tck[12];"},{"line_number":259,"context_line":"\tconst char *header \u003d \"set_tck:\";"},{"line_number":260,"context_line":"\tmemcpy(set_tck, header, strlen(header));"},{"line_number":261,"context_line":"\th_u32_to_le(set_tck + strlen(header), xvc_tck);"},{"line_number":262,"context_line":"\tssize_t written \u003d write_socket(xvc_fd, set_tck, 11);"}],"source_content_type":"text/x-csrc","patch_set":21,"id":"19e2ee90_525d270e","line":259,"in_reply_to":"c7edfed1_704479fd","updated":"2025-07-02 21:51:10.000000000","message":"Done","commit_id":"fc557e79b624b05a7c1923e4e12b9aac96327572"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"f93f27e2b49eddf4cbe4f06e3388d7b4e9159821","unresolved":false,"context_lines":[{"line_number":256,"context_line":"\t * copies the header and appends the value."},{"line_number":257,"context_line":"\t * */"},{"line_number":258,"context_line":"\tuint8_t set_tck[12];"},{"line_number":259,"context_line":"\tconst char *header \u003d \"set_tck:\";"},{"line_number":260,"context_line":"\tmemcpy(set_tck, header, strlen(header));"},{"line_number":261,"context_line":"\th_u32_to_le(set_tck + strlen(header), xvc_tck);"},{"line_number":262,"context_line":"\tssize_t written \u003d write_socket(xvc_fd, set_tck, 11);"}],"source_content_type":"text/x-csrc","patch_set":21,"id":"53096e17_008226fd","line":259,"in_reply_to":"c7edfed1_704479fd","updated":"2025-09-05 12:25:10.000000000","message":"Done. You are right, I think is a mistype when editing code.","commit_id":"fc557e79b624b05a7c1923e4e12b9aac96327572"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"cd675060b3644b7e8db6cee33b7f72e2ca2ef63d","unresolved":true,"context_lines":[{"line_number":421,"context_line":"\t\t.name \u003d \"host\","},{"line_number":422,"context_line":"\t\t.handler \u003d xvc_handle_host_command,"},{"line_number":423,"context_line":"\t\t.mode \u003d COMMAND_CONFIG,"},{"line_number":424,"context_line":"\t\t.help \u003d \"Set the host to use to connect to the remote XVC server.\","},{"line_number":425,"context_line":"\t\t.usage \u003d \"host_name\","},{"line_number":426,"context_line":"\t},"},{"line_number":427,"context_line":"\tCOMMAND_REGISTRATION_DONE"}],"source_content_type":"text/x-csrc","patch_set":21,"id":"e9195319_eb7b1672","line":424,"updated":"2025-06-26 14:02:15.000000000","message":"This is also used for the unix socket. Please document it.","commit_id":"fc557e79b624b05a7c1923e4e12b9aac96327572"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"f93f27e2b49eddf4cbe4f06e3388d7b4e9159821","unresolved":false,"context_lines":[{"line_number":421,"context_line":"\t\t.name \u003d \"host\","},{"line_number":422,"context_line":"\t\t.handler \u003d xvc_handle_host_command,"},{"line_number":423,"context_line":"\t\t.mode \u003d COMMAND_CONFIG,"},{"line_number":424,"context_line":"\t\t.help \u003d \"Set the host to use to connect to the remote XVC server.\","},{"line_number":425,"context_line":"\t\t.usage \u003d \"host_name\","},{"line_number":426,"context_line":"\t},"},{"line_number":427,"context_line":"\tCOMMAND_REGISTRATION_DONE"}],"source_content_type":"text/x-csrc","patch_set":21,"id":"bdab359d_a95c7c0f","line":424,"in_reply_to":"e9195319_eb7b1672","updated":"2025-09-05 12:25:10.000000000","message":"Done","commit_id":"fc557e79b624b05a7c1923e4e12b9aac96327572"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b8645f98582d4edd2a239b676cc457f76014bf93","unresolved":false,"context_lines":[{"line_number":421,"context_line":"\t\t.name \u003d \"host\","},{"line_number":422,"context_line":"\t\t.handler \u003d xvc_handle_host_command,"},{"line_number":423,"context_line":"\t\t.mode \u003d COMMAND_CONFIG,"},{"line_number":424,"context_line":"\t\t.help \u003d \"Set the host to use to connect to the remote XVC server.\","},{"line_number":425,"context_line":"\t\t.usage \u003d \"host_name\","},{"line_number":426,"context_line":"\t},"},{"line_number":427,"context_line":"\tCOMMAND_REGISTRATION_DONE"}],"source_content_type":"text/x-csrc","patch_set":21,"id":"e1a332e3_67f77d16","line":424,"in_reply_to":"e9195319_eb7b1672","updated":"2025-07-02 21:51:10.000000000","message":"Done","commit_id":"fc557e79b624b05a7c1923e4e12b9aac96327572"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"d5287260026f7cd6cacc71e5f8b7903810256eee","unresolved":true,"context_lines":[{"line_number":1,"context_line":"// SPDX-License-Identifier: GPL-2.0-or-later"},{"line_number":2,"context_line":"/***************************************************************************"},{"line_number":3,"context_line":" *   Copyright (C) 2021 by Jose Borja Castillo, DTE-UMA                    *"},{"line_number":4,"context_line":" *   joscassan@uma.es                                                      *"}],"source_content_type":"text/x-csrc","patch_set":22,"id":"6540c7a7_a8afde5a","line":1,"updated":"2025-08-11 18:53:20.000000000","message":"Filename `xlnx-xvc.c`, similar to the PCIe version `xlnx-pcei-xvc.c`?","commit_id":"3503281d1ad2fd078e9f3f6d7125aa1ac78dcb34"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"f93f27e2b49eddf4cbe4f06e3388d7b4e9159821","unresolved":false,"context_lines":[{"line_number":1,"context_line":"// SPDX-License-Identifier: GPL-2.0-or-later"},{"line_number":2,"context_line":"/***************************************************************************"},{"line_number":3,"context_line":" *   Copyright (C) 2021 by Jose Borja Castillo, DTE-UMA                    *"},{"line_number":4,"context_line":" *   joscassan@uma.es                                                      *"}],"source_content_type":"text/x-csrc","patch_set":22,"id":"7ed3dfda_b82fda60","line":1,"in_reply_to":"6540c7a7_a8afde5a","updated":"2025-09-05 12:25:10.000000000","message":"Current filename is xvc.c, I am not sure if \u0027xlnx-xvc.c\u0027 is a misunderstanding on your side or if we are required to rename this file, in which case I don\u0027t understand why.","commit_id":"3503281d1ad2fd078e9f3f6d7125aa1ac78dcb34"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"d5287260026f7cd6cacc71e5f8b7903810256eee","unresolved":true,"context_lines":[{"line_number":42,"context_line":"static uint8_t *xvc_tdi_buf;"},{"line_number":43,"context_line":"static uint8_t *xvc_send_buf;"},{"line_number":44,"context_line":"static uint8_t *xvc_tdo_buf;"},{"line_number":45,"context_line":"/* Being realistic, the protocol won\u0027t use as many bits. */"},{"line_number":46,"context_line":"static uint32_t xvc_used_bits;"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"/* XVC implementation specifics. */"}],"source_content_type":"text/x-csrc","patch_set":22,"id":"b8d33820_81ffa6e7","line":45,"updated":"2025-08-11 18:53:20.000000000","message":"Comment can be removed.","commit_id":"3503281d1ad2fd078e9f3f6d7125aa1ac78dcb34"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"f93f27e2b49eddf4cbe4f06e3388d7b4e9159821","unresolved":false,"context_lines":[{"line_number":42,"context_line":"static uint8_t *xvc_tdi_buf;"},{"line_number":43,"context_line":"static uint8_t *xvc_send_buf;"},{"line_number":44,"context_line":"static uint8_t *xvc_tdo_buf;"},{"line_number":45,"context_line":"/* Being realistic, the protocol won\u0027t use as many bits. */"},{"line_number":46,"context_line":"static uint32_t xvc_used_bits;"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"/* XVC implementation specifics. */"}],"source_content_type":"text/x-csrc","patch_set":22,"id":"91b2ac6c_c3ed1373","line":45,"in_reply_to":"b8d33820_81ffa6e7","updated":"2025-09-05 12:25:10.000000000","message":"Done","commit_id":"3503281d1ad2fd078e9f3f6d7125aa1ac78dcb34"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"d5287260026f7cd6cacc71e5f8b7903810256eee","unresolved":true,"context_lines":[{"line_number":45,"context_line":"/* Being realistic, the protocol won\u0027t use as many bits. */"},{"line_number":46,"context_line":"static uint32_t xvc_used_bits;"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"/* XVC implementation specifics. */"},{"line_number":49,"context_line":"static unsigned int xvc_max_vector_size;"},{"line_number":50,"context_line":"/* max_vector_size discounting command header. */"},{"line_number":51,"context_line":"static unsigned int xvc_max_usable_vector_size;"}],"source_content_type":"text/x-csrc","patch_set":22,"id":"77a1f247_02f54bbe","line":48,"updated":"2025-08-11 18:53:20.000000000","message":"Use `//` for single-line comments, see coding style guide.","commit_id":"3503281d1ad2fd078e9f3f6d7125aa1ac78dcb34"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"f93f27e2b49eddf4cbe4f06e3388d7b4e9159821","unresolved":false,"context_lines":[{"line_number":45,"context_line":"/* Being realistic, the protocol won\u0027t use as many bits. */"},{"line_number":46,"context_line":"static uint32_t xvc_used_bits;"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"/* XVC implementation specifics. */"},{"line_number":49,"context_line":"static unsigned int xvc_max_vector_size;"},{"line_number":50,"context_line":"/* max_vector_size discounting command header. */"},{"line_number":51,"context_line":"static unsigned int xvc_max_usable_vector_size;"}],"source_content_type":"text/x-csrc","patch_set":22,"id":"6dda19cc_7e23b701","line":48,"in_reply_to":"77a1f247_02f54bbe","updated":"2025-09-05 12:25:10.000000000","message":"Done.\n\nIs this a recent change?","commit_id":"3503281d1ad2fd078e9f3f6d7125aa1ac78dcb34"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"d5287260026f7cd6cacc71e5f8b7903810256eee","unresolved":true,"context_lines":[{"line_number":60,"context_line":"\t/* Offset in the destination buffer. */"},{"line_number":61,"context_line":"\tunsigned int buffer_offset;"},{"line_number":62,"context_line":"};"},{"line_number":63,"context_line":"/* MAX_BUF_SIZE holds the maximum size that internal buffers are allowed to"},{"line_number":64,"context_line":"\tbe allocated. This parameter is limited by the size of an unsigned int"},{"line_number":65,"context_line":"\t(2/4) bytes. Unsigned int types are employed by several functions in OpenOCD,"},{"line_number":66,"context_line":"\tlike \u0027write_socket\u0027. The offset of 11 bytes is set to ensure XVC commands"}],"source_content_type":"text/x-csrc","patch_set":22,"id":"bdfbd6bf_7a7fe2f4","line":63,"updated":"2025-08-11 18:53:20.000000000","message":"```\n/*\n * This is a multi-line comment.\n */\n```\n\nUse this style for multi-line comments.","commit_id":"3503281d1ad2fd078e9f3f6d7125aa1ac78dcb34"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"f93f27e2b49eddf4cbe4f06e3388d7b4e9159821","unresolved":false,"context_lines":[{"line_number":60,"context_line":"\t/* Offset in the destination buffer. */"},{"line_number":61,"context_line":"\tunsigned int buffer_offset;"},{"line_number":62,"context_line":"};"},{"line_number":63,"context_line":"/* MAX_BUF_SIZE holds the maximum size that internal buffers are allowed to"},{"line_number":64,"context_line":"\tbe allocated. This parameter is limited by the size of an unsigned int"},{"line_number":65,"context_line":"\t(2/4) bytes. Unsigned int types are employed by several functions in OpenOCD,"},{"line_number":66,"context_line":"\tlike \u0027write_socket\u0027. The offset of 11 bytes is set to ensure XVC commands"}],"source_content_type":"text/x-csrc","patch_set":22,"id":"fbdb9f02_37510c32","line":63,"in_reply_to":"bdfbd6bf_7a7fe2f4","updated":"2025-09-05 12:25:10.000000000","message":"Ack","commit_id":"3503281d1ad2fd078e9f3f6d7125aa1ac78dcb34"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"d5287260026f7cd6cacc71e5f8b7903810256eee","unresolved":true,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"static int read_frame(int sock_id, unsigned char *ptr, unsigned int size)"},{"line_number":106,"context_line":"{"},{"line_number":107,"context_line":"\tunsigned int i \u003d size;"},{"line_number":108,"context_line":"\twhile (i \u003e 0) {"},{"line_number":109,"context_line":"\t\tint state \u003d read_socket(sock_id, ptr, i);"},{"line_number":110,"context_line":"\t\tif (state \u003d\u003d 0) {"}],"source_content_type":"text/x-csrc","patch_set":22,"id":"3bbf9a80_afc7eb71","line":107,"updated":"2025-08-11 18:53:20.000000000","message":"Why do you need a new variable here?","commit_id":"3503281d1ad2fd078e9f3f6d7125aa1ac78dcb34"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"f93f27e2b49eddf4cbe4f06e3388d7b4e9159821","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"static int read_frame(int sock_id, unsigned char *ptr, unsigned int size)"},{"line_number":106,"context_line":"{"},{"line_number":107,"context_line":"\tunsigned int i \u003d size;"},{"line_number":108,"context_line":"\twhile (i \u003e 0) {"},{"line_number":109,"context_line":"\t\tint state \u003d read_socket(sock_id, ptr, i);"},{"line_number":110,"context_line":"\t\tif (state \u003d\u003d 0) {"}],"source_content_type":"text/x-csrc","patch_set":22,"id":"a2fff092_1df0c1a1","line":107,"in_reply_to":"3bbf9a80_afc7eb71","updated":"2025-09-05 12:25:10.000000000","message":"\u003e Why do you need a new variable here?\n\nWe aim for readable and easy to understand code.","commit_id":"3503281d1ad2fd078e9f3f6d7125aa1ac78dcb34"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"d5287260026f7cd6cacc71e5f8b7903810256eee","unresolved":true,"context_lines":[{"line_number":218,"context_line":"\t\tLOG_ERROR(\"%s: read\", __func__);"},{"line_number":219,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":220,"context_line":"\t}"},{"line_number":221,"context_line":"\tLOG_INFO(\"XVC HW server version: %.19s\", info_recv_buf);"},{"line_number":222,"context_line":"\tif (strncmp(info_recv_buf, \"xvcServer_v1.0:\", 15) !\u003d 0 \u0026\u0026"},{"line_number":223,"context_line":"\t\tstrncmp(info_recv_buf, \"xvcServer_v1.1:\", 15) !\u003d 0) {"},{"line_number":224,"context_line":"\t\tLOG_ERROR(\"Unexpected response from XVC server\");"}],"source_content_type":"text/x-csrc","patch_set":22,"id":"8640029e_dbeb1ec0","line":221,"updated":"2025-08-11 18:53:20.000000000","message":"You access potential uninitialized data.\n\n```\n\u003d\u003d746599\u003d\u003d Conditional jump or move depends on uninitialised value(s)\n\u003d\u003d746599\u003d\u003d    at 0x484ECCD: strnlen (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)\n\u003d\u003d746599\u003d\u003d    by 0x50C98D5: __vfprintf_internal (vfprintf-internal.c:1517)\n\u003d\u003d746599\u003d\u003d    by 0x50DC499: __vsnprintf_internal (vsnprintf.c:114)\n\u003d\u003d746599\u003d\u003d    by 0x20C5AF: vsnprintf (stdio2.h:85)\n\u003d\u003d746599\u003d\u003d    by 0x20C5AF: alloc_vprintf (log.c:358)\n\u003d\u003d746599\u003d\u003d    by 0x20C872: log_vprintf_lf (log.c:180)\n\u003d\u003d746599\u003d\u003d    by 0x20C872: log_vprintf_lf (log.c:170)\n\u003d\u003d746599\u003d\u003d    by 0x20C872: log_printf_lf (log.c:204)\n\u003d\u003d746599\u003d\u003d    by 0x1B511C: xvc_getinfo (xvc.c:221)\n\u003d\u003d746599\u003d\u003d    by 0x1B511C: xvc_init (xvc.c:459)\n\u003d\u003d746599\u003d\u003d    by 0x16E3E8: adapter_init (adapter.c:151)\n\u003d\u003d746599\u003d\u003d    by 0x16A768: handle_init_command (openocd.c:127)\n\u003d\u003d746599\u003d\u003d    by 0x16A768: handle_init_command (openocd.c:108)\n\u003d\u003d746599\u003d\u003d    by 0x209903: exec_command (command.c:453)\n\u003d\u003d746599\u003d\u003d    by 0x209903: jim_command_dispatch (command.c:870)\n\u003d\u003d746599\u003d\u003d    by 0x5024E06: ??? (in /usr/lib/x86_64-linux-gnu/libjim.so.0.79)\n\u003d\u003d746599\u003d\u003d    by 0x1: ???\n```","commit_id":"3503281d1ad2fd078e9f3f6d7125aa1ac78dcb34"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"f93f27e2b49eddf4cbe4f06e3388d7b4e9159821","unresolved":false,"context_lines":[{"line_number":218,"context_line":"\t\tLOG_ERROR(\"%s: read\", __func__);"},{"line_number":219,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":220,"context_line":"\t}"},{"line_number":221,"context_line":"\tLOG_INFO(\"XVC HW server version: %.19s\", info_recv_buf);"},{"line_number":222,"context_line":"\tif (strncmp(info_recv_buf, \"xvcServer_v1.0:\", 15) !\u003d 0 \u0026\u0026"},{"line_number":223,"context_line":"\t\tstrncmp(info_recv_buf, \"xvcServer_v1.1:\", 15) !\u003d 0) {"},{"line_number":224,"context_line":"\t\tLOG_ERROR(\"Unexpected response from XVC server\");"}],"source_content_type":"text/x-csrc","patch_set":22,"id":"a32384bc_926e4af3","line":221,"in_reply_to":"8640029e_dbeb1ec0","updated":"2025-09-05 12:25:10.000000000","message":"Ack.\n\n\u00270\u0027 set-value was given to the array. This should not affect in a great way because of the protocol details about how the server-driver interact.","commit_id":"3503281d1ad2fd078e9f3f6d7125aa1ac78dcb34"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"b5e2640bb355173ab03f9497ef061ea9dd36d066","unresolved":false,"context_lines":[{"line_number":218,"context_line":"\t\tLOG_ERROR(\"%s: read\", __func__);"},{"line_number":219,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":220,"context_line":"\t}"},{"line_number":221,"context_line":"\tLOG_INFO(\"XVC HW server version: %.19s\", info_recv_buf);"},{"line_number":222,"context_line":"\tif (strncmp(info_recv_buf, \"xvcServer_v1.0:\", 15) !\u003d 0 \u0026\u0026"},{"line_number":223,"context_line":"\t\tstrncmp(info_recv_buf, \"xvcServer_v1.1:\", 15) !\u003d 0) {"},{"line_number":224,"context_line":"\t\tLOG_ERROR(\"Unexpected response from XVC server\");"}],"source_content_type":"text/x-csrc","patch_set":22,"id":"c456ee6f_bcbb8241","line":221,"in_reply_to":"a32384bc_926e4af3","updated":"2025-10-14 09:08:54.000000000","message":"Please do not initialize with `\u00270\u0027` instead of `0` without a good reason. It\u0027s very confusing.\n\nYour `getinfo` handling is still not compliant with the protocol specification. The buffer size (`xvc_vector_len`) is **not** fixed-size. Your implementation fails for all cases where the textual representation of the buffer size is not 4 bytes.\n\n#### Server with buffer size of 128 bytes.\n\n```\nInfo : Listening on port 6666 for tcl connections\nInfo : Listening on port 4444 for telnet connections\nInfo : Connecting to 192.168.0.70:2542\nInfo : XVC HW server version: xvcServer_v1.0:128\n\nInfo : XVC tck period ns: 1000\nInfo : XVC tck period ns: 500\nInfo : clock speed 2000 kHz\n```\n\nStray newline here because of incorrect buffer handling.\n\n#### Server with buffer size of 16384.\n\n```\nInfo : Listening on port 6666 for tcl connections           \nInfo : Listening on port 4444 for telnet connections\nInfo : Connecting to 192.168.0.70:2542                                                      \nInfo : XVC HW server version: xvcServer_v1.0:1638      \n\u003d\u003d128797\u003d\u003d Use of uninitialised value of size 8               \n\u003d\u003d128797\u003d\u003d    at 0x499C430: _itoa_word (_itoa.c:177)   \n\u003d\u003d128797\u003d\u003d    by 0x49A6153: __vfprintf_internal (vfprintf-process-arg.c:164)\n\u003d\u003d128797\u003d\u003d    by 0x49C6D4F: __vsnprintf_internal (vsnprintf.c:114)            \n\u003d\u003d128797\u003d\u003d    by 0x49C6DCF: vsnprintf (vsnprintf.c:124)\n\u003d\u003d128797\u003d\u003d    by 0x1FCA7F: alloc_vprintf (log.c:358)           \n\u003d\u003d128797\u003d\u003d    by 0x1FCC37: log_vprintf_lf (log.c:180)                \n\u003d\u003d128797\u003d\u003d    by 0x1FCCEF: log_printf_lf (log.c:204)               \n\u003d\u003d128797\u003d\u003d    by 0x1A7E7B: xvc_set_tck (xvc.c:276)                 \n\u003d\u003d128797\u003d\u003d    by 0x1A87AB: xvc_init (xvc.c:457)                    \n\u003d\u003d128797\u003d\u003d    by 0x169F53: adapter_init (adapter.c:151)            \n\u003d\u003d128797\u003d\u003d    by 0x166357: handle_init_command (openocd.c:127)     \n\u003d\u003d128797\u003d\u003d    by 0x1F9F0B: exec_command (command.c:453)            \n\u003d\u003d128797\u003d\u003d    by 0x1F9F0B: jim_command_dispatch (command.c:870)    \n\u003d\u003d128797\u003d\u003d                                                                                  \n\u003d\u003d128797\u003d\u003d Conditional jump or move depends on uninitialised value(s)\n\u003d\u003d128797\u003d\u003d    at 0x499C43C: _itoa_word (_itoa.c:177)               \n\u003d\u003d128797\u003d\u003d    by 0x49A6153: __vfprintf_internal (vfprintf-process-arg.c:164)\n\u003d\u003d128797\u003d\u003d    by 0x49C6D4F: __vsnprintf_internal (vsnprintf.c:114)  \n\u003d\u003d128797\u003d\u003d    by 0x49C6DCF: vsnprintf (vsnprintf.c:124)             \n\u003d\u003d128797\u003d\u003d    by 0x1FCA7F: alloc_vprintf (log.c:358)               \n\u003d\u003d128797\u003d\u003d    by 0x1FCC37: log_vprintf_lf (log.c:180)              \n\u003d\u003d128797\u003d\u003d    by 0x1FCCEF: log_printf_lf (log.c:204)               \n\u003d\u003d128797\u003d\u003d    by 0x1A7E7B: xvc_set_tck (xvc.c:276)                 \n\u003d\u003d128797\u003d\u003d    by 0x1A87AB: xvc_init (xvc.c:457)                   \n\u003d\u003d128797\u003d\u003d    by 0x169F53: adapter_init (adapter.c:151)           \n\u003d\u003d128797\u003d\u003d    by 0x166357: handle_init_command (openocd.c:127)\n\u003d\u003d128797\u003d\u003d    by 0x1F9F0B: exec_command (command.c:453)   \n\u003d\u003d128797\u003d\u003d    by 0x1F9F0B: jim_command_dispatch (command.c:870)\n\u003d\u003d128797\u003d\u003d                                                                                  \nInfo : XVC tck period ns: 10                                                                \nInfo : XVC tck period ns: 1000                                                              \nInfo : clock speed 2000 kHz\n```\n\nSome valgrind errors (no time for root causing) and invalid server `getinfo` message.\n\nPlease fix the newline issue and use a reasonable large receive buffer to handle larger `xvc_vector_len`.","commit_id":"3503281d1ad2fd078e9f3f6d7125aa1ac78dcb34"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"6a3b1ae39749ac684839dd9888ee23620dcd77da","unresolved":false,"context_lines":[{"line_number":218,"context_line":"\t\tLOG_ERROR(\"%s: read\", __func__);"},{"line_number":219,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":220,"context_line":"\t}"},{"line_number":221,"context_line":"\tLOG_INFO(\"XVC HW server version: %.19s\", info_recv_buf);"},{"line_number":222,"context_line":"\tif (strncmp(info_recv_buf, \"xvcServer_v1.0:\", 15) !\u003d 0 \u0026\u0026"},{"line_number":223,"context_line":"\t\tstrncmp(info_recv_buf, \"xvcServer_v1.1:\", 15) !\u003d 0) {"},{"line_number":224,"context_line":"\t\tLOG_ERROR(\"Unexpected response from XVC server\");"}],"source_content_type":"text/x-csrc","patch_set":22,"id":"a6157e80_f79ac139","line":221,"in_reply_to":"c456ee6f_bcbb8241","updated":"2025-10-15 08:32:30.000000000","message":"Done.\nAlso passed valgrind OK without errors.","commit_id":"3503281d1ad2fd078e9f3f6d7125aa1ac78dcb34"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"d5287260026f7cd6cacc71e5f8b7903810256eee","unresolved":true,"context_lines":[{"line_number":280,"context_line":""},{"line_number":281,"context_line":"static int xvc_fill_buffer(void)"},{"line_number":282,"context_line":"{"},{"line_number":283,"context_line":"\tif (read_frame(xvc_fd, xvc_tdo_buf, DIV_ROUND_UP(last_used_bits, 8)) !\u003d ERROR_OK) {"},{"line_number":284,"context_line":"\t\tLOG_ERROR(\"Read_frame\");"},{"line_number":285,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":286,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":22,"id":"1e6dbd20_bea51f60","line":283,"updated":"2025-08-11 18:53:20.000000000","message":"Why not using your own function `xvc_bits_to_bytes()`?","commit_id":"3503281d1ad2fd078e9f3f6d7125aa1ac78dcb34"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"f93f27e2b49eddf4cbe4f06e3388d7b4e9159821","unresolved":false,"context_lines":[{"line_number":280,"context_line":""},{"line_number":281,"context_line":"static int xvc_fill_buffer(void)"},{"line_number":282,"context_line":"{"},{"line_number":283,"context_line":"\tif (read_frame(xvc_fd, xvc_tdo_buf, DIV_ROUND_UP(last_used_bits, 8)) !\u003d ERROR_OK) {"},{"line_number":284,"context_line":"\t\tLOG_ERROR(\"Read_frame\");"},{"line_number":285,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":286,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":22,"id":"2df7ba00_43421df7","line":283,"in_reply_to":"1e6dbd20_bea51f60","updated":"2025-09-05 12:25:10.000000000","message":"Done","commit_id":"3503281d1ad2fd078e9f3f6d7125aa1ac78dcb34"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"d5287260026f7cd6cacc71e5f8b7903810256eee","unresolved":true,"context_lines":[{"line_number":498,"context_line":"}"},{"line_number":499,"context_line":""},{"line_number":500,"context_line":"/*"},{"line_number":501,"context_line":" * Clock a bunch of TMS (or SWDIO) transitions, to change the JTAG"},{"line_number":502,"context_line":" * (or SWD) state machine. \"Legacy enqueue\""},{"line_number":503,"context_line":" */"},{"line_number":504,"context_line":"static int xvc_tap_execute_tms(struct jtag_command *cmd)"}],"source_content_type":"text/x-csrc","patch_set":22,"id":"d37a7bb7_8d8d4a08","line":501,"updated":"2025-08-11 18:53:20.000000000","message":"Remove SWD leftovers, only JTAG is supported.","commit_id":"3503281d1ad2fd078e9f3f6d7125aa1ac78dcb34"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"f93f27e2b49eddf4cbe4f06e3388d7b4e9159821","unresolved":false,"context_lines":[{"line_number":498,"context_line":"}"},{"line_number":499,"context_line":""},{"line_number":500,"context_line":"/*"},{"line_number":501,"context_line":" * Clock a bunch of TMS (or SWDIO) transitions, to change the JTAG"},{"line_number":502,"context_line":" * (or SWD) state machine. \"Legacy enqueue\""},{"line_number":503,"context_line":" */"},{"line_number":504,"context_line":"static int xvc_tap_execute_tms(struct jtag_command *cmd)"}],"source_content_type":"text/x-csrc","patch_set":22,"id":"4787aff3_760be267","line":501,"in_reply_to":"d37a7bb7_8d8d4a08","updated":"2025-09-05 12:25:10.000000000","message":"Done","commit_id":"3503281d1ad2fd078e9f3f6d7125aa1ac78dcb34"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"d5287260026f7cd6cacc71e5f8b7903810256eee","unresolved":true,"context_lines":[{"line_number":548,"context_line":""},{"line_number":549,"context_line":"static unsigned int xvc_tap_stableclocks(int num_cycles)"},{"line_number":550,"context_line":"{"},{"line_number":551,"context_line":"\tuint8_t tms \u003d (tap_get_state() \u003d\u003d TAP_RESET ? 0xff : 0);"},{"line_number":552,"context_line":""},{"line_number":553,"context_line":"\tfor (int i \u003d 0; i \u003c num_cycles; i++)"},{"line_number":554,"context_line":"\t\txvc_queue(\u0026tms, 0, NULL, 0, NULL, 0, 1);"}],"source_content_type":"text/x-csrc","patch_set":22,"id":"21d1032f_f1f115ca","line":551,"updated":"2025-08-11 18:53:20.000000000","message":"Remove useless parentheses.","commit_id":"3503281d1ad2fd078e9f3f6d7125aa1ac78dcb34"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"f93f27e2b49eddf4cbe4f06e3388d7b4e9159821","unresolved":false,"context_lines":[{"line_number":548,"context_line":""},{"line_number":549,"context_line":"static unsigned int xvc_tap_stableclocks(int num_cycles)"},{"line_number":550,"context_line":"{"},{"line_number":551,"context_line":"\tuint8_t tms \u003d (tap_get_state() \u003d\u003d TAP_RESET ? 0xff : 0);"},{"line_number":552,"context_line":""},{"line_number":553,"context_line":"\tfor (int i \u003d 0; i \u003c num_cycles; i++)"},{"line_number":554,"context_line":"\t\txvc_queue(\u0026tms, 0, NULL, 0, NULL, 0, 1);"}],"source_content_type":"text/x-csrc","patch_set":22,"id":"11b15474_6a91ff1f","line":551,"in_reply_to":"21d1032f_f1f115ca","updated":"2025-09-05 12:25:10.000000000","message":"The parentheses improve code clarity on our view.","commit_id":"3503281d1ad2fd078e9f3f6d7125aa1ac78dcb34"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"d5287260026f7cd6cacc71e5f8b7903810256eee","unresolved":true,"context_lines":[{"line_number":712,"context_line":"};"},{"line_number":713,"context_line":""},{"line_number":714,"context_line":"struct adapter_driver xvc_adapter_driver \u003d {"},{"line_number":715,"context_line":"\t.name \u003d \"xvc\","},{"line_number":716,"context_line":"\t.transport_ids \u003d TRANSPORT_JTAG,"},{"line_number":717,"context_line":"\t.transport_preferred_id \u003d TRANSPORT_JTAG,"},{"line_number":718,"context_line":"\t.commands \u003d xvc_command_handlers,"}],"source_content_type":"text/x-csrc","patch_set":22,"id":"9780a43e_54265a62","line":715,"updated":"2025-08-11 18:53:20.000000000","message":"xlnx-xvc?","commit_id":"3503281d1ad2fd078e9f3f6d7125aa1ac78dcb34"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"f93f27e2b49eddf4cbe4f06e3388d7b4e9159821","unresolved":false,"context_lines":[{"line_number":712,"context_line":"};"},{"line_number":713,"context_line":""},{"line_number":714,"context_line":"struct adapter_driver xvc_adapter_driver \u003d {"},{"line_number":715,"context_line":"\t.name \u003d \"xvc\","},{"line_number":716,"context_line":"\t.transport_ids \u003d TRANSPORT_JTAG,"},{"line_number":717,"context_line":"\t.transport_preferred_id \u003d TRANSPORT_JTAG,"},{"line_number":718,"context_line":"\t.commands \u003d xvc_command_handlers,"}],"source_content_type":"text/x-csrc","patch_set":22,"id":"f5f48b79_1b8e6c45","line":715,"in_reply_to":"9780a43e_54265a62","updated":"2025-09-05 12:25:10.000000000","message":"Same comment as #1.","commit_id":"3503281d1ad2fd078e9f3f6d7125aa1ac78dcb34"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"b5e2640bb355173ab03f9497ef061ea9dd36d066","unresolved":true,"context_lines":[{"line_number":217,"context_line":"\t\tLOG_ERROR(\"%s: read\", __func__);"},{"line_number":218,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":219,"context_line":"\t}"},{"line_number":220,"context_line":"\tLOG_INFO(\"XVC HW server version: %.19s\", info_recv_buf);"},{"line_number":221,"context_line":"\tif (strncmp(info_recv_buf, \"xvcServer_v1.0:\", 15) !\u003d 0 \u0026\u0026"},{"line_number":222,"context_line":"\t\tstrncmp(info_recv_buf, \"xvcServer_v1.1:\", 15) !\u003d 0) {"},{"line_number":223,"context_line":"\t\tLOG_ERROR(\"Unexpected response from XVC server\");"}],"source_content_type":"text/x-csrc","patch_set":23,"id":"73949bef_167f0d95","line":220,"updated":"2025-10-14 09:08:54.000000000","message":"Do not print the server response *before* checking it. Move behind the check and print something like `LOG_ERROR(\"Unexpected response from XVC server: %s\", info_recv_buf)`. Take care of string termination (see my comment about using `\u00270\u0027` instead of `0`)","commit_id":"a9ad0c0ca28eded67b36f031ed32df0ef9227a7d"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"6a3b1ae39749ac684839dd9888ee23620dcd77da","unresolved":false,"context_lines":[{"line_number":217,"context_line":"\t\tLOG_ERROR(\"%s: read\", __func__);"},{"line_number":218,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":219,"context_line":"\t}"},{"line_number":220,"context_line":"\tLOG_INFO(\"XVC HW server version: %.19s\", info_recv_buf);"},{"line_number":221,"context_line":"\tif (strncmp(info_recv_buf, \"xvcServer_v1.0:\", 15) !\u003d 0 \u0026\u0026"},{"line_number":222,"context_line":"\t\tstrncmp(info_recv_buf, \"xvcServer_v1.1:\", 15) !\u003d 0) {"},{"line_number":223,"context_line":"\t\tLOG_ERROR(\"Unexpected response from XVC server\");"}],"source_content_type":"text/x-csrc","patch_set":23,"id":"c0a53c60_f9954591","line":220,"in_reply_to":"73949bef_167f0d95","updated":"2025-10-15 08:32:30.000000000","message":"Done","commit_id":"a9ad0c0ca28eded67b36f031ed32df0ef9227a7d"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"6ce43516687764342519a2c7a365243933ac7ce5","unresolved":true,"context_lines":[{"line_number":222,"context_line":"\t// Byte read until \u0027\\n\u0027 or buffer full."},{"line_number":223,"context_line":"\tunsigned long idx \u003d 0;"},{"line_number":224,"context_line":"\twhile (idx \u003c sizeof(info_recv_buf) - 1) {"},{"line_number":225,"context_line":"\t\tint ret \u003d read_socket(xvc_fd, \u0026info_recv_buf[idx], 1);"},{"line_number":226,"context_line":"\t\tif (ret \u003c\u003d 0) {"},{"line_number":227,"context_line":"\t\t\tLOG_ERROR(\"%s: read\", __func__);"},{"line_number":228,"context_line":"\t\t\treturn ERROR_FAIL;"}],"source_content_type":"text/x-csrc","patch_set":25,"id":"b33651df_73dd27ad","line":225,"updated":"2025-11-14 10:03:08.000000000","message":"This can be quite inefficient, please read the entire buffer at once and search for \u0027\\n\u0027 afterwards, e.g.  with `strchr()`. If it\u0027s not found, raise an error. We ignore packet segmentation for now - the entire code and most of the OpenOCD code base ignores it anyway.","commit_id":"ed969c3410e0130ac2cda0d8759c42ad2ce0a78f"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"6ce43516687764342519a2c7a365243933ac7ce5","unresolved":true,"context_lines":[{"line_number":469,"context_line":"\tif (err !\u003d ERROR_OK)"},{"line_number":470,"context_line":"\t\treturn err;"},{"line_number":471,"context_line":""},{"line_number":472,"context_line":"\txvc_getinfo();"},{"line_number":473,"context_line":"\txvc_set_tck();"},{"line_number":474,"context_line":""},{"line_number":475,"context_line":"\tLOG_DEBUG(\"XVC driver initialized\");"}],"source_content_type":"text/x-csrc","patch_set":25,"id":"73ce7d95_155f8560","line":472,"updated":"2025-11-14 10:03:08.000000000","message":"Please check return values here.","commit_id":"ed969c3410e0130ac2cda0d8759c42ad2ce0a78f"}],"src/jtag/interface.h":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"0ee476617c076811187856a5e1f23cc527746e32","unresolved":true,"context_lines":[{"line_number":400,"context_line":"extern struct adapter_driver vdebug_adapter_driver;"},{"line_number":401,"context_line":"extern struct adapter_driver vsllink_adapter_driver;"},{"line_number":402,"context_line":"extern struct adapter_driver xds110_adapter_driver;"},{"line_number":403,"context_line":"extern struct adapter_driver xvc_driver;"},{"line_number":404,"context_line":"extern struct adapter_driver xlnx_pcie_xvc_adapter_driver;"},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"#endif /* OPENOCD_JTAG_INTERFACE_H */"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"6df6ff06_b3a64822","line":403,"updated":"2024-02-12 23:15:10.000000000","message":"Can you please rename it as ```xvc_adapter_driver``` to match the others","commit_id":"a6b4f4fc2b0cfae25a4386978dac8a6c8541b3f3"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"c74d2a12932dbbf27db9d6364608977df480ce66","unresolved":false,"context_lines":[{"line_number":400,"context_line":"extern struct adapter_driver vdebug_adapter_driver;"},{"line_number":401,"context_line":"extern struct adapter_driver vsllink_adapter_driver;"},{"line_number":402,"context_line":"extern struct adapter_driver xds110_adapter_driver;"},{"line_number":403,"context_line":"extern struct adapter_driver xvc_driver;"},{"line_number":404,"context_line":"extern struct adapter_driver xlnx_pcie_xvc_adapter_driver;"},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"#endif /* OPENOCD_JTAG_INTERFACE_H */"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"c37b4df0_4f6fd366","line":403,"in_reply_to":"6df6ff06_b3a64822","updated":"2024-02-14 15:47:59.000000000","message":"Done","commit_id":"a6b4f4fc2b0cfae25a4386978dac8a6c8541b3f3"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"244504ea04b93c88a3d428962a13f84ff8b974bf","unresolved":false,"context_lines":[{"line_number":400,"context_line":"extern struct adapter_driver vdebug_adapter_driver;"},{"line_number":401,"context_line":"extern struct adapter_driver vsllink_adapter_driver;"},{"line_number":402,"context_line":"extern struct adapter_driver xds110_adapter_driver;"},{"line_number":403,"context_line":"extern struct adapter_driver xvc_driver;"},{"line_number":404,"context_line":"extern struct adapter_driver xlnx_pcie_xvc_adapter_driver;"},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"#endif /* OPENOCD_JTAG_INTERFACE_H */"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"a2960d2c_bb00ce6f","line":403,"in_reply_to":"862a9c80_3181efff","updated":"2024-02-27 17:39:47.000000000","message":"Done","commit_id":"a6b4f4fc2b0cfae25a4386978dac8a6c8541b3f3"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"9a92fe7eaea278bf6d8d5991b56682e97bee4858","unresolved":true,"context_lines":[{"line_number":400,"context_line":"extern struct adapter_driver vdebug_adapter_driver;"},{"line_number":401,"context_line":"extern struct adapter_driver vsllink_adapter_driver;"},{"line_number":402,"context_line":"extern struct adapter_driver xds110_adapter_driver;"},{"line_number":403,"context_line":"extern struct adapter_driver xvc_driver;"},{"line_number":404,"context_line":"extern struct adapter_driver xlnx_pcie_xvc_adapter_driver;"},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"#endif /* OPENOCD_JTAG_INTERFACE_H */"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"862a9c80_3181efff","line":403,"in_reply_to":"c37b4df0_4f6fd366","updated":"2024-02-26 18:10:39.000000000","message":"not done","commit_id":"a6b4f4fc2b0cfae25a4386978dac8a6c8541b3f3"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"494aad863615265c56a35c50e5f9783d8397af22","unresolved":true,"context_lines":[{"line_number":410,"context_line":"extern struct adapter_driver vdebug_adapter_driver;"},{"line_number":411,"context_line":"extern struct adapter_driver vsllink_adapter_driver;"},{"line_number":412,"context_line":"extern struct adapter_driver xds110_adapter_driver;"},{"line_number":413,"context_line":"extern struct adapter_driver xvc_adapter_driver;"},{"line_number":414,"context_line":"extern struct adapter_driver xlnx_pcie_xvc_adapter_driver;"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"#endif /* OPENOCD_JTAG_INTERFACE_H */"}],"source_content_type":"text/x-csrc","patch_set":15,"id":"6af29bf0_db6dcc71","line":413,"updated":"2025-06-21 08:38:05.000000000","message":"keep alphabetic order","commit_id":"6aded56e662ad9ee4085ad5a6c9795bc11c6bb21"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"dd9f2bedf9077b57608cbdf3aeb37ba6b957aef6","unresolved":false,"context_lines":[{"line_number":410,"context_line":"extern struct adapter_driver vdebug_adapter_driver;"},{"line_number":411,"context_line":"extern struct adapter_driver vsllink_adapter_driver;"},{"line_number":412,"context_line":"extern struct adapter_driver xds110_adapter_driver;"},{"line_number":413,"context_line":"extern struct adapter_driver xvc_adapter_driver;"},{"line_number":414,"context_line":"extern struct adapter_driver xlnx_pcie_xvc_adapter_driver;"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"#endif /* OPENOCD_JTAG_INTERFACE_H */"}],"source_content_type":"text/x-csrc","patch_set":15,"id":"9eebd306_6d6c2c54","line":413,"in_reply_to":"6af29bf0_db6dcc71","updated":"2025-06-24 13:06:48.000000000","message":"Done","commit_id":"6aded56e662ad9ee4085ad5a6c9795bc11c6bb21"}],"src/jtag/interfaces.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"494aad863615265c56a35c50e5f9783d8397af22","unresolved":true,"context_lines":[{"line_number":156,"context_line":"#if BUILD_AM335XGPIO \u003d\u003d 1"},{"line_number":157,"context_line":"\t\t\u0026am335xgpio_adapter_driver,"},{"line_number":158,"context_line":"#endif"},{"line_number":159,"context_line":"#if BUILD_XVC \u003d\u003d 1"},{"line_number":160,"context_line":"\t\t\u0026xvc_adapter_driver,"},{"line_number":161,"context_line":"#endif"},{"line_number":162,"context_line":"\t\tNULL,"}],"source_content_type":"text/x-csrc","patch_set":15,"id":"0edd36ef_fbbcf133","line":159,"updated":"2025-06-21 08:38:05.000000000","message":"I\u0027m reordering this list in\nhttps://review.openocd.org/c/8950\nbut no review yet, no idea when it would be merged.\nKeep it as last entry, eventually would be modified later.","commit_id":"6aded56e662ad9ee4085ad5a6c9795bc11c6bb21"},{"author":{"_account_id":1001965,"name":"Jose Borja Castillo Sanchez","display_name":"Jose Borja Castillo","email":"joscassan@uma.es","username":"josborja7castillo","status":"Working"},"change_message_id":"dd9f2bedf9077b57608cbdf3aeb37ba6b957aef6","unresolved":false,"context_lines":[{"line_number":156,"context_line":"#if BUILD_AM335XGPIO \u003d\u003d 1"},{"line_number":157,"context_line":"\t\t\u0026am335xgpio_adapter_driver,"},{"line_number":158,"context_line":"#endif"},{"line_number":159,"context_line":"#if BUILD_XVC \u003d\u003d 1"},{"line_number":160,"context_line":"\t\t\u0026xvc_adapter_driver,"},{"line_number":161,"context_line":"#endif"},{"line_number":162,"context_line":"\t\tNULL,"}],"source_content_type":"text/x-csrc","patch_set":15,"id":"802777f5_1f873753","line":159,"in_reply_to":"0edd36ef_fbbcf133","updated":"2025-06-24 13:06:48.000000000","message":"Ack","commit_id":"6aded56e662ad9ee4085ad5a6c9795bc11c6bb21"}]}