)]}'
{"id":"openocd~master~I385321ddd32c3ac5cf6da3f1ce9eff76b05dd527","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1001667":{"account":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"last_update":"2022-03-26 13:21:19.000000000","reason":"Change was submitted"},"1001939":{"account":{"_account_id":1001939,"name":"zedudi","display_name":"Zoltán Dudás","email":"zedudi@gmail.com","username":"zedudi"},"last_update":"2022-03-26 13:21:19.000000000","reason":"Change was submitted"},"1001953":{"account":{"_account_id":1001953,"name":"Pavel Kirienko","email":"pavel.kirienko@gmail.com","username":"pavel-kirienko"},"last_update":"2022-03-26 13:21:19.000000000","reason":"Change was submitted"},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2022-03-12 10:18:56.000000000","reason":"Antonio Borneo replied on the change"},"1000863":{"account":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"last_update":"2022-03-26 13:21:19.000000000","reason":"Change was submitted"},"1001964":{"account":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"last_update":"2022-03-04 10:44:46.000000000","reason":"Erhan Kurubas replied on the change"}},"hashtags":[],"change_id":"I385321ddd32c3ac5cf6da3f1ce9eff76b05dd527","subject":"semihosting: fix mode flags for local host open()","status":"MERGED","created":"2022-03-04 08:42:19.000000000","updated":"2022-03-26 13:21:19.000000000","submitted":"2022-03-26 13:21:19.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":4,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"6870","meta_rev_id":"fb5d027966178fe40708bf279103703e97237eb6","_number":6870,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-03-26 13:21:19.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-03-26 13:21:19.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},{"_account_id":1001939,"name":"zedudi","display_name":"Zoltán Dudás","email":"zedudi@gmail.com","username":"zedudi"},{"_account_id":1001953,"name":"Pavel Kirienko","email":"pavel.kirienko@gmail.com","username":"pavel-kirienko"},{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"}],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},{"_account_id":1001939,"name":"zedudi","display_name":"Zoltán Dudás","email":"zedudi@gmail.com","username":"zedudi"},{"_account_id":1001953,"name":"Pavel Kirienko","email":"pavel.kirienko@gmail.com","username":"pavel-kirienko"},{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-03-04 08:42:19.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"state":"REVIEWER"},{"updated":"2022-03-04 08:42:19.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1001939,"name":"zedudi","display_name":"Zoltán Dudás","email":"zedudi@gmail.com","username":"zedudi"},"state":"REVIEWER"},{"updated":"2022-03-04 08:42:19.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"state":"REVIEWER"},{"updated":"2022-03-04 08:42:19.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"state":"REVIEWER"},{"updated":"2022-03-04 08:42:19.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1001953,"name":"Pavel Kirienko","email":"pavel.kirienko@gmail.com","username":"pavel-kirienko"},"state":"REVIEWER"},{"updated":"2022-03-04 09:00:58.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"44b4ebdf2574f78674f281ff943ed4042ae24539","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-03-04 08:42:19.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"467ae8f9ecc699a1d245f6c9f6c9d7535035f351","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-03-04 08:45:42.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"c436b3bc7e63e48befbc7ad0efbdd1d2d7b314af","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-03-04 09:00:58.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15950/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/15160/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"b217fde852af7f142705e30e7bd10e3573ed1e7a","author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"real_author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"date":"2022-03-04 10:44:46.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"bf4139b57dde22ec57104dacef32dc966a559c3a","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-03-12 10:18:56.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"0200fa3754ab6e364817247e30cfc03337f39615","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-03-19 09:20:52.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"d41af7977d8bbe454eeb7bb19543556616793ee8","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-03-26 13:16:28.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"fb5d027966178fe40708bf279103703e97237eb6","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-03-26 13:21:19.000000000","message":"Change has been successfully cherry-picked as 2cafa8be7320266756dd92a40d174cbc01487c15","accounts_in_message":[],"_revision_number":2}],"current_revision":"2cafa8be7320266756dd92a40d174cbc01487c15","revisions":{"2cafa8be7320266756dd92a40d174cbc01487c15":{"kind":"REWORK","_number":2,"created":"2022-03-26 13:21:19.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/70/6870/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/70/6870/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/70/6870/2 \u0026\u0026 git checkout -b change-6870 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/70/6870/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/70/6870/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/70/6870/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/70/6870/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/70/6870/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"92c4e634d7bb9d3fb27d9a0ca332925c7318a574","subject":"breakpoints: fix build on -fno-inline"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-03-04 08:26:19.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-03-26 13:21:19.000000000","tz":0},"subject":"semihosting: fix mode flags for local host open()","message":"semihosting: fix mode flags for local host open()\n\nCommit dbbac5f11d66 (\"semihosting: use open mode flags from GDB,\nnot from sys/stat.h\") fixes the conversion of the mode flags from\nARM semihosting encoding for SEMIHOSTING_SYS_OPEN to GDB mapping\nfor open().\nDoing this, it breaks the conversion to local host\u0027s OS mapping\nfor open().\n\nSplit the conversion array to one for GDB and one for local host.\nThe local host conversion array is taken directly from the old\ncode.\n\nChange-Id: I385321ddd32c3ac5cf6da3f1ce9eff76b05dd527\nFixes: dbbac5f11d66 (\"semihosting: use open mode flags from GDB, not from sys/stat.h\")\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReported-by: Erhan Kurubas \u003cerhan.kurubas@espressif.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6870\nTested-by: jenkins\n"}},"559a71cbb1e7d507eaac58fc8fa8758508b8b0e1":{"kind":"REWORK","_number":1,"created":"2022-03-04 08:42:19.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/70/6870/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/70/6870/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/70/6870/1 \u0026\u0026 git checkout -b change-6870 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/70/6870/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/70/6870/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/70/6870/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/70/6870/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/70/6870/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"8b740af10dd37b08c27588f34942154b817bf6fc","subject":"flash/stm32l4x: fix maybe-uninitialized compiler error"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-03-04 08:26:19.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-03-04 08:39:48.000000000","tz":60},"subject":"semihosting: fix mode flags for local host open()","message":"semihosting: fix mode flags for local host open()\n\nCommit dbbac5f11d66 (\"semihosting: use open mode flags from GDB,\nnot from sys/stat.h\") fixes the conversion of the mode flags from\nARM semihosting encoding for SEMIHOSTING_SYS_OPEN to GDB mapping\nfor open().\nDoing this, it breaks the conversion to local host\u0027s OS mapping\nfor open().\n\nSplit the conversion array to one for GDB and one for local host.\nThe local host conversion array is taken directly from the old\ncode.\n\nChange-Id: I385321ddd32c3ac5cf6da3f1ce9eff76b05dd527\nFixes: dbbac5f11d66 (\"semihosting: use open mode flags from GDB, not from sys/stat.h\")\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReported-by: Erhan Kurubas \u003cerhan.kurubas@espressif.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}