)]}'
{"id":"openocd~master~Id1a39b25cee3773b172faf70803fa150182f0cd6","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2022-03-12 09:47:13.000000000","reason":"removed on reply"},"1000853":{"account":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"last_update":"2022-03-05 18:14:26.000000000","reason":"Marc Schink replied on the change"}},"hashtags":[],"change_id":"Id1a39b25cee3773b172faf70803fa150182f0cd6","subject":"jimtcl: add configure flag for build maintainer mode","status":"MERGED","created":"2022-03-05 13:08:47.000000000","updated":"2022-03-12 09:47:18.000000000","submitted":"2022-03-12 09:47:18.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6871","meta_rev_id":"f8032ce11d59795b4d8dd463592ca21dd27b66d4","_number":6871,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-03-12 09:47:18.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-03-12 09:47:18.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-03-12 09:47:18.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-03-05 13:08:47.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"state":"REVIEWER"},{"updated":"2022-03-05 13:38:07.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"daaefc98dd3de4447df133d0eca71aa5af8c147c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-03-05 13:08:47.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a8bc056eff65528073c5aebc1d38548b66b773a6","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-03-05 13:38:07.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15954/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/15164/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"cde7cb73bd7656006e879b4a805da2b4b4ae7ddd","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-03-05 13:45:51.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"c1fd59a9a8da540d52cbb9567c1cf571f69372d9","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2022-03-05 18:14:26.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"fadfb5b86ac6774c45d4b1ca2f3fd2cd1a7cd7d6","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-03-12 09:47:13.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"f8032ce11d59795b4d8dd463592ca21dd27b66d4","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-03-12 09:47:18.000000000","message":"Change has been successfully cherry-picked as c5a23e96878d50b64b3d6ee4e52b37f58daaa17f","accounts_in_message":[],"_revision_number":2}],"current_revision":"c5a23e96878d50b64b3d6ee4e52b37f58daaa17f","revisions":{"c5a23e96878d50b64b3d6ee4e52b37f58daaa17f":{"kind":"REWORK","_number":2,"created":"2022-03-12 09:47:18.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/71/6871/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/71/6871/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/71/6871/2 \u0026\u0026 git checkout -b change-6871 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/71/6871/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/71/6871/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/71/6871/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/71/6871/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/71/6871/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"5b9da0eed215386b856c3168ff712f9af483c0c6","subject":"board: Add LS1046ARDB"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-03-05 13:00:04.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-03-12 09:47:18.000000000","tz":0},"subject":"jimtcl: add configure flag for build maintainer mode","message":"jimtcl: add configure flag for build maintainer mode\n\nWhen jimtcl is built in maintainer mode, it runs extra tests at\nexit to look for memory leak due to jim objects not properly freed\neither through Jim_IncrRefCount()/Jim_DecrRefCount() or by passing\nit to a jim API.\n\nAdd optional OpenOCD configure flag \u0027--enable-jimtcl-maintainer\u0027\nto enable jimtcl maintainer mode.\n\nModify the implementation of macro AX_CONFIG_SUBDIR_OPTION to\nallow expanding a variable passed as second argument.\n\nChange-Id: Id1a39b25cee3773b172faf70803fa150182f0cd6\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6871\nTested-by: jenkins\nReviewed-by: zapb \u003cdev@zapb.de\u003e\n"}},"ebd83222a59bbb45cc700d8e239fcb5143e4386a":{"kind":"REWORK","_number":1,"created":"2022-03-05 13:08:47.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/71/6871/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/71/6871/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/71/6871/1 \u0026\u0026 git checkout -b change-6871 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/71/6871/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/71/6871/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/71/6871/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/71/6871/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/71/6871/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"8b740af10dd37b08c27588f34942154b817bf6fc","subject":"flash/stm32l4x: fix maybe-uninitialized compiler error"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-03-05 13:00:04.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-03-05 13:00:04.000000000","tz":60},"subject":"jimtcl: add configure flag for build maintainer mode","message":"jimtcl: add configure flag for build maintainer mode\n\nWhen jimtcl is built in maintainer mode, it runs extra tests at\nexit to look for memory leak due to jim objects not properly freed\neither through Jim_IncrRefCount()/Jim_DecrRefCount() or by passing\nit to a jim API.\n\nAdd optional OpenOCD configure flag \u0027--enable-jimtcl-maintainer\u0027\nto enable jimtcl maintainer mode.\n\nModify the implementation of macro AX_CONFIG_SUBDIR_OPTION to\nallow expanding a variable passed as second argument.\n\nChange-Id: Id1a39b25cee3773b172faf70803fa150182f0cd6\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}