)]}'
{"id":"openocd~master~I6857868347260eced8e96429b43209dea25d220e","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1001667":{"account":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"last_update":"2022-03-21 08:17:19.000000000","reason":"Jan Matyas replied on the change"},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2022-03-21 08:17:43.000000000","reason":"Change was abandoned"}},"hashtags":[],"change_id":"I6857868347260eced8e96429b43209dea25d220e","subject":"target: Add option to disable SW breakpoints","status":"ABANDONED","created":"2022-03-18 15:40:55.000000000","updated":"2022-03-21 08:17:43.000000000","total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"00acdca70b04ed5eccdff16f60d14eba36814630","_number":6880,"owner":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":1,"date":"2022-03-18 16:41:47.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}],"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-03-18 15:42:17.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-03-18 15:53:07.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"CC"}],"messages":[{"id":"224ceb289c8323c05411992e6238d94a354b2e06","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2022-03-18 15:40:55.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"703d045dfe58177428b8df4565f22aa6b200848b","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-03-18 15:42:17.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit/15973/ : FAILURE\n\nhttps://build.openocd.org/job/openocd-gerrit-build/15183/ : FAILURE","accounts_in_message":[],"_revision_number":1},{"id":"db22b1042c53421cab8ffb14aef309a1bdfd4eea","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2022-03-18 15:47:01.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"03000fcf4c3d18c70c22f8409545cd8b258cd728","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-03-18 15:53:07.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"889a212bae60ec259a214fa7962af3e61705201f","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-03-18 16:41:47.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15974/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/15184/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"52fabddbc5d812b754f657b07f38ae69ceb50307","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2022-03-21 08:17:19.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"00acdca70b04ed5eccdff16f60d14eba36814630","tag":"autogenerated:gerrit:abandon","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2022-03-21 08:17:43.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":2}],"current_revision":"c32bf5af1e50b6c9e56cd093eec7b2f95999c289","revisions":{"ada5cf8665153c313f83f6894e9dd6b7bc76be44":{"kind":"REWORK","_number":1,"created":"2022-03-18 15:40:55.000000000","uploader":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"ref":"refs/changes/80/6880/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/80/6880/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/80/6880/1 \u0026\u0026 git checkout -b change-6880 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/80/6880/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/80/6880/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/80/6880/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/80/6880/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/80/6880/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"be0d68eb66b513ef406ffa83102f89a8f4602914","subject":"Remove all occurrences of \u0027mem2array\u0027 and \u0027array2mem\u0027"}],"author":{"name":"Jan Matyas","email":"matyas@codasip.com","date":"2022-03-18 15:19:08.000000000","tz":60},"committer":{"name":"Jan Matyas","email":"matyas@codasip.com","date":"2022-03-18 15:40:24.000000000","tz":60},"subject":"target: Add option to disable SW breakpoints","message":"target: Add option to disable SW breakpoints\n\nAdded \"my_target configure -allow-sw-breaks on|off\".\nDefault: on.\n\nThis option is important when debugging multiple CPUs\n/cores with shared memory as separate targets (using\nseparate GDB instances).\n\nIn such cases, SW breakpoints cannot be reliably used:\neach debugger only keeps track of SW breaks inserted\nby itself but is still affected by breaks from other\ndebuggers - due to the shared memory.\n\nIf where was no option to disable the SW breaks, the\nfollowing issues would occur during the debugging:\n\n- 1) Debugger may get unexpectedly stopped by SW BPs\n  that they do not know about as they were placed by\n  other debuggers.\n\n- 2) If multiple breakpoints are placed onto the same\n  address, the breakpoint instruction may get stuck\n  in the memory even when all debuggers removed those\n  SW BPs (if the removal took place in a not favourable\n  order).\n\nThe option added in this commit allows the user to\ndisable the SW breaks in such scenarios and still be\nable to run reliable debug sessions.\n\nChange-Id: I6857868347260eced8e96429b43209dea25d220e\nSigned-off-by: Jan Matyas \u003cmatyas@codasip.com\u003e\n"}},"c32bf5af1e50b6c9e56cd093eec7b2f95999c289":{"kind":"REWORK","_number":2,"created":"2022-03-18 15:47:01.000000000","uploader":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"ref":"refs/changes/80/6880/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/80/6880/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/80/6880/2 \u0026\u0026 git checkout -b change-6880 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/80/6880/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/80/6880/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/80/6880/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/80/6880/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/80/6880/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"be0d68eb66b513ef406ffa83102f89a8f4602914","subject":"Remove all occurrences of \u0027mem2array\u0027 and \u0027array2mem\u0027"}],"author":{"name":"Jan Matyas","email":"matyas@codasip.com","date":"2022-03-18 15:19:08.000000000","tz":60},"committer":{"name":"Jan Matyas","email":"matyas@codasip.com","date":"2022-03-18 15:46:39.000000000","tz":60},"subject":"target: Add option to disable SW breakpoints","message":"target: Add option to disable SW breakpoints\n\nAdded \"my_target configure -allow-sw-breaks on|off\".\nDefault: on.\n\nThis option is important when debugging multiple CPUs\n/cores with shared memory as separate targets (using\nseparate GDB instances).\n\nIn such cases, SW breakpoints cannot be reliably used:\neach debugger only keeps track of SW breaks inserted\nby itself but is still affected by breaks from other\ndebuggers - due to the shared memory.\n\nIf where was no option to disable the SW breaks, the\nfollowing issues would occur during the debugging:\n\n- 1) Debugger may get unexpectedly stopped by SW BPs\n  that they do not know about as they were placed by\n  other debuggers.\n\n- 2) If multiple breakpoints are placed onto the same\n  address, the breakpoint instruction may get stuck\n  in the memory even when all debuggers removed those\n  SW BPs (if the removal took place in a not favourable\n  order).\n\nThe option added in this commit allows the user to\ndisable the SW breaks in such scenarios and still be\nable to run reliable debug sessions.\n\nChange-Id: I6857868347260eced8e96429b43209dea25d220e\nSigned-off-by: Jan Matyas \u003cmatyas@codasip.com\u003e\n"}}},"requirements":[],"submit_records":[],"submit_requirements":[]}