)]}'
{"id":"openocd~master~I8bf31045a137bd34ed825f4b2a9338eb3c70046d","project":"openocd","branch":"master","hashtags":[],"change_id":"I8bf31045a137bd34ed825f4b2a9338eb3c70046d","subject":"breakpoints: fix build on -fno-inline","status":"MERGED","created":"2022-03-19 10:23:22.000000000","updated":"2022-03-19 11:35:32.000000000","submitted":"2022-03-19 11:35:32.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6881","meta_rev_id":"b29993256df4e192922573d6702b6a52acc1efec","_number":6881,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-03-19 11:35:32.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-03-19 11:35:32.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-03-19 11:31:44.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"23f8d412b67ba67ad963a7b8395bf569fd27d703","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-03-19 10:23:22.000000000","message":"Uploaded patch set 1: Code-Review+2.","accounts_in_message":[],"_revision_number":1},{"id":"73aa31e4535cd6db3df0d2880e4117d775cf9d32","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-03-19 11:31:44.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15975/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/15185/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"b29993256df4e192922573d6702b6a52acc1efec","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-03-19 11:35:32.000000000","message":"Change has been successfully cherry-picked as 92c4e634d7bb9d3fb27d9a0ca332925c7318a574","accounts_in_message":[],"_revision_number":2}],"current_revision":"92c4e634d7bb9d3fb27d9a0ca332925c7318a574","revisions":{"92c4e634d7bb9d3fb27d9a0ca332925c7318a574":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2022-03-19 11:35:32.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/81/6881/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/81/6881/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/81/6881/2 \u0026\u0026 git checkout -b change-6881 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/81/6881/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/81/6881/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/81/6881/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/81/6881/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/81/6881/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"fb43f1ff4e2f0638110ffcc4e63bee8b5361db64","subject":"target: Rework \u0027set\u0027 variable of break-/watchpoints"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-03-19 09:56:01.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-03-19 11:35:32.000000000","tz":0},"subject":"breakpoints: fix build on -fno-inline","message":"breakpoints: fix build on -fno-inline\n\nSome configuration of GCC could default to -fno-inline, causing\nthe build to fail after commit fb43f1ff4e2f (\"target: Rework \u0027set\u0027\nvariable of break-/watchpoints\").\n\nSwitch the new inline functions to \u0027static inline\u0027, as it\u0027s widely\nused in the rest of the code.\n\nChange-Id: I8bf31045a137bd34ed825f4b2a9338eb3c70046d\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nFixes: fb43f1ff4e2f (\"target: Rework \u0027set\u0027 variable of break-/watchpoints\")\nReviewed-on: https://review.openocd.org/c/openocd/+/6881\nTested-by: jenkins\n"}},"c83da2ac864d0db64da0305856faa31e7360ada3":{"kind":"REWORK","_number":1,"created":"2022-03-19 10:23:22.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/81/6881/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/81/6881/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/81/6881/1 \u0026\u0026 git checkout -b change-6881 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/81/6881/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/81/6881/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/81/6881/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/81/6881/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/81/6881/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"fb43f1ff4e2f0638110ffcc4e63bee8b5361db64","subject":"target: Rework \u0027set\u0027 variable of break-/watchpoints"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-03-19 09:56:01.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-03-19 10:13:32.000000000","tz":60},"subject":"breakpoints: fix build on -fno-inline","message":"breakpoints: fix build on -fno-inline\n\nSome configuration of GCC could default to -fno-inline, causing\nthe build to fail after commit fb43f1ff4e2f (\"target: Rework \u0027set\u0027\nvariable of break-/watchpoints\").\n\nSwitch the new inline functions to \u0027static inline\u0027, as it\u0027s widely\nused in the rest of the code.\n\nChange-Id: I8bf31045a137bd34ed825f4b2a9338eb3c70046d\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nFixes: fb43f1ff4e2f (\"target: Rework \u0027set\u0027 variable of break-/watchpoints\")\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}