)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"ee15933bae25734bb0435bf1dc24eb32f5fff3fc","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Gabor Csapo \u003cgaborcsapo@google.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-03-22 13:38:21 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Increase USB timeout"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When we debug and halt a USB device, it becomes unresponsive to"},{"line_number":10,"context_line":"host USB communication. The host will try to reconnect/reset/setup"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"f4f6fd87_346870d3","line":7,"updated":"2022-03-22 13:48:58.000000000","message":"Please change the title line as:\nlibusb_helper: increase USB timeout","commit_id":"8e99371359cbca69a5d3e5491d41d68aca31893a"},{"author":{"_account_id":1001970,"name":"Gabor Csapo","email":"gaborcsapo@google.com","username":"gaborcsapo"},"change_message_id":"1a0f2d2836e1f492f295d76730e0cff18aa443be","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Gabor Csapo \u003cgaborcsapo@google.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-03-22 13:38:21 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Increase USB timeout"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When we debug and halt a USB device, it becomes unresponsive to"},{"line_number":10,"context_line":"host USB communication. The host will try to reconnect/reset/setup"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bf7e129f_5a4e1d69","line":7,"in_reply_to":"f4f6fd87_346870d3","updated":"2022-03-23 01:11:28.000000000","message":"Done","commit_id":"8e99371359cbca69a5d3e5491d41d68aca31893a"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"88adbe62959ea0e06af0aa712e7bace9358d9289","unresolved":true,"context_lines":[{"line_number":7,"context_line":"libusb_helper.h: Increase USB timeout"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When we debug a target that works as a USB device, halting"},{"line_number":10,"context_line":"the target causes theUSB communication with the USB host to"},{"line_number":11,"context_line":"become unresponsive. The host will tryto reconnect/reset/setup"},{"line_number":12,"context_line":"the unresponsive device during which communicationwith other"},{"line_number":13,"context_line":"devices on the same USB bus can get stalled for several seconds."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"c5a67fe4_073eb026","line":10,"updated":"2022-03-23 09:24:46.000000000","message":"Attention, several mistakes:\ntheUSB","commit_id":"a8a5f474f1e496db975477009a87fb42bf1aa5bd"},{"author":{"_account_id":1001970,"name":"Gabor Csapo","email":"gaborcsapo@google.com","username":"gaborcsapo"},"change_message_id":"62693a7e26de169438c229723c666e9925f2bbd2","unresolved":false,"context_lines":[{"line_number":7,"context_line":"libusb_helper.h: Increase USB timeout"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When we debug a target that works as a USB device, halting"},{"line_number":10,"context_line":"the target causes theUSB communication with the USB host to"},{"line_number":11,"context_line":"become unresponsive. The host will tryto reconnect/reset/setup"},{"line_number":12,"context_line":"the unresponsive device during which communicationwith other"},{"line_number":13,"context_line":"devices on the same USB bus can get stalled for several seconds."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"32309617_43e03dca","line":10,"in_reply_to":"c5a67fe4_073eb026","updated":"2022-03-24 04:03:32.000000000","message":"Sorry, something must have gone bad while reflowing the comments. Thanks for spotting it.","commit_id":"a8a5f474f1e496db975477009a87fb42bf1aa5bd"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"88adbe62959ea0e06af0aa712e7bace9358d9289","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When we debug a target that works as a USB device, halting"},{"line_number":10,"context_line":"the target causes theUSB communication with the USB host to"},{"line_number":11,"context_line":"become unresponsive. The host will tryto reconnect/reset/setup"},{"line_number":12,"context_line":"the unresponsive device during which communicationwith other"},{"line_number":13,"context_line":"devices on the same USB bus can get stalled for several seconds."},{"line_number":14,"context_line":"If the JTAG adapter is on the same bus, we need to make sure"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f99bb11_bda4dc2d","line":11,"updated":"2022-03-23 09:24:46.000000000","message":"tryto","commit_id":"a8a5f474f1e496db975477009a87fb42bf1aa5bd"},{"author":{"_account_id":1001970,"name":"Gabor Csapo","email":"gaborcsapo@google.com","username":"gaborcsapo"},"change_message_id":"62693a7e26de169438c229723c666e9925f2bbd2","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When we debug a target that works as a USB device, halting"},{"line_number":10,"context_line":"the target causes theUSB communication with the USB host to"},{"line_number":11,"context_line":"become unresponsive. The host will tryto reconnect/reset/setup"},{"line_number":12,"context_line":"the unresponsive device during which communicationwith other"},{"line_number":13,"context_line":"devices on the same USB bus can get stalled for several seconds."},{"line_number":14,"context_line":"If the JTAG adapter is on the same bus, we need to make sure"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"c15908bd_b760a814","line":11,"in_reply_to":"9f99bb11_bda4dc2d","updated":"2022-03-24 04:03:32.000000000","message":"Done","commit_id":"a8a5f474f1e496db975477009a87fb42bf1aa5bd"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"88adbe62959ea0e06af0aa712e7bace9358d9289","unresolved":true,"context_lines":[{"line_number":9,"context_line":"When we debug a target that works as a USB device, halting"},{"line_number":10,"context_line":"the target causes theUSB communication with the USB host to"},{"line_number":11,"context_line":"become unresponsive. The host will tryto reconnect/reset/setup"},{"line_number":12,"context_line":"the unresponsive device during which communicationwith other"},{"line_number":13,"context_line":"devices on the same USB bus can get stalled for several seconds."},{"line_number":14,"context_line":"If the JTAG adapter is on the same bus, we need to make sure"},{"line_number":15,"context_line":"openOCD will waitfor packets at least as long as the host USB"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"209eb73c_1e4a22ee","line":12,"updated":"2022-03-23 09:24:46.000000000","message":"communicationwith","commit_id":"a8a5f474f1e496db975477009a87fb42bf1aa5bd"},{"author":{"_account_id":1001970,"name":"Gabor Csapo","email":"gaborcsapo@google.com","username":"gaborcsapo"},"change_message_id":"62693a7e26de169438c229723c666e9925f2bbd2","unresolved":false,"context_lines":[{"line_number":9,"context_line":"When we debug a target that works as a USB device, halting"},{"line_number":10,"context_line":"the target causes theUSB communication with the USB host to"},{"line_number":11,"context_line":"become unresponsive. The host will tryto reconnect/reset/setup"},{"line_number":12,"context_line":"the unresponsive device during which communicationwith other"},{"line_number":13,"context_line":"devices on the same USB bus can get stalled for several seconds."},{"line_number":14,"context_line":"If the JTAG adapter is on the same bus, we need to make sure"},{"line_number":15,"context_line":"openOCD will waitfor packets at least as long as the host USB"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"e96db7dd_fe0e6d86","line":12,"in_reply_to":"209eb73c_1e4a22ee","updated":"2022-03-24 04:03:32.000000000","message":"Done","commit_id":"a8a5f474f1e496db975477009a87fb42bf1aa5bd"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"88adbe62959ea0e06af0aa712e7bace9358d9289","unresolved":true,"context_lines":[{"line_number":12,"context_line":"the unresponsive device during which communicationwith other"},{"line_number":13,"context_line":"devices on the same USB bus can get stalled for several seconds."},{"line_number":14,"context_line":"If the JTAG adapter is on the same bus, we need to make sure"},{"line_number":15,"context_line":"openOCD will waitfor packets at least as long as the host USB"},{"line_number":16,"context_line":"stack. Otherwise the USB stackmight deliver a valid packet, but"},{"line_number":17,"context_line":"openOCD would ignore it due to the timeout.The xHCI spec uses 5"},{"line_number":18,"context_line":"sec timeouts, so let\u0027s use that in openOCD with some margin."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"c07ff9ed_4dc8c742","line":15,"range":{"start_line":15,"start_character":13,"end_line":15,"end_character":20},"updated":"2022-03-23 09:24:46.000000000","message":"waitfor","commit_id":"a8a5f474f1e496db975477009a87fb42bf1aa5bd"},{"author":{"_account_id":1001970,"name":"Gabor Csapo","email":"gaborcsapo@google.com","username":"gaborcsapo"},"change_message_id":"62693a7e26de169438c229723c666e9925f2bbd2","unresolved":false,"context_lines":[{"line_number":12,"context_line":"the unresponsive device during which communicationwith other"},{"line_number":13,"context_line":"devices on the same USB bus can get stalled for several seconds."},{"line_number":14,"context_line":"If the JTAG adapter is on the same bus, we need to make sure"},{"line_number":15,"context_line":"openOCD will waitfor packets at least as long as the host USB"},{"line_number":16,"context_line":"stack. Otherwise the USB stackmight deliver a valid packet, but"},{"line_number":17,"context_line":"openOCD would ignore it due to the timeout.The xHCI spec uses 5"},{"line_number":18,"context_line":"sec timeouts, so let\u0027s use that in openOCD with some margin."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ce6f25f3_099476f3","line":15,"range":{"start_line":15,"start_character":13,"end_line":15,"end_character":20},"in_reply_to":"c07ff9ed_4dc8c742","updated":"2022-03-24 04:03:32.000000000","message":"Done","commit_id":"a8a5f474f1e496db975477009a87fb42bf1aa5bd"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"88adbe62959ea0e06af0aa712e7bace9358d9289","unresolved":true,"context_lines":[{"line_number":13,"context_line":"devices on the same USB bus can get stalled for several seconds."},{"line_number":14,"context_line":"If the JTAG adapter is on the same bus, we need to make sure"},{"line_number":15,"context_line":"openOCD will waitfor packets at least as long as the host USB"},{"line_number":16,"context_line":"stack. Otherwise the USB stackmight deliver a valid packet, but"},{"line_number":17,"context_line":"openOCD would ignore it due to the timeout.The xHCI spec uses 5"},{"line_number":18,"context_line":"sec timeouts, so let\u0027s use that in openOCD with some margin."},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7385d87c_1d973fcf","line":16,"range":{"start_line":16,"start_character":25,"end_line":16,"end_character":35},"updated":"2022-03-23 09:24:46.000000000","message":"stackmight","commit_id":"a8a5f474f1e496db975477009a87fb42bf1aa5bd"},{"author":{"_account_id":1001970,"name":"Gabor Csapo","email":"gaborcsapo@google.com","username":"gaborcsapo"},"change_message_id":"62693a7e26de169438c229723c666e9925f2bbd2","unresolved":false,"context_lines":[{"line_number":13,"context_line":"devices on the same USB bus can get stalled for several seconds."},{"line_number":14,"context_line":"If the JTAG adapter is on the same bus, we need to make sure"},{"line_number":15,"context_line":"openOCD will waitfor packets at least as long as the host USB"},{"line_number":16,"context_line":"stack. Otherwise the USB stackmight deliver a valid packet, but"},{"line_number":17,"context_line":"openOCD would ignore it due to the timeout.The xHCI spec uses 5"},{"line_number":18,"context_line":"sec timeouts, so let\u0027s use that in openOCD with some margin."},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f0320c0_a6ac932d","line":16,"range":{"start_line":16,"start_character":25,"end_line":16,"end_character":35},"in_reply_to":"7385d87c_1d973fcf","updated":"2022-03-24 04:03:32.000000000","message":"Done","commit_id":"a8a5f474f1e496db975477009a87fb42bf1aa5bd"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"88adbe62959ea0e06af0aa712e7bace9358d9289","unresolved":true,"context_lines":[{"line_number":14,"context_line":"If the JTAG adapter is on the same bus, we need to make sure"},{"line_number":15,"context_line":"openOCD will waitfor packets at least as long as the host USB"},{"line_number":16,"context_line":"stack. Otherwise the USB stackmight deliver a valid packet, but"},{"line_number":17,"context_line":"openOCD would ignore it due to the timeout.The xHCI spec uses 5"},{"line_number":18,"context_line":"sec timeouts, so let\u0027s use that in openOCD with some margin."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Use this value in all libusb calls. HID API might have a libusb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"4b70ff51_620c2402","line":17,"updated":"2022-03-23 09:24:46.000000000","message":"add space after the \".\"","commit_id":"a8a5f474f1e496db975477009a87fb42bf1aa5bd"},{"author":{"_account_id":1001970,"name":"Gabor Csapo","email":"gaborcsapo@google.com","username":"gaborcsapo"},"change_message_id":"62693a7e26de169438c229723c666e9925f2bbd2","unresolved":false,"context_lines":[{"line_number":14,"context_line":"If the JTAG adapter is on the same bus, we need to make sure"},{"line_number":15,"context_line":"openOCD will waitfor packets at least as long as the host USB"},{"line_number":16,"context_line":"stack. Otherwise the USB stackmight deliver a valid packet, but"},{"line_number":17,"context_line":"openOCD would ignore it due to the timeout.The xHCI spec uses 5"},{"line_number":18,"context_line":"sec timeouts, so let\u0027s use that in openOCD with some margin."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Use this value in all libusb calls. HID API might have a libusb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"a22aca5d_abd747fd","line":17,"in_reply_to":"4b70ff51_620c2402","updated":"2022-03-24 04:03:32.000000000","message":"Done","commit_id":"a8a5f474f1e496db975477009a87fb42bf1aa5bd"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"ee15933bae25734bb0435bf1dc24eb32f5fff3fc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4829ffde_38193038","updated":"2022-03-22 13:48:58.000000000","message":"Cool thanks!\nJust 2 minor suggest for the text, otherwise it\u0027s ok for me.","commit_id":"8e99371359cbca69a5d3e5491d41d68aca31893a"},{"author":{"_account_id":1001970,"name":"Gabor Csapo","email":"gaborcsapo@google.com","username":"gaborcsapo"},"change_message_id":"b748cc2fb36801c9da3a507f0e310ba714ef7ffa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fa618d87_d5ed32c4","updated":"2022-03-22 05:40:34.000000000","message":"Hey Antonio, I made changes to everywhere where I found references to USB timeouts. Let me know what you think. I can remove some of them if you think it\u0027s dangerous.","commit_id":"8e99371359cbca69a5d3e5491d41d68aca31893a"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"f70ecd3258b2e0707a0e4a1a341db7f936ab4e9f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"dfd573eb_612432c4","updated":"2022-03-24 08:25:02.000000000","message":"Thanks. I will wait for ~2 weeks before merge, in case someone has any comment.","commit_id":"79b8852010a34a5bcc76460b8e95a429314c1b77"},{"author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"change_message_id":"4cddef270ecb434cb4c7a3cf375f1810ffbce4db","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"6e0042b9_a1e40894","updated":"2025-09-19 20:49:54.000000000","message":"This breaks the build when HIDAPI library is available during configure time but libusb-1.0 is not. Including `libusb_helper.h` in `nulink_usb.c` and `cmsis_dap.c` produces compile-time errors in that case.","commit_id":"f0d8c3b0e024d045262ba50a516a3bd66bf22686"}],"src/jtag/drivers/libusb_helper.h":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"ee15933bae25734bb0435bf1dc24eb32f5fff3fc","unresolved":true,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"#include \u003clibusb.h\u003e"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"/* When we debug and halt a USB device, it becomes unresponsive to host USB"},{"line_number":26,"context_line":" * communication. The host will try to reconnect/reset/setup the unresponsive device"},{"line_number":27,"context_line":" * during which communication with other devices on the same USB bus can get"},{"line_number":28,"context_line":" * stalled for several seconds. If the JTAG adapter is on the same bus, we need"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"e43b544d_8ecd9182","line":25,"updated":"2022-03-22 13:48:58.000000000","message":"I would suggest rewording the first sentence, in the hope to make it more clear:\n/* When debug a target that works as USB device, halting the target causes the USB communication with the USB host to become unresponsive.","commit_id":"8e99371359cbca69a5d3e5491d41d68aca31893a"},{"author":{"_account_id":1001970,"name":"Gabor Csapo","email":"gaborcsapo@google.com","username":"gaborcsapo"},"change_message_id":"1a0f2d2836e1f492f295d76730e0cff18aa443be","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"#include \u003clibusb.h\u003e"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"/* When we debug and halt a USB device, it becomes unresponsive to host USB"},{"line_number":26,"context_line":" * communication. The host will try to reconnect/reset/setup the unresponsive device"},{"line_number":27,"context_line":" * during which communication with other devices on the same USB bus can get"},{"line_number":28,"context_line":" * stalled for several seconds. If the JTAG adapter is on the same bus, we need"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"e82d4fa0_3771000f","line":25,"in_reply_to":"e43b544d_8ecd9182","updated":"2022-03-23 01:11:28.000000000","message":"Done","commit_id":"8e99371359cbca69a5d3e5491d41d68aca31893a"}]}