)]}'
{"id":"openocd~master~I1b85554d59221560e97861a499e16764e70c1172","project":"openocd","branch":"master","hashtags":[],"change_id":"I1b85554d59221560e97861a499e16764e70c1172","subject":"server/gdb: fix return of gdb remote monitor command","status":"MERGED","created":"2022-04-03 20:22:15.000000000","updated":"2022-05-04 12:28:22.000000000","submitted":"2022-04-23 09:25:43.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":1,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"6886","meta_rev_id":"1cad2ed93cafcac6578ed0e765c9c5f6d53c8691","_number":6886,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-04-23 09:25:43.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-04-23 09:25:43.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":1001422,"name":"Bohdan Tymkiv","email":"bohdan200@gmail.com","username":"bhdt"},{"_account_id":1001839,"name":"Antonio Borneo","email":"antonio.borneo@st.com"}],"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-04-03 20:45:42.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-05-04 12:28:22.000000000","updated_by":{"_account_id":1001422,"name":"Bohdan Tymkiv","email":"bohdan200@gmail.com","username":"bhdt"},"reviewer":{"_account_id":1001422,"name":"Bohdan Tymkiv","email":"bohdan200@gmail.com","username":"bhdt"},"state":"CC"},{"updated":"2022-05-04 12:28:22.000000000","updated_by":{"_account_id":1001422,"name":"Bohdan Tymkiv","email":"bohdan200@gmail.com","username":"bhdt"},"reviewer":{"_account_id":1001839,"name":"Antonio Borneo","email":"antonio.borneo@st.com"},"state":"CC"}],"messages":[{"id":"a34ed071d2a459dba666ff7eb4a7369355350ae1","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-04-03 20:22:15.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ed749676b0c23b99af5e2c87996f0c763631a884","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-04-03 20:45:42.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15990/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/15200/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"18d42d9377103d23efd42eaa0c657d819fbfa055","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-04-03 20:49:55.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"a0f8cf0aa2ffe6640110bf2164044157bdc8d2e6","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-04-23 09:22:20.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"3b6d8ca22e93a924c749c3f91f424f071e649753","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-04-23 09:25:43.000000000","message":"Change has been successfully cherry-picked as 5ebb1bdea1dfff9cce430bd17d08e340eea38e03","accounts_in_message":[],"_revision_number":2},{"id":"1cad2ed93cafcac6578ed0e765c9c5f6d53c8691","author":{"_account_id":1001422,"name":"Bohdan Tymkiv","email":"bohdan200@gmail.com","username":"bhdt"},"real_author":{"_account_id":1001422,"name":"Bohdan Tymkiv","email":"bohdan200@gmail.com","username":"bhdt"},"date":"2022-05-04 12:28:22.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2}],"current_revision":"5ebb1bdea1dfff9cce430bd17d08e340eea38e03","revisions":{"5ebb1bdea1dfff9cce430bd17d08e340eea38e03":{"kind":"REWORK","_number":2,"created":"2022-04-23 09:25:43.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/86/6886/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/86/6886/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/86/6886/2 \u0026\u0026 git checkout -b change-6886 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/86/6886/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/86/6886/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/86/6886/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/86/6886/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/86/6886/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d8c81d72540a9e6a9f59412686332379ece1618f","subject":"tcl/target/stm32l4x: align format/order/comments with stm32f4x"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-03-30 21:55:04.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-04-23 09:25:43.000000000","tz":0},"subject":"server/gdb: fix return of gdb remote monitor command","message":"server/gdb: fix return of gdb remote monitor command\n\nCurrent implementation for gdb remote monitor command uses the\ncommand_run_line() to execute the command.\nWhile command_run_line() has several advantages, it unfortunately\nhides the error codes and outputs the result of the command\nthrough LOG_USER(), which is not what gdb requires. See \u0027qRcmd\u0027 in\nhttps://sourceware.org/gdb/onlinedocs/gdb/General-Query-Packets.html\n\nReplace command_run_line() with Jim_EvalObj() and parse the output\nto provide the proper result to gdb.\n\nCan be tested by defining in OpenOCD:\n\tproc a {} {return hello}\n\tproc b {} {return -code 4}\n\tproc c {} {return -code 4 \"This is an error!\"}\nthen by executing in gdb console:\n\tmonitor a\n\tmonitor b\n\tmonitor c\n\tmonitor foo\n\nChange-Id: I1b85554d59221560e97861a499e16764e70c1172\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReported-by: Torbjorn Svensson \u003ctorbjorn.svensson@st.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6886\nTested-by: jenkins\n"}},"4afd37c23cd5ff99563feaa8e01aa5c8fed21e08":{"kind":"REWORK","_number":1,"created":"2022-04-03 20:22:15.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/86/6886/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/86/6886/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/86/6886/1 \u0026\u0026 git checkout -b change-6886 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/86/6886/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/86/6886/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/86/6886/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/86/6886/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/86/6886/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7c6d379cf4434c69a977af4f417fe1ab1f3f9178","subject":"tcl/board: Add NXP FRDM-K64F"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-03-30 21:55:04.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-04-03 20:17:53.000000000","tz":120},"subject":"server/gdb: fix return of gdb remote monitor command","message":"server/gdb: fix return of gdb remote monitor command\n\nCurrent implementation for gdb remote monitor command uses the\ncommand_run_line() to execute the command.\nWhile command_run_line() has several advantages, it unfortunately\nhides the error codes and outputs the result of the command\nthrough LOG_USER(), which is not what gdb requires. See \u0027qRcmd\u0027 in\nhttps://sourceware.org/gdb/onlinedocs/gdb/General-Query-Packets.html\n\nReplace command_run_line() with Jim_EvalObj() and parse the output\nto provide the proper result to gdb.\n\nCan be tested by defining in OpenOCD:\n\tproc a {} {return hello}\n\tproc b {} {return -code 4}\n\tproc c {} {return -code 4 \"This is an error!\"}\nthen by executing in gdb console:\n\tmonitor a\n\tmonitor b\n\tmonitor c\n\tmonitor foo\n\nChange-Id: I1b85554d59221560e97861a499e16764e70c1172\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReported-by: Torbjorn Svensson \u003ctorbjorn.svensson@st.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}