)]}'
{"id":"openocd~master~Ib465d676246fa3b4e95c3d399ba9a5cf1f8b3baf","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2022-04-04 20:49:35.000000000","reason":"Antonio Borneo replied on the change"}},"hashtags":[],"change_id":"Ib465d676246fa3b4e95c3d399ba9a5cf1f8b3baf","subject":"nds32: deprecate it, together with aice adapter driver","status":"MERGED","created":"2022-04-04 07:56:41.000000000","updated":"2022-04-23 09:16:52.000000000","submitted":"2022-04-23 09:16:52.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6887","meta_rev_id":"89ec6b118c3c93ed0d16e07856acbd0d11ed8a66","_number":6887,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-04-23 09:16:52.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-04-23 09:16:52.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-04-23 09:16:52.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-04-04 08:02:40.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"},{"updated":"2022-04-04 08:23:10.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"6065fcfabcbbdc0b730fb06b89396f8eec720a78","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-04-04 07:56:41.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"618bc188a227628644ee7cd453687f74a92c2a33","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-04-04 08:02:40.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"c5efc1d0364ae0d46fda0cf908a77e6d1361b3c4","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-04-04 08:23:10.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15992/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/15202/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"01e28b02a2771c3cccf8bb6a8d2d4d2d119d380f","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-04-04 20:49:35.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"6483fbdf66d948f968a53b431274a291d5e3a9d1","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-04-23 09:16:08.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"89ec6b118c3c93ed0d16e07856acbd0d11ed8a66","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-04-23 09:16:52.000000000","message":"Change has been successfully cherry-picked as 2e5df83de7f2bceeeab762f24d1a15a850d75d9e","accounts_in_message":[],"_revision_number":2}],"current_revision":"2e5df83de7f2bceeeab762f24d1a15a850d75d9e","revisions":{"2e5df83de7f2bceeeab762f24d1a15a850d75d9e":{"kind":"REWORK","_number":2,"created":"2022-04-23 09:16:52.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/87/6887/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/87/6887/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/87/6887/2 \u0026\u0026 git checkout -b change-6887 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/87/6887/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/87/6887/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/87/6887/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/87/6887/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/87/6887/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"e83eeb44aa96e380f46d37980b8b76a908757dc6","subject":"flash/nor/stm32f1x: lock flash in case of error"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-03-24 14:30:16.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-04-23 09:16:52.000000000","tz":0},"subject":"nds32: deprecate it, together with aice adapter driver","message":"nds32: deprecate it, together with aice adapter driver\n\nThe target nds32 and its companion adapter aice have not received\nany real improvement since 2013.\nIt has been hard to keep them aligned during the evolution of\nOpenOCD code, with no way for maintainers to really check if they\nare still working.\nNo real documentation is present for them in OpenOCD.\n\nThe arch nds32 has been dropped from Linux kernel v5.18-rc1.\n\nDeprecate both nds32 target and aice adapter with the target of\ndropping them for v0.13.0.\nRemove automatic build of aice, forcing user to select it.\n\nChange-Id: Ib465d676246fa3b4e95c3d399ba9a5cf1f8b3baf\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6887\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nTested-by: jenkins\n"}},"758f6226e28c6905b3fd8cf13e0d536e422dfc8b":{"kind":"REWORK","_number":1,"created":"2022-04-04 07:56:41.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/87/6887/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/87/6887/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/87/6887/1 \u0026\u0026 git checkout -b change-6887 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/87/6887/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/87/6887/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/87/6887/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/87/6887/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/87/6887/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7c6d379cf4434c69a977af4f417fe1ab1f3f9178","subject":"tcl/board: Add NXP FRDM-K64F"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-03-24 14:30:16.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-04-04 07:52:33.000000000","tz":120},"subject":"nds32: deprecate it, together with aice adapter driver","message":"nds32: deprecate it, together with aice adapter driver\n\nThe target nds32 and its companion adapter aice have not received\nany real improvement since 2013.\nIt has been hard to keep them aligned during the evolution of\nOpenOCD code, with no way for maintainers to really check if they\nare still working.\nNo real documentation is present for them in OpenOCD.\n\nThe arch nds32 has been dropped from Linux kernel v5.18-rc1.\n\nDeprecate both nds32 target and aice adapter with the target of\ndropping them for v0.13.0.\nRemove automatic build of aice, forcing user to select it.\n\nChange-Id: Ib465d676246fa3b4e95c3d399ba9a5cf1f8b3baf\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}