)]}'
{"id":"openocd~master~Ide0fe7d9ffb9fac95cee4c805735f434c7c4934d","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1001978":{"account":{"_account_id":1001978,"name":"Frank Dischner","email":"frank.dischner@gmail.com","username":"fdischner"},"last_update":"2022-08-08 20:48:10.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ide0fe7d9ffb9fac95cee4c805735f434c7c4934d","subject":"FreeRTOS: Always show current execution before scheduler is started","status":"MERGED","created":"2022-04-18 02:46:52.000000000","updated":"2022-08-08 20:48:10.000000000","submitted":"2022-08-08 20:48:10.000000000","submitter":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6935","meta_rev_id":"b45b06d4ed59d47f2082c2c433a3f88e4a4d2d09","_number":6935,"owner":{"_account_id":1001978,"name":"Frank Dischner","email":"frank.dischner@gmail.com","username":"fdischner"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1002011,"name":"Asier Llano","email":"asierllano@gmail.com","username":"asierllano"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-08-08 20:48:10.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-08-08 20:48:10.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1002011,"name":"Asier Llano","email":"asierllano@gmail.com","username":"asierllano"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-08-08 20:48:10.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1002011,"name":"Asier Llano","email":"asierllano@gmail.com","username":"asierllano"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-04-18 03:34:10.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-07-21 15:51:44.000000000","updated_by":{"_account_id":1002011,"name":"Asier Llano","email":"asierllano@gmail.com","username":"asierllano"},"reviewer":{"_account_id":1002011,"name":"Asier Llano","email":"asierllano@gmail.com","username":"asierllano"},"state":"REVIEWER"},{"updated":"2022-07-31 15:31:12.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"}],"messages":[{"id":"ef8581514c7c54073dad24a3d3693c165f66c6b0","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001978,"name":"Frank Dischner","email":"frank.dischner@gmail.com","username":"fdischner"},"real_author":{"_account_id":1001978,"name":"Frank Dischner","email":"frank.dischner@gmail.com","username":"fdischner"},"date":"2022-04-18 02:46:52.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"571c6e581f0c4a5e0c71fcfdc5883888446d626f","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-04-18 03:34:10.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/16014/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/15224/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"40c219622592acc35797edd0ddb2a29c2d9f62c8","author":{"_account_id":1002011,"name":"Asier Llano","email":"asierllano@gmail.com","username":"asierllano"},"real_author":{"_account_id":1002011,"name":"Asier Llano","email":"asierllano@gmail.com","username":"asierllano"},"date":"2022-07-21 15:51:44.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"4774a3c2689186ce2c4d8ec9d864fb3f56dac9e1","author":{"_account_id":1002011,"name":"Asier Llano","email":"asierllano@gmail.com","username":"asierllano"},"real_author":{"_account_id":1002011,"name":"Asier Llano","email":"asierllano@gmail.com","username":"asierllano"},"date":"2022-07-22 09:50:54.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"0dcd7bd0e5942155bdd5fc58fa10e474cac5a5df","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-07-31 15:31:12.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"b45b06d4ed59d47f2082c2c433a3f88e4a4d2d09","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-08-08 20:48:10.000000000","message":"Change has been successfully cherry-picked as df75bbd53620c3a59e9fd3cfd0aaeae26ab795af","accounts_in_message":[],"_revision_number":2}],"current_revision":"df75bbd53620c3a59e9fd3cfd0aaeae26ab795af","revisions":{"1f69b5ee46393b5ebcca1f228724e225f72c88b9":{"kind":"REWORK","_number":1,"created":"2022-04-18 02:46:52.000000000","uploader":{"_account_id":1001978,"name":"Frank Dischner","email":"frank.dischner@gmail.com","username":"fdischner"},"ref":"refs/changes/35/6935/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/35/6935/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/35/6935/1 \u0026\u0026 git checkout -b change-6935 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/35/6935/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/35/6935/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/35/6935/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/35/6935/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/35/6935/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"88ffd5817d9d495c4a15bf6164d3f2b28b38aae2","subject":"FreeRTOS: Fix current thread ID when no threads are active"}],"author":{"name":"Frank Dischner","email":"frank.dischner@gmail.com","date":"2022-04-18 02:24:28.000000000","tz":-300},"committer":{"name":"Frank Dischner","email":"frank.dischner@gmail.com","date":"2022-04-18 02:24:28.000000000","tz":-300},"subject":"FreeRTOS: Always show current execution before scheduler is started","message":"FreeRTOS: Always show current execution before scheduler is started\n\nPreviously, if the target was halted before the FreeRTOS scheduler was\nstarted but after at least one thread was created, then the current thread\nwould be set to whichever thread had the highest priority. In addition to\nbeing misleading, because that thread is not actually running, it can\ncause issues with gdb. For instance, breaking somewhere before the first\nthread is created will show the current execution as the current thread,\nbut stepping over a line that creates a thread will cause the current\nthread to switch to the newly created thread and the current execution to\ndisappear. The sudden disappearance of the current execution thread seems\nto confuse some versions of gdb.\n\nWith this change, the value of xSchedulerRunning is checked to determine\nwhether the scheduler has been started. If it hasn\u0027t, then a fake\n\u0027current execution\u0027 thread is always created and made the current thread.\n\nSigned-off-by: Frank Dischner \u003cfrank.dischner@gmail.com\u003e\nChange-Id: Ide0fe7d9ffb9fac95cee4c805735f434c7c4934d\n"}},"df75bbd53620c3a59e9fd3cfd0aaeae26ab795af":{"kind":"REWORK","_number":2,"created":"2022-08-08 20:48:10.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/35/6935/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/35/6935/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/35/6935/2 \u0026\u0026 git checkout -b change-6935 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/35/6935/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/35/6935/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/35/6935/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/35/6935/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/35/6935/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3865c411eebf01192ee347a1bd5c201c97ed23a6","subject":"FreeRTOS: Fix current thread ID when no threads are active"}],"author":{"name":"Frank Dischner","email":"frank.dischner@gmail.com","date":"2022-04-18 02:24:28.000000000","tz":-300},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-08-08 20:48:10.000000000","tz":0},"subject":"FreeRTOS: Always show current execution before scheduler is started","message":"FreeRTOS: Always show current execution before scheduler is started\n\nPreviously, if the target was halted before the FreeRTOS scheduler was\nstarted but after at least one thread was created, then the current thread\nwould be set to whichever thread had the highest priority. In addition to\nbeing misleading, because that thread is not actually running, it can\ncause issues with gdb. For instance, breaking somewhere before the first\nthread is created will show the current execution as the current thread,\nbut stepping over a line that creates a thread will cause the current\nthread to switch to the newly created thread and the current execution to\ndisappear. The sudden disappearance of the current execution thread seems\nto confuse some versions of gdb.\n\nWith this change, the value of xSchedulerRunning is checked to determine\nwhether the scheduler has been started. If it hasn\u0027t, then a fake\n\u0027current execution\u0027 thread is always created and made the current thread.\n\nSigned-off-by: Frank Dischner \u003cfrank.dischner@gmail.com\u003e\nChange-Id: Ide0fe7d9ffb9fac95cee4c805735f434c7c4934d\nReviewed-on: https://review.openocd.org/c/openocd/+/6935\nTested-by: jenkins\nReviewed-by: Asier Llano \u003casierllano@gmail.com\u003e\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}