)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"6bc34c7079381d9db59a8171c33fb439dde50158","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6be0f9cb_55364adb","updated":"2022-04-18 19:29:44.000000000","message":"Thanks for the patch.\nSome minor comment ...","commit_id":"42621ca9010c07e3695eebd3546bbbb167e28719"},{"author":{"_account_id":1001975,"name":"Steve Marple","email":"stevemarple@googlemail.com","username":"stevemarple"},"change_message_id":"65ef260df64866cea4742bd42118001d64de8990","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a0ef5f50_bee94ee0","updated":"2022-04-19 21:54:22.000000000","message":"I missed that too. I\u0027ll push a correction.","commit_id":"bf94ecd1ccb590d7a28b65898ce8db14e2e37598"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"20a0da7aae946e57dd38d898a067785a138b9fd0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5e91dd70_05550de0","updated":"2022-04-20 20:36:44.000000000","message":"Thanks!","commit_id":"ab49b37a3970beff26ead4f1d02ed027f8b83f7a"}],"src/jtag/drivers/linuxgpiod.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"6bc34c7079381d9db59a8171c33fb439dde50158","unresolved":true,"context_lines":[{"line_number":67,"context_line":"static int last_swdio;"},{"line_number":68,"context_line":"static bool last_stored;"},{"line_number":69,"context_line":"static bool swdio_input;"},{"line_number":70,"context_line":"static bool swdio_dir_output_value \u003d true;"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"/* Bitbang interface read of TDO */"},{"line_number":73,"context_line":"static bb_value_t linuxgpiod_read(void)"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"e5a1acec_aac8bfae","line":70,"updated":"2022-04-18 19:29:44.000000000","message":"I think you want to introduce the feature of \"dir\" pin active-high or active-low. Do you confirm?\nThat would be nice, even if this patch does not provide the feature.\nAnyway, I prefer a different name that better explains the purpose, as e.g. \"swdio_dir_is_active_high\".","commit_id":"42621ca9010c07e3695eebd3546bbbb167e28719"},{"author":{"_account_id":1001975,"name":"Steve Marple","email":"stevemarple@googlemail.com","username":"stevemarple"},"change_message_id":"dad337b13643a2d136a8ac97dce94171103e5a40","unresolved":false,"context_lines":[{"line_number":67,"context_line":"static int last_swdio;"},{"line_number":68,"context_line":"static bool last_stored;"},{"line_number":69,"context_line":"static bool swdio_input;"},{"line_number":70,"context_line":"static bool swdio_dir_output_value \u003d true;"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"/* Bitbang interface read of TDO */"},{"line_number":73,"context_line":"static bb_value_t linuxgpiod_read(void)"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"a8b660c1_7180f382","line":70,"in_reply_to":"e5a1acec_aac8bfae","updated":"2022-04-18 20:56:07.000000000","message":"Yes. The idea was to make it easy to add such a feature later.","commit_id":"42621ca9010c07e3695eebd3546bbbb167e28719"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"6bc34c7079381d9db59a8171c33fb439dde50158","unresolved":true,"context_lines":[{"line_number":158,"context_line":""},{"line_number":159,"context_line":"\tif (is_output) {"},{"line_number":160,"context_line":"\t\tif (gpiod_swdio_dir) {"},{"line_number":161,"context_line":"\t\t\tretval \u003d gpiod_line_set_value(gpiod_swdio_dir, (int)swdio_dir_output_value);"},{"line_number":162,"context_line":"\t\t\tif (retval \u003c 0)"},{"line_number":163,"context_line":"\t\t\t\tLOG_WARNING(\"Fail set swdio_dir\");"},{"line_number":164,"context_line":"\t\t}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"cb5cd520_d17d101b","line":161,"updated":"2022-04-18 19:29:44.000000000","message":"Here the cast from bool to int is not nice. Better writing:\nswdio_dir_is_active_high ? 1 : 0,","commit_id":"42621ca9010c07e3695eebd3546bbbb167e28719"},{"author":{"_account_id":1001975,"name":"Steve Marple","email":"stevemarple@googlemail.com","username":"stevemarple"},"change_message_id":"dad337b13643a2d136a8ac97dce94171103e5a40","unresolved":false,"context_lines":[{"line_number":158,"context_line":""},{"line_number":159,"context_line":"\tif (is_output) {"},{"line_number":160,"context_line":"\t\tif (gpiod_swdio_dir) {"},{"line_number":161,"context_line":"\t\t\tretval \u003d gpiod_line_set_value(gpiod_swdio_dir, (int)swdio_dir_output_value);"},{"line_number":162,"context_line":"\t\t\tif (retval \u003c 0)"},{"line_number":163,"context_line":"\t\t\t\tLOG_WARNING(\"Fail set swdio_dir\");"},{"line_number":164,"context_line":"\t\t}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"6798b7dc_9967ebb5","line":161,"in_reply_to":"cb5cd520_d17d101b","updated":"2022-04-18 20:56:07.000000000","message":"Done","commit_id":"42621ca9010c07e3695eebd3546bbbb167e28719"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"6bc34c7079381d9db59a8171c33fb439dde50158","unresolved":true,"context_lines":[{"line_number":170,"context_line":"\t\tif (retval \u003c 0)"},{"line_number":171,"context_line":"\t\t\tLOG_WARNING(\"Fail request_input line swdio\");"},{"line_number":172,"context_line":"\t\tif (gpiod_swdio_dir) {"},{"line_number":173,"context_line":"\t\t\tretval \u003d gpiod_line_set_value(gpiod_swdio_dir, (int)(!swdio_dir_output_value));"},{"line_number":174,"context_line":"\t\t\tif (retval \u003c 0)"},{"line_number":175,"context_line":"\t\t\t\tLOG_WARNING(\"Fail set swdio_dir\");"},{"line_number":176,"context_line":"\t\t}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"11f24ee6_730d00d4","line":173,"updated":"2022-04-18 19:29:44.000000000","message":"and here:\nswdio_dir_is_active_high ? 0 : 1,","commit_id":"42621ca9010c07e3695eebd3546bbbb167e28719"},{"author":{"_account_id":1001975,"name":"Steve Marple","email":"stevemarple@googlemail.com","username":"stevemarple"},"change_message_id":"dad337b13643a2d136a8ac97dce94171103e5a40","unresolved":false,"context_lines":[{"line_number":170,"context_line":"\t\tif (retval \u003c 0)"},{"line_number":171,"context_line":"\t\t\tLOG_WARNING(\"Fail request_input line swdio\");"},{"line_number":172,"context_line":"\t\tif (gpiod_swdio_dir) {"},{"line_number":173,"context_line":"\t\t\tretval \u003d gpiod_line_set_value(gpiod_swdio_dir, (int)(!swdio_dir_output_value));"},{"line_number":174,"context_line":"\t\t\tif (retval \u003c 0)"},{"line_number":175,"context_line":"\t\t\t\tLOG_WARNING(\"Fail set swdio_dir\");"},{"line_number":176,"context_line":"\t\t}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"d0963269_0c14d2d8","line":173,"in_reply_to":"11f24ee6_730d00d4","updated":"2022-04-18 20:56:07.000000000","message":"Done","commit_id":"42621ca9010c07e3695eebd3546bbbb167e28719"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"6bc34c7079381d9db59a8171c33fb439dde50158","unresolved":true,"context_lines":[{"line_number":487,"context_line":"\t\t\tif (!gpiod_swdio_dir)"},{"line_number":488,"context_line":"\t\t\t\tgoto out_error;"},{"line_number":489,"context_line":"\t\t} else {"},{"line_number":490,"context_line":"\t\t\tgpiod_swdio_dir \u003d NULL;"},{"line_number":491,"context_line":"\t\t}"},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"\t\tgpiod_swdio \u003d helper_get_output_line(\"swdio\", gpiod_chip_swdio, swdio_gpio, 1);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"fbb3a7c7_8b50334c","line":490,"updated":"2022-04-18 19:29:44.000000000","message":"no need for this \"else\" branch to set gpiod_swdio_dir to NULL. It is already NULL.","commit_id":"42621ca9010c07e3695eebd3546bbbb167e28719"},{"author":{"_account_id":1001975,"name":"Steve Marple","email":"stevemarple@googlemail.com","username":"stevemarple"},"change_message_id":"dad337b13643a2d136a8ac97dce94171103e5a40","unresolved":false,"context_lines":[{"line_number":487,"context_line":"\t\t\tif (!gpiod_swdio_dir)"},{"line_number":488,"context_line":"\t\t\t\tgoto out_error;"},{"line_number":489,"context_line":"\t\t} else {"},{"line_number":490,"context_line":"\t\t\tgpiod_swdio_dir \u003d NULL;"},{"line_number":491,"context_line":"\t\t}"},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"\t\tgpiod_swdio \u003d helper_get_output_line(\"swdio\", gpiod_chip_swdio, swdio_gpio, 1);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"45323811_443beff8","line":490,"in_reply_to":"fbb3a7c7_8b50334c","updated":"2022-04-18 20:56:07.000000000","message":"Done","commit_id":"42621ca9010c07e3695eebd3546bbbb167e28719"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"42df0b1ad10074dbf4b00acc9381f22f7420d079","unresolved":true,"context_lines":[{"line_number":483,"context_line":"\t\t/* Set buffer direction before making SWDIO an output */"},{"line_number":484,"context_line":"\t\tif (is_gpio_valid(swdio_dir_gpio)) {"},{"line_number":485,"context_line":"\t\t\tgpiod_swdio_dir \u003d helper_get_output_line(\"swdio_dir\", gpiod_chip_swdio_dir, swdio_dir_gpio,"},{"line_number":486,"context_line":"\t\t\t\t\t(int)swdio_dir_is_active_high);"},{"line_number":487,"context_line":"\t\t\tif (!gpiod_swdio_dir)"},{"line_number":488,"context_line":"\t\t\t\tgoto out_error;"},{"line_number":489,"context_line":"\t\t}"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"f8b51de5_31cd5c80","line":486,"updated":"2022-04-19 21:30:38.000000000","message":"sorry I have missed this. Don\u0027t use cast but:\nswdio_dir_is_active_high ? 1 : 0","commit_id":"bf94ecd1ccb590d7a28b65898ce8db14e2e37598"},{"author":{"_account_id":1001975,"name":"Steve Marple","email":"stevemarple@googlemail.com","username":"stevemarple"},"change_message_id":"65ef260df64866cea4742bd42118001d64de8990","unresolved":false,"context_lines":[{"line_number":483,"context_line":"\t\t/* Set buffer direction before making SWDIO an output */"},{"line_number":484,"context_line":"\t\tif (is_gpio_valid(swdio_dir_gpio)) {"},{"line_number":485,"context_line":"\t\t\tgpiod_swdio_dir \u003d helper_get_output_line(\"swdio_dir\", gpiod_chip_swdio_dir, swdio_dir_gpio,"},{"line_number":486,"context_line":"\t\t\t\t\t(int)swdio_dir_is_active_high);"},{"line_number":487,"context_line":"\t\t\tif (!gpiod_swdio_dir)"},{"line_number":488,"context_line":"\t\t\t\tgoto out_error;"},{"line_number":489,"context_line":"\t\t}"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"374ae142_bf63860f","line":486,"in_reply_to":"f8b51de5_31cd5c80","updated":"2022-04-19 21:54:22.000000000","message":"Done","commit_id":"bf94ecd1ccb590d7a28b65898ce8db14e2e37598"}]}