)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1001975,"name":"Steve Marple","email":"stevemarple@googlemail.com","username":"stevemarple"},"change_message_id":"94b2c68f0bf3efe429b390530de07bd1677306de","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9d65cf55_1195c6c7","updated":"2022-04-20 21:11:17.000000000","message":"Changes to follow soon.","commit_id":"a585a2995019934db8c57fb2990b087d8b1f78fa"},{"author":{"_account_id":1001975,"name":"Steve Marple","email":"stevemarple@googlemail.com","username":"stevemarple"},"change_message_id":"97445a033a43ea518dfc8fb2fe4e3f70983e2152","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"425d752c_eafa9dc0","updated":"2022-05-01 13:54:30.000000000","message":"Rebased and retested against nRF52832 (SWD) and STM32F401 (JTAG). Also moved is_gpio_valid() to avoid forward declaration (to take into account comment received for patch #6941).","commit_id":"453b60dd6e69e550b8990b60b64b7440b8616c46"},{"author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"change_message_id":"e50d43cc51de17d68d856cd967aba062d15daec7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1ae4fbf3_3f182d37","updated":"2022-05-03 14:23:03.000000000","message":"Thanks","commit_id":"453b60dd6e69e550b8990b60b64b7440b8616c46"}],"src/jtag/drivers/bcm2835gpio.c":[{"author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"change_message_id":"723f9b6cdb26a76e9053390ac5df8385f6838184","unresolved":true,"context_lines":[{"line_number":133,"context_line":"\tuint32_t set \u003d 0;"},{"line_number":134,"context_line":"\tuint32_t clear \u003d 0;"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"\tif (trst_gpio \u003e 0) {"},{"line_number":137,"context_line":"\t\tset |\u003d !trst\u003c\u003ctrst_gpio;"},{"line_number":138,"context_line":"\t\tclear |\u003d trst\u003c\u003ctrst_gpio;"},{"line_number":139,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"db322232_db8581b2","line":136,"updated":"2022-04-20 15:44:22.000000000","message":"Seems to be a widespread problem","commit_id":"a585a2995019934db8c57fb2990b087d8b1f78fa"},{"author":{"_account_id":1001975,"name":"Steve Marple","email":"stevemarple@googlemail.com","username":"stevemarple"},"change_message_id":"94b2c68f0bf3efe429b390530de07bd1677306de","unresolved":false,"context_lines":[{"line_number":133,"context_line":"\tuint32_t set \u003d 0;"},{"line_number":134,"context_line":"\tuint32_t clear \u003d 0;"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"\tif (trst_gpio \u003e 0) {"},{"line_number":137,"context_line":"\t\tset |\u003d !trst\u003c\u003ctrst_gpio;"},{"line_number":138,"context_line":"\t\tclear |\u003d trst\u003c\u003ctrst_gpio;"},{"line_number":139,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"31480ad3_04189e5f","line":136,"in_reply_to":"db322232_db8581b2","updated":"2022-04-20 21:11:17.000000000","message":"Ack","commit_id":"a585a2995019934db8c57fb2990b087d8b1f78fa"},{"author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"change_message_id":"723f9b6cdb26a76e9053390ac5df8385f6838184","unresolved":true,"context_lines":[{"line_number":151,"context_line":""},{"line_number":152,"context_line":"static void bcm2835_swdio_drive(bool is_output)"},{"line_number":153,"context_line":"{"},{"line_number":154,"context_line":"\tif (swdio_dir_gpio !\u003d -1) {"},{"line_number":155,"context_line":"\t\tif (is_output) {"},{"line_number":156,"context_line":"\t\t\tGPIO_SET \u003d 1 \u003c\u003c swdio_dir_gpio;"},{"line_number":157,"context_line":"\t\t\tOUT_GPIO(swdio_gpio);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"1b29d5a1_d0a5c688","line":154,"updated":"2022-04-20 15:44:22.000000000","message":"Nice catch. Although there is a is_gpio_valid() helper defined below that would be better to use... also in all the other places in this file which is using \u003e0 or \u003e\u003d0 or -1 etc.","commit_id":"a585a2995019934db8c57fb2990b087d8b1f78fa"},{"author":{"_account_id":1001975,"name":"Steve Marple","email":"stevemarple@googlemail.com","username":"stevemarple"},"change_message_id":"94b2c68f0bf3efe429b390530de07bd1677306de","unresolved":false,"context_lines":[{"line_number":151,"context_line":""},{"line_number":152,"context_line":"static void bcm2835_swdio_drive(bool is_output)"},{"line_number":153,"context_line":"{"},{"line_number":154,"context_line":"\tif (swdio_dir_gpio !\u003d -1) {"},{"line_number":155,"context_line":"\t\tif (is_output) {"},{"line_number":156,"context_line":"\t\t\tGPIO_SET \u003d 1 \u003c\u003c swdio_dir_gpio;"},{"line_number":157,"context_line":"\t\t\tOUT_GPIO(swdio_gpio);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"4df77929_19f77ced","line":154,"in_reply_to":"1b29d5a1_d0a5c688","updated":"2022-04-20 21:11:17.000000000","message":"I will use is_gpio_valid() for all such checks and submit a new patch.","commit_id":"a585a2995019934db8c57fb2990b087d8b1f78fa"}]}