)]}'
{"id":"openocd~master~Ib8fb704ab588a618ac41c111f6168d658891d92c","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1001975":{"account":{"_account_id":1001975,"name":"Steve Marple","email":"stevemarple@googlemail.com","username":"stevemarple"},"last_update":"2022-05-14 08:59:03.000000000","reason":"Change was submitted"},"1000005":{"account":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"last_update":"2022-05-03 14:23:03.000000000","reason":"Andreas Fritiofson replied on the change"}},"hashtags":[],"change_id":"Ib8fb704ab588a618ac41c111f6168d658891d92c","subject":"bcm2835gpio: Fix incorrect GPIO validation","status":"MERGED","created":"2022-04-20 14:09:26.000000000","updated":"2022-05-14 08:59:03.000000000","submitted":"2022-05-14 08:59:03.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":7,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6938","meta_rev_id":"db29402784baa0819a28a301772e45726b9615ff","_number":6938,"owner":{"_account_id":1001975,"name":"Steve Marple","email":"stevemarple@googlemail.com","username":"stevemarple"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-05-14 08:59:03.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-05-14 08:59:03.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-05-14 08:59:03.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-04-20 15:21:55.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-04-20 15:44:22.000000000","updated_by":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"reviewer":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"state":"CC"},{"updated":"2022-05-01 14:35:24.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"},{"updated":"2022-05-03 14:23:03.000000000","updated_by":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"reviewer":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"state":"REVIEWER"}],"messages":[{"id":"460dcb9bd0b4e06fe251038009e34a3dde7f6b01","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001975,"name":"Steve Marple","email":"stevemarple@googlemail.com","username":"stevemarple"},"real_author":{"_account_id":1001975,"name":"Steve Marple","email":"stevemarple@googlemail.com","username":"stevemarple"},"date":"2022-04-20 14:09:26.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"4f59ee1c68fb20516e6c9e88fa14b809454ccde5","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-04-20 15:21:55.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/16021/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/15231/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"723f9b6cdb26a76e9053390ac5df8385f6838184","author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"real_author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"date":"2022-04-20 15:44:22.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"94b2c68f0bf3efe429b390530de07bd1677306de","author":{"_account_id":1001975,"name":"Steve Marple","email":"stevemarple@googlemail.com","username":"stevemarple"},"real_author":{"_account_id":1001975,"name":"Steve Marple","email":"stevemarple@googlemail.com","username":"stevemarple"},"date":"2022-04-20 21:11:17.000000000","message":"Patch Set 1:\n\n(3 comments)","accounts_in_message":[],"_revision_number":1},{"id":"d27fe1cd361c67fb22b39d9b0942aa8f77009d58","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001975,"name":"Steve Marple","email":"stevemarple@googlemail.com","username":"stevemarple"},"real_author":{"_account_id":1001975,"name":"Steve Marple","email":"stevemarple@googlemail.com","username":"stevemarple"},"date":"2022-04-20 22:23:14.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"ac43e02b7e050ce8010981bae83b68edb9269e08","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-04-20 22:43:31.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/16023/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/15233/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"f0cde18ee6c60067356df96a6934d95b9074ea3a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001975,"name":"Steve Marple","email":"stevemarple@googlemail.com","username":"stevemarple"},"real_author":{"_account_id":1001975,"name":"Steve Marple","email":"stevemarple@googlemail.com","username":"stevemarple"},"date":"2022-05-01 13:27:26.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"9d6467014de53a0e6c2cfe0710c346fc54f29380","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-05-01 13:48:05.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/16088/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/15298/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"97445a033a43ea518dfc8fb2fe4e3f70983e2152","author":{"_account_id":1001975,"name":"Steve Marple","email":"stevemarple@googlemail.com","username":"stevemarple"},"real_author":{"_account_id":1001975,"name":"Steve Marple","email":"stevemarple@googlemail.com","username":"stevemarple"},"date":"2022-05-01 13:54:30.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"9ddf5e4a236490d4cbd184a16490d2d0c4e0c36c","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-05-01 14:35:24.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"e50d43cc51de17d68d856cd967aba062d15daec7","author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"real_author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"date":"2022-05-03 14:23:03.000000000","message":"Patch Set 3: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"db29402784baa0819a28a301772e45726b9615ff","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-05-14 08:59:03.000000000","message":"Change has been successfully cherry-picked as 0b241ca042b1376efdcaacc52a798a20a0d9fc2a","accounts_in_message":[],"_revision_number":4}],"current_revision":"0b241ca042b1376efdcaacc52a798a20a0d9fc2a","revisions":{"0b241ca042b1376efdcaacc52a798a20a0d9fc2a":{"kind":"REWORK","_number":4,"created":"2022-05-14 08:59:03.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/38/6938/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/38/6938/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/38/6938/4 \u0026\u0026 git checkout -b change-6938 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/38/6938/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/38/6938/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/38/6938/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/38/6938/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/38/6938/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"cc75aa37c5ba6267956a3613069b7d35420b76fc","subject":"openocd: add post-init and pre-shutdown helpers"}],"author":{"name":"Steve Marple","email":"stevemarple@googlemail.com","date":"2022-04-19 22:22:31.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-05-14 08:59:03.000000000","tz":0},"subject":"bcm2835gpio: Fix incorrect GPIO validation","message":"bcm2835gpio: Fix incorrect GPIO validation\n\nIncorrect validation prevented GPIO0 from controlling the direction of\nthe SWDIO buffer or operating TRST/SRST.\n\nHave all GPIO number validation checks performed by is_gpio_valid().\n\nChange-Id: Ib8fb704ab588a618ac41c111f6168d658891d92c\nSigned-off-by: Steve Marple \u003cstevemarple@googlemail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6938\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-by: Andreas Fritiofson \u003candreas.fritiofson@gmail.com\u003e\n"}},"453b60dd6e69e550b8990b60b64b7440b8616c46":{"kind":"REWORK","_number":3,"created":"2022-05-01 13:27:26.000000000","uploader":{"_account_id":1001975,"name":"Steve Marple","email":"stevemarple@googlemail.com","username":"stevemarple"},"ref":"refs/changes/38/6938/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/38/6938/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/38/6938/3 \u0026\u0026 git checkout -b change-6938 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/38/6938/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/38/6938/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/38/6938/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/38/6938/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/38/6938/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"66335683fec62ac89da48d64932fd9d082314225","subject":"drivers/cmsis-dap: Correct the DAP protocol parameter parsing error"}],"author":{"name":"Steve Marple","email":"stevemarple@googlemail.com","date":"2022-04-19 22:22:31.000000000","tz":60},"committer":{"name":"Steve Marple","email":"stevemarple@googlemail.com","date":"2022-05-01 13:26:46.000000000","tz":60},"subject":"bcm2835gpio: Fix incorrect GPIO validation","message":"bcm2835gpio: Fix incorrect GPIO validation\n\nIncorrect validation prevented GPIO0 from controlling the direction of\nthe SWDIO buffer or operating TRST/SRST.\n\nHave all GPIO number validation checks performed by is_gpio_valid().\n\nChange-Id: Ib8fb704ab588a618ac41c111f6168d658891d92c\nSigned-off-by: Steve Marple \u003cstevemarple@googlemail.com\u003e\n"}},"c23c79c8d9d46f2de948dce22f3e39bb0d4a8de9":{"kind":"REWORK","_number":2,"created":"2022-04-20 22:23:14.000000000","uploader":{"_account_id":1001975,"name":"Steve Marple","email":"stevemarple@googlemail.com","username":"stevemarple"},"ref":"refs/changes/38/6938/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/38/6938/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/38/6938/2 \u0026\u0026 git checkout -b change-6938 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/38/6938/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/38/6938/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/38/6938/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/38/6938/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/38/6938/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"e83eeb44aa96e380f46d37980b8b76a908757dc6","subject":"flash/nor/stm32f1x: lock flash in case of error"}],"author":{"name":"Steve Marple","email":"stevemarple@googlemail.com","date":"2022-04-19 22:22:31.000000000","tz":60},"committer":{"name":"Steve Marple","email":"stevemarple@googlemail.com","date":"2022-04-20 21:40:29.000000000","tz":60},"subject":"bcm2835gpio: Fix incorrect GPIO validation","message":"bcm2835gpio: Fix incorrect GPIO validation\n\nIncorrect validation prevented GPIO0 from controlling the direction of\nthe SWDIO buffer or operating TRST/SRST.\n\nHave all GPIO number validation checks performed by is_gpio_valid().\n\nChange-Id: Ib8fb704ab588a618ac41c111f6168d658891d92c\nSigned-off-by: Steve Marple \u003cstevemarple@googlemail.com\u003e\n"}},"a585a2995019934db8c57fb2990b087d8b1f78fa":{"kind":"REWORK","_number":1,"created":"2022-04-20 14:09:26.000000000","uploader":{"_account_id":1001975,"name":"Steve Marple","email":"stevemarple@googlemail.com","username":"stevemarple"},"ref":"refs/changes/38/6938/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/38/6938/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/38/6938/1 \u0026\u0026 git checkout -b change-6938 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/38/6938/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/38/6938/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/38/6938/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/38/6938/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/38/6938/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"e83eeb44aa96e380f46d37980b8b76a908757dc6","subject":"flash/nor/stm32f1x: lock flash in case of error"}],"author":{"name":"Steve Marple","email":"stevemarple@googlemail.com","date":"2022-04-19 22:22:31.000000000","tz":60},"committer":{"name":"Steve Marple","email":"stevemarple@googlemail.com","date":"2022-04-19 22:31:24.000000000","tz":60},"subject":"bcm2835gpio: Fix bug swdio_drive GPIO validation","message":"bcm2835gpio: Fix bug swdio_drive GPIO validation\n\nIncorrect validation prevented GPIO0 from controlling the direction of\nthe SWDIO buffer.\n\nChange-Id: Ib8fb704ab588a618ac41c111f6168d658891d92c\nSigned-off-by: Steve Marple \u003cstevemarple@googlemail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}