)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"fbb3c4db52352a1ae0e74d5e65854db98d6dff5e","unresolved":true,"context_lines":[{"line_number":7,"context_line":"target/arm_cti: Fix error handling in \u0027cti create\u0027"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Handle JIM_CONTINUE return value of adiv5_jim_mem_ap_spot_configure(),"},{"line_number":10,"context_line":"otherwise OpenOCD silently quits when \u0027-dap\u0027 is not provided in \u0027cti create\u0027."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I9b1351c0911e74999d8dd1260ede9760088510d7"},{"line_number":13,"context_line":"Signed-off-by: Marc Schink \u003cdev@zapb.de\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"23eaea14_828d199e","line":10,"updated":"2022-04-23 15:16:38.000000000","message":"This statement is incorrect. If \u0027-dap\u0027 is not provided the code logs:\nError: -dap required when creating CTI\nInstead the bug you are fixing is the silent quit in case an unknown option is passed to dap create, e.g.\n dap create dapname -zapb","commit_id":"cf9b48e0e5af07d67b7cb696d24a98cf9d9579d7"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"71915ecb42926323ce4e1564e3a5eedae23da6e0","unresolved":false,"context_lines":[{"line_number":7,"context_line":"target/arm_cti: Fix error handling in \u0027cti create\u0027"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Handle JIM_CONTINUE return value of adiv5_jim_mem_ap_spot_configure(),"},{"line_number":10,"context_line":"otherwise OpenOCD silently quits when \u0027-dap\u0027 is not provided in \u0027cti create\u0027."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I9b1351c0911e74999d8dd1260ede9760088510d7"},{"line_number":13,"context_line":"Signed-off-by: Marc Schink \u003cdev@zapb.de\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"807d95c0_da23039f","line":10,"in_reply_to":"23eaea14_828d199e","updated":"2022-04-24 18:18:18.000000000","message":"Done","commit_id":"cf9b48e0e5af07d67b7cb696d24a98cf9d9579d7"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"3028948b1e46ab5bf698932f41609a491f070913","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4e0918da_73fc8afa","updated":"2022-04-24 18:17:54.000000000","message":"Oups, you\u0027re right :-/ Maybe I had a typo in one of the options when I worked with \u0027cti create\u0027.","commit_id":"a3cdd9b27213037adb5f6ae8961b8c9ec61b4355"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"890eb08942d78e26a289e5fcae2b0a9f900d3f6a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"30f2f613_e3841957","updated":"2022-04-24 21:01:32.000000000","message":"thanks!","commit_id":"a3cdd9b27213037adb5f6ae8961b8c9ec61b4355"}],"src/target/arm_cti.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"fbb3c4db52352a1ae0e74d5e65854db98d6dff5e","unresolved":true,"context_lines":[{"line_number":436,"context_line":"\twhile (goi-\u003eargc \u003e 0) {"},{"line_number":437,"context_line":"\t\tint e \u003d adiv5_jim_mem_ap_spot_configure(\u0026cti-\u003espot, goi);"},{"line_number":438,"context_line":""},{"line_number":439,"context_line":"\t\tif (e \u003d\u003d JIM_ERR)"},{"line_number":440,"context_line":"\t\t\treturn e;"},{"line_number":441,"context_line":"\t\telse if (e \u003d\u003d JIM_CONTINUE)"},{"line_number":442,"context_line":"\t\t\tbreak;"},{"line_number":443,"context_line":"\t}"},{"line_number":444,"context_line":""},{"line_number":445,"context_line":"\tif (!cti-\u003espot.dap) {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"fae0cbdf_6b97def7","line":442,"range":{"start_line":439,"start_character":0,"end_line":442,"end_character":9},"updated":"2022-04-23 15:16:38.000000000","message":"No!\nIn case of unknown option, e.g. \u0027-zapb\u0027, e\u003d\u003dJIM_CONTINUE. A break will end the while loop, we do not parse the rest of the line, we don\u0027t trigger the error for unknown option!\nI think the correct code should be:\n while (...) {\n   int e \u003d adiv5_...();\n   if (e \u003d\u003d JIM_CONTINUE)\n     Jim_SetResultFormatted(goi-\u003einterp, \"unknown option \\\"%#s\\\"\", goi-\u003eargv[0]);\n   if (e !\u003d JIM_OK)\n     return JIM_ERR;\n  }","commit_id":"cf9b48e0e5af07d67b7cb696d24a98cf9d9579d7"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"71915ecb42926323ce4e1564e3a5eedae23da6e0","unresolved":false,"context_lines":[{"line_number":436,"context_line":"\twhile (goi-\u003eargc \u003e 0) {"},{"line_number":437,"context_line":"\t\tint e \u003d adiv5_jim_mem_ap_spot_configure(\u0026cti-\u003espot, goi);"},{"line_number":438,"context_line":""},{"line_number":439,"context_line":"\t\tif (e \u003d\u003d JIM_ERR)"},{"line_number":440,"context_line":"\t\t\treturn e;"},{"line_number":441,"context_line":"\t\telse if (e \u003d\u003d JIM_CONTINUE)"},{"line_number":442,"context_line":"\t\t\tbreak;"},{"line_number":443,"context_line":"\t}"},{"line_number":444,"context_line":""},{"line_number":445,"context_line":"\tif (!cti-\u003espot.dap) {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"7670d881_2514dec3","line":442,"range":{"start_line":439,"start_character":0,"end_line":442,"end_character":9},"in_reply_to":"fae0cbdf_6b97def7","updated":"2022-04-24 18:18:18.000000000","message":"Ack","commit_id":"cf9b48e0e5af07d67b7cb696d24a98cf9d9579d7"}]}