)]}'
{"id":"openocd~master~Ibae77a53de16375d3d500e728678740095547009","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2022-08-27 16:16:29.000000000","reason":"Change was submitted"},"1000863":{"account":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"last_update":"2022-08-27 16:16:29.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ibae77a53de16375d3d500e728678740095547009","subject":"tcl/target: stm32[fl]4x: document the settings for trace","status":"MERGED","created":"2022-04-23 14:27:27.000000000","updated":"2022-08-27 16:16:29.000000000","submitted":"2022-08-27 16:16:29.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6945","meta_rev_id":"643a41b78c28b930ac825f68647a775c20650637","_number":6945,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-08-27 16:16:29.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-08-27 16:16:29.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-08-27 16:16:29.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"}],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-04-23 15:14:17.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-04-23 15:17:29.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"state":"REVIEWER"},{"updated":"2022-08-15 14:31:29.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"}],"messages":[{"id":"36e2ca9de79015697b42a2f28b1da1a2b1675d0f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-04-23 14:27:27.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"316fb27162bdd465fce445c0161fd94b397596b8","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-04-23 15:14:17.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/16057/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/15267/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"cb1ff0dd868f12052ab86262563216c9d5f1b9bd","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-04-23 15:17:29.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"e0e7900261aefb6da6565439d7bbc2878b92926f","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-08-15 14:31:29.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"643a41b78c28b930ac825f68647a775c20650637","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-08-27 16:16:29.000000000","message":"Change has been successfully cherry-picked as 386155419bfd9a47d896dfe23dbda19f8a4cf2d0","accounts_in_message":[],"_revision_number":2}],"current_revision":"386155419bfd9a47d896dfe23dbda19f8a4cf2d0","revisions":{"386155419bfd9a47d896dfe23dbda19f8a4cf2d0":{"kind":"REWORK","_number":2,"created":"2022-08-27 16:16:29.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/45/6945/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/45/6945/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/45/6945/2 \u0026\u0026 git checkout -b change-6945 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/45/6945/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/45/6945/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/45/6945/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/45/6945/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/45/6945/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"09ca11066b568497cc2a191e9fedbf08673c15c6","subject":"tcl/target: replace event trace-config"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-04-23 14:14:15.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-08-27 16:16:29.000000000","tz":0},"subject":"tcl/target: stm32[fl]4x: document the settings for trace","message":"tcl/target: stm32[fl]4x: document the settings for trace\n\nWhile reviewing on gerrit the change\n\thttps://review.openocd.org/6932/\nit get clear that the missing documentation on stm32f4x\u0027s code\nwas triggering errors in the new change.\n\nOpenOCD is currently unable to read traces, but these can be\nhopefully be read with some other tool.\n\nDocument the settings for enabling trace on stm32[fl]4x.\n\nChange-Id: Ibae77a53de16375d3d500e728678740095547009\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6945\nTested-by: jenkins\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"b05c18be40bd62a823b21fc8f6dfa9dc0214e2ad":{"kind":"REWORK","_number":1,"created":"2022-04-23 14:27:27.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/45/6945/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/45/6945/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/45/6945/1 \u0026\u0026 git checkout -b change-6945 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/45/6945/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/45/6945/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/45/6945/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/45/6945/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/45/6945/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"08c4dcfbb1a238354faf8aa331d3486c267008ca","subject":"tcl/target: replace event trace-config"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-04-23 14:14:15.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-04-23 14:22:35.000000000","tz":120},"subject":"tcl/target: stm32[fl]4x: document the settings for trace","message":"tcl/target: stm32[fl]4x: document the settings for trace\n\nWhile reviewing on gerrit the change\n\thttps://review.openocd.org/6932/\nit get clear that the missing documentation on stm32f4x\u0027s code\nwas triggering errors in the new change.\n\nOpenOCD is currently unable to read traces, but these can be\nhopefully be read with some other tool.\n\nDocument the settings for enabling trace on stm32[fl]4x.\n\nChange-Id: Ibae77a53de16375d3d500e728678740095547009\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}