)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"ea4955ee1075bd64a55852a00c2d16baf64328dd","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"target/disassembler:  update capstone include path to \u003ccapstone.h\u003e"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"on macos (homebrew base) `pkg-config --cflags capstone` output with `-I/opt/homebrew/Cellar/capstone/4.0.2/include/capstone` which cause build error `fatal error: \u0027capstone/capstone.h\u0027 file not found`.  it\u0027s ok to change to \u003ccapstone.h\u003e for all platform."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Signed-off-by: fatalc \u003ccnfatal@gmail.com\u003e"},{"line_number":12,"context_line":"Change-Id: Ia2e2058024d4fc1a57a8b4ea847c664d74f67efb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"a3f8b61f_9a0a0da4","line":9,"updated":"2022-04-25 21:20:12.000000000","message":"Can you please split the commit message in lines shorter than 70~75 characters?","commit_id":"584658d5737ba3b57846441ffee5b673b0681041"},{"author":{"_account_id":1001979,"name":"cnfatal","email":"cnfatal@gmail.com","username":"cnfatal"},"change_message_id":"172d29910b26670486d968d27f41d849bc9ad3de","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"target/disassembler:  update capstone include path to \u003ccapstone.h\u003e"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"on macos (homebrew base) `pkg-config --cflags capstone` output with `-I/opt/homebrew/Cellar/capstone/4.0.2/include/capstone` which cause build error `fatal error: \u0027capstone/capstone.h\u0027 file not found`.  it\u0027s ok to change to \u003ccapstone.h\u003e for all platform."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Signed-off-by: fatalc \u003ccnfatal@gmail.com\u003e"},{"line_number":12,"context_line":"Change-Id: Ia2e2058024d4fc1a57a8b4ea847c664d74f67efb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"2879aa6d_f5b8a8e6","line":9,"in_reply_to":"a3f8b61f_9a0a0da4","updated":"2022-04-26 02:48:28.000000000","message":"Done","commit_id":"584658d5737ba3b57846441ffee5b673b0681041"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"ea4955ee1075bd64a55852a00c2d16baf64328dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"79899a60_7ec58e5f","updated":"2022-04-25 21:20:12.000000000","message":"Thanks for the patch!\nOnly one comment about the commit message","commit_id":"584658d5737ba3b57846441ffee5b673b0681041"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"dfe8ed4f34026262704b499bfd2fc2f526eff0e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"19ada775_6d64d842","updated":"2022-04-26 06:31:02.000000000","message":"Thanks!","commit_id":"38e754b48593ce42509b49ebbefba46140d37b00"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"0c64edbac4a1f9ba22f43899ca0e85a20a6ca112","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b0afe074_9bf71cb3","updated":"2022-05-04 17:07:20.000000000","message":"When I merge it down, this change breaks the github action https://review.openocd.org/gitweb?p\u003dopenocd.git;a\u003dblob;f\u003d.github/workflows/snapshot.yml;h\u003d96a2d34f2c877e80d95d79a561a7c4fada82b0e0;hb\u003drefs/heads/master\n\nBuild failure: https://github.com/riscv/riscv-openocd/runs/6293338772?check_suite_focus\u003dtrue\n\"/home/runner/work/riscv-openocd/riscv-openocd/src/target/arm_disassembler.c:30:10: fatal error: capstone.h: No such file or directory\"","commit_id":"12d1ad0c75298d56827debcacc83c679bfbe9ac2"},{"author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"change_message_id":"9cc6189cf659a95566062ffc67bfaea4c4b3ad3b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"23c1d4a2_5c07bf39","updated":"2022-05-06 11:47:46.000000000","message":"when I have added capstone to github action + cross-build.sh\nthere was a bug (harcoded paths) in capstone.pc.in file in the version 4.0.2\nthat\u0027s way I added a fix to the generated capstone.pc in cross-build.sh\n\nat that time, includedir\u003d${prefix}/include was working\nbut not now.\n\nif we need a hot fix, I propose the patch below, otherwise give me sometime to fix it correctly.\n\nhotfix link: https://review.openocd.org/c/openocd/+/6969","commit_id":"12d1ad0c75298d56827debcacc83c679bfbe9ac2"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"4503cf33f693dfd7dd13c00a8ee7b1c1db3a0132","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ed618dba_97789fee","in_reply_to":"871bc229_3033f8a7","updated":"2022-05-04 20:54:13.000000000","message":"Same failure here\nhttps://github.com/openocd-org/openocd/runs/6244582742?check_suite_focus\u003dtrue\n\nIn your fix you add the line\nCAPSTONE_CFLAGS: -I$(CAPSTONE_SRC)/include/capstone\nI\u0027m not at all in this github workflow stuff, but the fix looks incorrect.\nCapstone get installed, why you use the include files from the source?\nI see that pkg-config is in the requirements, but apparently it\u0027s not working.","commit_id":"12d1ad0c75298d56827debcacc83c679bfbe9ac2"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"4645985681e073cb7141c20c17a61f254c9f5f43","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"871bc229_3033f8a7","in_reply_to":"b0afe074_9bf71cb3","updated":"2022-05-04 17:39:53.000000000","message":"Fixed by https://github.com/riscv/riscv-openocd/pull/696/commits/a2c569f3be430ca4b75d4e02297f34801c3e2741\n\nIf that looks good, should I put it up for review in this repo?","commit_id":"12d1ad0c75298d56827debcacc83c679bfbe9ac2"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"e25af93242429fea93087d3b247eaabb8cacb73b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"85818bac_e0ec9627","in_reply_to":"ed618dba_97789fee","updated":"2022-05-05 17:14:00.000000000","message":"This is definitely a hack fix and not a proper fix, but I don\u0027t think it affects the final binary at all. Doing this properly isn\u0027t a high priority for me. I just care that the code in riscv-openocd will compile for Windows.","commit_id":"12d1ad0c75298d56827debcacc83c679bfbe9ac2"}],"contrib/cross-build.sh":[{"author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"change_message_id":"9cc6189cf659a95566062ffc67bfaea4c4b3ad3b","unresolved":true,"context_lines":[{"line_number":148,"context_line":"  sed -i \u00271s;^;prefix\u003d/usr \\"},{"line_number":149,"context_line":"exec_prefix\u003d${prefix} \\"},{"line_number":150,"context_line":"libdir\u003d${exec_prefix}/lib \\"},{"line_number":151,"context_line":"includedir\u003d${prefix}/include\\n\\n;\u0027 $CAPSTONE_PC_FILE"},{"line_number":152,"context_line":"fi"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":""}],"source_content_type":"text/x-sh","patch_set":3,"id":"b9784b6e_89db837b","line":151,"range":{"start_line":151,"start_character":0,"end_line":151,"end_character":52},"updated":"2022-05-06 11:47:46.000000000","message":"the proper fix should be here\n```\n- includedir\u003d${prefix}/include\\n\\n;\u0027 $CAPSTONE_PC_FILE\n+ includedir\u003d${prefix}/include/capstone\\n\\n;\u0027 $CAPSTONE_PC_FILE\n```","commit_id":"12d1ad0c75298d56827debcacc83c679bfbe9ac2"}]}