)]}'
{"id":"openocd~master~Ia2e2058024d4fc1a57a8b4ea847c664d74f67efb","project":"openocd","branch":"master","attention_set":{"1001979":{"account":{"_account_id":1001979,"name":"cnfatal","email":"cnfatal@gmail.com","username":"cnfatal"},"last_update":"2022-05-06 11:47:46.000000000","reason":"Tarek BOCHKATI replied on the change"}},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2022-04-26 06:31:02.000000000","reason":"Antonio Borneo replied on the change"}},"hashtags":[],"change_id":"Ia2e2058024d4fc1a57a8b4ea847c664d74f67efb","subject":"target/disassembler:  update capstone include path to \u003ccapstone.h\u003e","status":"MERGED","created":"2022-04-25 04:07:26.000000000","updated":"2022-05-06 11:47:46.000000000","submitted":"2022-04-30 17:53:30.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":10,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"6946","meta_rev_id":"9cc6189cf659a95566062ffc67bfaea4c4b3ad3b","_number":6946,"owner":{"_account_id":1001979,"name":"cnfatal","email":"cnfatal@gmail.com","username":"cnfatal"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-04-30 17:53:30.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-04-30 17:53:30.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"}],"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-04-25 04:09:49.000000000","updated_by":{"_account_id":1001979,"name":"cnfatal","email":"cnfatal@gmail.com","username":"cnfatal"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"},{"updated":"2022-04-25 04:40:21.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-05-04 17:07:20.000000000","updated_by":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"reviewer":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"state":"CC"},{"updated":"2022-05-06 11:47:46.000000000","updated_by":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"reviewer":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"state":"CC"}],"messages":[{"id":"e77e6c684eb04a09ea02ac34cf1ad853aad3c5ff","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001979,"name":"cnfatal","email":"cnfatal@gmail.com","username":"cnfatal"},"real_author":{"_account_id":1001979,"name":"cnfatal","email":"cnfatal@gmail.com","username":"cnfatal"},"date":"2022-04-25 04:07:26.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"bd4e7fa2ee2899acbd0ba41782eaa55955b5962e","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-04-25 04:40:21.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/16064/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/15274/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"ea4955ee1075bd64a55852a00c2d16baf64328dd","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-04-25 21:20:12.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"7efbbc01cfe4267b623e92a65a2c6942b70f5db8","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001979,"name":"cnfatal","email":"cnfatal@gmail.com","username":"cnfatal"},"real_author":{"_account_id":1001979,"name":"cnfatal","email":"cnfatal@gmail.com","username":"cnfatal"},"date":"2022-04-26 02:24:40.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"fdf03f5c0a696c6b5890200fb2b845dcd1468d86","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-04-26 02:48:06.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/16066/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/15276/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"172d29910b26670486d968d27f41d849bc9ad3de","author":{"_account_id":1001979,"name":"cnfatal","email":"cnfatal@gmail.com","username":"cnfatal"},"real_author":{"_account_id":1001979,"name":"cnfatal","email":"cnfatal@gmail.com","username":"cnfatal"},"date":"2022-04-26 02:48:28.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"dfe8ed4f34026262704b499bfd2fc2f526eff0e3","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-04-26 06:31:02.000000000","message":"Patch Set 2: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"3cf1f2e7cb0ace3fc2b4b11ddfbae73e08bd6726","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-04-30 17:53:30.000000000","message":"Change has been successfully cherry-picked as 12d1ad0c75298d56827debcacc83c679bfbe9ac2","accounts_in_message":[],"_revision_number":3},{"id":"0c64edbac4a1f9ba22f43899ca0e85a20a6ca112","author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"real_author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"date":"2022-05-04 17:07:20.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"4645985681e073cb7141c20c17a61f254c9f5f43","author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"real_author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"date":"2022-05-04 17:39:53.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"4503cf33f693dfd7dd13c00a8ee7b1c1db3a0132","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-05-04 20:54:13.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"e25af93242429fea93087d3b247eaabb8cacb73b","author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"real_author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"date":"2022-05-05 17:14:00.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"9cc6189cf659a95566062ffc67bfaea4c4b3ad3b","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2022-05-06 11:47:46.000000000","message":"Patch Set 3:\n\n(2 comments)","accounts_in_message":[],"_revision_number":3}],"current_revision":"12d1ad0c75298d56827debcacc83c679bfbe9ac2","revisions":{"584658d5737ba3b57846441ffee5b673b0681041":{"kind":"REWORK","_number":1,"created":"2022-04-25 04:07:26.000000000","uploader":{"_account_id":1001979,"name":"cnfatal","email":"cnfatal@gmail.com","username":"cnfatal"},"ref":"refs/changes/46/6946/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/46/6946/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/46/6946/1 \u0026\u0026 git checkout -b change-6946 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/46/6946/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/46/6946/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/46/6946/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/46/6946/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/46/6946/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9de084e0067a86b8040f8ea2c3f46dff0b9e6a70","subject":"flash/nor/stm32f1x: add can_load_options flag for GD32F1x0, F3x0 and E23x"}],"author":{"name":"fatalc","email":"cnfatal@gmail.com","date":"2022-04-25 04:06:10.000000000","tz":480},"committer":{"name":"fatalc","email":"cnfatal@gmail.com","date":"2022-04-25 04:07:13.000000000","tz":480},"subject":"target/disassembler:  update capstone include path to \u003ccapstone.h\u003e","message":"target/disassembler:  update capstone include path to \u003ccapstone.h\u003e\n\non macos (homebrew base) `pkg-config --cflags capstone` output with `-I/opt/homebrew/Cellar/capstone/4.0.2/include/capstone` which cause build error `fatal error: \u0027capstone/capstone.h\u0027 file not found`.  it\u0027s ok to change to \u003ccapstone.h\u003e for all platform.\n\nSigned-off-by: fatalc \u003ccnfatal@gmail.com\u003e\nChange-Id: Ia2e2058024d4fc1a57a8b4ea847c664d74f67efb\n"}},"12d1ad0c75298d56827debcacc83c679bfbe9ac2":{"kind":"REWORK","_number":3,"created":"2022-04-30 17:53:30.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/46/6946/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/46/6946/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/46/6946/3 \u0026\u0026 git checkout -b change-6946 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/46/6946/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/46/6946/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/46/6946/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/46/6946/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/46/6946/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"8789513fa94ff54f08eaffedce0cc6c38f44311d","subject":"target/arm_cti: Fix error handling in \u0027cti create\u0027"}],"author":{"name":"fatalc","email":"cnfatal@gmail.com","date":"2022-04-25 04:06:10.000000000","tz":480},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-04-30 17:53:30.000000000","tz":0},"subject":"target/disassembler:  update capstone include path to \u003ccapstone.h\u003e","message":"target/disassembler:  update capstone include path to \u003ccapstone.h\u003e\n\non macos (homebrew base) `pkg-config --cflags capstone` output with\n`-I/opt/homebrew/Cellar/capstone/4.0.2/include/capstone`\ngcc not find headers on parent \"include\" path,\ncauses build error `fatal error: \u0027capstone/capstone.h\u0027 file not found`\nit\u0027s ok to change to \u003ccapstone.h\u003e for all platforms.\n\nSigned-off-by: fatalc \u003ccnfatal@gmail.com\u003e\nChange-Id: Ia2e2058024d4fc1a57a8b4ea847c664d74f67efb\nReviewed-on: https://review.openocd.org/c/openocd/+/6946\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"38e754b48593ce42509b49ebbefba46140d37b00":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2022-04-26 02:24:40.000000000","uploader":{"_account_id":1001979,"name":"cnfatal","email":"cnfatal@gmail.com","username":"cnfatal"},"ref":"refs/changes/46/6946/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/46/6946/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/46/6946/2 \u0026\u0026 git checkout -b change-6946 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/46/6946/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/46/6946/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/46/6946/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/46/6946/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/46/6946/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9de084e0067a86b8040f8ea2c3f46dff0b9e6a70","subject":"flash/nor/stm32f1x: add can_load_options flag for GD32F1x0, F3x0 and E23x"}],"author":{"name":"fatalc","email":"cnfatal@gmail.com","date":"2022-04-25 04:06:10.000000000","tz":480},"committer":{"name":"fatalc","email":"cnfatal@gmail.com","date":"2022-04-26 02:15:50.000000000","tz":480},"subject":"target/disassembler:  update capstone include path to \u003ccapstone.h\u003e","message":"target/disassembler:  update capstone include path to \u003ccapstone.h\u003e\n\non macos (homebrew base) `pkg-config --cflags capstone` output with\n`-I/opt/homebrew/Cellar/capstone/4.0.2/include/capstone`\ngcc not find headers on parent \"include\" path,\ncauses build error `fatal error: \u0027capstone/capstone.h\u0027 file not found`\nit\u0027s ok to change to \u003ccapstone.h\u003e for all platforms.\n\nSigned-off-by: fatalc \u003ccnfatal@gmail.com\u003e\nChange-Id: Ia2e2058024d4fc1a57a8b4ea847c664d74f67efb\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}