)]}'
{"id":"openocd~master~I446dc03cb91524c6d388db485bc2388177af77b6","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1001013":{"account":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"last_update":"2022-05-14 08:57:36.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I446dc03cb91524c6d388db485bc2388177af77b6","subject":"aarch64: don\u0027t wait for smp targets halted in deassert reset","status":"MERGED","created":"2022-04-25 20:39:09.000000000","updated":"2022-05-14 08:57:36.000000000","submitted":"2022-05-14 08:57:36.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6947","meta_rev_id":"c48e13a911176c25742e4b914bab425bb9eb4779","_number":6947,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-05-14 08:57:36.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-05-14 08:57:36.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"}],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-04-25 20:39:09.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"state":"REVIEWER"},{"updated":"2022-04-25 20:56:59.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"b56c5f726cae73605ff303890937591c374bf082","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-04-25 20:39:09.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1cbcbbc7ad399d6a9fcee4476f86a6523269ad1e","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-04-25 20:56:59.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/16065/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/15275/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"6a73326cd7ef936d222e13dd1d471d3552713136","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-04-25 21:04:15.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"39807b9e40190e17d46946428ff793835d609f88","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-05-14 08:57:33.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"c48e13a911176c25742e4b914bab425bb9eb4779","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-05-14 08:57:36.000000000","message":"Change has been successfully cherry-picked as 99293ebd15bd2980fa4cb9e161f0069092741a55","accounts_in_message":[],"_revision_number":2}],"current_revision":"99293ebd15bd2980fa4cb9e161f0069092741a55","revisions":{"99293ebd15bd2980fa4cb9e161f0069092741a55":{"kind":"REWORK","_number":2,"created":"2022-05-14 08:57:36.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/47/6947/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/47/6947/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/47/6947/2 \u0026\u0026 git checkout -b change-6947 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/47/6947/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/47/6947/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/47/6947/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/47/6947/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/47/6947/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a47d1f1b795e037fafd16667d0056364159c7623","subject":"arm_adi_v5: add support for 64bit Class 0x9 ROM tables"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-04-25 20:25:08.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-05-14 08:57:36.000000000","tz":0},"subject":"aarch64: don\u0027t wait for smp targets halted in deassert reset","message":"aarch64: don\u0027t wait for smp targets halted in deassert reset\n\nThe function target_type::deassert_reset() is called for every\ntarget after reset is deasserted. If the target fails to get\nhalted, we log a warning and issue a halt request for the target\nitself.\n\nCurrent code calls the generic target_halt() that:\n- extends the halt to all the targets in the SMP node;\n- waits for targets to halt.\nThis breaks the logic of running target_type::deassert_reset()\nper target. Plus, waiting for targets to halt delays the call of\ntarget_type::deassert_reset() for the next targets.\n\nReplace the call to target_halt() with the aarch64 specific\nfunction to halt the single target. Pass the parameter HALT_LAZY\nto prevent the wait for target halted.\nSimilar solution is already implemented for cortex_a.\n\nChange-Id: I446dc03cb91524c6d388db485bc2388177af77b6\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6947\nTested-by: jenkins\n"}},"fd18c96c2ca012d62734703cec8bd759178e7631":{"kind":"REWORK","_number":1,"created":"2022-04-25 20:39:09.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/47/6947/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/47/6947/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/47/6947/1 \u0026\u0026 git checkout -b change-6947 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/47/6947/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/47/6947/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/47/6947/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/47/6947/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/47/6947/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9de084e0067a86b8040f8ea2c3f46dff0b9e6a70","subject":"flash/nor/stm32f1x: add can_load_options flag for GD32F1x0, F3x0 and E23x"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-04-25 20:25:08.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-04-25 20:37:38.000000000","tz":120},"subject":"aarch64: don\u0027t wait for smp targets halted in deassert reset","message":"aarch64: don\u0027t wait for smp targets halted in deassert reset\n\nThe function target_type::deassert_reset() is called for every\ntarget after reset is deasserted. If the target fails to get\nhalted, we log a warning and issue a halt request for the target\nitself.\n\nCurrent code calls the generic target_halt() that:\n- extends the halt to all the targets in the SMP node;\n- waits for targets to halt.\nThis breaks the logic of running target_type::deassert_reset()\nper target. Plus, waiting for targets to halt delays the call of\ntarget_type::deassert_reset() for the next targets.\n\nReplace the call to target_halt() with the aarch64 specific\nfunction to halt the single target. Pass the parameter HALT_LAZY\nto prevent the wait for target halted.\nSimilar solution is already implemented for cortex_a.\n\nChange-Id: I446dc03cb91524c6d388db485bc2388177af77b6\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}