)]}'
{"id":"openocd~master~I6fc78303b6a4db064a97f326c46119f4568e88f3","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1001651":{"account":{"_account_id":1001651,"name":"Florian Fainelli","email":"f.fainelli@gmail.com","username":"ffainelli"},"last_update":"2022-05-07 11:04:18.000000000","reason":"Change was submitted"},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2022-04-27 13:10:59.000000000","reason":"Antonio Borneo replied on the change"}},"hashtags":[],"change_id":"I6fc78303b6a4db064a97f326c46119f4568e88f3","subject":"target: fix build with jimtcl 0.79","status":"MERGED","created":"2022-04-26 06:33:44.000000000","updated":"2022-05-07 11:04:18.000000000","submitted":"2022-05-07 11:04:18.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":2,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"6948","meta_rev_id":"9e4718ce190b7d4c4e6a1078415b74264283f206","_number":6948,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-05-07 11:04:18.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-05-07 11:04:18.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":1001651,"name":"Florian Fainelli","email":"f.fainelli@gmail.com","username":"ffainelli"}],"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-04-26 06:53:41.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-04-26 22:22:16.000000000","updated_by":{"_account_id":1001651,"name":"Florian Fainelli","email":"f.fainelli@gmail.com","username":"ffainelli"},"reviewer":{"_account_id":1001651,"name":"Florian Fainelli","email":"f.fainelli@gmail.com","username":"ffainelli"},"state":"CC"}],"messages":[{"id":"31ef7f6d988b726930feddc8b78bc5965d3118e0","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-04-26 06:33:44.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"0d106158ad9f5820f1c386cafa4faeb35b6a31bc","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-04-26 06:53:41.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/16067/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/15277/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"8db53edfa6c930a209574b3f02abfa84f943f632","author":{"_account_id":1001651,"name":"Florian Fainelli","email":"f.fainelli@gmail.com","username":"ffainelli"},"real_author":{"_account_id":1001651,"name":"Florian Fainelli","email":"f.fainelli@gmail.com","username":"ffainelli"},"date":"2022-04-26 22:22:16.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"9647c019be7c182b2fefe28f9ae4fdc9ecd0e903","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-04-27 13:10:59.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"6a0fea74f68fbb24f32eb4edbc32c662571557ea","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-05-07 11:04:09.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"9e4718ce190b7d4c4e6a1078415b74264283f206","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-05-07 11:04:18.000000000","message":"Change has been successfully cherry-picked as 7819834ace37ca7f5d1b834c761dfcb9964ef845","accounts_in_message":[],"_revision_number":2}],"current_revision":"7819834ace37ca7f5d1b834c761dfcb9964ef845","revisions":{"7819834ace37ca7f5d1b834c761dfcb9964ef845":{"kind":"REWORK","_number":2,"created":"2022-05-07 11:04:18.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/48/6948/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/48/6948/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/48/6948/2 \u0026\u0026 git checkout -b change-6948 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/48/6948/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/48/6948/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/48/6948/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/48/6948/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/48/6948/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ad5ca263e931792483cdb2a820b7aba3980829eb","subject":"bluenrg: add support for bluenrg-lps device and board"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-04-25 21:04:49.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-05-07 11:04:18.000000000","tz":0},"subject":"target: fix build with jimtcl 0.79","message":"target: fix build with jimtcl 0.79\n\nIn jimtcl 0.80 the prototype of Jim_DictPairs() has changed.\nThe only code in OpenOCD that uses Jim_DictPairs() has been merged\nrecently and it only uses the current jimtcl syntax.\n\nTo allow compiling OpenOCD master branch with older versions of\njimtcl, detect the version of jimtcl and use the appropriate\nsyntax.\n\nChange-Id: I6fc78303b6a4db064a97f326c46119f4568e88f3\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReported-by: dullfire@yahoo.com\nReviewed-on: https://review.openocd.org/c/openocd/+/6948\nTested-by: jenkins\n"}},"e0c91037b7daf8289db68de6efba445032520a98":{"kind":"REWORK","_number":1,"created":"2022-04-26 06:33:44.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/48/6948/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/48/6948/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/48/6948/1 \u0026\u0026 git checkout -b change-6948 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/48/6948/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/48/6948/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/48/6948/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/48/6948/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/48/6948/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9de084e0067a86b8040f8ea2c3f46dff0b9e6a70","subject":"flash/nor/stm32f1x: add can_load_options flag for GD32F1x0, F3x0 and E23x"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-04-25 21:04:49.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-04-26 06:32:01.000000000","tz":120},"subject":"target: fix build with jimtcl 0.79","message":"target: fix build with jimtcl 0.79\n\nIn jimtcl 0.80 the prototype of Jim_DictPairs() has changed.\nThe only code in OpenOCD that uses Jim_DictPairs() has been merged\nrecently and it only uses the current jimtcl syntax.\n\nTo allow compiling OpenOCD master branch with older versions of\njimtcl, detect the version of jimtcl and use the appropriate\nsyntax.\n\nChange-Id: I6fc78303b6a4db064a97f326c46119f4568e88f3\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReported-by: dullfire@yahoo.com\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}