)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"change_message_id":"339501985ab133098e778ba4736af9b871affb04","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3a25e263_cd731b09","updated":"2023-12-18 14:16:32.000000000","message":"Henrik, I really don\u0027t understand how I missed this.\nI might be very tired when writing this, but no excuse.\n\nThanks for spotting the code issue.\nI will be re-writing the patch ASAP.","commit_id":"f322422b4c0a15659bd764c4dbb9b35674d0a222"},{"author":{"_account_id":1002216,"name":"Henrik Nordström","email":"henrik.nordstrom@wires.se","username":"hno-addiva"},"change_message_id":"cb6bba96946031a69905f8e000d9b836650b422c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"aa3f741f_f98a5f41","updated":"2023-12-17 23:04:11.000000000","message":"The fields in NVFR0 \u0026 NVFR1 are value fields, not boolean bits. Mask and match whole fields.","commit_id":"f322422b4c0a15659bd764c4dbb9b35674d0a222"}],"src/target/cortex_m.c":[{"author":{"_account_id":1002216,"name":"Henrik Nordström","email":"henrik.nordstrom@wires.se","username":"hno-addiva"},"change_message_id":"cb6bba96946031a69905f8e000d9b836650b422c","unresolved":true,"context_lines":[{"line_number":2585,"context_line":"\t\t\ttarget_read_u32(target, MVFR0, \u0026mvfr0);"},{"line_number":2586,"context_line":"\t\t\ttarget_read_u32(target, MVFR1, \u0026mvfr1);"},{"line_number":2587,"context_line":""},{"line_number":2588,"context_line":"\t\t\tif ((mvfr0 \u0026 MVFR0_SP) \u003d\u003d MVFR0_SP) {"},{"line_number":2589,"context_line":"\t\t\t\tLOG_TARGET_DEBUG(target, \"%s floating point feature FPv4_SP found\","},{"line_number":2590,"context_line":"\t\t\t\t\t\tcortex_m-\u003ecore_info-\u003ename);"},{"line_number":2591,"context_line":"\t\t\t\tarmv7m-\u003efp_feature \u003d FPV4_SP;"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"b9c46cc4_453e6cfb","line":2588,"updated":"2023-12-17 23:04:11.000000000","message":"This should be checking the whole Single Precision field of MVFR0, not just a single bit of it. There is no telling what future field values may mean.\n\nFrom the ARM-M:\n\nFPSP, bits [7:4]\nFloating-point single-precision. Indicates support for Floating-point single-precision operations.\nThe possible values of this field are:\n0b0000 Not supported.\n0b0010 Supported.\nAll other values are reserved.","commit_id":"f322422b4c0a15659bd764c4dbb9b35674d0a222"},{"author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"change_message_id":"be6dc0c4ddccaa8bdfe26f577912eed918ed048c","unresolved":false,"context_lines":[{"line_number":2585,"context_line":"\t\t\ttarget_read_u32(target, MVFR0, \u0026mvfr0);"},{"line_number":2586,"context_line":"\t\t\ttarget_read_u32(target, MVFR1, \u0026mvfr1);"},{"line_number":2587,"context_line":""},{"line_number":2588,"context_line":"\t\t\tif ((mvfr0 \u0026 MVFR0_SP) \u003d\u003d MVFR0_SP) {"},{"line_number":2589,"context_line":"\t\t\t\tLOG_TARGET_DEBUG(target, \"%s floating point feature FPv4_SP found\","},{"line_number":2590,"context_line":"\t\t\t\t\t\tcortex_m-\u003ecore_info-\u003ename);"},{"line_number":2591,"context_line":"\t\t\t\tarmv7m-\u003efp_feature \u003d FPV4_SP;"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"8496e1c7_c560348b","line":2588,"in_reply_to":"b9c46cc4_453e6cfb","updated":"2023-12-18 14:51:37.000000000","message":"Ack","commit_id":"f322422b4c0a15659bd764c4dbb9b35674d0a222"},{"author":{"_account_id":1002216,"name":"Henrik Nordström","email":"henrik.nordstrom@wires.se","username":"hno-addiva"},"change_message_id":"cb6bba96946031a69905f8e000d9b836650b422c","unresolved":true,"context_lines":[{"line_number":2594,"context_line":"\t\t\ttarget_read_u32(target, MVFR0, \u0026mvfr0);"},{"line_number":2595,"context_line":"\t\t\ttarget_read_u32(target, MVFR1, \u0026mvfr1);"},{"line_number":2596,"context_line":""},{"line_number":2597,"context_line":"\t\t\tif ((mvfr0 \u0026 MVFR0_DP) \u003d\u003d MVFR0_DP) {"},{"line_number":2598,"context_line":"\t\t\t\tif ((mvfr1 \u0026 MVFR1_MVE_F) \u003d\u003d MVFR1_MVE_F) {"},{"line_number":2599,"context_line":"\t\t\t\t\tLOG_TARGET_DEBUG(target, \"%s floating point feature FPv5_DP + MVE-F found\","},{"line_number":2600,"context_line":"\t\t\t\t\t\t\tcortex_m-\u003ecore_info-\u003ename);"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"a140217d_3f78df1a","line":2597,"updated":"2023-12-17 23:04:11.000000000","message":"This should be checking the whole Double Precision field of MVFR0, not just a single bit of it. There is no telling what future field values may mean.\n\nFrom the ARM-M:\n\nFPDP, bits [11:8]\nFloating-point double-precision. Indicates support for Floating-point double-precision operations.\nThe possible values of this field are:\n0b0000 Not supported.\n0b0010 Supported.\nAll other values are reserved.","commit_id":"f322422b4c0a15659bd764c4dbb9b35674d0a222"},{"author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"change_message_id":"be6dc0c4ddccaa8bdfe26f577912eed918ed048c","unresolved":false,"context_lines":[{"line_number":2594,"context_line":"\t\t\ttarget_read_u32(target, MVFR0, \u0026mvfr0);"},{"line_number":2595,"context_line":"\t\t\ttarget_read_u32(target, MVFR1, \u0026mvfr1);"},{"line_number":2596,"context_line":""},{"line_number":2597,"context_line":"\t\t\tif ((mvfr0 \u0026 MVFR0_DP) \u003d\u003d MVFR0_DP) {"},{"line_number":2598,"context_line":"\t\t\t\tif ((mvfr1 \u0026 MVFR1_MVE_F) \u003d\u003d MVFR1_MVE_F) {"},{"line_number":2599,"context_line":"\t\t\t\t\tLOG_TARGET_DEBUG(target, \"%s floating point feature FPv5_DP + MVE-F found\","},{"line_number":2600,"context_line":"\t\t\t\t\t\t\tcortex_m-\u003ecore_info-\u003ename);"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"295ccc01_811ba213","line":2597,"in_reply_to":"a140217d_3f78df1a","updated":"2023-12-18 14:51:37.000000000","message":"Ack","commit_id":"f322422b4c0a15659bd764c4dbb9b35674d0a222"},{"author":{"_account_id":1002216,"name":"Henrik Nordström","email":"henrik.nordstrom@wires.se","username":"hno-addiva"},"change_message_id":"cb6bba96946031a69905f8e000d9b836650b422c","unresolved":true,"context_lines":[{"line_number":2595,"context_line":"\t\t\ttarget_read_u32(target, MVFR1, \u0026mvfr1);"},{"line_number":2596,"context_line":""},{"line_number":2597,"context_line":"\t\t\tif ((mvfr0 \u0026 MVFR0_DP) \u003d\u003d MVFR0_DP) {"},{"line_number":2598,"context_line":"\t\t\t\tif ((mvfr1 \u0026 MVFR1_MVE_F) \u003d\u003d MVFR1_MVE_F) {"},{"line_number":2599,"context_line":"\t\t\t\t\tLOG_TARGET_DEBUG(target, \"%s floating point feature FPv5_DP + MVE-F found\","},{"line_number":2600,"context_line":"\t\t\t\t\t\t\tcortex_m-\u003ecore_info-\u003ename);"},{"line_number":2601,"context_line":"\t\t\t\t\tarmv7m-\u003efp_feature \u003d FPV5_MVE_F;"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"411bc6fa_c131664f","line":2598,"updated":"2023-12-17 23:04:11.000000000","message":"This should be checking the whole MVE field of MVFR1, not just a single bit of it. There is no telling what future field values may mean.\n\nFrom the ARM-M:\n\nMVE, bits [11:8]\nIndicates support for M-profile vector extension.\nThe possible values of this field are:\n0b0000 Not supported.\n0b0001 Supported, no Floating-point.\n0b0010 Supported, with single-precision and half-precision Floating-point.\nAll other values are reserved.","commit_id":"f322422b4c0a15659bd764c4dbb9b35674d0a222"},{"author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"change_message_id":"be6dc0c4ddccaa8bdfe26f577912eed918ed048c","unresolved":false,"context_lines":[{"line_number":2595,"context_line":"\t\t\ttarget_read_u32(target, MVFR1, \u0026mvfr1);"},{"line_number":2596,"context_line":""},{"line_number":2597,"context_line":"\t\t\tif ((mvfr0 \u0026 MVFR0_DP) \u003d\u003d MVFR0_DP) {"},{"line_number":2598,"context_line":"\t\t\t\tif ((mvfr1 \u0026 MVFR1_MVE_F) \u003d\u003d MVFR1_MVE_F) {"},{"line_number":2599,"context_line":"\t\t\t\t\tLOG_TARGET_DEBUG(target, \"%s floating point feature FPv5_DP + MVE-F found\","},{"line_number":2600,"context_line":"\t\t\t\t\t\t\tcortex_m-\u003ecore_info-\u003ename);"},{"line_number":2601,"context_line":"\t\t\t\t\tarmv7m-\u003efp_feature \u003d FPV5_MVE_F;"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"a79c2dd1_3414e1d3","line":2598,"in_reply_to":"411bc6fa_c131664f","updated":"2023-12-18 14:51:37.000000000","message":"Ack","commit_id":"f322422b4c0a15659bd764c4dbb9b35674d0a222"}]}