)]}'
{"id":"openocd~master~I7482990755b300fcbe4963c9a599d599bc02684d","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000853":{"account":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"last_update":"2022-04-30 06:53:48.000000000","reason":"Reviewer/Cc was removed"},"1001242":{"account":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"last_update":"2022-05-12 17:35:01.000000000","reason":"Tim Newsome replied on the change"},"1001983":{"account":{"_account_id":1001983,"name":"Tom Hebb","email":"tommyhebb@gmail.com","username":"tchebb"},"last_update":"2023-11-30 14:32:09.000000000","reason":"Change was submitted"},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2023-11-17 06:22:38.000000000","reason":"\u003cGERRIT_ACCOUNT_1000687\u003e replied on the change","reason_account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}},"hashtags":[],"change_id":"I7482990755b300fcbe4963c9a599d599bc02684d","subject":"tcl/target/gd32vf103: work around broken ndmreset","status":"MERGED","created":"2022-04-30 06:37:21.000000000","updated":"2025-10-29 14:38:55.000000000","submitted":"2023-11-30 14:32:09.000000000","submitter":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"total_comment_count":17,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"6957","meta_rev_id":"48e91206e83f7f06eb57e03ab6d340e3ec2d3ad0","_number":6957,"owner":{"_account_id":1001983,"name":"Tom Hebb","email":"tommyhebb@gmail.com","username":"tchebb"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1001983,"name":"Tom Hebb","email":"tommyhebb@gmail.com","username":"tchebb"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-11-30 14:32:09.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-11-30 14:32:09.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-11-30 14:32:09.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":1,"date":"2025-10-28 03:27:41.000000000","post_submit":true,"permitted_voting_range":{"min":1,"max":1},"_account_id":1001983,"name":"Tom Hebb","email":"tommyhebb@gmail.com","username":"tchebb"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"_account_id":1001983,"name":"Tom Hebb","email":"tommyhebb@gmail.com","username":"tchebb"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-04-30 06:51:59.000000000","updated_by":{"_account_id":1001983,"name":"Tom Hebb","email":"tommyhebb@gmail.com","username":"tchebb"},"reviewer":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"state":"CC"},{"updated":"2022-04-30 06:51:59.000000000","updated_by":{"_account_id":1001983,"name":"Tom Hebb","email":"tommyhebb@gmail.com","username":"tchebb"},"reviewer":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"state":"REVIEWER"},{"updated":"2022-04-30 06:51:59.000000000","updated_by":{"_account_id":1001983,"name":"Tom Hebb","email":"tommyhebb@gmail.com","username":"tchebb"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"},{"updated":"2022-04-30 06:53:48.000000000","updated_by":{"_account_id":1001983,"name":"Tom Hebb","email":"tommyhebb@gmail.com","username":"tchebb"},"reviewer":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"state":"REMOVED"},{"updated":"2022-04-30 06:55:18.000000000","updated_by":{"_account_id":1001983,"name":"Tom Hebb","email":"tommyhebb@gmail.com","username":"tchebb"},"reviewer":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"state":"CC"},{"updated":"2022-04-30 06:55:19.000000000","updated_by":{"_account_id":1001983,"name":"Tom Hebb","email":"tommyhebb@gmail.com","username":"tchebb"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REMOVED"},{"updated":"2022-04-30 07:54:14.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-05-01 14:31:56.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"CC"},{"updated":"2022-05-12 17:35:07.000000000","updated_by":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"reviewer":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"state":"REMOVED"},{"updated":"2022-09-16 12:55:49.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"},{"updated":"2023-04-08 20:15:03.000000000","updated_by":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"reviewer":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"state":"REVIEWER"}],"messages":[{"id":"bf847867bbf83bc3882dfee0208c013b81ae46f9","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001983,"name":"Tom Hebb","email":"tommyhebb@gmail.com","username":"tchebb"},"real_author":{"_account_id":1001983,"name":"Tom Hebb","email":"tommyhebb@gmail.com","username":"tchebb"},"date":"2022-04-30 06:37:21.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"114314530f376ec19173205dac5a8c4b232a3166","author":{"_account_id":1001983,"name":"Tom Hebb","email":"tommyhebb@gmail.com","username":"tchebb"},"real_author":{"_account_id":1001983,"name":"Tom Hebb","email":"tommyhebb@gmail.com","username":"tchebb"},"date":"2022-04-30 06:53:21.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"ef56988054d8b1ae280e0b097cfb49b359859595","tag":"autogenerated:gerrit:deleteReviewer","author":{"_account_id":1001983,"name":"Tom Hebb","email":"tommyhebb@gmail.com","username":"tchebb"},"real_author":{"_account_id":1001983,"name":"Tom Hebb","email":"tommyhebb@gmail.com","username":"tchebb"},"date":"2022-04-30 06:53:48.000000000","message":"Removed reviewer zapb.","accounts_in_message":[],"_revision_number":1},{"id":"df41b9a936d46927024f52c1b10506de93fb6e86","tag":"autogenerated:gerrit:deleteReviewer","author":{"_account_id":1001983,"name":"Tom Hebb","email":"tommyhebb@gmail.com","username":"tchebb"},"real_author":{"_account_id":1001983,"name":"Tom Hebb","email":"tommyhebb@gmail.com","username":"tchebb"},"date":"2022-04-30 06:55:19.000000000","message":"Removed reviewer Tomas Vanek.","accounts_in_message":[],"_revision_number":1},{"id":"b114c8930672c4e378739e3dc61215148b25beb4","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-04-30 07:54:14.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/16085/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/15295/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"d2f03617f88b92f99540741a4ee2f10b793972fb","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-05-01 14:31:56.000000000","message":"Patch Set 1:\n\n(3 comments)","accounts_in_message":[],"_revision_number":1},{"id":"a157278f25e45bdedb9eb03a2b87a4bd0353366d","author":{"_account_id":1001983,"name":"Tom Hebb","email":"tommyhebb@gmail.com","username":"tchebb"},"real_author":{"_account_id":1001983,"name":"Tom Hebb","email":"tommyhebb@gmail.com","username":"tchebb"},"date":"2022-05-03 02:03:49.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"fb4626ad2ca6df55831a38509671c383aac362d5","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-05-03 08:51:45.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"316fa244b7159107f459d400b87630f5cc33ac2a","author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"real_author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"date":"2022-05-12 17:35:01.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"e9833f78a4446ad2f6e6022a34417ba6a673d750","tag":"autogenerated:gerrit:deleteReviewer","author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"real_author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"date":"2022-05-12 17:35:07.000000000","message":"Removed cc Tim Newsome.","accounts_in_message":[],"_revision_number":1},{"id":"ff3b45f3160ec35bed504ab28126d3a9813f7b2c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-09-16 12:55:49.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"0e3f852909695e166e71f8fd2963cec06ff1276a","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-09-16 13:12:42.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"e80be652cdb2ee667ab048dbb9282223370d3549","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-09-16 13:31:30.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/15945/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/16736/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"5c20829b25299b47f26c36493c4ff4dd7913693e","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-02-04 07:51:03.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"f900d519c0ea37693048d04cfdad38595a68ac82","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-03-31 06:14:24.000000000","message":"Patch Set 2: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"0791302412948da471e81ca9db2ee127668edf19","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2023-04-02 08:39:58.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"f3ac9c3c84affed1ceb58af81f6b34fb9007bfc2","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-04-02 09:26:44.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"70fcfcabbddb5e8ee0122f77da6d10793f45e8ca","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2023-04-08 20:15:03.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"b1a597803a7cfd5cb93e3387269686f49342a4ca","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-11-17 06:22:38.000000000","message":"Patch Set 2: Code-Review+2\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"b1805af3b14d8fe6ac4b2d606bee36f8a9c1f742","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-11-30 14:32:09.000000000","message":"Change has been successfully cherry-picked as 7ac389cf47463cc35667659804d939015a4815e5","accounts_in_message":[],"_revision_number":3},{"id":"5a33bfb8e51085f97539d3a24f3eec3cb82a9ac8","author":{"_account_id":1001983,"name":"Tom Hebb","email":"tommyhebb@gmail.com","username":"tchebb"},"real_author":{"_account_id":1001983,"name":"Tom Hebb","email":"tommyhebb@gmail.com","username":"tchebb"},"date":"2025-10-28 03:27:41.000000000","message":"Patch Set 3: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"48e91206e83f7f06eb57e03ab6d340e3ec2d3ad0","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-10-29 14:38:55.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3}],"current_revision":"7ac389cf47463cc35667659804d939015a4815e5","revisions":{"89eb05a0807be92b78b573356b50051cbcd5ae2d":{"kind":"REWORK","_number":1,"created":"2022-04-30 06:37:21.000000000","uploader":{"_account_id":1001983,"name":"Tom Hebb","email":"tommyhebb@gmail.com","username":"tchebb"},"ref":"refs/changes/57/6957/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/57/6957/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/57/6957/1 \u0026\u0026 git checkout -b change-6957 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/57/6957/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/57/6957/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/57/6957/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/57/6957/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/57/6957/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9de084e0067a86b8040f8ea2c3f46dff0b9e6a70","subject":"flash/nor/stm32f1x: add can_load_options flag for GD32F1x0, F3x0 and E23x"}],"author":{"name":"Thomas Hebb","email":"tommyhebb@gmail.com","date":"2022-04-30 05:17:18.000000000","tz":-420},"committer":{"name":"Thomas Hebb","email":"tommyhebb@gmail.com","date":"2022-04-30 05:21:27.000000000","tz":-420},"subject":"tcl/target/gd32vf103: work around broken ndmreset","message":"tcl/target/gd32vf103: work around broken ndmreset\n\nOn this chip, the ndmreset bit in the RISC-V debug module doesn\u0027t\ntrigger a system reset like it should. To work around this, add a custom\n\"reset-assert\" handler in its config file that resets the system by\nwriting to memory-mapped registers.\n\nI\u0027ve tested this workaround on a Sipeed Longan Nano dev board with a\nGD32VF103CBT6 chip. It works correctly for both \"reset run\" and \"reset\nhalt\" (halting at pc\u003d0 for the latter).\n\nI originally submitted[1] this workaround to the riscv-openocd fork of\nOpenOCD. That fork\u0027s maintainers accepted it, but have not upstreamed it\nlike they have several other of my changes.\n\n[1] https://github.com/riscv/riscv-openocd/pull/538\n\nChange-Id: I7482990755b300fcbe4963c9a599d599bc02684d\nSigned-off-by: Thomas Hebb \u003ctommyhebb@gmail.com\u003e\n"}},"9f0ff9c8f01ad086b1d9f1fd4fca09c016c409ba":{"kind":"REWORK","_number":2,"created":"2022-09-16 12:55:49.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/57/6957/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/57/6957/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/57/6957/2 \u0026\u0026 git checkout -b change-6957 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/57/6957/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/57/6957/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/57/6957/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/57/6957/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/57/6957/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"219cb9598a6221ed24967f205a144a223add039a","subject":"FreeRTOS: Fix thread reg list for Cortex-M7"}],"author":{"name":"Thomas Hebb","email":"tommyhebb@gmail.com","date":"2022-04-30 05:17:18.000000000","tz":-420},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-09-16 12:55:29.000000000","tz":120},"subject":"tcl/target/gd32vf103: work around broken ndmreset","message":"tcl/target/gd32vf103: work around broken ndmreset\n\nOn this chip, the ndmreset bit in the RISC-V debug module doesn\u0027t\ntrigger a system reset like it should. To work around this, add a custom\n\"reset-assert\" handler in its config file that resets the system by\nwriting to memory-mapped registers.\n\nI\u0027ve tested this workaround on a Sipeed Longan Nano dev board with a\nGD32VF103CBT6 chip. It works correctly for both \"reset run\" and \"reset\nhalt\" (halting at pc\u003d0 for the latter).\n\nI originally submitted[1] this workaround to the riscv-openocd fork of\nOpenOCD. That fork\u0027s maintainers accepted it, but have not upstreamed it\nlike they have several other of my changes.\n\n[1] https://github.com/riscv/riscv-openocd/pull/538\n\nChange-Id: I7482990755b300fcbe4963c9a599d599bc02684d\nSigned-off-by: Thomas Hebb \u003ctommyhebb@gmail.com\u003e\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"7ac389cf47463cc35667659804d939015a4815e5":{"kind":"REWORK","_number":3,"created":"2023-11-30 14:32:09.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/57/6957/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/57/6957/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/57/6957/3 \u0026\u0026 git checkout -b change-6957 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/57/6957/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/57/6957/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/57/6957/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/57/6957/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/57/6957/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1b0b07baab2b23318ddc484a58d66214f0c2a0d2","subject":"target: Throw error in \u0027debug_reason\u0027 command"}],"author":{"name":"Thomas Hebb","email":"tommyhebb@gmail.com","date":"2022-04-30 05:17:18.000000000","tz":-420},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2023-11-30 14:32:09.000000000","tz":0},"subject":"tcl/target/gd32vf103: work around broken ndmreset","message":"tcl/target/gd32vf103: work around broken ndmreset\n\nOn this chip, the ndmreset bit in the RISC-V debug module doesn\u0027t\ntrigger a system reset like it should. To work around this, add a custom\n\"reset-assert\" handler in its config file that resets the system by\nwriting to memory-mapped registers.\n\nI\u0027ve tested this workaround on a Sipeed Longan Nano dev board with a\nGD32VF103CBT6 chip. It works correctly for both \"reset run\" and \"reset\nhalt\" (halting at pc\u003d0 for the latter).\n\nI originally submitted[1] this workaround to the riscv-openocd fork of\nOpenOCD. That fork\u0027s maintainers accepted it, but have not upstreamed it\nlike they have several other of my changes.\n\n[1] https://github.com/riscv/riscv-openocd/pull/538\n\nChange-Id: I7482990755b300fcbe4963c9a599d599bc02684d\nSigned-off-by: Thomas Hebb \u003ctommyhebb@gmail.com\u003e\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6957\nTested-by: jenkins\nReviewed-by: zapb \u003cdev@zapb.de\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}