)]}'
{"id":"openocd~master~I9eb8462d354f096eee231c0e5e2bffa538a5903e","project":"openocd","branch":"master","attention_set":{"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2025-10-30 16:17:51.000000000","reason":"\u003cGERRIT_ACCOUNT_1001983\u003e replied on the change","reason_account":{"_account_id":1001983,"name":"Tom Hebb","email":"tommyhebb@gmail.com","username":"tchebb"}}},"removed_from_attention_set":{"1001983":{"account":{"_account_id":1001983,"name":"Tom Hebb","email":"tommyhebb@gmail.com","username":"tchebb"},"last_update":"2025-10-30 16:17:51.000000000","reason":"\u003cGERRIT_ACCOUNT_1001983\u003e replied on the change","reason_account":{"_account_id":1001983,"name":"Tom Hebb","email":"tommyhebb@gmail.com","username":"tchebb"}}},"hashtags":[],"change_id":"I9eb8462d354f096eee231c0e5e2bffa538a5903e","subject":"tcl/target/gd32vf103: add main flash alias","status":"NEW","created":"2022-04-30 06:37:21.000000000","updated":"2025-12-11 17:30:35.000000000","submit_type":"CHERRY_PICK","mergeable":false,"submittable":false,"total_comment_count":7,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"435b0cfbd46c4c4966af2eb047360d4e25d59d52","_number":6958,"owner":{"_account_id":1001983,"name":"Tom Hebb","email":"tommyhebb@gmail.com","username":"tchebb"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:jenkins-gerrit-trigger","value":1,"date":"2025-12-11 17:30:35.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"}],"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-04-30 07:00:12.000000000","updated_by":{"_account_id":1001983,"name":"Tom Hebb","email":"tommyhebb@gmail.com","username":"tchebb"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"CC"},{"updated":"2022-04-30 07:00:12.000000000","updated_by":{"_account_id":1001983,"name":"Tom Hebb","email":"tommyhebb@gmail.com","username":"tchebb"},"reviewer":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"state":"CC"},{"updated":"2022-04-30 07:00:12.000000000","updated_by":{"_account_id":1001983,"name":"Tom Hebb","email":"tommyhebb@gmail.com","username":"tchebb"},"reviewer":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"state":"CC"},{"updated":"2022-04-30 07:26:55.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"afed0f6c72c9d2a5fe7ae252630aa2b265566910","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001983,"name":"Tom Hebb","email":"tommyhebb@gmail.com","username":"tchebb"},"real_author":{"_account_id":1001983,"name":"Tom Hebb","email":"tommyhebb@gmail.com","username":"tchebb"},"date":"2022-04-30 06:37:21.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a3b6b6e349ac3926a8228d19fcbd88a3182f0671","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-04-30 07:26:55.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/16083/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/15294/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"8f905b6e7b56a234b6957e1a161551aa18741c79","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-05-01 14:43:23.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"fb9acd0cec5b4b7994c9c87891632f0091a3508b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001983,"name":"Tom Hebb","email":"tommyhebb@gmail.com","username":"tchebb"},"real_author":{"_account_id":1001983,"name":"Tom Hebb","email":"tommyhebb@gmail.com","username":"tchebb"},"date":"2025-10-28 02:41:29.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"9d78c978c4731f3e90929f6f6ad8268675f814c2","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-10-28 02:56:39.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/22125/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/21246/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"647e308f259824372c039662f42d6b03cc1b2cfd","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-10-28 10:50:00.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"b1d55a632124ee5eeefd186ac2e3fa55e1cea1a7","author":{"_account_id":1001983,"name":"Tom Hebb","email":"tommyhebb@gmail.com","username":"tchebb"},"real_author":{"_account_id":1001983,"name":"Tom Hebb","email":"tommyhebb@gmail.com","username":"tchebb"},"date":"2025-10-28 14:04:34.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"a28166284175e378fe32008f7468cc12493a8d34","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-10-29 06:58:58.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"9998ceba4bda8ebf467aeebb2a92ba042c9add62","author":{"_account_id":1001983,"name":"Tom Hebb","email":"tommyhebb@gmail.com","username":"tchebb"},"real_author":{"_account_id":1001983,"name":"Tom Hebb","email":"tommyhebb@gmail.com","username":"tchebb"},"date":"2025-10-30 15:26:51.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"58456f3e5f1ef7364f2fd706c9bb2921a673d75f","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-10-30 16:09:54.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"3a0bdb77361c8b2f556bdbb5a1f73a572498d4d8","author":{"_account_id":1001983,"name":"Tom Hebb","email":"tommyhebb@gmail.com","username":"tchebb"},"real_author":{"_account_id":1001983,"name":"Tom Hebb","email":"tommyhebb@gmail.com","username":"tchebb"},"date":"2025-10-30 16:17:51.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"4de3199dc2c130e77503bc5c785b3714bd18deef","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001983,"name":"Tom Hebb","email":"tommyhebb@gmail.com","username":"tchebb"},"real_author":{"_account_id":1001983,"name":"Tom Hebb","email":"tommyhebb@gmail.com","username":"tchebb"},"date":"2025-12-11 17:03:06.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"435b0cfbd46c4c4966af2eb047360d4e25d59d52","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-12-11 17:30:35.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/21550/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/22437/ : SUCCESS","accounts_in_message":[],"_revision_number":3}],"current_revision":"fe084dca815cc40561226ccf3c4657eebac19508","revisions":{"0ef135de01bf814df4e486d3fb47ece2ac644d53":{"kind":"REWORK","_number":1,"created":"2022-04-30 06:37:21.000000000","uploader":{"_account_id":1001983,"name":"Tom Hebb","email":"tommyhebb@gmail.com","username":"tchebb"},"ref":"refs/changes/58/6958/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/58/6958/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/58/6958/1 \u0026\u0026 git checkout -b change-6958 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/58/6958/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/58/6958/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/58/6958/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/58/6958/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/58/6958/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"89eb05a0807be92b78b573356b50051cbcd5ae2d","subject":"tcl/target/gd32vf103: work around broken ndmreset"}],"author":{"name":"Thomas Hebb","email":"tommyhebb@gmail.com","date":"2020-09-27 23:45:11.000000000","tz":-420},"committer":{"name":"Thomas Hebb","email":"tommyhebb@gmail.com","date":"2022-04-30 05:23:07.000000000","tz":-420},"subject":"tcl/target/gd32vf103: add main flash alias","message":"tcl/target/gd32vf103: add main flash alias\n\nThe GD32VF103 creates an alias to either main flash or the bootloader at\n0x0, depending on how it was booted. As such, we want to indicate to\ndebuggers that the memory at 0x0 is flash and so cannot support software\nbreakpoints. To do this, add an alias to the main flash in the config.\nThis isn\u0027t strictly accurate in the case where we\u0027re running the\nbootloader, but it still suits our purpose of fixing breakpoint\nbehavior.\n\nI originally submitted[1] this change to the riscv-openocd fork of\nOpenOCD. That fork\u0027s maintainers accepted it, but have not upstreamed it\nlike they have several other of my changes.\n\nChange-Id: I9eb8462d354f096eee231c0e5e2bffa538a5903e\nSigned-off-by: Thomas Hebb \u003ctommyhebb@gmail.com\u003e\n"}},"045f7a245ddb624442eb78146aee9a064d3f44f6":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2025-10-28 02:41:29.000000000","uploader":{"_account_id":1001983,"name":"Tom Hebb","email":"tommyhebb@gmail.com","username":"tchebb"},"ref":"refs/changes/58/6958/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/58/6958/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/58/6958/2 \u0026\u0026 git checkout -b change-6958 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/58/6958/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/58/6958/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/58/6958/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/58/6958/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/58/6958/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"88b9bd396d5a1f83c49fa1b28745fd7feaca2b2e","subject":"target: cortex-m: fix support for armv8m caches"}],"author":{"name":"Thomas Hebb","email":"tommyhebb@gmail.com","date":"2020-09-27 23:45:11.000000000","tz":-420},"committer":{"name":"Thomas Hebb","email":"tommyhebb@gmail.com","date":"2025-10-28 02:32:32.000000000","tz":-240},"subject":"tcl/target/gd32vf103: add main flash alias","message":"tcl/target/gd32vf103: add main flash alias\n\nThe GD32VF103 creates an alias to either main flash or the bootloader at\n0x0, depending on how it was booted. As such, we want to indicate to\ndebuggers that the memory at 0x0 is flash and so cannot support software\nbreakpoints. To do this, add an alias to the main flash in the config.\nThis isn\u0027t strictly accurate in the case where we\u0027re running the\nbootloader, but it still suits our purpose of fixing breakpoint\nbehavior.\n\nI originally submitted[1] this change to the riscv-openocd fork of\nOpenOCD. That fork\u0027s maintainers accepted it, but have not upstreamed it\nlike they have several other of my changes.\n\nChange-Id: I9eb8462d354f096eee231c0e5e2bffa538a5903e\nSigned-off-by: Thomas Hebb \u003ctommyhebb@gmail.com\u003e\n"}},"fe084dca815cc40561226ccf3c4657eebac19508":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2025-12-11 17:03:06.000000000","uploader":{"_account_id":1001983,"name":"Tom Hebb","email":"tommyhebb@gmail.com","username":"tchebb"},"ref":"refs/changes/58/6958/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/58/6958/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/58/6958/3 \u0026\u0026 git checkout -b change-6958 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/58/6958/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/58/6958/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/58/6958/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/58/6958/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/58/6958/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"aa9ff8dc5ec60c46134f57a2f858149bb083036e","subject":"target/esirisc_trace: drop macro BIT_MASK() conflicting with bits.h"}],"author":{"name":"Thomas Hebb","email":"tommyhebb@gmail.com","date":"2020-09-27 23:45:11.000000000","tz":-420},"committer":{"name":"Thomas Hebb","email":"tommyhebb@gmail.com","date":"2025-12-11 16:47:22.000000000","tz":-300},"subject":"tcl/target/gd32vf103: add main flash alias","message":"tcl/target/gd32vf103: add main flash alias\n\nThe GD32VF103 creates an alias to either main flash or the bootloader at\n0x0, depending on how it was booted. As such, we want to indicate to\ndebuggers that the memory at 0x0 is flash and so cannot support software\nbreakpoints. To do this, add an alias to the main flash in the config.\nThis isn\u0027t strictly accurate in the case where we\u0027re running the\nbootloader, but it still suits our purpose of fixing breakpoint\nbehavior.\n\nI originally submitted[1] this change to the riscv-openocd fork of\nOpenOCD. That fork\u0027s maintainers accepted it, but have not upstreamed it\nlike they have several other of my changes.\n\nChange-Id: I9eb8462d354f096eee231c0e5e2bffa538a5903e\nSigned-off-by: Thomas Hebb \u003ctommyhebb@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"NOT_READY","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"NEED"}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"]}}]}