)]}'
{"id":"openocd~master~Iae0454b425e81e64774b9785bb5ba1d4564d940b","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1001242":{"account":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"last_update":"2022-05-02 16:18:37.000000000","reason":"Tim Newsome replied on the change"},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2022-05-18 09:03:41.000000000","reason":"Change was submitted"},"1001983":{"account":{"_account_id":1001983,"name":"Tom Hebb","email":"tommyhebb@gmail.com","username":"tchebb"},"last_update":"2022-05-18 09:03:41.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Iae0454b425e81e64774b9785bb5ba1d4564d940b","subject":"target/riscv: fix \u0027reset run\u0027 after \u0027reset halt\u0027","status":"MERGED","created":"2022-05-01 17:03:54.000000000","updated":"2022-05-18 09:03:41.000000000","submitted":"2022-05-18 09:03:41.000000000","submitter":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6961","meta_rev_id":"5a4ce2a48c089f6e0011ee8349484657e1ae87ad","_number":6961,"owner":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-05-18 09:03:41.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-05-18 09:03:41.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1001983,"name":"Tom Hebb","email":"tommyhebb@gmail.com","username":"tchebb"}],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},{"_account_id":1001983,"name":"Tom Hebb","email":"tommyhebb@gmail.com","username":"tchebb"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-05-01 17:21:42.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-05-01 17:24:11.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1001983,"name":"Tom Hebb","email":"tommyhebb@gmail.com","username":"tchebb"},"state":"REVIEWER"},{"updated":"2022-05-01 17:24:11.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"state":"REVIEWER"}],"messages":[{"id":"933c24d8950d66d456cba6519d02eda063794b57","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-05-01 17:03:54.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"054f3e1d1dcb81b1d33cad8c641214c147043c57","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-05-01 17:21:42.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/16090/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/15300/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"d1f0474bca69046b50898853efbeb4f09033d197","author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"real_author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"date":"2022-05-02 16:18:37.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"5a4ce2a48c089f6e0011ee8349484657e1ae87ad","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-05-18 09:03:41.000000000","message":"Change has been successfully cherry-picked as 7d2ea186cf212c64a8e5b10725e0a2512a137fbe","accounts_in_message":[],"_revision_number":2}],"current_revision":"7d2ea186cf212c64a8e5b10725e0a2512a137fbe","revisions":{"7d2ea186cf212c64a8e5b10725e0a2512a137fbe":{"kind":"REWORK","_number":2,"created":"2022-05-18 09:03:41.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/61/6961/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/61/6961/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/61/6961/2 \u0026\u0026 git checkout -b change-6961 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/61/6961/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/61/6961/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/61/6961/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/61/6961/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/61/6961/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4d1b29313ace5b26687f75fb132c04f91cc1edcb","subject":"doc: prevent writing \"topic:\" to commit message"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-05-01 13:20:24.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-05-18 09:03:41.000000000","tz":0},"subject":"target/riscv: fix \u0027reset run\u0027 after \u0027reset halt\u0027","message":"target/riscv: fix \u0027reset run\u0027 after \u0027reset halt\u0027\n\n\u0027reset halt\u0027 does not clear DM_DMCONTROL_HALTREQ at deassert_reset().\nIf hw reset line is configured e.g. \u0027reset_config srst_only\u0027\nthe folowing \u0027reset run\u0027 halts:\n\n \u003e gd32v.cpu curstate\n running\n\n \u003e reset halt\n JTAG tap: gd32v.cpu tap/device found: 0x1000563d (mfg: 0x31e ...\n \u003e gd32v.cpu curstate\n halted\n\n \u003e reset\n JTAG tap: gd32v.cpu tap/device found: 0x1000563d (mfg: 0x31e ...\n \u003e gd32v.cpu curstate\n halted \u003c\u003c\u003c\u003c---- wrong!!!\n\n \u003e reset\n JTAG tap: gd32v.cpu tap/device found: 0x1000563d (mfg: 0x31e ...\n \u003e gd32v.cpu curstate\n running\n\nClear DM_DMCONTROL_HALTREQ when acking reset.\n\nChange-Id: Iae0454b425e81e64774b9785bb5ba1d4564d940b\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6961\nTested-by: jenkins\nReviewed-by: Tim Newsome \u003ctim@sifive.com\u003e\n"}},"28abd15ad4ff17c3da9d5d100a73cefa92739938":{"kind":"REWORK","_number":1,"created":"2022-05-01 17:03:54.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/61/6961/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/61/6961/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/61/6961/1 \u0026\u0026 git checkout -b change-6961 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/61/6961/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/61/6961/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/61/6961/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/61/6961/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/61/6961/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"66335683fec62ac89da48d64932fd9d082314225","subject":"drivers/cmsis-dap: Correct the DAP protocol parameter parsing error"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-05-01 13:20:24.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-05-01 16:59:09.000000000","tz":120},"subject":"target/riscv: fix \u0027reset run\u0027 after \u0027reset halt\u0027","message":"target/riscv: fix \u0027reset run\u0027 after \u0027reset halt\u0027\n\n\u0027reset halt\u0027 does not clear DM_DMCONTROL_HALTREQ at deassert_reset().\nIf hw reset line is configured e.g. \u0027reset_config srst_only\u0027\nthe folowing \u0027reset run\u0027 halts:\n\n \u003e gd32v.cpu curstate\n running\n\n \u003e reset halt\n JTAG tap: gd32v.cpu tap/device found: 0x1000563d (mfg: 0x31e ...\n \u003e gd32v.cpu curstate\n halted\n\n \u003e reset\n JTAG tap: gd32v.cpu tap/device found: 0x1000563d (mfg: 0x31e ...\n \u003e gd32v.cpu curstate\n halted \u003c\u003c\u003c\u003c---- wrong!!!\n\n \u003e reset\n JTAG tap: gd32v.cpu tap/device found: 0x1000563d (mfg: 0x31e ...\n \u003e gd32v.cpu curstate\n running\n\nClear DM_DMCONTROL_HALTREQ when acking reset.\n\nChange-Id: Iae0454b425e81e64774b9785bb5ba1d4564d940b\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}