)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"change_message_id":"cd7e389601feca98dd9606f9d7a58d999d3a6a84","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"db627148_9e2a83ea","updated":"2022-05-06 16:10:50.000000000","message":"I have modified the configure script to exclude the driver from the build on big endian platforms.\nI have also modified the documentation to state the platform limitation. ","commit_id":"4293e56ca1ee8a1e400873425c769f144b35a213"},{"author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"change_message_id":"b195337ab9139dc0eae33258f735b62dd03204d5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c0fff0e7_245b8d21","updated":"2022-05-23 18:58:16.000000000","message":"I have rewritten the driver to be support big endian platforms and tested it with buildroot.\nUnfortunately some of the nice, descriptive structures with bit fields needed to go away, as they are simply not portable. And the the driver code got bigger...   ","commit_id":"700d4c9e18e14d961606a1428b8aa7bc0435b72b"},{"author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"change_message_id":"8d54f033dd89a2a1d69e3b71ad215023343f2d41","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3e7da919_260f3ae8","updated":"2022-06-21 11:23:14.000000000","message":"Thank you for the review Antonio. \nThe new patch addresses your comments and fixes sanitize warning in vdebug_socket_open.","commit_id":"700d4c9e18e14d961606a1428b8aa7bc0435b72b"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"f504cdc4118548bbfeccf2a905273f17d41b58db","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e471988c_afad50f4","updated":"2022-06-11 17:49:21.000000000","message":"thanks for the huge effort!\nI have two comments, even not sure are really relevant, plus few s/unsigned/unsigned int/","commit_id":"700d4c9e18e14d961606a1428b8aa7bc0435b72b"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"99809c8442b0ff347b89ed1e4e4b6767a1118911","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ba944345_27ea6d08","updated":"2022-07-02 16:07:43.000000000","message":"Thanks!","commit_id":"6e9fe7095a3f0892f97404fbb99cafa9bb8c3bf6"}],"src/jtag/drivers/vdebug.c":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"9384ad65b62673614365c4df9ae17c3d755212ba","unresolved":true,"context_lines":[{"line_number":198,"context_line":"\t\tint32_t  status;         /* fd4; */"},{"line_number":199,"context_line":"\t\tuint64_t duttime;        /* fd8; */"},{"line_number":200,"context_line":"\t};"},{"line_number":201,"context_line":"\tunion {                      /* fe0: */"},{"line_number":202,"context_line":"\t\tuint8_t rd8[VD_BUFFER_LEN];"},{"line_number":203,"context_line":"\t\tuint16_t rd16[VD_BUFFER_LEN / 2];"},{"line_number":204,"context_line":"\t\tuint32_t rd32[VD_BUFFER_LEN / 4];"},{"line_number":205,"context_line":"\t\tuint64_t rd64[VD_BUFFER_LEN / 8];"},{"line_number":206,"context_line":"\t};"},{"line_number":207,"context_line":"\tuint32_t state;              /* 1f98; connection state */"},{"line_number":208,"context_line":"\tuint32_t count;              /* 1f9c; */"},{"line_number":209,"context_line":"\tuint8_t dummy[96];           /* 1fa0; 48+40B+8B; */"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"173da2dd_8c56f844","line":206,"range":{"start_line":201,"start_character":1,"end_line":206,"end_character":3},"updated":"2022-05-04 16:10:28.000000000","message":"Such union for processing of adapter in/out data certainly results in bugs if OpenOCD runs on big endian host. Use just byte oriented buffer and le_to_h_u16/32/64(), h_uxx_to_le() or buf_get/set_u32/64() helpers","commit_id":"d60cbc7358a51fc43e5baebb62b313d5d591c1a3"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"11324f2ab8dc7dc74462c3f9a4b83a4d4fb688c6","unresolved":true,"context_lines":[{"line_number":198,"context_line":"\t\tint32_t  status;         /* fd4; */"},{"line_number":199,"context_line":"\t\tuint64_t duttime;        /* fd8; */"},{"line_number":200,"context_line":"\t};"},{"line_number":201,"context_line":"\tunion {                      /* fe0: */"},{"line_number":202,"context_line":"\t\tuint8_t rd8[VD_BUFFER_LEN];"},{"line_number":203,"context_line":"\t\tuint16_t rd16[VD_BUFFER_LEN / 2];"},{"line_number":204,"context_line":"\t\tuint32_t rd32[VD_BUFFER_LEN / 4];"},{"line_number":205,"context_line":"\t\tuint64_t rd64[VD_BUFFER_LEN / 8];"},{"line_number":206,"context_line":"\t};"},{"line_number":207,"context_line":"\tuint32_t state;              /* 1f98; connection state */"},{"line_number":208,"context_line":"\tuint32_t count;              /* 1f9c; */"},{"line_number":209,"context_line":"\tuint8_t dummy[96];           /* 1fa0; 48+40B+8B; */"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"272feb17_b1688fc6","line":206,"range":{"start_line":201,"start_character":1,"end_line":206,"end_character":3},"in_reply_to":"077adb46_206444eb","updated":"2022-05-04 21:10:45.000000000","message":"No, it\u0027s written nowhere.\nAs it\u0027s now, this driver should be excluded from configure in case of big-endian build and this should be reported in the documentation.\nYes, the review has been very frustrating, but I still hope Jacek and Cadence takes more seriously the contribution to OpenOCD, also considering that some new contribution from Cadence for Xtensa in ongoing.","commit_id":"d60cbc7358a51fc43e5baebb62b313d5d591c1a3"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"4d2a6b3d7fd80a83f9732e4ebde0de0c58a56fd5","unresolved":true,"context_lines":[{"line_number":198,"context_line":"\t\tint32_t  status;         /* fd4; */"},{"line_number":199,"context_line":"\t\tuint64_t duttime;        /* fd8; */"},{"line_number":200,"context_line":"\t};"},{"line_number":201,"context_line":"\tunion {                      /* fe0: */"},{"line_number":202,"context_line":"\t\tuint8_t rd8[VD_BUFFER_LEN];"},{"line_number":203,"context_line":"\t\tuint16_t rd16[VD_BUFFER_LEN / 2];"},{"line_number":204,"context_line":"\t\tuint32_t rd32[VD_BUFFER_LEN / 4];"},{"line_number":205,"context_line":"\t\tuint64_t rd64[VD_BUFFER_LEN / 8];"},{"line_number":206,"context_line":"\t};"},{"line_number":207,"context_line":"\tuint32_t state;              /* 1f98; connection state */"},{"line_number":208,"context_line":"\tuint32_t count;              /* 1f9c; */"},{"line_number":209,"context_line":"\tuint8_t dummy[96];           /* 1fa0; 48+40B+8B; */"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"e6f9a578_a6435c57","line":206,"range":{"start_line":201,"start_character":1,"end_line":206,"end_character":3},"in_reply_to":"173da2dd_8c56f844","updated":"2022-05-04 17:08:33.000000000","message":"This driver is known to be broken on big-endian host and Jacek has already refused to address the endianess issue\nhttps://review.openocd.org/c/openocd/+/6097/comment/aedf27f1_cf61fd02/\nJacek, any update on this?","commit_id":"d60cbc7358a51fc43e5baebb62b313d5d591c1a3"},{"author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"change_message_id":"1e165335814d13e533a7ce22435d7e779a0db203","unresolved":true,"context_lines":[{"line_number":198,"context_line":"\t\tint32_t  status;         /* fd4; */"},{"line_number":199,"context_line":"\t\tuint64_t duttime;        /* fd8; */"},{"line_number":200,"context_line":"\t};"},{"line_number":201,"context_line":"\tunion {                      /* fe0: */"},{"line_number":202,"context_line":"\t\tuint8_t rd8[VD_BUFFER_LEN];"},{"line_number":203,"context_line":"\t\tuint16_t rd16[VD_BUFFER_LEN / 2];"},{"line_number":204,"context_line":"\t\tuint32_t rd32[VD_BUFFER_LEN / 4];"},{"line_number":205,"context_line":"\t\tuint64_t rd64[VD_BUFFER_LEN / 8];"},{"line_number":206,"context_line":"\t};"},{"line_number":207,"context_line":"\tuint32_t state;              /* 1f98; connection state */"},{"line_number":208,"context_line":"\tuint32_t count;              /* 1f9c; */"},{"line_number":209,"context_line":"\tuint8_t dummy[96];           /* 1fa0; 48+40B+8B; */"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"290280ae_0b748353","line":206,"range":{"start_line":201,"start_character":1,"end_line":206,"end_character":3},"in_reply_to":"272feb17_b1688fc6","updated":"2022-05-05 08:27:29.000000000","message":"Tomas, Antonio,\nThank you for the feedback. \nYes, this driver does not work on big endian platforms, there was nobody interested to run virtual debug interface on any of the big endian platforms, for that reason we have neither implemented it, nor established any infrastructure to test it.\nI did not know there was a mechanism to exclude from build on certain platforms in place.\nIf you agree, I will check and add it to this patch. Also update the documentation to clearly mention the limitation. Right now it is only only mentioned as TODO/FIXME in the code. The endianess problem/limitation will be addressed in a separate patch.\n\nThere is an effort to add the support for Xtensa architecture, started by Espressif as a limited scope, now working with Cadence team to add it in the consistent way, that can be expanded in the future.","commit_id":"d60cbc7358a51fc43e5baebb62b313d5d591c1a3"},{"author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"change_message_id":"b195337ab9139dc0eae33258f735b62dd03204d5","unresolved":false,"context_lines":[{"line_number":198,"context_line":"\t\tint32_t  status;         /* fd4; */"},{"line_number":199,"context_line":"\t\tuint64_t duttime;        /* fd8; */"},{"line_number":200,"context_line":"\t};"},{"line_number":201,"context_line":"\tunion {                      /* fe0: */"},{"line_number":202,"context_line":"\t\tuint8_t rd8[VD_BUFFER_LEN];"},{"line_number":203,"context_line":"\t\tuint16_t rd16[VD_BUFFER_LEN / 2];"},{"line_number":204,"context_line":"\t\tuint32_t rd32[VD_BUFFER_LEN / 4];"},{"line_number":205,"context_line":"\t\tuint64_t rd64[VD_BUFFER_LEN / 8];"},{"line_number":206,"context_line":"\t};"},{"line_number":207,"context_line":"\tuint32_t state;              /* 1f98; connection state */"},{"line_number":208,"context_line":"\tuint32_t count;              /* 1f9c; */"},{"line_number":209,"context_line":"\tuint8_t dummy[96];           /* 1fa0; 48+40B+8B; */"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"531f07f2_46e32b3b","line":206,"range":{"start_line":201,"start_character":1,"end_line":206,"end_character":3},"in_reply_to":"290280ae_0b748353","updated":"2022-05-23 18:58:16.000000000","message":"Done","commit_id":"d60cbc7358a51fc43e5baebb62b313d5d591c1a3"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"a5ebbbff964d889cb61307bc365a4aad96e09189","unresolved":true,"context_lines":[{"line_number":198,"context_line":"\t\tint32_t  status;         /* fd4; */"},{"line_number":199,"context_line":"\t\tuint64_t duttime;        /* fd8; */"},{"line_number":200,"context_line":"\t};"},{"line_number":201,"context_line":"\tunion {                      /* fe0: */"},{"line_number":202,"context_line":"\t\tuint8_t rd8[VD_BUFFER_LEN];"},{"line_number":203,"context_line":"\t\tuint16_t rd16[VD_BUFFER_LEN / 2];"},{"line_number":204,"context_line":"\t\tuint32_t rd32[VD_BUFFER_LEN / 4];"},{"line_number":205,"context_line":"\t\tuint64_t rd64[VD_BUFFER_LEN / 8];"},{"line_number":206,"context_line":"\t};"},{"line_number":207,"context_line":"\tuint32_t state;              /* 1f98; connection state */"},{"line_number":208,"context_line":"\tuint32_t count;              /* 1f9c; */"},{"line_number":209,"context_line":"\tuint8_t dummy[96];           /* 1fa0; 48+40B+8B; */"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"077adb46_206444eb","line":206,"range":{"start_line":201,"start_character":1,"end_line":206,"end_character":3},"in_reply_to":"e6f9a578_a6435c57","updated":"2022-05-04 18:33:24.000000000","message":"Antonio, I shortly looked to #6097 and seen how long and frustrating work it was for reviewers. On the other hand normally patches are not merged just because the reviewers are too exhausted to continue ;-)\n\nWhat do you mean by \u0027The driver is known to be broken on big-endian\u0027?\nIs it written in the doc? I don\u0027t see any warning.\nIs the the driver compiled only\n #if __BYTE_ORDER__ \u003d\u003d __ORDER_LITTLE_ENDIAN__\n\n?\nOr is there any other check?","commit_id":"d60cbc7358a51fc43e5baebb62b313d5d591c1a3"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"9384ad65b62673614365c4df9ae17c3d755212ba","unresolved":true,"context_lines":[{"line_number":471,"context_line":"\tts \u003d timeval_ms();"},{"line_number":472,"context_line":"\trc \u003d vdebug_wait_server(hsock, pm);"},{"line_number":473,"context_line":"\twhile (!rc \u0026\u0026 (req \u003c count)) {      /* loop over requests to read data and print out */"},{"line_number":474,"context_line":"\t\thdr \u003d (struct vd_reg_hdr *)\u0026pm-\u003ewd32[waddr];"},{"line_number":475,"context_line":"\t\taddr \u003d hdr-\u003eaddr;               /* reconstruct data for a single request */"},{"line_number":476,"context_line":"\t\tnum \u003d hdr-\u003etlen;"},{"line_number":477,"context_line":"\t\taspace \u003d hdr-\u003eprot;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"575f0f21_9bf4fb14","line":474,"range":{"start_line":474,"start_character":1,"end_line":474,"end_character":46},"updated":"2022-05-04 16:10:28.000000000","message":"This is also endianess problem.\nI\u0027m afraid that almost any of numerous pointer typecasts is a bug on big endian.","commit_id":"d60cbc7358a51fc43e5baebb62b313d5d591c1a3"},{"author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"change_message_id":"b195337ab9139dc0eae33258f735b62dd03204d5","unresolved":false,"context_lines":[{"line_number":471,"context_line":"\tts \u003d timeval_ms();"},{"line_number":472,"context_line":"\trc \u003d vdebug_wait_server(hsock, pm);"},{"line_number":473,"context_line":"\twhile (!rc \u0026\u0026 (req \u003c count)) {      /* loop over requests to read data and print out */"},{"line_number":474,"context_line":"\t\thdr \u003d (struct vd_reg_hdr *)\u0026pm-\u003ewd32[waddr];"},{"line_number":475,"context_line":"\t\taddr \u003d hdr-\u003eaddr;               /* reconstruct data for a single request */"},{"line_number":476,"context_line":"\t\tnum \u003d hdr-\u003etlen;"},{"line_number":477,"context_line":"\t\taspace \u003d hdr-\u003eprot;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"6dae7dbe_747ac28c","line":474,"range":{"start_line":474,"start_character":1,"end_line":474,"end_character":46},"in_reply_to":"575f0f21_9bf4fb14","updated":"2022-05-23 18:58:16.000000000","message":"Done","commit_id":"d60cbc7358a51fc43e5baebb62b313d5d591c1a3"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"f504cdc4118548bbfeccf2a905273f17d41b58db","unresolved":true,"context_lines":[{"line_number":197,"context_line":"\tuint8_t state[4];            /* 1f98; connection state */"},{"line_number":198,"context_line":"\tuint8_t count[4];            /* 1f9c; */"},{"line_number":199,"context_line":"\tuint8_t dummy[96];           /* 1fa0; 48+40B+8B; */"},{"line_number":200,"context_line":"};"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"struct vd_rdata {"},{"line_number":203,"context_line":"\tstruct list_head lh;"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"0a120f93_2f996e20","line":200,"updated":"2022-06-11 17:49:21.000000000","message":"It should work as expected, but I\u0027m afraid that some compiler could decide to re-align each entry of this struct.\nThink about adding __attribute__((packed)) to avoid any headache later.\nSyntax should be by adding it at the end:\n    uint8_t dummy[96];           /* 1fa0; 48+40B+8B; */\n } __attribute__ ((packed));\n\nAny other struct that is exchanged as an array through recv()/send() ?","commit_id":"700d4c9e18e14d961606a1428b8aa7bc0435b72b"},{"author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"change_message_id":"8d54f033dd89a2a1d69e3b71ad215023343f2d41","unresolved":false,"context_lines":[{"line_number":197,"context_line":"\tuint8_t state[4];            /* 1f98; connection state */"},{"line_number":198,"context_line":"\tuint8_t count[4];            /* 1f9c; */"},{"line_number":199,"context_line":"\tuint8_t dummy[96];           /* 1fa0; 48+40B+8B; */"},{"line_number":200,"context_line":"};"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"struct vd_rdata {"},{"line_number":203,"context_line":"\tstruct list_head lh;"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"6f6071ba_73da51cc","line":200,"in_reply_to":"0a120f93_2f996e20","updated":"2022-06-21 11:23:14.000000000","message":"Sure, good idea","commit_id":"700d4c9e18e14d961606a1428b8aa7bc0435b72b"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"f504cdc4118548bbfeccf2a905273f17d41b58db","unresolved":true,"context_lines":[{"line_number":436,"context_line":"\th_u32_to_le(pm-\u003eoffset, 0);"},{"line_number":437,"context_line":"\th_u16_to_le(pm-\u003erwords, 0);"},{"line_number":438,"context_line":"\th_u16_to_le(pm-\u003ewaddr, 0);"},{"line_number":439,"context_line":"\tINIT_LIST_HEAD(\u0026vdc.rdataq.lh);    /* just in case, list should be empty */"},{"line_number":440,"context_line":""},{"line_number":441,"context_line":"\treturn rc;"},{"line_number":442,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"b44a7fe8_7cd88890","line":439,"updated":"2022-06-11 17:49:21.000000000","message":"Humm, what about\n assert(!list_empty(\u0026vdc.rdataq.lh));\nto highlight a possible error? Someone could modify the code and messup the use of the list.\nAlso below.\nBut pay attention to keep the initial init of the list, I think it\u0027s the one in vdebug_open()","commit_id":"700d4c9e18e14d961606a1428b8aa7bc0435b72b"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"99809c8442b0ff347b89ed1e4e4b6767a1118911","unresolved":false,"context_lines":[{"line_number":436,"context_line":"\th_u32_to_le(pm-\u003eoffset, 0);"},{"line_number":437,"context_line":"\th_u16_to_le(pm-\u003erwords, 0);"},{"line_number":438,"context_line":"\th_u16_to_le(pm-\u003ewaddr, 0);"},{"line_number":439,"context_line":"\tINIT_LIST_HEAD(\u0026vdc.rdataq.lh);    /* just in case, list should be empty */"},{"line_number":440,"context_line":""},{"line_number":441,"context_line":"\treturn rc;"},{"line_number":442,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"332f8a30_116e9223","line":439,"in_reply_to":"4d383eaa_f1dace6c","updated":"2022-07-02 16:07:43.000000000","message":"Yes, correct!","commit_id":"700d4c9e18e14d961606a1428b8aa7bc0435b72b"},{"author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"change_message_id":"8d54f033dd89a2a1d69e3b71ad215023343f2d41","unresolved":false,"context_lines":[{"line_number":436,"context_line":"\th_u32_to_le(pm-\u003eoffset, 0);"},{"line_number":437,"context_line":"\th_u16_to_le(pm-\u003erwords, 0);"},{"line_number":438,"context_line":"\th_u16_to_le(pm-\u003ewaddr, 0);"},{"line_number":439,"context_line":"\tINIT_LIST_HEAD(\u0026vdc.rdataq.lh);    /* just in case, list should be empty */"},{"line_number":440,"context_line":""},{"line_number":441,"context_line":"\treturn rc;"},{"line_number":442,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"4d383eaa_f1dace6c","line":439,"in_reply_to":"b44a7fe8_7cd88890","updated":"2022-06-21 11:23:14.000000000","message":"I think you meant assert(list_empty(\u0026vdc.rdataq.lh)); Done.","commit_id":"700d4c9e18e14d961606a1428b8aa7bc0435b72b"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"f504cdc4118548bbfeccf2a905273f17d41b58db","unresolved":true,"context_lines":[{"line_number":1107,"context_line":"\treturn ERROR_OK;"},{"line_number":1108,"context_line":"}"},{"line_number":1109,"context_line":""},{"line_number":1110,"context_line":"static int vdebug_dap_queue_dp_read(struct adiv5_dap *dap, unsigned reg, uint32_t *data)"},{"line_number":1111,"context_line":"{"},{"line_number":1112,"context_line":"\treturn vdebug_reg_read(vdc.hsocket, pbuf, (reg \u0026 DP_SELECT_DPBANK) \u003e\u003e 2, data, VD_ASPACE_DP, 0);"},{"line_number":1113,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"4d3bc794_82c3f886","line":1110,"updated":"2022-06-11 17:49:21.000000000","message":"s/unsigned/unsigned int/","commit_id":"700d4c9e18e14d961606a1428b8aa7bc0435b72b"},{"author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"change_message_id":"8d54f033dd89a2a1d69e3b71ad215023343f2d41","unresolved":false,"context_lines":[{"line_number":1107,"context_line":"\treturn ERROR_OK;"},{"line_number":1108,"context_line":"}"},{"line_number":1109,"context_line":""},{"line_number":1110,"context_line":"static int vdebug_dap_queue_dp_read(struct adiv5_dap *dap, unsigned reg, uint32_t *data)"},{"line_number":1111,"context_line":"{"},{"line_number":1112,"context_line":"\treturn vdebug_reg_read(vdc.hsocket, pbuf, (reg \u0026 DP_SELECT_DPBANK) \u003e\u003e 2, data, VD_ASPACE_DP, 0);"},{"line_number":1113,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"67ccbddd_3a332381","line":1110,"in_reply_to":"4d3bc794_82c3f886","updated":"2022-06-21 11:23:14.000000000","message":"These functions have been declared this way in the header arm_adi_v5.h. Should it be updated as well ? There are more sources which implement the dap_ops and they need to change too...","commit_id":"700d4c9e18e14d961606a1428b8aa7bc0435b72b"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"f504cdc4118548bbfeccf2a905273f17d41b58db","unresolved":true,"context_lines":[{"line_number":1112,"context_line":"\treturn vdebug_reg_read(vdc.hsocket, pbuf, (reg \u0026 DP_SELECT_DPBANK) \u003e\u003e 2, data, VD_ASPACE_DP, 0);"},{"line_number":1113,"context_line":"}"},{"line_number":1114,"context_line":""},{"line_number":1115,"context_line":"static int vdebug_dap_queue_dp_write(struct adiv5_dap *dap, unsigned reg, uint32_t data)"},{"line_number":1116,"context_line":"{"},{"line_number":1117,"context_line":"\treturn vdebug_reg_write(vdc.hsocket, pbuf, (reg \u0026 DP_SELECT_DPBANK) \u003e\u003e 2, data, VD_ASPACE_DP, 0);"},{"line_number":1118,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"6d147ac4_faee28cd","line":1115,"updated":"2022-06-11 17:49:21.000000000","message":"s/unsigned/unsigned int/","commit_id":"700d4c9e18e14d961606a1428b8aa7bc0435b72b"},{"author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"change_message_id":"8d54f033dd89a2a1d69e3b71ad215023343f2d41","unresolved":false,"context_lines":[{"line_number":1112,"context_line":"\treturn vdebug_reg_read(vdc.hsocket, pbuf, (reg \u0026 DP_SELECT_DPBANK) \u003e\u003e 2, data, VD_ASPACE_DP, 0);"},{"line_number":1113,"context_line":"}"},{"line_number":1114,"context_line":""},{"line_number":1115,"context_line":"static int vdebug_dap_queue_dp_write(struct adiv5_dap *dap, unsigned reg, uint32_t data)"},{"line_number":1116,"context_line":"{"},{"line_number":1117,"context_line":"\treturn vdebug_reg_write(vdc.hsocket, pbuf, (reg \u0026 DP_SELECT_DPBANK) \u003e\u003e 2, data, VD_ASPACE_DP, 0);"},{"line_number":1118,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"d8e11cd8_14119230","line":1115,"in_reply_to":"6d147ac4_faee28cd","updated":"2022-06-21 11:23:14.000000000","message":"Done","commit_id":"700d4c9e18e14d961606a1428b8aa7bc0435b72b"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"f504cdc4118548bbfeccf2a905273f17d41b58db","unresolved":true,"context_lines":[{"line_number":1117,"context_line":"\treturn vdebug_reg_write(vdc.hsocket, pbuf, (reg \u0026 DP_SELECT_DPBANK) \u003e\u003e 2, data, VD_ASPACE_DP, 0);"},{"line_number":1118,"context_line":"}"},{"line_number":1119,"context_line":""},{"line_number":1120,"context_line":"static int vdebug_dap_queue_ap_read(struct adiv5_ap *ap, unsigned reg, uint32_t *data)"},{"line_number":1121,"context_line":"{"},{"line_number":1122,"context_line":"\tif ((reg \u0026 DP_SELECT_APBANK) !\u003d ap-\u003edap-\u003eselect) {"},{"line_number":1123,"context_line":"\t\tvdebug_reg_write(vdc.hsocket, pbuf, DP_SELECT \u003e\u003e 2, reg \u0026 DP_SELECT_APBANK, VD_ASPACE_DP, 0);"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"89e4460f_81191b58","line":1120,"updated":"2022-06-11 17:49:21.000000000","message":"s/unsigned/unsigned int/","commit_id":"700d4c9e18e14d961606a1428b8aa7bc0435b72b"},{"author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"change_message_id":"8d54f033dd89a2a1d69e3b71ad215023343f2d41","unresolved":false,"context_lines":[{"line_number":1117,"context_line":"\treturn vdebug_reg_write(vdc.hsocket, pbuf, (reg \u0026 DP_SELECT_DPBANK) \u003e\u003e 2, data, VD_ASPACE_DP, 0);"},{"line_number":1118,"context_line":"}"},{"line_number":1119,"context_line":""},{"line_number":1120,"context_line":"static int vdebug_dap_queue_ap_read(struct adiv5_ap *ap, unsigned reg, uint32_t *data)"},{"line_number":1121,"context_line":"{"},{"line_number":1122,"context_line":"\tif ((reg \u0026 DP_SELECT_APBANK) !\u003d ap-\u003edap-\u003eselect) {"},{"line_number":1123,"context_line":"\t\tvdebug_reg_write(vdc.hsocket, pbuf, DP_SELECT \u003e\u003e 2, reg \u0026 DP_SELECT_APBANK, VD_ASPACE_DP, 0);"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"e574553d_86fed2c5","line":1120,"in_reply_to":"89e4460f_81191b58","updated":"2022-06-21 11:23:14.000000000","message":"Done","commit_id":"700d4c9e18e14d961606a1428b8aa7bc0435b72b"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"f504cdc4118548bbfeccf2a905273f17d41b58db","unresolved":true,"context_lines":[{"line_number":1129,"context_line":"\treturn vdebug_reg_read(vdc.hsocket, pbuf, DP_RDBUFF \u003e\u003e 2, data, VD_ASPACE_DP, 0);"},{"line_number":1130,"context_line":"}"},{"line_number":1131,"context_line":""},{"line_number":1132,"context_line":"static int vdebug_dap_queue_ap_write(struct adiv5_ap *ap, unsigned reg, uint32_t data)"},{"line_number":1133,"context_line":"{"},{"line_number":1134,"context_line":"\tif ((reg \u0026 DP_SELECT_APBANK) !\u003d ap-\u003edap-\u003eselect) {"},{"line_number":1135,"context_line":"\t\tvdebug_reg_write(vdc.hsocket, pbuf, DP_SELECT \u003e\u003e 2, reg \u0026 DP_SELECT_APBANK, VD_ASPACE_DP, 0);"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"037199d2_6be30d9c","line":1132,"updated":"2022-06-11 17:49:21.000000000","message":"s/unsigned/unsigned int/","commit_id":"700d4c9e18e14d961606a1428b8aa7bc0435b72b"},{"author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"change_message_id":"8d54f033dd89a2a1d69e3b71ad215023343f2d41","unresolved":false,"context_lines":[{"line_number":1129,"context_line":"\treturn vdebug_reg_read(vdc.hsocket, pbuf, DP_RDBUFF \u003e\u003e 2, data, VD_ASPACE_DP, 0);"},{"line_number":1130,"context_line":"}"},{"line_number":1131,"context_line":""},{"line_number":1132,"context_line":"static int vdebug_dap_queue_ap_write(struct adiv5_ap *ap, unsigned reg, uint32_t data)"},{"line_number":1133,"context_line":"{"},{"line_number":1134,"context_line":"\tif ((reg \u0026 DP_SELECT_APBANK) !\u003d ap-\u003edap-\u003eselect) {"},{"line_number":1135,"context_line":"\t\tvdebug_reg_write(vdc.hsocket, pbuf, DP_SELECT \u003e\u003e 2, reg \u0026 DP_SELECT_APBANK, VD_ASPACE_DP, 0);"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"821b9e59_ca4f0999","line":1132,"in_reply_to":"037199d2_6be30d9c","updated":"2022-06-21 11:23:14.000000000","message":"Done","commit_id":"700d4c9e18e14d961606a1428b8aa7bc0435b72b"}]}