)]}'
{"id":"openocd~master~I56738c80779082ca146a06c01bc30e28bc835fd3","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2022-05-07 11:03:03.000000000","reason":"Change was submitted"},"1001422":{"account":{"_account_id":1001422,"name":"Bohdan Tymkiv","email":"bohdan200@gmail.com","username":"bhdt"},"last_update":"2022-05-04 15:03:04.000000000","reason":"Bohdan Tymkiv replied on the change"},"1001964":{"account":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"last_update":"2022-05-04 14:59:32.000000000","reason":"Erhan Kurubas replied on the change"}},"hashtags":[],"change_id":"I56738c80779082ca146a06c01bc30e28bc835fd3","subject":"server/gdb: fix gdb remote monitor cmd on multi-target","status":"MERGED","created":"2022-05-04 14:27:48.000000000","updated":"2022-05-07 11:03:03.000000000","submitted":"2022-05-07 11:03:03.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6966","meta_rev_id":"f733a3e4988c60ca87dc942a0a73b42b8d072c9c","_number":6966,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-05-07 11:03:03.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"value":0,"_account_id":1001422,"name":"Bohdan Tymkiv","email":"bohdan200@gmail.com","username":"bhdt"}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-05-07 11:03:03.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-05-07 11:03:03.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-05-07 11:03:03.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-05-07 11:03:03.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1001422,"name":"Bohdan Tymkiv","email":"bohdan200@gmail.com","username":"bhdt"}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"}],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},{"_account_id":1001422,"name":"Bohdan Tymkiv","email":"bohdan200@gmail.com","username":"bhdt"},{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-05-04 14:27:48.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1001422,"name":"Bohdan Tymkiv","email":"bohdan200@gmail.com","username":"bhdt"},"state":"REVIEWER"},{"updated":"2022-05-04 14:55:11.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-05-04 14:56:28.000000000","updated_by":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"reviewer":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"state":"REVIEWER"},{"updated":"2022-05-04 14:59:32.000000000","updated_by":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"reviewer":{"_account_id":1001839,"name":"Antonio Borneo","email":"antonio.borneo@st.com"},"state":"CC"},{"updated":"2022-05-04 15:42:25.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"},{"updated":"2022-05-04 15:54:58.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1001839,"name":"Antonio Borneo","email":"antonio.borneo@st.com"},"state":"REMOVED"},{"updated":"2022-05-04 16:12:37.000000000","updated_by":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"reviewer":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"state":"REVIEWER"}],"messages":[{"id":"17b051182a666dce1bebc765a9f7e9431d624c61","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-05-04 14:27:48.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7704b654f9db2398671b96e958948a4ef6c8ff6b","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-05-04 14:55:11.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/16099/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/15309/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"bfe2ee817ada867b1bb28a9229fc642ce8ad3e58","author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"real_author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"date":"2022-05-04 14:59:32.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"7dc6b565d25524fdf1d0f49b2198e9429506b47d","author":{"_account_id":1001422,"name":"Bohdan Tymkiv","email":"bohdan200@gmail.com","username":"bhdt"},"real_author":{"_account_id":1001422,"name":"Bohdan Tymkiv","email":"bohdan200@gmail.com","username":"bhdt"},"date":"2022-05-04 15:03:04.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"bd5f485a21961baa95bdd8838a8d43b45c4fd530","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-05-04 15:33:47.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"810757542e6facf573f1bde546deeb502099176c","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-05-04 15:42:25.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"f7d8db661a152506caeed2ece635cec5314aab2f","tag":"autogenerated:gerrit:deleteReviewer","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-05-04 15:54:58.000000000","message":"Removed cc Antonio Borneo.","accounts_in_message":[],"_revision_number":1},{"id":"3c5fced485d473f18d735ac12a6c2bdb57784405","author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"real_author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"date":"2022-05-04 16:12:37.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"f733a3e4988c60ca87dc942a0a73b42b8d072c9c","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-05-07 11:03:03.000000000","message":"Change has been successfully cherry-picked as f88a7dde6a0c5e0a74806f6e81528a8525591e9e","accounts_in_message":[],"_revision_number":2}],"current_revision":"f88a7dde6a0c5e0a74806f6e81528a8525591e9e","revisions":{"f88a7dde6a0c5e0a74806f6e81528a8525591e9e":{"kind":"REWORK","_number":2,"created":"2022-05-07 11:03:03.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/66/6966/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/66/6966/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/66/6966/2 \u0026\u0026 git checkout -b change-6966 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/66/6966/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/66/6966/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/66/6966/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/66/6966/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/66/6966/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b4f8d99c8d9e453b2beb3f6c9db7ff01c8d00756","subject":"smp: deprecate legacy SMP core switching support"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-05-04 14:17:08.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-05-07 11:03:03.000000000","tz":0},"subject":"server/gdb: fix gdb remote monitor cmd on multi-target","message":"server/gdb: fix gdb remote monitor cmd on multi-target\n\nCommit 5ebb1bdea1df (\"server/gdb: fix return of gdb remote monitor\ncommand\") replaces the call to command_run_line() with call to\nJim_EvalObj() but does not properly set the \"context\".\nIn multi-target environment, his can cause the erroneously\nexecution of the command on the wrong target.\n\nCopy from the code in command_run_line() the proper setup before\nexecuting Jim_EvalObj().\n\nChange-Id: I56738c80779082ca146a06c01bc30e28bc835fd3\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReported-by: Bohdan Tymkiv \u003cbohdan200@gmail.com\u003e\nFixes: 5ebb1bdea1df (\"server/gdb: fix return of gdb remote monitor command\")\nReviewed-on: https://review.openocd.org/c/openocd/+/6966\nTested-by: jenkins\nReviewed-by: Bohdan Tymkiv \u003cbohdan200@gmail.com\u003e\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nReviewed-by: Tim Newsome \u003ctim@sifive.com\u003e\n"}},"3fe14f1718e8a74214e4f43a1e9eb0ba4148cd90":{"kind":"REWORK","_number":1,"created":"2022-05-04 14:27:48.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/66/6966/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/66/6966/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/66/6966/1 \u0026\u0026 git checkout -b change-6966 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/66/6966/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/66/6966/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/66/6966/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/66/6966/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/66/6966/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"66335683fec62ac89da48d64932fd9d082314225","subject":"drivers/cmsis-dap: Correct the DAP protocol parameter parsing error"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-05-04 14:17:08.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-05-04 14:26:48.000000000","tz":120},"subject":"server/gdb: fix gdb remote monitor cmd on multi-target","message":"server/gdb: fix gdb remote monitor cmd on multi-target\n\nCommit 5ebb1bdea1df (\"server/gdb: fix return of gdb remote monitor\ncommand\") replaces the call to command_run_line() with call to\nJim_EvalObj() but does not properly set the \"context\".\nIn multi-target environment, his can cause the erroneously\nexecution of the command on the wrong target.\n\nCopy from the code in command_run_line() the proper setup before\nexecuting Jim_EvalObj().\n\nChange-Id: I56738c80779082ca146a06c01bc30e28bc835fd3\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReported-by: Bohdan Tymkiv \u003cbohdan200@gmail.com\u003e\nFixes: 5ebb1bdea1df (\"server/gdb: fix return of gdb remote monitor command\")\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}