)]}'
{"id":"openocd~master~Ia90baf5b4857db2b5569ebe6adbbb832de772aad","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1001839":{"account":{"_account_id":1001839,"name":"Antonio Borneo","email":"antonio.borneo@st.com"},"last_update":"2022-05-21 09:00:51.000000000","reason":"Change was submitted"},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2022-05-21 09:00:51.000000000","reason":"Change was submitted"},"1001964":{"account":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"last_update":"2022-05-21 09:00:51.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ia90baf5b4857db2b5569ebe6adbbb832de772aad","subject":"flash: fix clang static analyzer build errors","status":"MERGED","created":"2022-05-09 21:09:31.000000000","updated":"2022-05-21 09:00:51.000000000","submitted":"2022-05-21 09:00:51.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6971","meta_rev_id":"ab0c9ab143f614afcf5feea5cad634baf2246efb","_number":6971,"owner":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-05-21 09:00:51.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-05-21 09:00:51.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1001839,"name":"Antonio Borneo","email":"antonio.borneo@st.com"}],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1001839,"name":"Antonio Borneo","email":"antonio.borneo@st.com"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-05-09 21:31:40.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-05-09 21:59:28.000000000","updated_by":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"},{"updated":"2022-05-09 21:59:28.000000000","updated_by":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"reviewer":{"_account_id":1001839,"name":"Antonio Borneo","email":"antonio.borneo@st.com"},"state":"REVIEWER"},{"updated":"2022-05-09 22:38:32.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"f03c8765c7fc3ba737f6b7a5d5524de48f0f62ef","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"real_author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"date":"2022-05-09 21:09:31.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"83b1ef0817478b3011cd36a3dfc660b1d97d36f8","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"real_author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"date":"2022-05-09 21:30:07.000000000","message":"Patch Set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"65e514898583065093905d0522dbdbb190d4f717","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-05-09 21:31:40.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit-build/15336/ : ABORTED\n\nhttps://build.openocd.org/job/openocd-gerrit/16126/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"bf3eabc29203e914887783edaced15b6013878f6","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-05-09 22:15:55.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/16128/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/15338/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"82c72885c884fe99d5769fd8653eda7c7aca1332","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-05-09 22:38:32.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"d2de36afb8a8b6687857535a122a389e3261ab65","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-05-21 09:00:46.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"ab0c9ab143f614afcf5feea5cad634baf2246efb","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-05-21 09:00:51.000000000","message":"Change has been successfully cherry-picked as 631d0bddfaadac63a7d8ff3ef916614d62c86b1e","accounts_in_message":[],"_revision_number":3}],"current_revision":"631d0bddfaadac63a7d8ff3ef916614d62c86b1e","revisions":{"d7465df4f15554d520c031631e34ba0f0aae8d0b":{"kind":"REWORK","_number":1,"created":"2022-05-09 21:09:31.000000000","uploader":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"ref":"refs/changes/71/6971/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/71/6971/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/71/6971/1 \u0026\u0026 git checkout -b change-6971 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/71/6971/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/71/6971/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/71/6971/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/71/6971/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/71/6971/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d1e14abdba478c59f4b948c86191e67216941151","subject":"cross-build.sh: fix build with capstone"}],"author":{"name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","date":"2022-05-09 21:01:35.000000000","tz":120},"committer":{"name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","date":"2022-05-09 21:07:18.000000000","tz":120},"subject":"flash: fix clang static analyzer build errors on macos","message":"flash: fix clang static analyzer build errors on macos\n\nFixes variables set but not used errors.\n\nSigned-off-by: Erhan Kurubas \u003cerhan.kurubas@espressif.com\u003e\nChange-Id: Ia90baf5b4857db2b5569ebe6adbbb832de772aad\n"}},"3c868d2b76a57de01378f4fa7ea4e6fda939b3f5":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2022-05-09 21:30:07.000000000","uploader":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"ref":"refs/changes/71/6971/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/71/6971/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/71/6971/2 \u0026\u0026 git checkout -b change-6971 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/71/6971/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/71/6971/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/71/6971/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/71/6971/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/71/6971/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d1e14abdba478c59f4b948c86191e67216941151","subject":"cross-build.sh: fix build with capstone"}],"author":{"name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","date":"2022-05-09 21:01:35.000000000","tz":120},"committer":{"name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","date":"2022-05-09 21:30:07.000000000","tz":0},"subject":"flash: fix clang static analyzer build errors","message":"flash: fix clang static analyzer build errors\n\nFixes \"variable set but not used\" errors.\nTested with Homebrew clang version 13.0.1\n\nSigned-off-by: Erhan Kurubas \u003cerhan.kurubas@espressif.com\u003e\nChange-Id: Ia90baf5b4857db2b5569ebe6adbbb832de772aad\n"},"description":"Edit commit message"},"631d0bddfaadac63a7d8ff3ef916614d62c86b1e":{"kind":"REWORK","_number":3,"created":"2022-05-21 09:00:51.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/71/6971/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/71/6971/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/71/6971/3 \u0026\u0026 git checkout -b change-6971 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/71/6971/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/71/6971/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/71/6971/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/71/6971/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/71/6971/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"0f11f951e7774c54953f3f06916dcb62ac9b086d","subject":"target: fix clang static analyzer warning"}],"author":{"name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","date":"2022-05-09 21:01:35.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-05-21 09:00:51.000000000","tz":0},"subject":"flash: fix clang static analyzer build errors","message":"flash: fix clang static analyzer build errors\n\nFixes \"variable set but not used\" errors.\nTested with Homebrew clang version 13.0.1\n\nSigned-off-by: Erhan Kurubas \u003cerhan.kurubas@espressif.com\u003e\nChange-Id: Ia90baf5b4857db2b5569ebe6adbbb832de772aad\nReviewed-on: https://review.openocd.org/c/openocd/+/6971\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}