)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"a440bb5cac5b4fccff3854155a22aa41aa3e2300","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"de688148_4214e192","updated":"2022-05-26 14:31:11.000000000","message":"Yes, thanks, I added this in my todo list, but didn\u0027t really started fixing anything.\n\nThere are other struct assigned to target-\u003earch_info that do not have a common_magic.\nI reported them here, but not sure should be fixed here or in separate patches","commit_id":"37ddec4a866f091f157423299caab016ce5bbbe2"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"c36dc732db44afdc8a268e6d92b5e7ffb2a186aa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2ec6c4f5_443433ea","in_reply_to":"2dea0777_3d975971","updated":"2022-08-01 09:24:39.000000000","message":"\u003e Targets avrt, esirisc are used in flash drivers so they need cmn magic.\n\nI will add cmn magic to these targets later (as time permits) in separate patches.","commit_id":"37ddec4a866f091f157423299caab016ce5bbbe2"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"d4670ee75adcd4cf46b18e02c1ef52341401e4b6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1c5b7fb1_7ebbaa1c","in_reply_to":"2ec6c4f5_443433ea","updated":"2022-08-01 11:13:12.000000000","message":"\u003e The question is if we need cmn magic for all targets.\n\nWe need to enforce that target specific commands are executed on the proper target only.\nToday in multi-target systems, even for targets that define common_magic, we can sometime run commands for the other targets.\nI need to dive in the code to find a good example, I don\u0027t remember where I got this issue.\n\n\u003e I will add cmn magic to these targets later (as time permits) in separate patches.\n\nThanks. I left as \"unresolved\" my comments to the missing command_magic. This will make it easy to find them even when this patch get merged (either if get fixed in another patch or not)","commit_id":"37ddec4a866f091f157423299caab016ce5bbbe2"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"940e3074a6e267af4d21af28023b8721c2759bfb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2dea0777_3d975971","in_reply_to":"de688148_4214e192","updated":"2022-05-26 15:37:15.000000000","message":"Yes I know some targets miss common_magic. That\u0027s why I wrote about \u0027existing common_magic\u0027 in the commit msg.\n\nThe question is if we need cmn magic for all targets.\nSome targets don\u0027t have any associated flash and the target struct is not used outside target_type routines and target specific cmd extensions. In such case mismatching of targets seems me possible only by a faulty OpenOCD code.\nOf course I\u0027m not against adding cmn magic even there.\n\nAlso note that e.g. Cortex-A cmn magic is set but never tested.\n\nTargets avrt, esirisc are used in flash drivers so they need cmn magic.\n\ndsp5680xx has a flash driver too, but TBH I\u0027m not comfortable touching that old unmaintained code.","commit_id":"37ddec4a866f091f157423299caab016ce5bbbe2"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"d4670ee75adcd4cf46b18e02c1ef52341401e4b6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ad495175_bffaaf28","updated":"2022-08-01 11:13:12.000000000","message":"Ok, let\u0027s proceed with this","commit_id":"86bca5d8b6018714c19e6bf05a487f863330057b"}],"src/target/arm11.h":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"a440bb5cac5b4fccff3854155a22aa41aa3e2300","unresolved":true,"context_lines":[{"line_number":45,"context_line":"};"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"struct arm11_common {"},{"line_number":48,"context_line":"\tstruct arm arm;"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"\t/** Debug module state. */"},{"line_number":51,"context_line":"\tstruct arm_dpm dpm;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"f422e1c2_f63b712b","line":48,"updated":"2022-05-26 14:31:11.000000000","message":"missing common_magic","commit_id":"37ddec4a866f091f157423299caab016ce5bbbe2"}],"src/target/arm7_9_common.h":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"a440bb5cac5b4fccff3854155a22aa41aa3e2300","unresolved":false,"context_lines":[{"line_number":37,"context_line":" * Structure for items that are common between both ARM7 and ARM9 targets."},{"line_number":38,"context_line":" */"},{"line_number":39,"context_line":"struct arm7_9_common {"},{"line_number":40,"context_line":"\tunsigned int common_magic;"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"\tstruct arm arm;"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"1bac0d5b_4fb33b08","line":40,"updated":"2022-05-26 14:31:11.000000000","message":"Ok, but this reordering is not really a problem, as we never set\ntarget-\u003earch_info \u003d \u0026arm7_9_common;\nbut instead we always set\ntarget-\u003earch_info \u003d \u0026arm7_9_common.arm;\nso reading\n*(unsigned int *)target-\u003earch_info;\nwill always return ARM_COMMON_MAGIC\n\nSame also for xscale, arm11, armv7m, armv7a and armv8.\nAnd on top, also arm720t, arm920t, arm926ejs, arm946e and arm966e.","commit_id":"37ddec4a866f091f157423299caab016ce5bbbe2"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"940e3074a6e267af4d21af28023b8721c2759bfb","unresolved":false,"context_lines":[{"line_number":37,"context_line":" * Structure for items that are common between both ARM7 and ARM9 targets."},{"line_number":38,"context_line":" */"},{"line_number":39,"context_line":"struct arm7_9_common {"},{"line_number":40,"context_line":"\tunsigned int common_magic;"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"\tstruct arm arm;"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"7d16294c_f0596da4","line":40,"in_reply_to":"1bac0d5b_4fb33b08","updated":"2022-05-26 15:37:15.000000000","message":"\u003e Ok, but this reordering is not really a problem, as we never set\n\nThe problem could be possible memory fault when the code tests for a target with common_magic at a big offset and the real arch_info points to a short struct.","commit_id":"37ddec4a866f091f157423299caab016ce5bbbe2"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"d4670ee75adcd4cf46b18e02c1ef52341401e4b6","unresolved":false,"context_lines":[{"line_number":37,"context_line":" * Structure for items that are common between both ARM7 and ARM9 targets."},{"line_number":38,"context_line":" */"},{"line_number":39,"context_line":"struct arm7_9_common {"},{"line_number":40,"context_line":"\tunsigned int common_magic;"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"\tstruct arm arm;"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"efe4a505_14d0d63d","line":40,"in_reply_to":"7d16294c_f0596da4","updated":"2022-08-01 11:13:12.000000000","message":"Agree!","commit_id":"37ddec4a866f091f157423299caab016ce5bbbe2"}],"src/target/avrt.h":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"a440bb5cac5b4fccff3854155a22aa41aa3e2300","unresolved":true,"context_lines":[{"line_number":26,"context_line":"};"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"struct avr_common {"},{"line_number":29,"context_line":"\tstruct mcu_jtag jtag_info;"},{"line_number":30,"context_line":"};"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"int mcu_execute_queue(void);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"9dfbdbac_2f06fca0","line":29,"updated":"2022-05-26 14:31:11.000000000","message":"missing common_magic","commit_id":"37ddec4a866f091f157423299caab016ce5bbbe2"}],"src/target/cortex_a.h":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"a440bb5cac5b4fccff3854155a22aa41aa3e2300","unresolved":true,"context_lines":[{"line_number":31,"context_line":"#include \"armv7a.h\""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"#define CORTEX_A_COMMON_MAGIC 0x411fc082U"},{"line_number":34,"context_line":"#define CORTEX_A15_COMMON_MAGIC 0x413fc0f1U"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"#define CORTEX_A5_PARTNUM 0xc05"},{"line_number":37,"context_line":"#define CORTEX_A7_PARTNUM 0xc07"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"61ed791b_3e426da3","line":34,"updated":"2022-05-26 14:31:11.000000000","message":"This CORTEX_A15_COMMON_MAGIC is never used. Drop it?","commit_id":"37ddec4a866f091f157423299caab016ce5bbbe2"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"d4670ee75adcd4cf46b18e02c1ef52341401e4b6","unresolved":false,"context_lines":[{"line_number":31,"context_line":"#include \"armv7a.h\""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"#define CORTEX_A_COMMON_MAGIC 0x411fc082U"},{"line_number":34,"context_line":"#define CORTEX_A15_COMMON_MAGIC 0x413fc0f1U"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"#define CORTEX_A5_PARTNUM 0xc05"},{"line_number":37,"context_line":"#define CORTEX_A7_PARTNUM 0xc07"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"03019034_2372c05b","line":34,"in_reply_to":"1f82e9df_584d592d","updated":"2022-08-01 11:13:12.000000000","message":"Thanks","commit_id":"37ddec4a866f091f157423299caab016ce5bbbe2"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"c36dc732db44afdc8a268e6d92b5e7ffb2a186aa","unresolved":false,"context_lines":[{"line_number":31,"context_line":"#include \"armv7a.h\""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"#define CORTEX_A_COMMON_MAGIC 0x411fc082U"},{"line_number":34,"context_line":"#define CORTEX_A15_COMMON_MAGIC 0x413fc0f1U"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"#define CORTEX_A5_PARTNUM 0xc05"},{"line_number":37,"context_line":"#define CORTEX_A7_PARTNUM 0xc07"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"1f82e9df_584d592d","line":34,"in_reply_to":"61ed791b_3e426da3","updated":"2022-08-01 09:24:39.000000000","message":"Done in separate change\n7099: target/cortex_a: remove unused CORTEX_A15_COMMON_MAGIC | https://review.openocd.org/c/openocd/+/7099","commit_id":"37ddec4a866f091f157423299caab016ce5bbbe2"}],"src/target/dsp563xx.h":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"a440bb5cac5b4fccff3854155a22aa41aa3e2300","unresolved":true,"context_lines":[{"line_number":39,"context_line":"\tenum breakpoint_usage used;"},{"line_number":40,"context_line":"};"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"struct dsp563xx_common {"},{"line_number":43,"context_line":"\tstruct mcu_jtag jtag_info;"},{"line_number":44,"context_line":"\tstruct reg_cache *core_cache;"},{"line_number":45,"context_line":"\tuint32_t core_regs[DSP563XX_NUMCOREREGS];"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"eddfb492_0ba5b054","line":42,"updated":"2022-05-26 14:31:11.000000000","message":"missing common_magic","commit_id":"37ddec4a866f091f157423299caab016ce5bbbe2"}],"src/target/dsp5680xx.h":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"a440bb5cac5b4fccff3854155a22aa41aa3e2300","unresolved":true,"context_lines":[{"line_number":284,"context_line":" */"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"struct dsp5680xx_common {"},{"line_number":287,"context_line":"\tuint32_t stored_pc;"},{"line_number":288,"context_line":"\tint flush;"},{"line_number":289,"context_line":"\tbool debug_mode_enabled;"},{"line_number":290,"context_line":"};"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"bde5caa8_65c6c839","line":287,"updated":"2022-05-26 14:31:11.000000000","message":"missing common_magic","commit_id":"37ddec4a866f091f157423299caab016ce5bbbe2"}],"src/target/esirisc.h":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"a440bb5cac5b4fccff3854155a22aa41aa3e2300","unresolved":true,"context_lines":[{"line_number":73,"context_line":"};"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"struct esirisc_common {"},{"line_number":76,"context_line":"\tstruct target *target;"},{"line_number":77,"context_line":"\tstruct esirisc_jtag jtag_info;"},{"line_number":78,"context_line":"\tenum esirisc_cache cache_arch;"},{"line_number":79,"context_line":"\tchar *gdb_arch;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"96ba844f_8ef93667","line":76,"updated":"2022-05-26 14:31:11.000000000","message":"missing common_magic","commit_id":"37ddec4a866f091f157423299caab016ce5bbbe2"}],"src/target/ls1_sap.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"a440bb5cac5b4fccff3854155a22aa41aa3e2300","unresolved":true,"context_lines":[{"line_number":23,"context_line":"#include \u003cjtag/jtag.h\u003e"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"struct ls1_sap {"},{"line_number":26,"context_line":"\tstruct jtag_tap *tap;"},{"line_number":27,"context_line":"};"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"static int ls1_sap_target_create(struct target *target, Jim_Interp *interp)"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"e1d4df8f_87e31310","line":26,"updated":"2022-05-26 14:31:11.000000000","message":"missing common_magic","commit_id":"37ddec4a866f091f157423299caab016ce5bbbe2"}],"src/target/openrisc/or1k.h":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"a440bb5cac5b4fccff3854155a22aa41aa3e2300","unresolved":true,"context_lines":[{"line_number":96,"context_line":"};"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"struct or1k_common {"},{"line_number":99,"context_line":"\tstruct or1k_jtag jtag;"},{"line_number":100,"context_line":"\tstruct reg_cache *core_cache;"},{"line_number":101,"context_line":"\tuint32_t core_regs[OR1KNUMCOREREGS];"},{"line_number":102,"context_line":"\tint nb_regs;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"103f84d3_4c4e0c07","line":99,"updated":"2022-05-26 14:31:11.000000000","message":"missing common_magic","commit_id":"37ddec4a866f091f157423299caab016ce5bbbe2"}]}