)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"53075af4574679273d23de4129cceb5996bd6bf1","unresolved":true,"context_lines":[{"line_number":10,"context_line":"command not used or basedir set to empty string."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Signed-off-by: Erhan Kurubas \u003cerhan.kurubas@espressif.com\u003e"},{"line_number":13,"context_line":"Change-Id: I3afa049d74b30496f5c03ba4ef67431784f81bdc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"2377e1f2_7fe82470","line":13,"updated":"2022-05-28 08:51:35.000000000","message":"please add a line:\nFixes: ce5027ab019a (\"semihosting: add semihosting_basedir command\")","commit_id":"f3b800fd4c1e7155f83ae191e4f264c02d67b976"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"aa812f66db9aeb17b4085bd7c4eed278d73e023a","unresolved":false,"context_lines":[{"line_number":10,"context_line":"command not used or basedir set to empty string."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Signed-off-by: Erhan Kurubas \u003cerhan.kurubas@espressif.com\u003e"},{"line_number":13,"context_line":"Change-Id: I3afa049d74b30496f5c03ba4ef67431784f81bdc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"4402e9c8_07b9c3e3","line":13,"in_reply_to":"2377e1f2_7fe82470","updated":"2022-05-28 09:53:09.000000000","message":"Done","commit_id":"f3b800fd4c1e7155f83ae191e4f264c02d67b976"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"0ba784f71ea149e435936373baaa53539354992b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2c40af92_1591ee40","updated":"2022-05-28 06:54:38.000000000","message":"Hi Maxim,\n\nCan you please verify the change is working for you? \n","commit_id":"97e0b324d9e9b136cd565c76ba7e73fdf6a428b6"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"53075af4574679273d23de4129cceb5996bd6bf1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b6ebce57_6753b697","updated":"2022-05-28 08:51:35.000000000","message":"Thanks for the fix","commit_id":"f3b800fd4c1e7155f83ae191e4f264c02d67b976"},{"author":{"_account_id":1001482,"name":"Muhammad Omair Javaid","email":"omair.javaid@linaro.org","username":"omjavaid"},"change_message_id":"82fe6f9b443d55518f7fb3807b33e98c3617c6ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4661ff04_fb7480e0","updated":"2022-06-02 11:28:00.000000000","message":"Hi Antonio,\n\nI was wondering if you can kindly merge this patch to master.\n\nThanks!","commit_id":"78c79ba4ad2e38a424021156d850e0ecdec356f3"},{"author":{"_account_id":1001994,"name":"maxim-kuvyrkov","username":"maxim-kuvyrkov"},"change_message_id":"62a73213c3cf22823dba725e76d154f7e1cec8dc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"99a171d9_f587a24f","updated":"2022-05-30 11:40:03.000000000","message":"Semihosting is back to normal.  Thanks!","commit_id":"78c79ba4ad2e38a424021156d850e0ecdec356f3"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"1bc3b92737d99af70c7ef7294abbcdfa1ac940b5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4b2a6141_231bf75c","updated":"2022-05-28 21:22:39.000000000","message":"Thanks for the fix!\nI would like to merge this asap.\nMaxim, can you please add your +1 if this patch works for you?","commit_id":"78c79ba4ad2e38a424021156d850e0ecdec356f3"}],"src/target/semihosting_common.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"53075af4574679273d23de4129cceb5996bd6bf1","unresolved":true,"context_lines":[{"line_number":878,"context_line":"\t\t\t\t\tsemihosting-\u003esys_errno \u003d ENOMEM;"},{"line_number":879,"context_line":"\t\t\t\t} else {"},{"line_number":880,"context_line":"\t\t\t\t\tif (basedir_len \u003e 0) {"},{"line_number":881,"context_line":"\t\t\t\t\t\tstrncpy((char *)fn, semihosting-\u003ebasedir, basedir_len);"},{"line_number":882,"context_line":"\t\t\t\t\t\tif (fn[basedir_len - 1] !\u003d \u0027/\u0027)"},{"line_number":883,"context_line":"\t\t\t\t\t\t\tfn[basedir_len++] \u003d \u0027/\u0027;"},{"line_number":884,"context_line":"\t\t\t\t\t}"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"64ef991e_3231067b","line":881,"updated":"2022-05-28 08:51:35.000000000","message":"Strange build error, I\u0027m even thinking there could have been an update in Jenkins\u0027 GCC because this was not triggered on https://review.openocd.org/6888\n\nAnyway the error is clear: the third argument \u0027basedir_len\u0027 is usually there to prevent buffer overflow of the target buffer \u0027fn\u0027. Here it is computed on the source length, not on the target\u0027s one. But damn\u0027d, target length is \u0027basedir_len + len + 2\u0027 where everything is unsigned size_t!!!\n\nSimply use strcpy in place of strncpy, it should drop the error.","commit_id":"f3b800fd4c1e7155f83ae191e4f264c02d67b976"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"aa812f66db9aeb17b4085bd7c4eed278d73e023a","unresolved":false,"context_lines":[{"line_number":878,"context_line":"\t\t\t\t\tsemihosting-\u003esys_errno \u003d ENOMEM;"},{"line_number":879,"context_line":"\t\t\t\t} else {"},{"line_number":880,"context_line":"\t\t\t\t\tif (basedir_len \u003e 0) {"},{"line_number":881,"context_line":"\t\t\t\t\t\tstrncpy((char *)fn, semihosting-\u003ebasedir, basedir_len);"},{"line_number":882,"context_line":"\t\t\t\t\t\tif (fn[basedir_len - 1] !\u003d \u0027/\u0027)"},{"line_number":883,"context_line":"\t\t\t\t\t\t\tfn[basedir_len++] \u003d \u0027/\u0027;"},{"line_number":884,"context_line":"\t\t\t\t\t}"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"581e631c_d3a2f6a1","line":881,"in_reply_to":"64ef991e_3231067b","updated":"2022-05-28 09:53:09.000000000","message":"Done","commit_id":"f3b800fd4c1e7155f83ae191e4f264c02d67b976"}]}