)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"a8669b9c20d907f73f0cb51ee108ac642e4e86f8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8b54923c_49e3b012","updated":"2022-05-29 07:50:32.000000000","message":"Never seen this valgrind error. Generally calloc() is safer anyway...","commit_id":"29250463b99212b4c3258318fadf49620edde41e"}],"src/server/telnet_server.c":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"a8669b9c20d907f73f0cb51ee108ac642e4e86f8","unresolved":true,"context_lines":[{"line_number":234,"context_line":"\tconnection-\u003epriv \u003d telnet_connection;"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"\t/* initialize telnet connection information */"},{"line_number":237,"context_line":"\ttelnet_connection-\u003eclosed \u003d false;"},{"line_number":238,"context_line":"\ttelnet_connection-\u003eline_size \u003d 0;"},{"line_number":239,"context_line":"\ttelnet_connection-\u003eline_cursor \u003d 0;"},{"line_number":240,"context_line":"\ttelnet_connection-\u003eprompt \u003d strdup(\"\u003e \");"},{"line_number":241,"context_line":"\ttelnet_connection-\u003eprompt_visible \u003d true;"},{"line_number":242,"context_line":"\ttelnet_connection-\u003estate \u003d TELNET_STATE_DATA;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"c06305e8_3cf46b9e","line":239,"range":{"start_line":237,"start_character":1,"end_line":239,"end_character":36},"updated":"2022-05-29 07:50:32.000000000","message":"We can also drop this part of initialization","commit_id":"29250463b99212b4c3258318fadf49620edde41e"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"d6605a07315ae16e49586d15fea32f2318ee307f","unresolved":false,"context_lines":[{"line_number":234,"context_line":"\tconnection-\u003epriv \u003d telnet_connection;"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"\t/* initialize telnet connection information */"},{"line_number":237,"context_line":"\ttelnet_connection-\u003eclosed \u003d false;"},{"line_number":238,"context_line":"\ttelnet_connection-\u003eline_size \u003d 0;"},{"line_number":239,"context_line":"\ttelnet_connection-\u003eline_cursor \u003d 0;"},{"line_number":240,"context_line":"\ttelnet_connection-\u003eprompt \u003d strdup(\"\u003e \");"},{"line_number":241,"context_line":"\ttelnet_connection-\u003eprompt_visible \u003d true;"},{"line_number":242,"context_line":"\ttelnet_connection-\u003estate \u003d TELNET_STATE_DATA;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"1c0f81b5_aeb4cceb","line":239,"range":{"start_line":237,"start_character":1,"end_line":239,"end_character":36},"in_reply_to":"c06305e8_3cf46b9e","updated":"2022-05-29 12:03:25.000000000","message":"Done","commit_id":"29250463b99212b4c3258318fadf49620edde41e"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"b1512a4f082429c2e498f4595efaf7e59c3a9721","unresolved":true,"context_lines":[{"line_number":258,"context_line":"\ttelnet_prompt(connection);"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"\t/* initialize history */"},{"line_number":261,"context_line":"\tfor (i \u003d 0; i \u003c TELNET_LINE_HISTORY_SIZE; i++)"},{"line_number":262,"context_line":"\t\ttelnet_connection-\u003ehistory[i] \u003d NULL;"},{"line_number":263,"context_line":"\ttelnet_connection-\u003enext_history \u003d 0;"},{"line_number":264,"context_line":"\ttelnet_connection-\u003ecurrent_history \u003d 0;"},{"line_number":265,"context_line":"\ttelnet_load_history(telnet_connection);"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"\tlog_add_callback(telnet_log_callback, connection);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"b2385a73_fabc39d0","line":264,"range":{"start_line":261,"start_character":0,"end_line":264,"end_character":40},"updated":"2022-05-29 08:14:56.000000000","message":"ok then, should I remove this part, too?","commit_id":"29250463b99212b4c3258318fadf49620edde41e"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"d6605a07315ae16e49586d15fea32f2318ee307f","unresolved":false,"context_lines":[{"line_number":258,"context_line":"\ttelnet_prompt(connection);"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"\t/* initialize history */"},{"line_number":261,"context_line":"\tfor (i \u003d 0; i \u003c TELNET_LINE_HISTORY_SIZE; i++)"},{"line_number":262,"context_line":"\t\ttelnet_connection-\u003ehistory[i] \u003d NULL;"},{"line_number":263,"context_line":"\ttelnet_connection-\u003enext_history \u003d 0;"},{"line_number":264,"context_line":"\ttelnet_connection-\u003ecurrent_history \u003d 0;"},{"line_number":265,"context_line":"\ttelnet_load_history(telnet_connection);"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"\tlog_add_callback(telnet_log_callback, connection);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"50b2deb4_dc8d2aff","line":264,"range":{"start_line":261,"start_character":0,"end_line":264,"end_character":40},"in_reply_to":"b2385a73_fabc39d0","updated":"2022-05-29 12:03:25.000000000","message":"Done","commit_id":"29250463b99212b4c3258318fadf49620edde41e"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"edfdbaeb23548b532cafe19a43db95f4c2051dce","unresolved":true,"context_lines":[{"line_number":258,"context_line":"\ttelnet_prompt(connection);"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"\t/* initialize history */"},{"line_number":261,"context_line":"\tfor (i \u003d 0; i \u003c TELNET_LINE_HISTORY_SIZE; i++)"},{"line_number":262,"context_line":"\t\ttelnet_connection-\u003ehistory[i] \u003d NULL;"},{"line_number":263,"context_line":"\ttelnet_connection-\u003enext_history \u003d 0;"},{"line_number":264,"context_line":"\ttelnet_connection-\u003ecurrent_history \u003d 0;"},{"line_number":265,"context_line":"\ttelnet_load_history(telnet_connection);"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"\tlog_add_callback(telnet_log_callback, connection);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"57dfdb56_6482b130","line":264,"range":{"start_line":261,"start_character":0,"end_line":264,"end_character":40},"in_reply_to":"b2385a73_fabc39d0","updated":"2022-05-29 08:37:21.000000000","message":"Oh yes","commit_id":"29250463b99212b4c3258318fadf49620edde41e"}]}
