)]}'
{"id":"openocd~master~Ia435a5d2039be9b247e2336616dab53ed5d983ac","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2022-08-15 13:22:18.000000000","reason":"Change was submitted"},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2022-08-02 10:46:17.000000000","reason":"Tomas Vanek replied on the change"}},"hashtags":[],"change_id":"Ia435a5d2039be9b247e2336616dab53ed5d983ac","subject":"openocd: prevent target polling during \u0027init\u0027","status":"MERGED","created":"2022-05-30 13:50:15.000000000","updated":"2022-08-15 13:22:18.000000000","submitted":"2022-08-15 13:22:18.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7007","meta_rev_id":"c29336e3bdb57f434df1b3e159ba720b666dbc86","_number":7007,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-08-15 13:22:18.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-08-15 13:22:18.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-08-15 13:22:18.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-05-30 13:50:15.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"},{"updated":"2022-05-30 14:12:35.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"19ea7a1b39ffe12af74f77e4d2902cae5d32306f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-05-30 13:50:15.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f4f47b4d18d7a83bdfd2b3922c985e7e9f974082","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-05-30 14:12:35.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/16220/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/15430/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"f1c91d43944e57e3f31222fe878fc712f4983f78","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-05-30 16:14:35.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"5c818a9ac390e416e1aa712e9a25b5a64e4a7a4a","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-05-30 16:34:23.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"8f1a5049049c292ee4fa937981ec30e1f72fa983","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-05-31 08:07:33.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"b29c7fa112912ebc9d1fe910b29ec7cdbab8d76e","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-05-31 09:02:29.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/16222/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/15432/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"db03bf26a288d81cb9b7be0523cbbab12a6018c6","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-05-31 15:10:28.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"34c1223df67432913cb7f471e60307c62dec8b74","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-05-31 15:11:06.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"ddb312ef84bdbe1b607c005862c8b6805694b5b5","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-08-01 16:48:18.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.","accounts_in_message":[],"_revision_number":3},{"id":"83e4d13a703d418c2747c0fb85d8e08975791f41","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-08-01 17:02:12.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"067114fd7d54b8f53ee7d52b04db8a6c9769b826","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-08-01 17:31:27.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/15674/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/16465/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"7bd973f88ae6ceb465c803aa0b8645e85d38ba84","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-08-02 10:46:17.000000000","message":"Patch Set 3: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"c29336e3bdb57f434df1b3e159ba720b666dbc86","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-08-15 13:22:18.000000000","message":"Change has been successfully cherry-picked as e282d208321ed1661efa894b583cf8922d67ba3f","accounts_in_message":[],"_revision_number":4}],"current_revision":"e282d208321ed1661efa894b583cf8922d67ba3f","revisions":{"6ae92364162ff51f976584cffdaeed7be6b8aa1a":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2022-08-01 16:48:18.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/07/7007/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/07/7007/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/07/7007/3 \u0026\u0026 git checkout -b change-7007 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/07/7007/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/07/7007/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/07/7007/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/07/7007/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/07/7007/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"bc480c167a09dd1cc65932063d5aaec60c58f660","subject":"target: add API to temporarily mask target polling"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-05-30 13:32:24.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-08-01 16:46:36.000000000","tz":120},"subject":"openocd: prevent target polling during \u0027init\u0027","message":"openocd: prevent target polling during \u0027init\u0027\n\nThe command \u0027init\u0027 causes the execution of few lower level\ncommands, e.g. \u0027target init\u0027, and switches from command mode\nCOMMAND_CONFIG to COMMAND_EXEC, with an intermediate switch back\nto mode COMMAND_CONFIG.\n\nA timed target polling can occur during the execution of \u0027init\u0027\nand the target\u0027s status can trigger the execution of some events.\nE.g. if a target has been left halted by a previous execution of\nOpenOCD, the first poll will find the target halted, calling the\ncorresponding \u0027halted\u0027 event.\nThe event handler can use commands that can only be executed in\nmode COMMAND_EXEC. If the poll happens while OpenOCD is in mode\nCOMMAND_CONFIG, the triggered handler will fail.\n\nPrevent the target polling to operate during the execution of the\n\u0027init\u0027 command.\n\nChange-Id: Ia435a5d2039be9b247e2336616dab53ed5d983ac\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"9dc5cb69fa2a87f033f1a0b24369030abcd4e905":{"kind":"REWORK","_number":2,"created":"2022-05-31 08:07:33.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/07/7007/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/07/7007/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/07/7007/2 \u0026\u0026 git checkout -b change-7007 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/07/7007/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/07/7007/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/07/7007/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/07/7007/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/07/7007/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3ec6104b0b5cde67e4707c6a2605144fb0ce5170","subject":"target: add API to temporarily mask target polling"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-05-30 13:32:24.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-05-30 20:59:14.000000000","tz":120},"subject":"openocd: prevent target polling during \u0027init\u0027","message":"openocd: prevent target polling during \u0027init\u0027\n\nThe command \u0027init\u0027 causes the execution of few lower level\ncommands, e.g. \u0027target init\u0027, and switches from command mode\nCOMMAND_CONFIG to COMMAND_EXEC, with an intermediate switch back\nto mode COMMAND_CONFIG.\n\nA timed target polling can occur during the execution of \u0027init\u0027\nand the target\u0027s status can trigger the execution of some events.\nE.g. if a target has been left halted by a previous execution of\nOpenOCD, the first poll will find the target halted, calling the\ncorresponding \u0027halted\u0027 event.\nThe event handler can use commands that can only be executed in\nmode COMMAND_EXEC. If the poll happens while OpenOCD is in mode\nCOMMAND_CONFIG, the triggered handler will fail.\n\nPrevent the target polling to operate during the execution of the\n\u0027init\u0027 command.\n\nChange-Id: Ia435a5d2039be9b247e2336616dab53ed5d983ac\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"774365a67a1b027dec9ab6683535a62a2f7facd2":{"kind":"REWORK","_number":1,"created":"2022-05-30 13:50:15.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/07/7007/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/07/7007/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/07/7007/1 \u0026\u0026 git checkout -b change-7007 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/07/7007/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/07/7007/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/07/7007/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/07/7007/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/07/7007/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"cc8b491856c9fee675732dc21a2307f5c9617f54","subject":"flash/nor/core, target: don\u0027t ask for working mem if no target algo"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-05-30 13:32:24.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-05-30 13:45:43.000000000","tz":120},"subject":"openocd: prevent target polling during \u0027init\u0027","message":"openocd: prevent target polling during \u0027init\u0027\n\nThe command \u0027init\u0027 causes the execution of few lower level\ncommands, e.g. \u0027target init\u0027, and switches from command mode\nCOMMAND_CONFIG to COMMAND_EXEC, with an intermediate switch back\nto mode COMMAND_CONFIG.\n\nA timed target polling can occur during the execution of \u0027init\u0027\nand the target\u0027s status can trigger the execution of some events.\nE.g. if a target has been left halted by a previous execution of\nOpenOCD, the first poll will find the target halted, calling the\ncorresponding \u0027halted\u0027 event.\nThe event handler can use commands that can only be executed in\nmode COMMAND_EXEC. If the poll happens while OpenOCD is in mode\nCOMMAND_CONFIG, the triggered handler will fail.\n\nPrevent the target polling to operate during the execution of the\n\u0027init\u0027 command.\n\nChange-Id: Ia435a5d2039be9b247e2336616dab53ed5d983ac\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"e282d208321ed1661efa894b583cf8922d67ba3f":{"kind":"REWORK","_number":4,"created":"2022-08-15 13:22:18.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/07/7007/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/07/7007/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/07/7007/4 \u0026\u0026 git checkout -b change-7007 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/07/7007/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/07/7007/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/07/7007/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/07/7007/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/07/7007/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"0d56f379b55b24959c88e705a83e1fbb826b75e7","subject":"target: add API to temporarily mask target polling"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-05-30 13:32:24.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-08-15 13:22:18.000000000","tz":0},"subject":"openocd: prevent target polling during \u0027init\u0027","message":"openocd: prevent target polling during \u0027init\u0027\n\nThe command \u0027init\u0027 causes the execution of few lower level\ncommands, e.g. \u0027target init\u0027, and switches from command mode\nCOMMAND_CONFIG to COMMAND_EXEC, with an intermediate switch back\nto mode COMMAND_CONFIG.\n\nA timed target polling can occur during the execution of \u0027init\u0027\nand the target\u0027s status can trigger the execution of some events.\nE.g. if a target has been left halted by a previous execution of\nOpenOCD, the first poll will find the target halted, calling the\ncorresponding \u0027halted\u0027 event.\nThe event handler can use commands that can only be executed in\nmode COMMAND_EXEC. If the poll happens while OpenOCD is in mode\nCOMMAND_CONFIG, the triggered handler will fail.\n\nPrevent the target polling to operate during the execution of the\n\u0027init\u0027 command.\n\nChange-Id: Ia435a5d2039be9b247e2336616dab53ed5d983ac\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7007\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nTested-by: jenkins\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}
