)]}'
{"id":"openocd~master~Iade26a152925ee0f1bf114ed829b94f7ed5b254f","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2022-06-10 21:54:01.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Iade26a152925ee0f1bf114ed829b94f7ed5b254f","subject":"arm_adi_v5: fix scan-build warning [1/3]","status":"MERGED","created":"2022-06-01 20:04:20.000000000","updated":"2022-06-10 21:54:01.000000000","submitted":"2022-06-10 21:54:01.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7010","meta_rev_id":"49a3229f0c8463745c92d3968b69af43ccae27ac","_number":7010,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-06-10 21:54:01.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-06-10 21:54:01.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-06-10 21:54:01.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-06-01 20:29:58.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-06-02 04:19:35.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"}],"messages":[{"id":"72af1857942367673a4c29f63261efe808f0c9da","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-06-01 20:04:20.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"31c545483b6465fbe9ab662f2e9afe73f63d42e4","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-06-01 20:29:58.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/16224/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/15434/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"cca6c5bdd1b6105a601a30f301f32c09efc51b7d","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-06-01 22:03:35.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"3696eb692d70a447b6697de60631ab360d80f1cd","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-06-02 04:19:35.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"49a3229f0c8463745c92d3968b69af43ccae27ac","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-06-10 21:54:01.000000000","message":"Change has been successfully cherry-picked as 63e22d5fb97fd99d88d840e88a25aff721e0424b","accounts_in_message":[],"_revision_number":2}],"current_revision":"63e22d5fb97fd99d88d840e88a25aff721e0424b","revisions":{"63e22d5fb97fd99d88d840e88a25aff721e0424b":{"kind":"REWORK","_number":2,"created":"2022-06-10 21:54:01.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/10/7010/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/10/7010/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/10/7010/2 \u0026\u0026 git checkout -b change-7010 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/10/7010/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/10/7010/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/10/7010/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/10/7010/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/10/7010/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"e78b96421c6c782605127332011043d01c393ea7","subject":"flash/nor/numicro: remove useless architecture check"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-06-01 16:26:35.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-06-10 21:54:01.000000000","tz":0},"subject":"arm_adi_v5: fix scan-build warning [1/3]","message":"arm_adi_v5: fix scan-build warning [1/3]\n\nCommit 21f7885d1c2a (\"arm_adi_v5: separate ROM table parsing from\ncommand output [1/3]\") introduces a new scan-build warning because\ncontinues the execution even when dap_get_debugbase() returns\nerror. The value of \u0027apid\u0027 can be uninitialized:\n\n\t5th function call argument is an uninitialized value\n\nCheck the return value and quit on error.\nWhile there, remove the useless initialization of \u0027dbgbase\u0027 that\nwas apparently required for the same problem.\n\nChange-Id: Iade26a152925ee0f1bf114ed829b94f7ed5b254f\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nFixes: 21f7885d1c2a (\"arm_adi_v5: separate ROM table parsing from command output [1/3]\")\nReviewed-on: https://review.openocd.org/c/openocd/+/7010\nTested-by: jenkins\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"ce9ac7cb167c4917bdd4efc64220486649f3660a":{"kind":"REWORK","_number":1,"created":"2022-06-01 20:04:20.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/10/7010/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/10/7010/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/10/7010/1 \u0026\u0026 git checkout -b change-7010 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/10/7010/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/10/7010/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/10/7010/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/10/7010/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/10/7010/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"cc8b491856c9fee675732dc21a2307f5c9617f54","subject":"flash/nor/core, target: don\u0027t ask for working mem if no target algo"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-06-01 16:26:35.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-06-01 17:24:20.000000000","tz":120},"subject":"arm_adi_v5: fix scan-build warning [1/3]","message":"arm_adi_v5: fix scan-build warning [1/3]\n\nCommit 21f7885d1c2a (\"arm_adi_v5: separate ROM table parsing from\ncommand output [1/3]\") introduces a new scan-build warning because\ncontinues the execution even when dap_get_debugbase() returns\nerror. The value of \u0027apid\u0027 can be uninitialized:\n\n\t5th function call argument is an uninitialized value\n\nCheck the return value and quit on error.\nWhile there, remove the useless initialization of \u0027dbgbase\u0027 that\nwas apparently required for the same problem.\n\nChange-Id: Iade26a152925ee0f1bf114ed829b94f7ed5b254f\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nFixes: 21f7885d1c2a (\"arm_adi_v5: separate ROM table parsing from command output [1/3]\")\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}