)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1001995,"name":"Martin Hierholzer","email":"hier@beta-centauri.de","username":"mhier"},"change_message_id":"b8e0567a8d8d5e74e858592b6d1d24e768fc0d05","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3b7f8024_d494548b","updated":"2022-06-03 14:16:21.000000000","message":"See also initial discussion here: https://sourceforge.net/p/openocd/tickets/236/#2e60\n\nI have check with valgrind and seen no errors. The clang scanbuild shows no errors related to the changed file.","commit_id":"88618b17a0d61661adc904a6b0a8b82564bc879c"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"28a02fa23b0c0ab54465dc7cfa8eb2870e109dfd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"616f9a60_3c5cd9ff","updated":"2022-06-08 09:08:33.000000000","message":"Thanks Martin!\nLooks good, just small cosmetic problems.\n","commit_id":"88618b17a0d61661adc904a6b0a8b82564bc879c"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"4bc977599e8fe9857887c98d31fcc0cb204ed6c0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7e6e024f_c634a4c5","updated":"2022-07-30 12:09:48.000000000","message":"I have no rev 1.x device to test.\nTested at least with K22FX512 (SDID 0x00009318), no regression found.\nThanks!","commit_id":"2332a38d35ed896903d4d11942be2c5af96e93d2"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"57c0f9f167f98a9d765c2186f31e64444d7e6d61","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4ecf09dc_e9e40949","updated":"2022-07-31 13:20:54.000000000","message":"Just set my comment to resolved","commit_id":"2332a38d35ed896903d4d11942be2c5af96e93d2"},{"author":{"_account_id":1001995,"name":"Martin Hierholzer","email":"hier@beta-centauri.de","username":"mhier"},"change_message_id":"6ca488b6df758f3c9cdcf5c14ff97f6d7888411d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c884358e_1b14c661","updated":"2022-08-01 08:42:33.000000000","message":"Oh, now I see all my earlier comments were just drafts, sorry ;-) Anyway not much info in there, I just said that I have addressed your points (as you already have seen now).\n\nIs there anything more to do from my side? It says it would be my turn to take action now, but I have no clue what action to take... (I am sorry, I am new to the Gerrit system...)","commit_id":"2332a38d35ed896903d4d11942be2c5af96e93d2"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"b193792786e6a6142c58a348b629e6b67d611a3b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b1bd9ceb_16857167","in_reply_to":"c884358e_1b14c661","updated":"2022-08-01 08:48:58.000000000","message":"No problem, Martin. I\u0027ll merge the change after a week or so.","commit_id":"2332a38d35ed896903d4d11942be2c5af96e93d2"}],"src/flash/nor/kinetis.c":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"28a02fa23b0c0ab54465dc7cfa8eb2870e109dfd","unresolved":true,"context_lines":[{"line_number":201,"context_line":"#define KINETIS_K_SDID_K60_M150  0x000001C0"},{"line_number":202,"context_line":"#define KINETIS_K_SDID_K70_M150  0x000001D0"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"#define KINETIS_K_REVID_TYPE_MASK\t0x0000F000"},{"line_number":205,"context_line":"#define KINETIS_K_REVID_TYPE_SHIFT\t12"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"#define KINETIS_SDID_SERIESID_MASK 0x00F00000"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"1cf2d3fe_fbfc4334","line":204,"range":{"start_line":204,"start_character":24,"end_line":204,"end_character":28},"updated":"2022-06-08 09:08:33.000000000","message":"TYPE seems me just a copy \u0026 paste error (was KINETIS_K_SDID_TYPE_MASK the origin?)\nUse KINETIS_K_REVID_MASK","commit_id":"88618b17a0d61661adc904a6b0a8b82564bc879c"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"57c0f9f167f98a9d765c2186f31e64444d7e6d61","unresolved":false,"context_lines":[{"line_number":201,"context_line":"#define KINETIS_K_SDID_K60_M150  0x000001C0"},{"line_number":202,"context_line":"#define KINETIS_K_SDID_K70_M150  0x000001D0"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"#define KINETIS_K_REVID_TYPE_MASK\t0x0000F000"},{"line_number":205,"context_line":"#define KINETIS_K_REVID_TYPE_SHIFT\t12"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"#define KINETIS_SDID_SERIESID_MASK 0x00F00000"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"311a4f96_7bba619f","line":204,"range":{"start_line":204,"start_character":24,"end_line":204,"end_character":28},"in_reply_to":"1cf2d3fe_fbfc4334","updated":"2022-07-31 13:20:54.000000000","message":"Done","commit_id":"88618b17a0d61661adc904a6b0a8b82564bc879c"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"28a02fa23b0c0ab54465dc7cfa8eb2870e109dfd","unresolved":true,"context_lines":[{"line_number":202,"context_line":"#define KINETIS_K_SDID_K70_M150  0x000001D0"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"#define KINETIS_K_REVID_TYPE_MASK\t0x0000F000"},{"line_number":205,"context_line":"#define KINETIS_K_REVID_TYPE_SHIFT\t12"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"#define KINETIS_SDID_SERIESID_MASK 0x00F00000"},{"line_number":208,"context_line":"#define KINETIS_SDID_SERIESID_K   0x00000000"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"a0ea47ac_4e6b12f6","line":205,"range":{"start_line":205,"start_character":24,"end_line":205,"end_character":29},"updated":"2022-06-08 09:08:33.000000000","message":"...and KINETIS_K_REVID_SHIFT","commit_id":"88618b17a0d61661adc904a6b0a8b82564bc879c"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"57c0f9f167f98a9d765c2186f31e64444d7e6d61","unresolved":false,"context_lines":[{"line_number":202,"context_line":"#define KINETIS_K_SDID_K70_M150  0x000001D0"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"#define KINETIS_K_REVID_TYPE_MASK\t0x0000F000"},{"line_number":205,"context_line":"#define KINETIS_K_REVID_TYPE_SHIFT\t12"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"#define KINETIS_SDID_SERIESID_MASK 0x00F00000"},{"line_number":208,"context_line":"#define KINETIS_SDID_SERIESID_K   0x00000000"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"1da112c6_3cf0e6e4","line":205,"range":{"start_line":205,"start_character":24,"end_line":205,"end_character":29},"in_reply_to":"a0ea47ac_4e6b12f6","updated":"2022-07-31 13:20:54.000000000","message":"Done","commit_id":"88618b17a0d61661adc904a6b0a8b82564bc879c"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"28a02fa23b0c0ab54465dc7cfa8eb2870e109dfd","unresolved":true,"context_lines":[{"line_number":2168,"context_line":"\t\t\t\t /* highest bit set corresponds to rev 2.x */"},{"line_number":2169,"context_line":"\t\t\t\tif (revid \u003c\u003d 7) {"},{"line_number":2170,"context_line":"\t\t\t\t\tk_chip-\u003esysmodectrlr_type \u003d KINETIS_MC;"},{"line_number":2171,"context_line":"\t\t\t\t\tsize_t l \u003d strlen(name);"},{"line_number":2172,"context_line":"\t\t\t\t\tstrcpy(name+l, \" Rev 1.x\");"},{"line_number":2173,"context_line":"\t\t\t\t}"},{"line_number":2174,"context_line":"\t\t\t}"},{"line_number":2175,"context_line":"\t\t\tbreak;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"edac5bdf_80c1ec3b","line":2172,"range":{"start_line":2171,"start_character":5,"end_line":2172,"end_character":32},"updated":"2022-06-08 09:08:33.000000000","message":"I would prefer strcat(name, \" Rev...\") for simplicity","commit_id":"88618b17a0d61661adc904a6b0a8b82564bc879c"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"57c0f9f167f98a9d765c2186f31e64444d7e6d61","unresolved":false,"context_lines":[{"line_number":2168,"context_line":"\t\t\t\t /* highest bit set corresponds to rev 2.x */"},{"line_number":2169,"context_line":"\t\t\t\tif (revid \u003c\u003d 7) {"},{"line_number":2170,"context_line":"\t\t\t\t\tk_chip-\u003esysmodectrlr_type \u003d KINETIS_MC;"},{"line_number":2171,"context_line":"\t\t\t\t\tsize_t l \u003d strlen(name);"},{"line_number":2172,"context_line":"\t\t\t\t\tstrcpy(name+l, \" Rev 1.x\");"},{"line_number":2173,"context_line":"\t\t\t\t}"},{"line_number":2174,"context_line":"\t\t\t}"},{"line_number":2175,"context_line":"\t\t\tbreak;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"47ab77a9_eb5accf2","line":2172,"range":{"start_line":2171,"start_character":5,"end_line":2172,"end_character":32},"in_reply_to":"edac5bdf_80c1ec3b","updated":"2022-07-31 13:20:54.000000000","message":"Done","commit_id":"88618b17a0d61661adc904a6b0a8b82564bc879c"}]}