)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"34a11dc378600c2c66d9965f18405decd73b6ace","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f4614cac_d1b631a9","updated":"2022-06-04 11:23:23.000000000","message":"Thanks!","commit_id":"b6f3121f76f0ffb0e25061ab9130c53aa8d441b3"}],"tcl/mmr_helpers.tcl":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"72f3c94529cd2979bb36a7decf2db854281dce6e","unresolved":true,"context_lines":[{"line_number":74,"context_line":"# Give: ADDR - address of the register."},{"line_number":75,"context_line":"#       BIT - bit\u0027s number."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"proc mmr_get_bit { ADDR BIT } {"},{"line_number":78,"context_line":"\tset val [memread32 $ADDR]"},{"line_number":79,"context_line":"    set bit_val [expr {$val \u0026 [expr {1 \u003c\u003c $BIT}]}]"},{"line_number":80,"context_line":"    return $bit_val"}],"source_content_type":"text/x-tcl","patch_set":1,"id":"14f1f7ba_ed7e66ec","line":77,"updated":"2022-06-04 09:40:10.000000000","message":"To be consistent within this file, should it be get_mmr_bit?\nAnd next get_mmr_bitfield?","commit_id":"16581c29afd25712413c88d05766dd1c2b0788a2"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"6e8f6d2b9a7bbecf0c6351185be0d70814036c73","unresolved":false,"context_lines":[{"line_number":74,"context_line":"# Give: ADDR - address of the register."},{"line_number":75,"context_line":"#       BIT - bit\u0027s number."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"proc mmr_get_bit { ADDR BIT } {"},{"line_number":78,"context_line":"\tset val [memread32 $ADDR]"},{"line_number":79,"context_line":"    set bit_val [expr {$val \u0026 [expr {1 \u003c\u003c $BIT}]}]"},{"line_number":80,"context_line":"    return $bit_val"}],"source_content_type":"text/x-tcl","patch_set":1,"id":"e7aed276_e2e64246","line":77,"in_reply_to":"14f1f7ba_ed7e66ec","updated":"2022-06-04 09:51:00.000000000","message":"Done","commit_id":"16581c29afd25712413c88d05766dd1c2b0788a2"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"72f3c94529cd2979bb36a7decf2db854281dce6e","unresolved":true,"context_lines":[{"line_number":75,"context_line":"#       BIT - bit\u0027s number."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"proc mmr_get_bit { ADDR BIT } {"},{"line_number":78,"context_line":"\tset val [memread32 $ADDR]"},{"line_number":79,"context_line":"    set bit_val [expr {$val \u0026 [expr {1 \u003c\u003c $BIT}]}]"},{"line_number":80,"context_line":"    return $bit_val"},{"line_number":81,"context_line":"}"}],"source_content_type":"text/x-tcl","patch_set":1,"id":"4af7ee0d_9074c4fc","line":78,"updated":"2022-06-04 09:40:10.000000000","message":"please use the same type of indentation. This line uses one TAB and following lines use 4 spaces.\nEven if the rest of this file is not consistent, use TAB in your new code.","commit_id":"16581c29afd25712413c88d05766dd1c2b0788a2"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"6e8f6d2b9a7bbecf0c6351185be0d70814036c73","unresolved":false,"context_lines":[{"line_number":75,"context_line":"#       BIT - bit\u0027s number."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"proc mmr_get_bit { ADDR BIT } {"},{"line_number":78,"context_line":"\tset val [memread32 $ADDR]"},{"line_number":79,"context_line":"    set bit_val [expr {$val \u0026 [expr {1 \u003c\u003c $BIT}]}]"},{"line_number":80,"context_line":"    return $bit_val"},{"line_number":81,"context_line":"}"}],"source_content_type":"text/x-tcl","patch_set":1,"id":"41bd2ac0_147e43aa","line":78,"in_reply_to":"4af7ee0d_9074c4fc","updated":"2022-06-04 09:51:00.000000000","message":"Done","commit_id":"16581c29afd25712413c88d05766dd1c2b0788a2"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"72f3c94529cd2979bb36a7decf2db854281dce6e","unresolved":true,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"proc mmr_get_bitfield { ADDR MSB LSB } {"},{"line_number":89,"context_line":"\tset rval [memread32 $ADDR]"},{"line_number":90,"context_line":"    return normalize_bitfield $rval $MSB $LSB"},{"line_number":91,"context_line":"}"}],"source_content_type":"text/x-tcl","patch_set":1,"id":"5370f496_b6e85e76","line":90,"updated":"2022-06-04 09:40:10.000000000","message":"use TAB for indentation here too","commit_id":"16581c29afd25712413c88d05766dd1c2b0788a2"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"6e8f6d2b9a7bbecf0c6351185be0d70814036c73","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"proc mmr_get_bitfield { ADDR MSB LSB } {"},{"line_number":89,"context_line":"\tset rval [memread32 $ADDR]"},{"line_number":90,"context_line":"    return normalize_bitfield $rval $MSB $LSB"},{"line_number":91,"context_line":"}"}],"source_content_type":"text/x-tcl","patch_set":1,"id":"633b65b7_8e89e79f","line":90,"in_reply_to":"5370f496_b6e85e76","updated":"2022-06-04 09:51:00.000000000","message":"Done","commit_id":"16581c29afd25712413c88d05766dd1c2b0788a2"}]}